next-issue 0.11.1 → 0.12.1

package/README.md

@@ -85,9 +85,10 @@ only between two issues, finishes the issue that it holds, deletes the file and
 then writes the summary as usual. A file from an earlier run is dropped at the
 start, so it stops nothing.
 
-`Ctrl-C` is different: the terminal signals every child too, so the run dies in
-the middle of a step. The saved state lets the next run continue the issue, but
-the issue keeps `status:in-progress` and the run writes no summary.
+`Ctrl-C` is different: the harness passes the signal on to the command that runs
+and to every child of it, so the run dies in the middle of a step. The saved
+state lets the next run continue the issue, but the issue keeps
+`status:in-progress` and the run writes no summary.
 
 Every status label that the harness puts on the issue goes on the pull request
 too, from the first review round. Thus a draft pull request shows work that the
@@ -193,7 +194,11 @@ does not know all stop the run, so a typo cannot pass without a word.
   "diffMaxChars": 60000,
   "keepRunDays": 7,
   "draftPullRequest": true,
-  "models": {},
+  "models": {
+    "implementer": null,
+    "reviewer": null,
+    "fixer": null
+  },
   "labels": {
     "ready": "status:todo",
     "inProgress": "status:in-progress",
@@ -222,7 +227,7 @@ does not know all stop the run, so a typo cannot pass without a word.
 | `keepRunDays` | `7` | The number of days to keep the run files; `0` keeps them all |
 | `draftPullRequest` | `true` | Open the pull request as a draft, until the review approves |
 | `setupCommand` | from the lock file | A shell command to run in a new worktree, before the implementer |
-| `models` | `{}` | The model per agent role |
+| `models` | `null` per role | The model per agent role: `implementer`, `reviewer`, `fixer` |
 | `labels` | see above | The names of the labels that the harness reads and sets |
 
 An empty `labels.ready` turns the ready requirement off. The harness then
@@ -231,7 +236,8 @@ claims every open issue that no other label and no assignee holds back.
 The log gives the reason for a skipped issue as `stop-label`, `not-ready`,
 `in-flight` or `assigned`.
 
-A role without an entry in `models` uses the default model of the SDK.
+A role set to `null`, or with no entry in `models`, uses the default model of
+the SDK.
 
 Without a `setupCommand`, the harness looks in the new worktree for a lock file
 and runs the install command that goes with it:

package/dist/config.mjs

@@ -43,11 +43,17 @@ const WHOLE_FIELDS = [
 ];
 const MODEL_ROLES = ["implementer", "reviewer", "fixer"];
 const LABEL_NAMES = ["ready", "inProgress", "inReview", "done", "needsHuman", "skip"];
+const FILE_DEFAULTS = {
+    ...DEFAULTS,
+    models: Object.fromEntries(MODEL_ROLES.map((role) => [role, null])),
+};
 export const CONFIG_FILE = "next-issue.config.json";
 export async function writeDefaultConfig(root, force) {
     const path = join(root, CONFIG_FILE);
     try {
-        await writeFile(path, `${JSON.stringify(DEFAULTS, null, 2)}\n`, { flag: force ? "w" : "wx" });
+        await writeFile(path, `${JSON.stringify(FILE_DEFAULTS, null, 2)}\n`, {
+            flag: force ? "w" : "wx",
+        });
     }
     catch (error) {
         if (error.code === "EEXIST") {
@@ -111,7 +117,7 @@ export function parseConfig(value) {
             }
         }
         for (const role of MODEL_ROLES) {
-            if (models[role] !== undefined) {
+            if (models[role] !== undefined && models[role] !== null) {
                 config.models[role] = text(models[role], `models.${role}`, false);
             }
         }

package/dist/exec.mjs

@@ -2,6 +2,41 @@ import { spawn } from "node:child_process";
 let observer;
 let defaultTimeoutMs = 10 * 60_000;
 const STDERR_TAIL = 200_000;
+const groups = new Set();
+function forward(signal) {
+    for (const pid of groups) {
+        try {
+            process.kill(-pid, signal);
+        }
+        catch { }
+    }
+    groups.clear();
+    process.off("SIGINT", onInterrupt);
+    process.off("SIGTERM", onTerminate);
+    process.kill(process.pid, signal);
+}
+const onInterrupt = () => forward("SIGINT");
+const onTerminate = () => forward("SIGTERM");
+function watch(pid) {
+    if (pid === undefined) {
+        return;
+    }
+    if (groups.size === 0) {
+        process.on("SIGINT", onInterrupt);
+        process.on("SIGTERM", onTerminate);
+    }
+    groups.add(pid);
+}
+function unwatch(pid) {
+    if (pid === undefined) {
+        return;
+    }
+    groups.delete(pid);
+    if (groups.size === 0) {
+        process.off("SIGINT", onInterrupt);
+        process.off("SIGTERM", onTerminate);
+    }
+}
 export function setCommandObserver(next) {
     observer = next;
 }
@@ -14,12 +49,15 @@ export function run(command, args, options = {}) {
     return new Promise((resolve, reject) => {
         const child = spawn(command, args, {
             cwd: options.cwd,
+            detached: true,
             stdio: [
                 options.input === undefined ? "ignore" : "pipe",
                 options.show === true ? 2 : "pipe",
                 "pipe",
             ],
         });
+        const pid = child.pid;
+        watch(pid);
         let stdout = "";
         let stderr = "";
         let timedOut = false;
@@ -40,11 +78,21 @@ export function run(command, args, options = {}) {
         });
         const timer = setTimeout(() => {
             timedOut = true;
-            child.kill("SIGKILL");
+            if (pid === undefined) {
+                child.kill("SIGKILL");
+                return;
+            }
+            try {
+                process.kill(-pid, "SIGKILL");
+            }
+            catch {
+                child.kill("SIGKILL");
+            }
         }, limit);
         let done = false;
         const settle = (code) => {
             clearTimeout(timer);
+            unwatch(pid);
             if (done) {
                 return;
             }
@@ -63,6 +111,7 @@ export function run(command, args, options = {}) {
         };
         child.on("error", (error) => {
             clearTimeout(timer);
+            unwatch(pid);
             done = true;
             reject(error);
         });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "next-issue",
-  "version": "0.11.1",
+  "version": "0.12.1",
   "description": "Autonomous issue harness driven by the Claude Agent SDK",
   "keywords": [
     "github",