newrelic 9.10.0 → 9.10.2

package/NEWS.md

@@ -1,3 +1,13 @@
+### v9.10.2 (2023-02-21)
+
+* fix: Replaced `request.aborted` with `response.close` in HTTP instrumentation.
+* Fixed issue where setting `NEW_RELIC_GRPC_IGNORE_STATUS_CODES` was not properly parsing the codes as integers, thus not ignoring reporting errors of certain status codes.
+* Upgraded `@grpc/grpc-js` from 1.8.4 to 1.8.7.
+
+### v9.10.1 (2023-02-13)
+
+* Fixed error with Lambda/ALB serverless instrumentation when no response headers were included
+
 ### v9.10.0 (2023-02-09)
 
 * Exposed a method on [API](https://newrelic.github.io/node-newrelic/API.html#obfuscateSql) to obfuscate sql: `newrelic.obfuscateSql`.

package/lib/config/index.js

@@ -1285,16 +1285,21 @@ Config.prototype._enforceServerless = function _enforceServerless(inputConfig) {
  * based on special properties of configuration values should go here as well.
  */
 Config.prototype._canonicalize = function _canonicalize() {
-  const statusCodes = this.error_collector && this.error_collector.ignore_status_codes
+  const statusCodes = this?.error_collector?.ignore_status_codes
   if (statusCodes) {
     this.error_collector.ignore_status_codes = _parseCodes(statusCodes)
   }
 
-  const expectedCodes = this.error_collector && this.error_collector.expected_status_codes
+  const expectedCodes = this?.error_collector?.expected_status_codes
   if (expectedCodes) {
     this.error_collector.expected_status_codes = _parseCodes(expectedCodes)
   }
 
+  const grpcStatusCodes = this?.grpc?.ignore_status_codes
+  if (grpcStatusCodes) {
+    this.grpc.ignore_status_codes = _parseCodes(grpcStatusCodes)
+  }
+
   const logAliases = {
     verbose: 'trace',
     debugging: 'debug',

package/lib/instrumentation/core/http.js

@@ -146,7 +146,7 @@ function wrapEmitWithTransaction(agent, emit, isHTTPS) {
     function instrumentedFinish() {
       // Remove listeners so this doesn't get called twice.
       response.removeListener('finish', instrumentedFinish)
-      request.removeListener('aborted', instrumentedFinish)
+      response.removeListener('close', instrumentedFinish)
 
       // Naming must happen before the segment and transaction are ended,
       // because metrics recording depends on naming's side effects.
@@ -188,7 +188,7 @@ function wrapEmitWithTransaction(agent, emit, isHTTPS) {
       transaction.end()
     }
     response.once('finish', instrumentedFinish)
-    request.once('aborted', instrumentedFinish)
+    response.once('close', instrumentedFinish)
 
     return tracer.bindFunction(emit, segment).apply(this, arguments)
   })

package/lib/serverless/api-gateway.js

@@ -59,7 +59,8 @@ function normalizeQueryStringParameters(event) {
 }
 
 /**
- * normalizes headers either from multi value headers or normal headers to a
+ * Normalizes both request and response headers,
+ * either from Multi Value headers or "normal" headers to a
  * lowercase key map with comma separated string
  *
  * @param {object} event The event with headers to normalize
@@ -67,8 +68,14 @@ function normalizeQueryStringParameters(event) {
  * @returns {Object<string, string>} The normalized headers map
  */
 function normalizeHeaders(event, lowerCaseKey = false) {
+  const headers = event.multiValueHeaders ?? event.headers
+
+  if (!headers) {
+    return
+  }
+
   return Object.fromEntries(
-    Object.entries(event.multiValueHeaders ?? event.headers).map(([headerKey, headerValue]) => {
+    Object.entries(headers).map(([headerKey, headerValue]) => {
       const newKey = lowerCaseKey ? headerKey.toLowerCase() : headerKey
 
       if (Array.isArray(headerValue)) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "newrelic",
-  "version": "9.10.0",
+  "version": "9.10.2",
   "author": "New Relic Node.js agent team <nodejs@newrelic.com>",
   "license": "Apache-2.0",
   "contributors": [
@@ -179,7 +179,7 @@
     "newrelic-naming-rules": "./bin/test-naming-rules.js"
   },
   "dependencies": {
-    "@grpc/grpc-js": "^1.8.4",
+    "@grpc/grpc-js": "^1.8.7",
     "@grpc/proto-loader": "^0.7.4",
     "@newrelic/aws-sdk": "^5.0.2",
     "@newrelic/koa": "^7.1.1",