newrelic 8.5.0 → 8.5.1

package/NEWS.md

@@ -1,3 +1,25 @@
+### v8.5.1 (2021-11-03)
+
+* Fixed bug where failure to retrieve CPU/Memory details for certain Linux distros could result in a crash.
+
+  `parseProcCPUInfo` and `parseProcMeminfo` now check for `null` input prior to processing.
+
+* Updated README to favor using `-r` to load the agent vs `require('newrelic')`.
+
+* Updated `@newrelic/test-utilities` to 6.1.1 and applied a global sampling value of 10 for versioned tests.
+
+* Migrated utilization unit tests from mocha to tap.
+
+* Migrated logger unit tests from mocha to tap.
+
+* Cleaned up or added future removal comments for several deprecation warnings.
+
+* Added a script and corresponding CI job that will check for PRs that have been merged and not release and notify the team in a private slack channel.
+
+* Updated the versioned test runner to always run against minor versions.
+
+* Fixed a high severity npm audit failure.
+
 ### v8.5.0 (2021-10-12)
 
 * Added full support for Fastify v2 and v3. Fastify instrumentation is now GA.

package/README.md

@@ -44,7 +44,13 @@ To use New Relic's Node.js agent entails these three steps, which are described
     }
 ```
 
-4. Finally, load the `newrelic` module _before any other module_ in your program.
+4. Finally, run your program with the `newrelic` module loaded first by using node's `-r/--require` flag.
+
+```
+ $ node -r newrelic your-program.js
+```
+
+If you cannot control how your program is run, you can load the `newrelic` module _before any other module_ in your program.
 
 ```js
     const newrelic = require('newrelic')
@@ -52,11 +58,6 @@ To use New Relic's Node.js agent entails these three steps, which are described
     /* ... the rest of your program ... */
 ```
 
-If you're compiling your JavaScript and can't control the final `require` order, the Node.js agent will work with node's `-r/--require` flag.
-
-    $ node -r newrelic your-program.js
-    $ node --require newrelic your-program.js
-
 ## Getting Started
 
 For more information on getting started, [check the Node.js docs](https://docs.newrelic.com/docs/agents/nodejs-agent/getting-started/introduction-new-relic-nodejs).

package/THIRD_PARTY_NOTICES.md

@@ -34,6 +34,7 @@ code, the source code can be found at [https://github.com/newrelic/node-newrelic
 * [@newrelic/proxy](#newrelicproxy)
 * [@newrelic/test-utilities](#newrelictest-utilities)
 * [@octokit/rest](#octokitrest)
+* [@slack/bolt](#slackbolt)
 * [ajv](#ajv)
 * [architect](#architect)
 * [benchmark](#benchmark)
@@ -1769,7 +1770,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
 
 ### @newrelic/test-utilities
 
-This product includes source derived from [@newrelic/test-utilities](https://github.com/newrelic/node-test-utilities) ([v6.0.0](https://github.com/newrelic/node-test-utilities/tree/v6.0.0)), distributed under the [Apache-2.0 License](https://github.com/newrelic/node-test-utilities/blob/v6.0.0/LICENSE):
+This product includes source derived from [@newrelic/test-utilities](https://github.com/newrelic/node-test-utilities) ([v6.1.1](https://github.com/newrelic/node-test-utilities/tree/v6.1.1)), distributed under the [Apache-2.0 License](https://github.com/newrelic/node-test-utilities/blob/v6.1.1/LICENSE):
 
 ```
                                  Apache License
@@ -2006,6 +2007,36 @@ THE SOFTWARE.
 
 ```
 
+### @slack/bolt
+
+This product includes source derived from [@slack/bolt](https://github.com/slackapi/bolt) ([v3.7.0](https://github.com/slackapi/bolt/tree/v3.7.0)), distributed under the [MIT License](https://github.com/slackapi/bolt/blob/v3.7.0/LICENSE):
+
+```
+The MIT License (MIT)
+
+Copyright (c) 2016-2018 Robots & Pencils
+Copyright (c) 2019- Slack Technologies, LLC
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.
+
+```
+
 ### ajv
 
 This product includes source derived from [ajv](https://github.com/ajv-validator/ajv) ([v6.12.6](https://github.com/ajv-validator/ajv/tree/v6.12.6)), distributed under the [MIT License](https://github.com/ajv-validator/ajv/blob/v6.12.6/LICENSE):
@@ -3261,7 +3292,7 @@ THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 ### tap
 
-This product includes source derived from [tap](https://github.com/tapjs/node-tap) ([v15.0.9](https://github.com/tapjs/node-tap/tree/v15.0.9)), distributed under the [ISC License](https://github.com/tapjs/node-tap/blob/v15.0.9/LICENSE):
+This product includes source derived from [tap](https://github.com/tapjs/node-tap) ([v15.0.10](https://github.com/tapjs/node-tap/tree/v15.0.10)), distributed under the [ISC License](https://github.com/tapjs/node-tap/blob/v15.0.10/LICENSE):
 
 ```
 The ISC License

package/lib/instrumentation/mongodb/common.js

@@ -47,9 +47,11 @@ common.instrumentCollection = function instrumentCollection(shim, Collection) {
  * Instruments all methods from constants.DB_OPS on
  * the Db class.
  *
- * @param {Object} params
+ * @param {object} params
  * @param {Shim} params.shim
  * @param {Db} params.Db
+ * @param shim
+ * @param Db
  */
 common.instrumentDb = function instrumentDb(shim, Db) {
   if (Db && Db.prototype) {
@@ -62,6 +64,7 @@ common.instrumentDb = function instrumentDb(shim, Db) {
 
 /**
  * Sets up the desc for all instrumented query methods
+ *
  * @param {Shim} shim
  * @param {string} methodName
  */
@@ -123,7 +126,7 @@ common.captureAttributesOnStarted = function captureAttributesOnStarted(shim, in
  * @param {Shim} shim
  * @param {string} connStr
  * @param {string} db database name
- * @param {Object} client mongo client instance
+ * @param {object} client mongo client instance
  */
 function setHostPort(shim, connStr, db, client) {
   const parts = connStr.split(':')
@@ -153,6 +156,9 @@ function setHostPort(shim, connStr, db, client) {
  * for the query segment. v4 refactored where the toplogy is stored.
  * You can now get the details via the client obj that's deeply nested
  * See: https://github.com/mongodb/node-mongodb-native/pull/2594/files#diff-1d214e57ddda9095d296e5700ebce701333bfefcf417e234c584d14091b2f50dR168
+ *
+ * @param shim
+ * @param obj
  */
 function getInstanceAttributeParameters(shim, obj) {
   if (obj.s && obj.s.db && obj.s.topology) {
@@ -197,8 +203,10 @@ function getInstanceAttributeParameters(shim, obj) {
   }
 
   function doCapture(conf, database) {
-    let host = null
-    let port = null
+    // in older versions of 3.x the host/port
+    // lived directly on the topology.s.options
+    let host = conf.host
+    let port = conf.port
 
     // servers is an array but we will always pull the first for consistency
     if (conf.servers && conf.servers.length) {

package/lib/parse-proc-cpuinfo.js

@@ -17,6 +17,12 @@ function parseProcCPUInfo(data) {
     packages: null
   }
 
+  // In some rare cases the OS may be locked down so that you cannot retrieve this info.
+  if (!data) {
+    logger.debug('No CPU data to parse, returning empty stats.')
+    return processorStats
+  }
+
   // separate the processors
   let splitData = data.split('\n').map(function formatAttribute(attr) {
     return attr.split(':').map(function eliminateExtraWhitespace(s) {
@@ -34,7 +40,7 @@ function parseProcCPUInfo(data) {
 
   splitData = collapseMultilineValues(splitData)
 
-  const processors = seperateProcessors(splitData)
+  const processors = separateProcessors(splitData)
 
   processorStats = countProcessorStats(processors)
   if (!processorStats.cores) {
@@ -73,7 +79,7 @@ function collapseMultilineValues(li) {
 
 // walk through the processed list of key, value pairs and populate
 // objects till you find a collision
-function seperateProcessors(processorData) {
+function separateProcessors(processorData) {
   const processors = []
   let processor = Object.create(null)
   for (let i = 0; i < processorData.length; ++i) {

package/lib/parse-proc-meminfo.js

@@ -10,6 +10,12 @@ const logger = require('./logger.js').child({ component: 'proc-meminfo' })
 module.exports = parseProcMeminfo
 
 function parseProcMeminfo(data) {
+  // In some rare cases the OS may be locked down so that you cannot retrieve this info.
+  if (!data) {
+    logger.debug('No memory data to parse.')
+    return null
+  }
+
   const memTotal = parseInt(data.replace(/MemTotal:\s*(\d*)\skB/, '$1'), 10)
 
   if (memTotal) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "newrelic",
-  "version": "8.5.0",
+  "version": "8.5.1",
   "author": "New Relic Node.js agent team <nodejs@newrelic.com>",
   "license": "Apache-2.0",
   "contributors": [
@@ -177,8 +177,9 @@
     "@newrelic/eslint-config": "^0.0.3",
     "@newrelic/newrelic-oss-cli": "^0.1.2",
     "@newrelic/proxy": "^2.0.0",
-    "@newrelic/test-utilities": "^6.0.0",
+    "@newrelic/test-utilities": "^6.1.1",
     "@octokit/rest": "^18.0.15",
+    "@slack/bolt": "^3.7.0",
     "ajv": "^6.12.6",
     "architect": "*",
     "benchmark": "^2.1.4",