newrelic 8.17.0 → 8.17.1

package/NEWS.md

@@ -1,3 +1,10 @@
+### v8.17.1 (2022-08-02)
+ * Fixed issue where instrumetned code invoked within a @grpc/grpc-js client callback would not get tracked by the agent.
+
+   Bound the external client segment to the onReceiveStatus listener to propagate transaction context to the grpc client callbacks.
+
+ * Fixed issue with truncate in `lib/util/application-logging.js`. It now checks that the argument is a string before checking its length.
+
 ### v8.17.0 (2022-07-27)
 
 * Added instrumentation for `grpc-js` server unary, client-streaming, server-streaming and bidirectional streaming handlers.
@@ -95,7 +102,7 @@
     * Added sent, seen and dropped metrics that collected on every harvest cycle around log lines.
 
     * Added supportability metrics for some popular logging frameworks.
-    
+
     * Added supportability metrics to record if the logging features are enabled.
 
     * Added a storage mechanisms to transactions to keep logs until transaction ends.
@@ -160,7 +167,7 @@
 
 * Removed upper-bound testing from restify versioned tests so future major versions will be covered.
 
-* Removed upper-bound testing from mysql2 versioned tests to cover existing and future major versions. 
+* Removed upper-bound testing from mysql2 versioned tests to cover existing and future major versions.
 
   Continues to skip version 1.6.2 which had a bug that broke tests which was resolved in 1.6.3.
 

package/THIRD_PARTY_NOTICES.md

@@ -26,7 +26,6 @@ code, the source code can be found at [https://github.com/newrelic/node-newrelic
 * [json-stringify-safe](#json-stringify-safe)
 * [readable-stream](#readable-stream)
 * [semver](#semver)
-* [winston-transport](#winston-transport)
 
 **[devDependencies](#devDependencies)**
 
@@ -295,7 +294,7 @@ This product includes source derived from [@grpc/grpc-js](https://github.com/grp
 
 ### @grpc/proto-loader
 
-This product includes source derived from [@grpc/proto-loader](https://github.com/grpc/grpc-node) ([v0.6.13](https://github.com/grpc/grpc-node/tree/v0.6.13)), distributed under the [Apache-2.0 License](https://github.com/grpc/grpc-node/blob/v0.6.13/LICENSE):
+This product includes source derived from [@grpc/proto-loader](https://github.com/grpc/grpc-node) ([v0.6.9](https://github.com/grpc/grpc-node/tree/v0.6.9)), distributed under the [Apache-2.0 License](https://github.com/grpc/grpc-node/blob/v0.6.9/LICENSE):
 
 ```
                                  Apache License
@@ -1330,36 +1329,6 @@ WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
 ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR
 IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 
-```
-
-### winston-transport
-
-This product includes source derived from [winston-transport](https://github.com/winstonjs/winston-transport) ([v4.5.0](https://github.com/winstonjs/winston-transport/tree/v4.5.0)), distributed under the [MIT License](https://github.com/winstonjs/winston-transport/blob/v4.5.0/LICENSE):
-
-```
-The MIT License (MIT)
-
-Copyright (c) 2015 Charlie Robbins & the contributors.
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all
-copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.
-
-
 ```
 
 
@@ -1800,7 +1769,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
 
 ### @newrelic/test-utilities
 
-This product includes source derived from [@newrelic/test-utilities](https://github.com/newrelic/node-test-utilities) ([v6.5.5](https://github.com/newrelic/node-test-utilities/tree/v6.5.5)), distributed under the [Apache-2.0 License](https://github.com/newrelic/node-test-utilities/blob/v6.5.5/LICENSE):
+This product includes source derived from [@newrelic/test-utilities](https://github.com/newrelic/node-test-utilities) ([v6.5.2](https://github.com/newrelic/node-test-utilities/tree/v6.5.2)), distributed under the [Apache-2.0 License](https://github.com/newrelic/node-test-utilities/blob/v6.5.2/LICENSE):
 
 ```
                                  Apache License
@@ -2515,7 +2484,7 @@ https://creativecommons.org/licenses/by-sa/4.0/
 
 ### got
 
-This product includes source derived from [got](https://github.com/sindresorhus/got) ([v11.8.5](https://github.com/sindresorhus/got/tree/v11.8.5)), distributed under the [MIT License](https://github.com/sindresorhus/got/blob/v11.8.5/license):
+This product includes source derived from [got](https://github.com/sindresorhus/got) ([v8.3.2](https://github.com/sindresorhus/got/tree/v8.3.2)), distributed under the [MIT License](https://github.com/sindresorhus/got/blob/v8.3.2/license):
 
 ```
 MIT License
@@ -3295,12 +3264,12 @@ THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 ### tap
 
-This product includes source derived from [tap](https://github.com/tapjs/node-tap) ([v16.0.1](https://github.com/tapjs/node-tap/tree/v16.0.1)), distributed under the [ISC License](https://github.com/tapjs/node-tap/blob/v16.0.1/LICENSE):
+This product includes source derived from [tap](https://github.com/tapjs/node-tap) ([v15.1.6](https://github.com/tapjs/node-tap/tree/v15.1.6)), distributed under the [ISC License](https://github.com/tapjs/node-tap/blob/v15.1.6/LICENSE):
 
 ```
 The ISC License
 
-Copyright (c) 2011-2022 Isaac Z. Schlueter and Contributors
+Copyright (c) Isaac Z. Schlueter and Contributors
 
 Permission to use, copy, modify, and/or distribute this software for any
 purpose with or without fee is hereby granted, provided that the above

package/lib/instrumentation/grpc-js/grpc.js

@@ -94,9 +94,11 @@ function wrapStart(shim, original) {
         segment.addAttribute('http.url', url)
         segment.addAttribute('http.method', this.methodName)
 
+        if (originalListener && originalListener.onReceiveStatus) {
+          const onReceiveStatuts = shim.bindSegment(originalListener.onReceiveStatus, segment)
+          onReceiveStatuts(status)
+        }
         segment.end()
-
-        originalListener && originalListener.onReceiveStatus(status)
       }
 
       args[1] = nrListener

package/lib/util/application-logging.js

@@ -16,7 +16,7 @@ const { LOGGING } = require('../metrics/names')
  * @returns {string}
  */
 utils.truncate = function truncate(str) {
-  if (str.length > OUTPUT_LENGTH) {
+  if (typeof str === 'string' && str.length > OUTPUT_LENGTH) {
     return str.substring(0, MAX_LENGTH) + '...'
   }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "newrelic",
-  "version": "8.17.0",
+  "version": "8.17.1",
   "author": "New Relic Node.js agent team <nodejs@newrelic.com>",
   "license": "Apache-2.0",
   "contributors": [