newrelic 7.5.2 → 8.0.0

package/NEWS.md

@@ -1,3 +1,39 @@
+### v8.0.0 (2021-07-26)
+
+* Added official parity support for Node 16.
+
+* **BREAKING**: Dropped Node v10.x support. For further information on our support policy,
+  see: https://docs.newrelic.com/docs/agents/nodejs-agent/getting-started/compatibility-requirements-nodejs-agent.
+  * Upgraded `@newrelic/superagent` `@newrelic/aws-sdk` `@newrelic/koa` `@newrelic/native-metrics` and `@newrelic/test-utilities` to the latest major versions.
+  * Refactored creation of span event aggregator to prevent crash of gRPC when running on invalid Node.js version.
+  * Added check for minimum `node` version >= 12.
+  * Set package.json engines `node` field >= 12 and `npm` field to >=6.
+  * Removed Node v10 from ci workflow and smoke-test version matrix.
+  * Removed comments around replacing `temporarilyOverrideTapUncaughtBehavior` test helper function.
+  * Removed non-applicable semver checks for versions the agents no longer supports.
+
+* **BREAKING**: The agent no-longer includes the New Relic certificate bundle automatically when using the 'certificates' configuration (commonly with proxies). If you find this breaking your current environment, you may leverage a feature-flag to temporarily restore this functionality. Example configuration: feature_flag: { certificate_bundle: true }. In this case, we recommend getting a certificate bundle for your environment such as the one from Mozilla. The New Relic bundle and feature flag will be fully removed in next major release.
+   * Defaulted config.feature_flags.certificate_bundle to false.
+
+* **BREAKING**: Removed `serverless_mode` as a feature flag.
+
+  The standard `serverless_mode` configuration still exists.
+
+* Added hapi 19 and 20 to versioned tests for Node.js `>=12` and `<16`
+ * Added hapi `^20.1.2` to versioned tests for for Node.js `>=16`
+
+* Upgraded tap to v15.
+
+* Upgraded https-proxy-agent to v5.0.0.
+
+* Updated linting to always use latest LTS Node version.
+
+* Updated CI and Smoke Test scripts to use setup-node@v2.
+
+* Added `no-const-assign` to eslint ruleset.
+
+* Pinned mongodb versioned tests to <4.0.0.
+
 ### v7.5.2 (2021-07-07)
 
 * Fixed bug where promise-based cursor methods would not properly measure the duration of execution.

package/THIRD_PARTY_NOTICES.md

@@ -495,7 +495,7 @@ This product includes source derived from [@grpc/proto-loader](https://github.co
 
 ### @newrelic/aws-sdk
 
-This product includes source derived from [@newrelic/aws-sdk](https://github.com/newrelic/node-newrelic-aws-sdk) ([v3.1.0](https://github.com/newrelic/node-newrelic-aws-sdk/tree/v3.1.0)), distributed under the [Apache-2.0 License](https://github.com/newrelic/node-newrelic-aws-sdk/blob/v3.1.0/LICENSE):
+This product includes source derived from [@newrelic/aws-sdk](https://github.com/newrelic/node-newrelic-aws-sdk) ([v4.0.1](https://github.com/newrelic/node-newrelic-aws-sdk/tree/v4.0.1)), distributed under the [Apache-2.0 License](https://github.com/newrelic/node-newrelic-aws-sdk/blob/v4.0.1/LICENSE):
 
 ```
                                  Apache License
@@ -703,7 +703,7 @@ This product includes source derived from [@newrelic/aws-sdk](https://github.com
 
 ### @newrelic/koa
 
-This product includes source derived from [@newrelic/koa](https://github.com/newrelic/node-newrelic-koa) ([v5.0.0](https://github.com/newrelic/node-newrelic-koa/tree/v5.0.0)), distributed under the [Apache-2.0 License](https://github.com/newrelic/node-newrelic-koa/blob/v5.0.0/LICENSE):
+This product includes source derived from [@newrelic/koa](https://github.com/newrelic/node-newrelic-koa) ([v6.0.1](https://github.com/newrelic/node-newrelic-koa/tree/v6.0.1)), distributed under the [Apache-2.0 License](https://github.com/newrelic/node-newrelic-koa/blob/v6.0.1/LICENSE):
 
 ```
 Apache License
@@ -912,7 +912,7 @@ Apache License
 
 ### @newrelic/superagent
 
-This product includes source derived from [@newrelic/superagent](https://github.com/newrelic/node-newrelic-superagent) ([v4.0.0](https://github.com/newrelic/node-newrelic-superagent/tree/v4.0.0)), distributed under the [Apache-2.0 License](https://github.com/newrelic/node-newrelic-superagent/blob/v4.0.0/LICENSE):
+This product includes source derived from [@newrelic/superagent](https://github.com/newrelic/node-newrelic-superagent) ([v5.0.1](https://github.com/newrelic/node-newrelic-superagent/tree/v5.0.1)), distributed under the [Apache-2.0 License](https://github.com/newrelic/node-newrelic-superagent/blob/v5.0.1/LICENSE):
 
 ```
                                  Apache License
@@ -1208,7 +1208,7 @@ SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 ### https-proxy-agent
 
-This product includes source derived from [https-proxy-agent](https://github.com/TooTallNate/node-https-proxy-agent) ([v4.0.0](https://github.com/TooTallNate/node-https-proxy-agent/tree/v4.0.0)), distributed under the [MIT License](https://github.com/TooTallNate/node-https-proxy-agent/blob/v4.0.0/README.md):
+This product includes source derived from [https-proxy-agent](https://github.com/TooTallNate/node-https-proxy-agent) ([v5.0.0](https://github.com/TooTallNate/node-https-proxy-agent/tree/v5.0.0)), distributed under the [MIT License](https://github.com/TooTallNate/node-https-proxy-agent/blob/v5.0.0/README.md):
 
 ```
 MIT License
@@ -1553,7 +1553,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
 
 ### @newrelic/test-utilities
 
-This product includes source derived from [@newrelic/test-utilities](https://github.com/newrelic/node-test-utilities) ([v5.0.0](https://github.com/newrelic/node-test-utilities/tree/v5.0.0)), distributed under the [Apache-2.0 License](https://github.com/newrelic/node-test-utilities/blob/v5.0.0/LICENSE):
+This product includes source derived from [@newrelic/test-utilities](https://github.com/newrelic/node-test-utilities) ([v6.0.0](https://github.com/newrelic/node-test-utilities/tree/v6.0.0)), distributed under the [Apache-2.0 License](https://github.com/newrelic/node-test-utilities/blob/v6.0.0/LICENSE):
 
 ```
                                  Apache License
@@ -2066,7 +2066,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
 
 ### glob
 
-This product includes source derived from [glob](https://github.com/isaacs/node-glob) ([v7.1.6](https://github.com/isaacs/node-glob/tree/v7.1.6)), distributed under the [ISC License](https://github.com/isaacs/node-glob/blob/v7.1.6/LICENSE):
+This product includes source derived from [glob](https://github.com/isaacs/node-glob) ([v7.1.7](https://github.com/isaacs/node-glob/tree/v7.1.7)), distributed under the [ISC License](https://github.com/isaacs/node-glob/blob/v7.1.7/LICENSE):
 
 ```
 The ISC License
@@ -3003,7 +3003,7 @@ THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 ### tap
 
-This product includes source derived from [tap](https://github.com/tapjs/node-tap) ([v14.10.8](https://github.com/tapjs/node-tap/tree/v14.10.8)), distributed under the [ISC License](https://github.com/tapjs/node-tap/blob/v14.10.8/LICENSE):
+This product includes source derived from [tap](https://github.com/tapjs/node-tap) ([v15.0.9](https://github.com/tapjs/node-tap/tree/v15.0.9)), distributed under the [ISC License](https://github.com/tapjs/node-tap/blob/v15.0.9/LICENSE):
 
 ```
 The ISC License

package/index.js

@@ -48,16 +48,17 @@ function initialize() {
       preAgentTime
     )
 
-    // TODO: Update this check when Node v10 is deprecated.
-    if (psemver.satisfies('<10.0.0')) {
+    if (!psemver.satisfies(pkgJSON.engines.node)) {
+      // TODO: Update this message when Node v12 is deprecated.
       message = 'New Relic for Node.js requires a version of Node equal to or\n' +
-                'greater than 10.0.0. Not starting!'
+      'greater than 12.0.0. Not starting!'
 
       logger.error(message)
       throw new Error(message)
+    }
 
-      // TODO: Update this check when Node v16 support is added
-    } else if (!psemver.satisfies(pkgJSON.engines.node) || psemver.satisfies('>=15.0.0')) {
+    // TODO: Update this check when Node v18 support is added
+    if (psemver.satisfies('>=17.0.0')) {
       logger.warn(
         'New Relic for Node.js %s has not been tested on Node.js %s. Please ' +
         'update the agent or downgrade your version of Node.js',

package/lib/config/index.js

@@ -17,7 +17,6 @@ const hashes = require('../util/hashes')
 const os = require('os')
 const parseKey = require('../collector/key-parser').parseKey
 const path = require('path')
-const psemver = require('../util/process-version')
 const stringify = require('json-stringify-safe')
 const util = require('util')
 const MergeServerConfig = require('./merge-server-config')
@@ -94,7 +93,7 @@ function fromObjectList(setting) {
 
 function _findConfigFile() {
   const configFileCandidates = getConfigFileLocations().reduce((files, configPath) => {
-    const configFiles = getConfigFileNames().map(filename => 
+    const configFiles = getConfigFileNames().map(filename =>
       path.join(path.resolve(configPath), filename)
     )
 
@@ -885,10 +884,7 @@ Config.prototype.logUnknown = function logUnknown(json, key) {
  * Return the availability of async_hook for use by the agent.
  */
 Config.prototype.checkAsyncHookStatus = function checkAsyncHookStatus() {
-  return (
-    this.feature_flag.await_support &&
-    (psemver.satisfies('>=8') || psemver.prerelease())
-  )
+  return this.feature_flag.await_support
 }
 
 /**
@@ -1326,9 +1322,6 @@ Config.prototype._canonicalize = function _canonicalize() {
     )
   }
 
-  this.serverless_mode.enabled = this.serverless_mode.enabled
-    && this.feature_flag.serverless_mode
-
   if (this.license_key) {
     this.license_key = this.license_key.trim()
   }

package/lib/feature_flags.js

@@ -9,13 +9,10 @@
 exports.prerelease = {
   express5: false,
   await_support: true,
-  serverless_mode: true, // TODO: Move to released & remove code checks next Major.
   promise_segments: false,
   reverse_naming_rules: false,
   fastify_instrumentation: false,
-  // Starts by defaulting true as introducing for deprecation/removal purposes.
-  // Will eventually set false prior full removal of feature.
-  certificate_bundle: true,
+  certificate_bundle: false,
   new_promise_tracking: false
 }
 
@@ -28,6 +25,7 @@ exports.released = [
   'express_segments',
   'native_metrics',
   'protocol_17',
+  'serverless_mode',
   'send_request_uri_attribute',
   'synthetics',
   'dt_format_w3c'

package/lib/spans/create-span-event-aggregator.js

@@ -5,7 +5,6 @@
 
 'use strict'
 
-const psemver = require('../util/process-version')
 const logger = require('../logger')
 const SpanEventAggregator = require('./span-event-aggregator')
 const StreamingSpanEventAggregator = require('./streaming-span-event-aggregator')
@@ -13,22 +12,7 @@ const StreamingSpanEventAggregator = require('./streaming-span-event-aggregator'
 function createSpanEventAggregator(config, collector, metrics) {
   const trace_observer = config.infinite_tracing.trace_observer
 
-  let shouldCreateStreaming = false
   if (trace_observer.host) {
-    // TODO: ideally this validation and configuration clearing would happen
-    // in the config. Since we don't currently have a way to generate
-    // support metrics in the config, keeping this related logic together here.
-    // If logic happened prior, could merely check for existence of trace_observer.host.
-    shouldCreateStreaming = validateInfiniteTracing()
-
-    if (!shouldCreateStreaming) {
-      // Explicitly disable for any downstream consumers
-      trace_observer.host = ''
-      trace_observer.port = ''
-    }
-  }
-
-  if (shouldCreateStreaming) {
     trace_observer.host = trace_observer.host.trim()
 
     if (typeof trace_observer.port !== 'string') {
@@ -36,7 +20,17 @@ function createSpanEventAggregator(config, collector, metrics) {
     }
     trace_observer.port = trace_observer.port.trim()
 
-    return createStreamingAggregator(config, collector, metrics)
+    try {
+      return createStreamingAggregator(config, collector, metrics)
+    } catch (err) {
+      logger.warn(err, 'Failed to create streaming span event aggregator for infinite tracing. ' +
+        'Reverting to standard span event aggregator and disabling infinite tracing')
+      config.infinite_tracing.trace_observer = {
+        host: '',
+        port: ''
+      }
+      return createStandardAggregator(config, collector, metrics)
+    }
   }
 
   return createStandardAggregator(config, collector, metrics)
@@ -44,12 +38,10 @@ function createSpanEventAggregator(config, collector, metrics) {
 
 function createStreamingAggregator(config, collector, metrics) {
   logger.trace('Creating streaming span event aggregator for infinite tracing.')
-
-  // loading the class here to ensure its behind a feature flag
-  // and won't trigger a grpc load in node 8
   const GrpcConnection = require('../grpc/connection')
-  const connection = new GrpcConnection(config.infinite_tracing.trace_observer, metrics)
   const SpanStreamer = require('./span-streamer')
+
+  const connection = new GrpcConnection(config.infinite_tracing.trace_observer, metrics)
   const spanStreamer = new SpanStreamer(
     config.license_key,
     connection,
@@ -63,9 +55,7 @@ function createStreamingAggregator(config, collector, metrics) {
     span_streamer: spanStreamer
   }
 
-  const aggregator = new StreamingSpanEventAggregator(opts, collector, metrics)
-
-  return aggregator
+  return new StreamingSpanEventAggregator(opts, collector, metrics)
 }
 
 function createStandardAggregator(config, collector, metrics) {
@@ -76,20 +66,7 @@ function createStandardAggregator(config, collector, metrics) {
     limit: config.event_harvest_config.harvest_limits.span_event_data
   }
 
-  const aggregator = new SpanEventAggregator(opts, collector, metrics)
-  return aggregator
-}
-
-function validateInfiniteTracing() {
-  // TODO: Remove semver check when Node 10 support dropped.
-  if (!psemver.satisfies('>=10.10.0')) {
-    logger.warn(
-      'Infinite tracing disabled: this version of Node is not supported (must be >=10.10.0)'
-    )
-    return false
-  }
-
-  return true
+  return new SpanEventAggregator(opts, collector, metrics)
 }
 
 module.exports = createSpanEventAggregator

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "newrelic",
-  "version": "7.5.2",
+  "version": "8.0.0",
   "author": "New Relic Node.js agent team <nodejs@newrelic.com>",
   "license": "Apache-2.0",
   "contributors": [
@@ -111,8 +111,8 @@
   ],
   "homepage": "http://github.com/newrelic/node-newrelic",
   "engines": {
-    "node": ">=10.0.0",
-    "npm": ">=3.0.0"
+    "node": ">=12.0.0",
+    "npm": ">=6.0.0"
   },
   "directories": {
     "lib": "lib"
@@ -122,7 +122,7 @@
     "ca-gen": "./bin/update-ca-bundle.sh",
     "docker-env": "./bin/docker-env-vars.sh",
     "docs": "npm ci && jsdoc -c ./jsdoc-conf.json --private -r .",
-    "integration": "npm run prepare-test && npm run sub-install && time tap --no-esm test/integration/**/**/*.tap.js --timeout=180 --no-coverage",
+    "integration": "npm run prepare-test && npm run sub-install && time tap test/integration/**/**/*.tap.js --timeout=180 --no-coverage --reporter classic",
     "prepare-test": "npm run ca-gen && npm run ssl && npm run docker-env",
     "lint": "eslint ./*.js lib test bin",
     "public-docs": "npm ci && jsdoc -c ./jsdoc-conf.json --tutorials examples/shim api.js lib/shim/ lib/transaction/handle.js && cp examples/shim/*.png out/",
@@ -132,11 +132,13 @@
     "ssl": "./bin/ssl.sh",
     "sub-install": "node test/bin/install_sub_deps",
     "test": "npm run integration && npm run unit",
-    "unit": "rm -f newrelic_agent.log && time tap --test-regex='(\\/|^test\\/unit\\/.*\\.test\\.js)$' --timeout=180 --no-coverage",
+    "unit": "rm -f newrelic_agent.log && time tap --test-regex='(\\/|^test\\/unit\\/.*\\.test\\.js)$' --timeout=180 --no-coverage --reporter classic",
     "update-cross-agent-tests": "./bin/update-cats.sh",
     "versioned-tests": "./bin/run-versioned-tests.sh",
     "update-changelog-version": "node ./bin/update-changelog-version",
-    "versioned": "npm run prepare-test && time ./bin/run-versioned-tests.sh",
+    "versioned": "npm run versioned:npm7",
+    "versioned:npm6": "npm run prepare-test && time ./bin/run-versioned-tests.sh",
+    "versioned:npm7": "npm run prepare-test && NPM7=1 time ./bin/run-versioned-tests.sh",
     "prepare": "husky install"
   },
   "bin": {
@@ -145,25 +147,24 @@
   "dependencies": {
     "@grpc/grpc-js": "^1.2.11",
     "@grpc/proto-loader": "^0.5.6",
-    "@newrelic/aws-sdk": "^3.1.0",
-    "@newrelic/koa": "^5.0.0",
-    "@newrelic/superagent": "^4.0.0",
+    "@newrelic/aws-sdk": "^4.0.1",
+    "@newrelic/koa": "^6.0.1",
+    "@newrelic/superagent": "^5.0.1",
     "@tyriar/fibonacci-heap": "^2.0.7",
     "async": "^3.2.0",
     "concat-stream": "^2.0.0",
-    "https-proxy-agent": "^4.0.0",
+    "https-proxy-agent": "^5.0.0",
     "json-stringify-safe": "^5.0.0",
     "readable-stream": "^3.6.0",
     "semver": "^5.3.0"
   },
   "optionalDependencies": {
-    "@newrelic/native-metrics": "^6.0.0"
+    "@newrelic/native-metrics": "^7.0.1"
   },
   "devDependencies": {
     "@newrelic/proxy": "^2.0.0",
-    "@newrelic/test-utilities": "^5.1.0",
+    "@newrelic/test-utilities": "^6.0.0",
     "@octokit/rest": "^18.0.15",
-    "JSV": "~4.0.2",
     "architect": "*",
     "benchmark": "^2.1.4",
     "bluebird": "^3.4.7",
@@ -178,6 +179,7 @@
     "http-errors": "^1.7.3",
     "husky": "^6.0.0",
     "jsdoc": "^3.6.3",
+    "JSV": "~4.0.2",
     "lint-staged": "^11.0.0",
     "memcached": ">=0.2.8",
     "minami": "^1.1.1",
@@ -192,7 +194,7 @@
     "rimraf": "^2.6.3",
     "should": "*",
     "sinon": "^4.5.0",
-    "tap": "^14.10.8",
+    "tap": "^15.0.9",
     "temp": "^0.8.1",
     "through": "^2.3.6",
     "when": "*"