newrelic 7.1.2 → 7.1.3

package/NEWS.md

@@ -1,3 +1,36 @@
+### v7.1.3 (2021-03-09)
+
+* Bumped @grpc/grpc-js to ^1.2.7.
+
+* Removed index-bad-config test which tested a no-longer possible use-case.
+
+* Removed license-key test logic from serverless-harvest test.
+
+  Serverless mode does not require a license key as data transfer is handled by the integration.
+
+* Added support metric to be able to track usage of cert bundle via usage of custom certificates.
+
+* Removed requirement to configure application name when running in AWS Lambda (serverless mode).
+
+  Application name is not currently leveraged by New Relic for Lambda invocations. The agent now defaults the application name in serverless mode to remove the requirement of end-user configuration while handling cases if it were to be leveraged in the future.
+
+* Stopped binding/propagating segments via `setImmediate` for ended transactions.
+
+* Fixed bug where agent would attempt to call the 'preconnect' endpoint on the redirect host returned by the previous 'preconnect' call when reconnecting to the New Relic servers.
+
+  The 'preconnect' calls will now always use the original agent configuration value. Subsequent endpoints (connect, harvest endpoints, etc.) will continue to leverage the new redirect host value returned by 'preconnect.' The original config values are no-longer overridden.
+
+* Fixed issue where a call to `transaction.acceptDistributedTraceHeaders` would throw an error when the `headers` parameter is a string.
+
+* Improved clarity of logging between 'no log file' or disabled agent startup issues.
+
+  * Logs no-config file error to initialized logger (stdout) in addition to existing console.error() logging.
+  * Adds specific message to no config file separate from being disabled.
+
+* Removed aws-sdk versioned test filtering.
+
+* Removed unused Travis CI scripts.
+
 ### v7.1.2 (2021-02-24)
 
 * Fixed bug where the agent failed to reconnect to Infinite Tracing gRPC streams on Status OK at higher log levels.

package/bin/create-github-release.js

@@ -0,0 +1,109 @@
+'use strict'
+
+const fs = require('fs')
+const {program} = require('commander')
+
+const Github = require('./github')
+const { indexOf } = require('benchmark')
+
+const DEFAULT_FILE_NAME = 'NEWS.md'
+/** e.g. v7.2.1 */
+const TAG_VALID_REGEX = /v\d+\.\d+\.\d+/
+
+program.requiredOption('--tag <tag>', 'tag name to create GitHub release for')
+program.option('--repo-owner <repoOwner>', 'repository owner', 'newrelic')
+program.option('--release-notes-file <releaseNotesFile>', 'path to release notes file', DEFAULT_FILE_NAME)
+program.option('-f --force', 'bypass validation')
+
+async function createRelease() {
+  // Parse commandline options inputs
+  program.parse()
+
+  const options = program.opts()
+
+  console.log('Script running with following options: ', JSON.stringify(options))
+
+  const github = new Github(options.repoOwner)
+
+  try {
+    const tagName = options.tag.replace('refs/tags/', '')
+    console.log('Using tag name: ', tagName)
+
+    logStep('Validation')
+    if (options.force) {
+      console.log('--force set. Skipping validation logic')
+    }
+
+    if (!options.force && !TAG_VALID_REGEX.exec(tagName)) {
+      console.log('Tag arg invalid (%s). Valid tags in form: v#.#.# (e.g. v7.2.1)', tagName)
+      stopOnError()
+    }
+
+    logStep('Get Release Notes from File')
+    const body = await getReleaseNotes(tagName, options.releaseNotesFile)
+
+    logStep('Create Release')
+    await github.createRelease(tagName, tagName, body)
+
+    console.log('*** Full Run Successful ***')
+  } catch (err) {
+    if (err.status && err.status === 404) {
+      console.log('404 status error detected. For octokit, this may mean insuffient permissions.')
+      console.log('Ensure you have a valid GITHUB_TOKEN set in your env vars.')
+    }
+
+    stopOnError(err)
+  }
+}
+
+async function getReleaseNotes(tagName, releaseNotesFile) {
+  console.log('Retrieving release notes from file: ', releaseNotesFile)
+
+  const data = await readReleaseNoteFile(releaseNotesFile)
+
+  const currentVersionHeader = `### ${tagName}`
+  if (data.indexOf(currentVersionHeader) !== 0) {
+    throw new Error(`Current tag (${currentVersionHeader}) not first line of release notes.`)
+  }
+
+  const sections = data.split('### ', 2)
+  if (sections.length !== 2) {
+    throw new Error('Did not split into multiple sections. Double check notes format.')
+  }
+
+  const tagSection = sections[1]
+  // e.g. v7.1.2 (2021-02-24)\n\n
+  const headingRegex = /^v\d+\.\d+\.\d+ \(\d{4}-\d{2}-\d{2}\)\n\n/
+  const headingRemoved = tagSection.replace(headingRegex, '')
+
+  return headingRemoved
+}
+
+async function readReleaseNoteFile(file) {
+  const promise = new Promise((resolve, reject) => {
+    fs.readFile(file, 'utf8', function (err, data) {
+      if (err) {
+        return reject(err)
+      }
+
+      resolve(data)
+    })
+  })
+
+  return promise
+}
+
+function stopOnError(err) {
+  if (err) {
+    console.error(err)
+  }
+
+  console.log('Halting execution with exit code: 1')
+  process.exit(1)
+}
+
+function logStep(step) {
+  console.log(`\n ----- [Step]: ${step} -----\n`)
+}
+
+createRelease()

package/bin/create-release-tag.js

@@ -0,0 +1,95 @@
+'use strict'
+
+const {program} = require('commander')
+
+const checkWorkflowRun = require('./check-workflow-run')
+const git = require('./git-commands')
+
+// Add command line options
+program.option('-b, --branch <branch>', 'release branch', 'main')
+program.option('-o, --repo-owner <repoOwner>', 'repository owner', 'newrelic')
+program.option('-f --force', 'bypass validation')
+
+async function createReleaseTag() {
+  // Parse commandline options inputs
+  program.parse()
+
+  const options = program.opts()
+
+  console.log('Script running with following options: ', JSON.stringify(options))
+
+  const branch = options.branch.replace('refs/heads/', '')
+  const repoOwner = options.repoOwner
+
+  if (options.force) {
+    console.log('--force set. Skipping validation logic')
+  }
+
+  try {
+    const isValid = options.force || (
+      await validateLocalChanges() &&
+      await validateCurrentBranch(branch) &&
+      await checkWorkflowRun(repoOwner, branch)
+    )
+
+    if (!isValid) {
+      process.exit(1)
+    }
+
+    const packagePath = '../package.json'
+    console.log('Extracting new version from package.json here: ', )
+    const packageInfo = require(packagePath)
+
+    const version = `v${packageInfo.version}`
+    console.log('New version is: ', version)
+
+    console.log('Creating and pushing tag')
+
+    await git.createAnnotatedTag(version, version)
+    await git.pushTags()
+
+    console.log('*** Full Run Successful ***')
+  } catch (err) {
+    console.log(err)
+
+    process.exit(1)
+  }
+}
+
+async function validateLocalChanges() {
+  try {
+    const localChanges = await git.getLocalChanges()
+    if (localChanges.length > 0) {
+      console.log('Local changes detected: ', localChanges)
+      console.log('Please commit to a feature branch or stash changes and then try again.')
+      return false
+    }
+
+    return true
+  } catch (err) {
+    console.error(err)
+    return false
+  }
+}
+
+async function validateCurrentBranch(branch) {
+  try {
+    const currentBranch = await git.getCurrentBranch()
+
+    if (branch != currentBranch) {
+      console.log(
+        'Current checked-out branch (%s) does not match expected (%s)',
+        currentBranch,
+        branch
+      )
+      return false
+    }
+
+    return true
+  } catch (err) {
+    console.error(err)
+    return false
+  }
+}
+
+createReleaseTag()

package/bin/git-commands.js

@@ -0,0 +1,110 @@
+'use strict'
+
+const { exec } = require('child_process')
+
+async function getPushRemotes() {
+  const stdout = await execAsPromise('git remote -v')
+
+  const remotes = stdout.split('\n')
+  const processedRemotes = remotes.reduce((remotePairs, currentRemote) => {
+    const parts = currentRemote.split('\t')
+    if (parts.length < 2) {
+      return remotePairs
+    }
+
+    const [name, url] = parts
+    if (url.indexOf('(push)') >= 0) {
+      remotePairs[name] = url
+    }
+
+    return remotePairs
+  }, {})
+
+  return processedRemotes
+}
+
+async function getLocalChanges() {
+  const stdout = await execAsPromise('git status --short --porcelain')
+  const changes = stdout.split('\n').filter((line) => {
+    return line.length > 0
+  })
+
+  return changes
+}
+
+async function getCurrentBranch() {
+  const stdout = await execAsPromise('git branch --show-current')
+  const branch = stdout.trim()
+
+  return branch
+}
+
+async function checkoutNewBranch(name) {
+  const stdout = await execAsPromise(`git checkout -b ${name}`)
+  const output = stdout.trim()
+
+  return output
+}
+
+async function addAllFiles() {
+  const stdout = await execAsPromise(`git add .`)
+  const output = stdout.trim()
+
+  return output
+}
+
+async function commit(message) {
+  const stdout = await execAsPromise(`git commit -m "${message}"`)
+  const output = stdout.trim()
+
+  return output
+}
+
+async function pushToRemote(remote, branchName) {
+  const stdout = await execAsPromise(`git push --set-upstream ${remote} ${branchName}`)
+  const output = stdout.trim()
+
+  return output
+}
+
+async function createAnnotatedTag(name, message) {
+  const stdout = await execAsPromise(`git tag -a ${name} -m ${message}`)
+  const output = stdout.trim()
+
+  return output
+}
+
+async function pushTags() {
+  const stdout = await execAsPromise('git push --tags')
+  const output = stdout.trim()
+
+  return output
+}
+
+function execAsPromise(command) {
+  const promise = new Promise((resolve, reject) => {
+    console.log(`Executing: '${command}'`)
+
+    exec(command, (err, stdout) => {
+      if (err) {
+        return reject(err)
+      }
+
+      resolve(stdout)
+    })
+  })
+
+  return promise
+}
+
+module.exports = {
+  getPushRemotes,
+  getLocalChanges,
+  getCurrentBranch,
+  checkoutNewBranch,
+  addAllFiles,
+  commit,
+  pushToRemote,
+  createAnnotatedTag,
+  pushTags
+}

package/bin/github.js

@@ -11,10 +11,9 @@ const octokit = new Octokit({
 })
 
 class Github {
-  constructor(repoOwner, repository) {
-    // Default to node agent repo for now
-    this.repoOwner = repoOwner || 'newrelic'
-    this.repository = repository || 'node-newrelic'
+  constructor(repoOwner = 'newrelic', repository = 'node-newrelic') {
+    this.repoOwner = repoOwner
+    this.repository = repository
   }
 
   async getLatestRelease() {
@@ -26,6 +25,18 @@ class Github {
     return result.data
   }
 
+  async createRelease(tag, name, body) {
+    const result = await octokit.repos.createRelease({
+      owner: this.repoOwner,
+      repo: this.repository,
+      tag_name: tag,
+      name: name,
+      body: body
+    })
+
+    return result.data
+  }
+
   async getTagByName(name) {
     const perPage = 100
 
@@ -114,6 +125,20 @@ class Github {
 
     return runs.data.workflow_runs[0]
   }
+
+  async createPR(options) {
+    const {head, base, title, body, draft} = options
+
+    await octokit.pulls.create({
+      owner: this.repoOwner,
+      repo: this.repository,
+      head: head,
+      base: base,
+      title: title,
+      body: body,
+      draft: draft
+    })
+  }
 }
 
 module.exports = Github

package/bin/npm-commands.js

@@ -0,0 +1,31 @@
+'use strict'
+
+const { exec } = require('child_process')
+
+async function version(typeOrVersion, shouldCommitAndTag) {
+  let command = `npm version ${typeOrVersion}`
+
+  command += shouldCommitAndTag ? '' : ' --no-git-tag-version'
+
+  await execAsPromise(command)
+}
+
+function execAsPromise(command) {
+  const promise = new Promise((resolve, reject) => {
+    console.log(`Executing: '${command}'`)
+
+    exec(command, (err, stdout) => {
+      if (err) {
+        return reject(err)
+      }
+
+      resolve(stdout)
+    })
+  })
+
+  return promise
+}
+
+module.exports = {
+  version
+}