newrelic 6.13.1 → 7.0.1

package/NEWS.md

@@ -1,4 +1,83 @@
-## 6.13.1 (2020-09-24):
+### 7.0.1 (2020-11-07):
+
+* Fixed a bug where spans queued up during backpressure situations would be improperly formatted and ultimately dropped when sent to an Infinite Tracing trace observer.
+* Updated @grpc/grpc-js to version v1.2.0.
+* Updated tap to clear up npm audit issues around lodash sub-dependency.
+
+### 7.0.0 (2020-11-09):
+
+* Added official parity support for Node 14
+
+* Dropped Node v8.x support. For further information on our support policy,
+  see: https://docs.newrelic.com/docs/agents/nodejs-agent/getting-started/compatibility-requirements-nodejs-agent.
+  * Removed Node v8.x from CI
+  * Adds check that minimum Node version is >=10 and warns if >=15
+  * Sets Node engine to >=10
+  * **BREAKING** Dropped support for Node v8.x HTTP get() function signature
+    * strictly uses global.URL class in http core instrumentation
+    * removes Nodejs 8.x - 9.x checks
+  * Update New Relic Dependencies to versions with updated Node version support
+    * @newrelic/aws-sdk v3.0.0
+    * @newrelic/koa v5.0.0
+    * @newrelic/native-metrics v6.0.0
+    * @newrelic/superagent v4.0.0
+    * @newrelic/test-utilities v5.0.0
+
+* **BREAKING** Removed deprecated setIgnoreTransaction API method
+
+* **BREAKING** Removed deprecated httpResponseCode, response.status and
+  httpResponseMessage http response attributes
+
+* **BREAKING** Removed the api.custom_parameters_enabled configuration item and
+  associated environment variable NEW_RELIC_API_CUSTOM_PARAMETERS. Please use
+  api.custom_attributes_enabled instead
+
+* **BREAKING** Removed deprecated Distributed Tracing API methods,
+  createDistributedTracePayload() and acceptDistributedTracePayload()
+
+* Finalized removal of ignored_params and capture_params
+
+* Added additional logging to W3C Trace Context header creation
+
+### 6.14.0 (2020-10-28):
+
+* Updated README for consistency.
+
+* Fixed issue where gRPC connection used for infinite tracing could throw if the server
+  shutdown during disconnect of an existing connection.
+
+* Bumped @grpc/grpc-js to 1.1.7.
+
+* Bumped @grpc/proto-loader to ^0.5.5.
+
+* Infinite tracing logging and support metric improvements.
+
+  * Increased logging level of certain infinite tracing / gRPC errors.
+  * Decreased logging interval of dropped span warning for infinite tracing.
+  * Added additional support metrics and logging for infinite tracing.
+
+* Fixed bug where errors would still be collected for transactions with ignored error
+  status codes in certain situations.
+
+* Converted errors ignore unit tests to tap API.
+
+* Added Node 14 to CI test coverage.
+
+  Many thanks to @jgeurts for the contribution.
+
+### 6.13.2 (2020-10-13):
+
+* Removed lodash as a development dependency
+
+* Check for named pipe existence before each flush
+
+  This removes the cached value used in 6.13.1
+
+* Update shim documentation
+
+  Thank you to @ronen-e for the contribution!
+
+### 6.13.1 (2020-09-24):
 
 * Fixed named-pipe check for lambda invocations to avoid race-condition.
 

package/README.md

@@ -10,7 +10,7 @@ In order to take full advantage of this package, make sure you have a [New Relic
 
 As with any instrumentation tool, please test before using in production.
 
-## Installation and getting started
+## Installation
 
 To use New Relic's Node.js agent entails these three steps, which are described in detail below:
 
@@ -57,9 +57,13 @@ If you're compiling your JavaScript and can't control the final `require` order,
     $ node -r newrelic your-program.js
     $ node --require newrelic your-program.js
 
+## Getting Started
+
 For more information on getting started, [check the Node.js docs](https://docs.newrelic.com/docs/agents/nodejs-agent/getting-started/introduction-new-relic-nodejs).
 
-## Using the API
+## Usage
+
+### Using the API
 
 The `newrelic` module returns an object with the Node agent's API methods attached.
 
@@ -72,7 +76,7 @@ The `newrelic` module returns an object with the Node agent's API methods attach
 
 You can read more about using the API over on the [New Relic documentation](https://docs.newrelic.com/docs/agents/nodejs-agent/api-guides/guide-using-nodejs-agent-api) site.
 
-## Core agent development and tests
+## Testing
 
 These are the steps to work on core agent features, with more detail below:
 
@@ -149,17 +153,22 @@ Please review [New Relic’s General Data Privacy Notice](https://newrelic.com/t
 
 See our [roadmap](./ROADMAP_Node.md), to learn more about our product vision, understand our plans, and provide us valuable feedback.
 
-## Contributing
+## Contribute
 
 We encourage your contributions to improve the Node.js agent! Keep in mind when you submit your pull request, you'll need to sign the CLA via the click-through using CLA-Assistant. You only have to sign the CLA one time per project.
+
 If you have any questions, or to execute our corporate CLA, required if your contribution is on behalf of a company,  please drop us an email at opensource@newrelic.com.
 
 **A note about vulnerabilities**
 
-As noted in our [security policy](https://github.com/newrelic/node-newrelic/security/policy), New Relic is committed to the privacy and security of our customers and their data. We believe that providing coordinated disclosure by security researchers and engaging with the security community are important means to achieve our security goals.
+As noted in our [security policy](../../security/policy), New Relic is committed to the privacy and security of our customers and their data. We believe that providing coordinated disclosure by security researchers and engaging with the security community are important means to achieve our security goals.
 
 If you believe you have found a security vulnerability in this project or any of New Relic's products or websites, we welcome and greatly appreciate you reporting it to New Relic through [HackerOne](https://hackerone.com/newrelic).
 
+If you would like to contribute to this project, review [these guidelines](./CONTRIBUTING.md).
+
+To [all contributors](https://github.com/newrelic/node-newrelic/graphs/contributors), we thank you!  Without your contribution, this project would not be what it is today.  We also host a community project page dedicated to [New Relic Node Agent](https://opensource.newrelic.com/projects/newrelic/node-newrelic).
+
 ## License
 
 The Node.js agent is licensed under the [Apache 2.0](http://apache.org/licenses/LICENSE-2.0.txt) License.

package/THIRD_PARTY_NOTICES.md

@@ -48,7 +48,6 @@ code, the source code can be found at [https://github.com/newrelic/node-newrelic
 * [got](#got)
 * [http-errors](#http-errors)
 * [jsdoc](#jsdoc)
-* [lodash](#lodash)
 * [memcached](#memcached)
 * [minami](#minami)
 * [mongodb](#mongodb)
@@ -69,15 +68,12 @@ code, the source code can be found at [https://github.com/newrelic/node-newrelic
 * [through](#through)
 * [when](#when)
 
-**[additional-licenses](#additional-licenses)**
-
-* [symantec](#symantec)
 
 ## dependencies
 
 ### @grpc/grpc-js
 
-This product includes source derived from [@grpc/grpc-js](https://github.com/grpc/grpc-node/tree/master/packages/grpc-js) ([v1.0.5](https://github.com/grpc/grpc-node/tree/master/packages/grpc-js/tree/v1.0.5)), distributed under the [Apache-2.0 License](https://github.com/grpc/grpc-node/tree/master/packages/grpc-js/blob/v1.0.5/LICENSE):
+This product includes source derived from [@grpc/grpc-js](https://github.com/grpc/grpc-node/tree/master/packages/grpc-js) ([v1.2.0](https://github.com/grpc/grpc-node/tree/master/packages/grpc-js/tree/v1.2.0)), distributed under the [Apache-2.0 License](https://github.com/grpc/grpc-node/tree/master/packages/grpc-js/blob/v1.2.0/LICENSE):
 
 ```
                                  Apache License
@@ -286,7 +282,7 @@ This product includes source derived from [@grpc/grpc-js](https://github.com/grp
 
 ### @grpc/proto-loader
 
-This product includes source derived from [@grpc/proto-loader](https://github.com/grpc/grpc-node) ([v0.5.4](https://github.com/grpc/grpc-node/tree/v0.5.4)), distributed under the [Apache-2.0 License](https://github.com/grpc/grpc-node/blob/v0.5.4/LICENSE):
+This product includes source derived from [@grpc/proto-loader](https://github.com/grpc/grpc-node) ([v0.5.5](https://github.com/grpc/grpc-node/tree/v0.5.5)), distributed under the [Apache-2.0 License](https://github.com/grpc/grpc-node/blob/v0.5.5/LICENSE):
 
 ```
                                  Apache License
@@ -495,7 +491,7 @@ This product includes source derived from [@grpc/proto-loader](https://github.co
 
 ### @newrelic/aws-sdk
 
-This product includes source derived from [@newrelic/aws-sdk](https://github.com/newrelic/node-newrelic-aws-sdk) ([v2.0.0](https://github.com/newrelic/node-newrelic-aws-sdk/tree/v2.0.0)), distributed under the [Apache-2.0 License](https://github.com/newrelic/node-newrelic-aws-sdk/blob/v2.0.0/LICENSE):
+This product includes source derived from [@newrelic/aws-sdk](https://github.com/newrelic/node-newrelic-aws-sdk) ([v3.0.0](https://github.com/newrelic/node-newrelic-aws-sdk/tree/v3.0.0)), distributed under the [Apache-2.0 License](https://github.com/newrelic/node-newrelic-aws-sdk/blob/v3.0.0/LICENSE):
 
 ```
                                  Apache License
@@ -703,7 +699,7 @@ This product includes source derived from [@newrelic/aws-sdk](https://github.com
 
 ### @newrelic/koa
 
-This product includes source derived from [@newrelic/koa](https://github.com/newrelic/node-newrelic-koa) ([v4.0.0](https://github.com/newrelic/node-newrelic-koa/tree/v4.0.0)), distributed under the [Apache-2.0 License](https://github.com/newrelic/node-newrelic-koa/blob/v4.0.0/LICENSE):
+This product includes source derived from [@newrelic/koa](https://github.com/newrelic/node-newrelic-koa) ([v5.0.0](https://github.com/newrelic/node-newrelic-koa/tree/v5.0.0)), distributed under the [Apache-2.0 License](https://github.com/newrelic/node-newrelic-koa/blob/v5.0.0/LICENSE):
 
 ```
 Apache License
@@ -912,7 +908,7 @@ Apache License
 
 ### @newrelic/superagent
 
-This product includes source derived from [@newrelic/superagent](https://github.com/newrelic/node-newrelic-superagent) ([v3.0.0](https://github.com/newrelic/node-newrelic-superagent/tree/v3.0.0)), distributed under the [Apache-2.0 License](https://github.com/newrelic/node-newrelic-superagent/blob/v3.0.0/LICENSE):
+This product includes source derived from [@newrelic/superagent](https://github.com/newrelic/node-newrelic-superagent) ([v4.0.0](https://github.com/newrelic/node-newrelic-superagent/tree/v4.0.0)), distributed under the [Apache-2.0 License](https://github.com/newrelic/node-newrelic-superagent/blob/v4.0.0/LICENSE):
 
 ```
                                  Apache License
@@ -1324,7 +1320,7 @@ IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 ## optionalDependencies
 
 ### @newrelic/native-metrics
-This product includes source derived from [@newrelic/native-metrics](https://github.com/newrelic/node-native-metrics) ([v5.3.0](https://github.com/newrelic/node-native-metrics/tree/v5.3.0)), distributed under the [Apache-2.0 License](https://github.com/newrelic/node-native-metrics/blob/v5.3.0/LICENSE):
+This product includes source derived from [@newrelic/native-metrics](https://github.com/newrelic/node-native-metrics) ([v6.0.0](https://github.com/newrelic/node-native-metrics/tree/v6.0.0)), distributed under the [Apache-2.0 License](https://github.com/newrelic/node-native-metrics/blob/v6.0.0/LICENSE):
 
 ```
                                  Apache License
@@ -1549,7 +1545,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
 
 ### @newrelic/test-utilities
 
-This product includes source derived from [@newrelic/test-utilities](https://github.com/newrelic/node-test-utilities) ([v4.0.0](https://github.com/newrelic/node-test-utilities/tree/v4.0.0)), distributed under the [Apache-2.0 License](https://github.com/newrelic/node-test-utilities/blob/v4.0.0/LICENSE):
+This product includes source derived from [@newrelic/test-utilities](https://github.com/newrelic/node-test-utilities) ([v5.0.0](https://github.com/newrelic/node-test-utilities/tree/v5.0.0)), distributed under the [Apache-2.0 License](https://github.com/newrelic/node-test-utilities/blob/v5.0.0/LICENSE):
 
 ```
                                  Apache License
@@ -2197,61 +2193,6 @@ https://github.com/jmblog/color-themes-for-google-code-prettify
 
 ```
 
-### lodash
-
-This product includes source derived from [lodash](https://github.com/lodash/lodash) ([v4.17.15](https://github.com/lodash/lodash/tree/v4.17.15)), distributed under the [MIT License](https://github.com/lodash/lodash/blob/v4.17.15/LICENSE):
-
-```
-Copyright OpenJS Foundation and other contributors <https://openjsf.org/>
-
-Based on Underscore.js, copyright Jeremy Ashkenas,
-DocumentCloud and Investigative Reporters & Editors <http://underscorejs.org/>
-
-This software consists of voluntary contributions made by many
-individuals. For exact contribution history, see the revision history
-available at https://github.com/lodash/lodash
-
-The following license applies to all parts of this software except as
-documented below:
-
-====
-
-Permission is hereby granted, free of charge, to any person obtaining
-a copy of this software and associated documentation files (the
-"Software"), to deal in the Software without restriction, including
-without limitation the rights to use, copy, modify, merge, publish,
-distribute, sublicense, and/or sell copies of the Software, and to
-permit persons to whom the Software is furnished to do so, subject to
-the following conditions:
-
-The above copyright notice and this permission notice shall be
-included in all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
-EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
-MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
-NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
-LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
-OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
-WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-====
-
-Copyright and related rights for sample code are waived via CC0. Sample
-code is defined as all source code displayed within the prose of the
-documentation.
-
-CC0: http://creativecommons.org/publicdomain/zero/1.0/
-
-====
-
-Files located in the node_modules and vendor directories are externally
-maintained libraries used by this software which have their own
-licenses; we recommend you read them, as their terms may differ from the
-terms above.
-
-```
-
 ### memcached
 
 This product includes source derived from [memcached](https://github.com/3rd-Eden/node-memcached) ([v2.2.2](https://github.com/3rd-Eden/node-memcached/tree/v2.2.2)), distributed under the [MIT License](https://github.com/3rd-Eden/node-memcached/blob/v2.2.2/LICENSE):
@@ -2944,7 +2885,7 @@ THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 ### tap
 
-This product includes source derived from [tap](https://github.com/tapjs/node-tap) ([v14.10.7](https://github.com/tapjs/node-tap/tree/v14.10.7)), distributed under the [ISC License](https://github.com/tapjs/node-tap/blob/v14.10.7/LICENSE):
+This product includes source derived from [tap](https://github.com/tapjs/node-tap) ([v14.10.8](https://github.com/tapjs/node-tap/tree/v14.10.8)), distributed under the [ISC License](https://github.com/tapjs/node-tap/blob/v14.10.8/LICENSE):
 
 ```
 The ISC License
@@ -3056,6 +2997,7 @@ OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
 WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 ```
 
+
 ## additional-licenses
 
 ### symantec
@@ -3260,4 +3202,4 @@ Root Certificate License Agreement v3.0 (January 2014)
 Portions copyright Node.js contributors. Depending on your existing libraries and package management settings,
 your systems may call externally maintained libraries in addition to those listed above.
 See [here](https://nodejs.org/en/docs/meta/topics/dependencies/) and [here](https://github.com/nodejs/node/blob/v4.3.1/LICENSE)
-for additional details regarding externally maintained libraries and certain related licenses and notices.”
+for additional details regarding externally maintained libraries and certain related licenses and notices.”

package/api.js

@@ -430,38 +430,6 @@ API.prototype.addCustomSpanAttribute = function addCustomSpanAttribute(key, valu
   spanContext.addCustomAttribute(key, value)
 }
 
-API.prototype.setIgnoreTransaction = util.deprecate(
-  setIgnoreTransaction, [
-    'API#setIgnoreTransaction is being deprecated!',
-    'Please use TransactionHandle#ignore to ignore a transaction.',
-    'Use API#getTransaction to create a new TransactionHandle instance.'
-  ].join(' ')
-)
-
-/**
- * Tell the tracer whether to ignore the current transaction. The most common
- * use for this will be to mark a transaction as ignored (maybe it's handling
- * a websocket polling channel, or maybe it's an external call you don't care
- * is slow), but it's also useful when you want a transaction that would
- * otherwise be ignored due to URL or transaction name normalization rules
- * to *not* be ignored.
- *
- * @param {boolean} ignored Ignore, or don't ignore, the current transaction.
- */
-function setIgnoreTransaction(ignored) {
-  var metric = this.agent.metrics.getOrCreateMetric(
-    NAMES.SUPPORTABILITY.API + '/setIgnoreTransaction'
-  )
-  metric.incrementCallCount()
-
-  var transaction = this.agent.tracer.getTransaction()
-  if (!transaction) {
-    return logger.warn("No transaction found to ignore.")
-  }
-
-  transaction.setForceIgnore(ignored)
-}
-
 /**
  * Send errors to New Relic that you've already handled yourself. Should be an
  * `Error` or one of its subtypes, but the API will handle strings and objects

package/bin/run-versioned-tests.sh

@@ -24,14 +24,9 @@ fi
 
 export AGENT_PATH=`pwd`
 
-# @koa/router 8.03+ breaks segment naming for nested routes
-skip="koa"
-
 # Don't run the aws-sdk tests if we don't have the keys set
 if [[ -z "$AWS_ACCESS_KEY_ID" ]]; then
-  skip="${skip},aws-sdk"
+  time ./node_modules/.bin/versioned-tests $VERSIONED_MODE -i 2 -s aws-sdk ${directories[@]}
+else
+  time ./node_modules/.bin/versioned-tests $VERSIONED_MODE -i 2 ${directories[@]}
 fi
-
-
-# This is meant to be temporary. Remove once new major version with fixes rolled into agent.
-time ./node_modules/.bin/versioned-tests $VERSIONED_MODE -i 2 -s $skip ${directories[@]}

package/index.js

@@ -48,14 +48,16 @@ function initialize() {
       preAgentTime
     )
 
-    // TODO: Update this check when Node v8 is deprecated.
-    if (psemver.satisfies('<8.0.0')) {
+    // TODO: Update this check when Node v10 is deprecated.
+    if (psemver.satisfies('<10.0.0')) {
       message = 'New Relic for Node.js requires a version of Node equal to or\n' +
                 'greater than 8.0.0. Not starting!'
 
       logger.error(message)
       throw new Error(message)
-    } else if (!psemver.satisfies(pkgJSON.engines.node)) {
+
+      // TODO: Update this check when Node v16 support is added
+    } else if (!psemver.satisfies(pkgJSON.engines.node) || psemver.satisfies('>=15.0.0')) { 
       logger.warn(
         'New Relic for Node.js %s has not been tested on Node.js %s. Please ' +
         'update the agent or downgrade your version of Node.js',

package/lib/agent.js

@@ -581,6 +581,10 @@ Agent.prototype._beforeMetricDataSend = function _beforeMetricDataSend() {
 
   // Send uninstrumented supportability metrics every metric harvest cycle
   uninstrumented.createMetrics(this.metrics)
+
+  if (this.spanEventAggregator.isStream) {
+    this.spanEventAggregator.createMetrics()
+  }
 }
 
 Agent.prototype._generateEntityStatsAndClear = function _generateHarvestMetrics() {

package/lib/collector/remote-method.js

@@ -107,17 +107,23 @@ RemoteMethod.prototype._post = function _post(data, nrHeaders, callback) {
   }
 
   if (options.compressed) {
-    var useGzip = this._config.compressed_content_encoding === 'gzip'
-    var compressor = useGzip ? zlib.gzip : zlib.deflate
-    compressor(data, function onCompress(err, compressed) {
-      if (err) {
-        logger.warn(err, 'Error compressing JSON for delivery. Not sending.')
-        return callback(err)
-      }
-
-      options.body = compressed
-      makeRequest()
-    })
+    // NOTE: gzip and deflate throw immediately in Node 14+ with an invalid argument
+    try {
+      var useGzip = this._config.compressed_content_encoding === 'gzip'
+      var compressor = useGzip ? zlib.gzip : zlib.deflate
+      compressor(data, function onCompress(err, compressed) {
+        if (err) {
+          logger.warn(err, 'Error compressing JSON for delivery. Not sending.')
+          return callback(err)
+        }
+
+        options.body = compressed
+        makeRequest()
+      })
+    } catch (err) {
+      logger.warn(err, 'Error compressing JSON for delivery. Not sending.')
+      return callback(err)
+    }
   } else {
     options.body = data
     makeRequest()

package/lib/collector/serverless.js

@@ -292,10 +292,7 @@ class ServerlessCollector {
       payload
     ]) + '\n'
 
-    if (this.shouldUsePipe === undefined) {
-      this.shouldUsePipe = fs.existsSync(this.pipePath)
-    }
-    const didUsePipe = this.shouldUsePipe && this.flushToPipeSync(serializedPayload)
+    const didUsePipe = fs.existsSync(this.pipePath) && this.flushToPipeSync(serializedPayload)
 
     if (!didUsePipe) {
       this.flushToStdOut(serializedPayload, payload.length, sync)

package/lib/config/default.js

@@ -595,14 +595,6 @@ exports.config = () => ({
    * options are disabled when high-security mode is enabled.
    */
   api: {
-    /**
-     * Deprecated. Please use `api.custom_attributes_enabled` instead.
-     *
-     * @env NEW_RELIC_API_CUSTOM_PARAMETERS
-     */
-    // TODO: This somehow survived the v5 cut, even though
-    // it's already removed from docs site. Remove in v6.
-    custom_parameters_enabled: true,
     /**
      * Controls for the `API.addCustomAttribute` method.
      *

package/lib/config/env.js

@@ -106,7 +106,6 @@ const ENV_MAPPING = {
   },
   api: {
     custom_attributes_enabled: 'NEW_RELIC_API_CUSTOM_ATTRIBUTES',
-    custom_parameters_enabled: 'NEW_RELIC_API_CUSTOM_PARAMETERS',
     custom_events_enabled: 'NEW_RELIC_API_CUSTOM_EVENTS',
     notice_error_enabled: 'NEW_RELIC_API_NOTICE_ERROR'
   },

package/lib/config/index.js

@@ -1025,15 +1025,6 @@ Config.prototype._fromPassed = function _fromPassed(external, internal, arbitrar
       return
     }
 
-    // TODO: remove in v6
-    if (key === 'ignored_params') {
-      warnDeprecated(key, 'attributes.exclude')
-    }
-
-    if (key === 'capture_params') {
-      warnDeprecated(key, 'attributes.enabled')
-    }
-
     try {
       var node = external[key]
     } catch (err) {
@@ -1049,14 +1040,6 @@ Config.prototype._fromPassed = function _fromPassed(external, internal, arbitrar
       internal[key] = node
     }
   }, this)
-
-  function warnDeprecated(key, replacement) {
-    logger.warn(
-      'Config key %s is deprecated, please use %s instead',
-      key,
-      replacement
-    )
-  }
 }
 
 /**
@@ -1327,10 +1310,6 @@ Config.prototype._canonicalize = function _canonicalize() {
     )
   }
 
-  this.api.custom_attributes_enabled = !this.api.custom_attributes_enabled
-    ? this.api.custom_attributes_enabled
-    : this.api.custom_parameters_enabled
-
   this.serverless_mode.enabled = this.serverless_mode.enabled
     && this.feature_flag.serverless_mode
 

package/lib/errors/error-collector.js

@@ -142,13 +142,18 @@ class ErrorCollector {
     }
 
     const isErroredTransaction = urltils.isError(this.config, transaction.statusCode)
+    const isIgnoredErrorStatusCode = urltils.isIgnoredError(
+      this.config,
+      transaction.statusCode
+    )
+
     const isExpectedErrorStatusCode = urltils.isExpectedError(
       this.config,
       transaction.statusCode
     )
 
     // collect other exceptions only if status code is not ignored
-    if (transaction.exceptions.length) {
+    if (transaction.exceptions.length && !isIgnoredErrorStatusCode) {
       for (let i = 0; i < transaction.exceptions.length; i++) {
         const exception = transaction.exceptions[i]
         if (this.collect(transaction, exception)) {

package/lib/errors/index.js

@@ -20,7 +20,20 @@ class Exception {
   }
 
   getErrorDetails(config) {
-    return errorHelper.extractErrorInformation(null, this.error, config)
+    const errorDetails = errorHelper.extractErrorInformation(null, this.error, config)
+    errorDetails.expected = this.isExpected(config, errorDetails)
+
+    return errorDetails
+  }
+
+  isExpected(config, {type, message}) {
+    if (!this._expected) {
+      this._expected =
+        errorHelper.isExpectedErrorClass(config, type) ||
+        errorHelper.isExpectedErrorMessage(config, type, message)
+    }
+
+    return this._expected
   }
 }
 

package/lib/grpc/connection.js

@@ -121,7 +121,7 @@ class GrpcConnection extends EventEmitter {
       // immediately.
       this._setState(connectionStates.connected, this.stream)
     } catch (err) {
-      logger.trace(
+      logger.warn(
         err,
         'Unexpected error establishing gRPC stream, will not attempt reconnect.'
       )
@@ -198,9 +198,26 @@ class GrpcConnection extends EventEmitter {
     if (this.stream) {
       this.stream.removeAllListeners()
 
+      const oldStream = this.stream
+      this.stream.on('status', function endStreamStatusHandler(grpcStatus) {
+        logger.trace('End stream status received [%s]: %s', grpcStatus.code, grpcStatus.details)
+
+        // Cleanup the final end stream listeners.
+        oldStream.removeAllListeners()
+      })
+
+      // Listen to any final errors to prevent throwing.
+      // This is unlikely but if the server closes post
+      // removing listeners and prior to response it could
+      // happen. We noticed this via tests on Node 14.
+      this.stream.on('error', function endStreamErrorHandler(err) {
+        logger.trace('End stream error received. Code: [%s]: %s', err.code, err.details)
+      })
+
       // Indicates to server we are done.
       // Server officially closes the stream.
       this.stream.end()
+
       this.stream = null
     }
 
@@ -238,6 +255,9 @@ class GrpcConnection extends EventEmitter {
         // per the spec, An UNIMPLEMENTED status code from gRPC indicates
         // that the versioned Trace Observer is no longer available. Agents
         // MUST NOT attempt to reconnect in this case
+        logger.info(
+          '[UNIMPLEMENTED]: Trace Obserserver is no longer available. Shutting down connection.'
+        )
         this._disconnect()
       } else if (grpc.status[grpc.status.OK] === grpcStatusName) {
         this._reconnect()
@@ -256,7 +276,11 @@ class GrpcConnection extends EventEmitter {
       this._metrics.getOrCreateMetric(NAMES.INFINITE_TRACING.SPAN_RESPONSE_ERROR)
         .incrementCallCount()
 
-      logger.trace('span stream error. Code: [%s]: %s',err.code, err.details)
+      // For errors, the status will either result in a disconnect or a reconnect
+      // delay that should prevent too frequent spamming. Unless the app is idle
+      // and regularly getting Status 13 reconnects from the server, in which case
+      // this will be almost the only logging.
+      logger.warn('Span stream error. Code: [%s]: %s', err.code, err.details)
     })
   }