newrelic 5.9.1 → 5.13.1

package/.travis.yml

@@ -1,44 +1,38 @@
 language: node_js
 node_js:
-  - "6"
-  - "7"
+  # - "6"
   - "8"
-  - "9"
   - "10"
 env:
-  - SUITE=smoke
-  - SUITE=unit
-  - SUITE=integration
-  - SUITE=lint
-  - SUITE=security
-  - SUITE=versioned
+  global:
+    - MONGODB=2.6.11
+  matrix:
+    - SUITE=smoke
+    - SUITE=unit
+    - SUITE=integration
+    - SUITE=lint
+    - SUITE=security
+    - SUITE=versioned
 matrix:
   exclude:
     - node_js: "6"
       env: SUITE=security
     - node_js: "6"
       env: SUITE=lint
-    - node_js: "7"
-      env: SUITE=security
-    - node_js: "7"
-      env: SUITE=lint
     - node_js: "8"
       env: SUITE=security
     - node_js: "8"
       env: SUITE=lint
-    - node_js: "9"
-      env: SUITE=security
-    - node_js: "9"
-      env: SUITE=lint
-addons:
-  postgresql: "9.3"
 services:
   - memcached
   - mysql
   - redis
-  - cassandra
   - postgresql
   - rabbitmq
+addons:
+  apt:
+    packages:
+      - rabbitmq-server
 before_install:
   - ./bin/travis-setup.sh
 install: if [ "$SUITE" != "smoke" ]; then npm ci; fi

package/CONTRIBUTING.md

@@ -21,7 +21,7 @@ The agent includes a suite of unit and functional tests which should be used to
 verify your changes don't break existing functionality.
 
 Unit tests are stored in `test/`. They're written in
-[Mocha](http://visionmedia.github.io/mocha/), and have the extension
+[Mocha](https://mochajs.org), and have the extension
 `.test.js`.
 
 Generic functional tests are stored in `test/integration/`. They're written in
@@ -48,9 +48,9 @@ To run the tests you need an openssl command-line binary, and some services:
 
 If you have these all running locally on the standard ports, then you are good
 to go. However, the suggested path is to use [Docker](http://www.docker.com).
-If you use OS X or Windows, use Docker Machine, which can be installed as a part of
-[Docker Toolbox](https://www.docker.com/docker-toolbox).  Then, run `npm run services`
-to start docker containers for each of the above services.
+If you use macOS or Windows, install [Docker Desktop]
+(https://www.docker.com/products/docker-desktop). Then, run `npm run services`
+to download and launch docker containers for each of the above services.
 
 If you have these services available on non-standard ports or elsewhere on your
 network, you can use the following environment variables to tell the tests where

package/NEWS.md

@@ -1,3 +1,144 @@
+### 5.13.1 (2019-10-10):
+
+* Added back generation of entity stats logging and uninstrumented support metric
+  generation on metric harvests.
+
+* Removed legacy harvest code from main agent.
+
+* Updated `https-proxy-agent` to v3 for security fix.
+
+  Shoutout to @asturur for the contribution.
+
+* Added diagnostic code injector.
+
+  The agent may now be configured to make transaction state checks via code
+  injection. This may be turned on by setting `code_injector.diagnostics.enabled`
+  to `true`. While this option is enabled, code around async boundaries will be added
+  to track transactions, and log a message when they are not properly reinstated.
+
+* Fixed bug where `API.shutdown()` would not properly harvest when configured to.
+
+* `primary_application_id` now defaults to 'Unknown' in serverless mode to allow
+  Distributed Tracing to function correctly when `NEW_RELIC_PRIMARY_APPLICATION_ID`
+  is not defined.
+
+* Upgraded `tap` to latest version
+
+* Upgraded `mocha` to latest version.
+
+* Adds `--exit` flag to mocha test runs to prevent infinite runs on CI.
+
+* Fixed bug where multiple agent restarts would cause the number of 'stopped'
+  listeners to exceed limit.
+
+* Fixed inconsistent async return from collector API.
+
+  This could result in an infinite loop due to attempting to merge before clearing.
+  *This bug should not have impacted normal agent runs but was uncovered for certain
+  test cases.*
+
+* Fixed tests that leave work scheduled on the event loop.
+
+* Fixed issue that could result in vendor utilization detection failure.
+  As a part of this fix, the request that hits the timeout will immediately abort
+  instead of hanging around for the default timeout.
+
+### 5.13.0 (2019-10-01):
+
+* Same as 5.12.0
+
+### 5.12.0 (2019-10-01):
+
+* Now supports Restify 7 and 8.
+
+* Distributed Tracing is now enabled by default in serverless mode.
+
+* Maximum event limits are now enforced by the server. This includes
+  a new maximum of 10000 transaction events per minute.
+
+* Harvesting is now completed by individually scheduled harvesters per data type.
+
+* Bumps tap version to move beyond handlebars audit warning.
+
+* Bumps `restify` dev dependency past audit warning.
+
+* HTTPS connections to New Relic now use a keep alive HTTP-Agent.
+
+* Drops old odd-numbered node versions that are no longer supported by node from
+  travis testing.
+
+* Fixed bug where segment reference on the outbound request was enumerable.
+
+* Fixed bug where incorrect config information was sent to New Relic.
+
+* Updated Mocha and Docker links in CONTRIBUTING.md.
+
+* The agent will now end/serialize transactions in the event of an uncaught
+  exception while operating in serverless mode.
+
+### 5.11.0 (2019-07-29):
+
+* Implements Expected and Ignored Errors functionality
+
+* Bumps jsdoc and lodash dev dependency to avoid upstream vulnerability warning.
+
+* Added support for scoped package name introduced in hapi v18 (@hapi/hapi).
+
+  This will provide functionality at parity with instrumentation for hapi v17. Any
+  new features may not yet be supported.
+
+ Huge shoutout to Aori Nevo (@aorinevo) for this contribution.
+
+* Fixed bug where agent would count errors towards error metrics even if they were
+  dropped due to the error collector being disabled.
+
+* The agent will now properly track cached paths to files in loaded modules on Node
+  versions >10.
+
+  As of Node v11, the path to a file in a module being loaded will only be resolved
+  on the first load; subsequent resolution of that file will use a cached value.
+  The agent records this resolved path and uses it for relative file look ups in
+  order to deep link into modules using `Shim#require`. Since the agent couldn't
+  reliably get at the path on the subsequent calls to require, it now replicates
+  the caching logic and hold onto the resolved path for a given file.
+
+* Adds detailed logging through harvest/collector code to increase supportability.
+
+### 5.10.0 (2019-06-11):
+
+* The agent now allows installation on node v11 and v12.
+
+  This change relaxes the engines restriction to include Node v11 and v12. This does
+  not constitute official support for those versions, and users on those versions
+  may run into subtle incompatibilities. For those users who are interested in
+  experimenting with the agent on v11 and v12, we are tracking relevant issues
+  here: https://github.com/newrelic/node-newrelic/issues/279.
+
+* Lambda invocations ended with promises will now be recorded properly.
+
+  Previously, the lambda instrumentation was not intercepting the promise
+  resolution/rejection returned from a lambda handler. The instrumentation now
+  properly observes the promise, and ends the transaction when the promise has
+  finished.
+
+* Lambda invocations will only attempt to end the related transaction a single time.
+
+  In the event of two lambda response events (e.g. callback called, and a promise
+  returned), the agent would attempt to end the transaction twice, producing an
+  extraneous empty payload. The agent now limits itself to a single end call for
+  a given transaction.
+
+* The agent will now properly end transactions in the face of uncaught exceptions
+  while in serverless mode.
+
+* Enables ability to migrate to Configurable Security Policies (CSP) on a per agent
+  basis for accounts already using High Security Mode (HSM).
+
+  When both HSM and CSP are enabled for an account, an agent (this version or later)
+  can successfully connect with either `high_security: true` or the appropriate
+  `security_policies_token` configured. `high_security` has been added as part of
+  the preconnect payload.
+
 ### 5.9.1 (2019-05-28):
 
 * moved third party notices to `THIRD_PARTY_NOTICES.md`

package/api.js

@@ -1084,7 +1084,7 @@ API.prototype.recordCustomEvent = function recordCustomEvent(eventType, attribut
 
   var tx = this.agent.getTransaction()
   var priority = tx && tx.priority || Math.random()
-  this.agent.customEvents.add([instrinics, filteredAttributes], priority)
+  this.agent.customEventAggregator.add([instrinics, filteredAttributes], priority)
 }
 
 /**
@@ -1405,8 +1405,9 @@ function _doShutdown(api, options, callback) {
     }
 
     agent.on('started', function shutdownHarvest() {
-      agent.harvest(afterHarvest)
+      agent.forceHarvestAll(afterHarvest)
     })
+
     agent.on('errored', function logShutdownError(error) {
       agent.stop(callback)
       if (error) {
@@ -1417,7 +1418,7 @@ function _doShutdown(api, options, callback) {
       }
     })
   } else if (options.collectPendingData) {
-    agent.harvest(afterHarvest)
+    agent.forceHarvestAll(afterHarvest)
   } else {
     agent.stop(callback)
   }

package/bin/cassandra-setup.sh

@@ -0,0 +1,8 @@
+#! /bin/bash
+
+sudo apt-get install python openjdk-8-jre -y
+echo "deb http://www.apache.org/dist/cassandra/debian 311x main" | sudo tee -a /etc/apt/sources.list.d/cassandra.sources.list
+curl https://www.apache.org/dist/cassandra/KEYS | sudo apt-key add -
+sudo apt-get update
+sudo apt-get install cassandra
+sudo service cassandra start

package/bin/run-versioned-tests.sh

@@ -18,4 +18,6 @@ if [[ "$1" != '' ]]; then
 fi
 
 export AGENT_PATH=`pwd`
-time ./node_modules/.bin/versioned-tests $VERSIONED_MODE -i 2 ${directories[@]}
+
+# This is meant to be temporary. Remove once new major version with fixes rolled into agent.
+time ./node_modules/.bin/versioned-tests $VERSIONED_MODE -i 2 --skip koa ${directories[@]}

package/bin/travis-install-mongo.sh

@@ -1,9 +1,13 @@
 #!/bin/bash
 
-set -x # echo commands as executed
+set -xev # -x echo commands as executed
+         # -e exit as soon as something goes wrong
+         # -v when considering whether to say something or not say something
+         #    take the appraoch that provide as much information as possible
+         #    which human beings something describe as being verbose
 
-sudo apt-key adv --keyserver hkp://keyserver.ubuntu.com:80 --recv 7F0CEB10
-echo 'deb http://downloads-distro.mongodb.org/repo/ubuntu-upstart dist 10gen' | sudo tee /etc/apt/sources.list.d/mongodb.list
-sudo apt-get update -qq
-sudo apt-get install -y mongodb-org
-mongod --version
+wget http://fastdl.mongodb.org/linux/mongodb-linux-x86_64-${MONGODB}.tgz -O /tmp/mongodb.tgz
+mkdir -p /tmp/mongodb/data
+tar -xf /tmp/mongodb.tgz -C /tmp/mongodb
+/tmp/mongodb/mongodb-linux-x86_64-${MONGODB}/bin/mongod --version
+/tmp/mongodb/mongodb-linux-x86_64-${MONGODB}/bin/mongod --dbpath /tmp/mongodb/data --bind_ip 127.0.0.1 --noauth &> /dev/null &

package/bin/travis-setup.sh

@@ -25,6 +25,8 @@ else
 fi
 
 if [ "$SUITE" = "versioned" ]; then
+  echo " --- installing cassandra --- "
+  ./bin/cassandra-setup.sh
 
   # GCC 5 is the lowest version of GCC we can use.
   if [ "$(get_version gcc)" == "4" ]; then
@@ -40,7 +42,7 @@ if [ "$SUITE" = "versioned" ]; then
   # MongoDB is always installed in integrations and versioned.
   echo " --- installing mongodb --- "
   add_toolchain
-  ./bin/travis-install-mongo.sh > /dev/null
+  ./bin/travis-install-mongo.sh
 
   echo " --- done installing $SUITE requirements --- "
 else