newrelic 5.6.1 → 5.6.2

package/NEWS.md

@@ -1,3 +1,18 @@
+### 5.6.2 (2019-03-25):
+
+* Agent now respects attribute type restrictions on trace/segment attributes, as
+  well as error event/trace attributes.
+
+* Fixes potential for `RangeError: Maximum call stack size exceeded` error on
+  Transaction/Trace end.
+
+* Custom events no longer accept attributes with invalid types.
+
+  The only attribute types accepted by the backend are `boolean`, `string`, and
+  `number`; any attribute assigned to a custom event outside these types would be
+  dropped on ingest. The agent now filters these attributes out, and logs out a
+  helpful message detailing the issue.
+
 ### 5.6.1 (2019-03-11):
 
 * Updated log message for not adding attributes and change the log level to debug.

package/api.js

@@ -9,6 +9,7 @@ const hashes = require('./lib/util/hashes')
 const properties = require('./lib/util/properties')
 const stringify = require('json-stringify-safe')
 const shimmer = require('./lib/shimmer')
+const isValidType = require('./lib/util/attribute-types')
 const TransactionShim = require('./lib/shim/transaction-shim')
 const TransactionHandle = require('./lib/transaction/handle')
 const AwsLambda = require('./lib/serverless/aws-lambda')
@@ -16,7 +17,6 @@ const AwsLambda = require('./lib/serverless/aws-lambda')
 const ATTR_DEST = require('./lib/config/attribute-filter').DESTINATIONS
 const MODULE_TYPE = require('./lib/shim/constants').MODULE_TYPE
 const NAMES = require('./lib/metrics/names')
-
 /*
  *
  * CONSTANTS
@@ -365,7 +365,13 @@ API.prototype.noticeError = function noticeError(error, customAttributes) {
   }
   const transaction = this.agent.tracer.getTransaction()
 
-  this.agent.errors.addUserError(transaction, error, customAttributes)
+  // Filter all object type valued attributes out
+  let filteredAttributes = customAttributes
+  if (customAttributes) {
+    filteredAttributes = _filterAttributes(customAttributes, 'noticeError')
+  }
+
+  this.agent.errors.addUserError(transaction, error, filteredAttributes)
 }
 
 /**
@@ -1067,6 +1073,9 @@ API.prototype.recordCustomEvent = function recordCustomEvent(eventType, attribut
     return
   }
 
+  // Filter all object type valued attributes out
+  const filteredAttributes = _filterAttributes(attributes, `${eventType} custom event`)
+
   var instrinics = {
     type: eventType,
     timestamp: Date.now()
@@ -1074,7 +1083,7 @@ API.prototype.recordCustomEvent = function recordCustomEvent(eventType, attribut
 
   var tx = this.agent.getTransaction()
   var priority = tx && tx.priority || Math.random()
-  this.agent.customEvents.add([instrinics, attributes], priority)
+  this.agent.customEvents.add([instrinics, filteredAttributes], priority)
 }
 
 /**
@@ -1390,4 +1399,19 @@ API.prototype.setLambdaHandler = function setLambdaHandler(handler) {
   return this.awsLambda.patchLambdaHandler(handler)
 }
 
+function _filterAttributes(attributes, name) {
+  const filteredAttributes = Object.create(null)
+  Object.keys(attributes).forEach((attributeKey) => {
+    if (!isValidType(attributes[attributeKey])) {
+      logger.info(
+        `Omitting attribute ${attributeKey} from ${name} call, type must ` +
+        'be boolean, number, or string'
+      )
+      return
+    }
+    filteredAttributes[attributeKey] = attributes[attributeKey]
+  })
+  return filteredAttributes
+}
+
 module.exports = API

package/lib/attributes.js

@@ -2,6 +2,7 @@
 
 const Config = require('./config')
 const logger = require('./logger').child({component: 'attributes'})
+const isValidType = require('./util/attribute-types')
 const byteUtils = require('./util/byte-limit')
 const properties = require('./util/properties')
 
@@ -141,18 +142,6 @@ class Attributes {
   }
 }
 
-/**
- * Checks incoming attribute value against valid types:
- * string, number, & boolean.
- *
- * @param {*} val
- *
- * @return {boolean}
- */
-function isValidType(val) {
-  return typeof val !== 'object' && val !== undefined
-}
-
 /**
  * Creates a filter function for the given scope.
  *

package/lib/collector/facts.js

@@ -88,8 +88,13 @@ function getAllIPAddresses() {
       const interfaceAddresses = interfaces[key].map(function getAddress(inter) {
         return inter.address
       })
-      Array.prototype.push.apply(addresses, interfaceAddresses)
+
+      for (let index = 0; index < interfaceAddresses.length; index++) {
+        const address = interfaceAddresses[index]
+        addresses.push(address)
+      }
     }
+
     return addresses
   }, [])
 }

package/lib/transaction/trace/index.js

@@ -55,7 +55,11 @@ Trace.prototype.end = function end() {
   while (segments.length) {
     const segment = segments.pop()
     segment.finalize()
-    Array.prototype.push.apply(segments, segment.getChildren())
+
+    const children = segment.getChildren()
+    for (let i = 0; i < children.length; ++i) {
+      segments.push(children[i])
+    }
   }
 }
 
@@ -87,10 +91,11 @@ Trace.prototype.generateSpanEvents = function generateSpanEvents() {
       // the spans as seen.
       spanAggregator.addSegment(segment, segmentInfo.parentId)
 
-      Array.prototype.push.apply(
-        toProcess,
-        segment.getChildren().map(child => new DTTraceNode(child, segment.id))
-      )
+      const nodes = segment.getChildren()
+      for (let i = 0; i < nodes.length; ++i) {
+        const node = new DTTraceNode(nodes[i], segment.id)
+        toProcess.push(node)
+      }
     }
   }
 }

package/lib/util/attribute-types.js

@@ -0,0 +1,21 @@
+'use strict'
+
+const VALID_ATTR_TYPES = new Set([
+  'string',
+  'number',
+  'boolean'
+])
+
+/**
+ * Checks incoming attribute value against valid types:
+ * string, number, & boolean.
+ *
+ * @param {*} val
+ *
+ * @return {boolean}
+ */
+function isValidType(val) {
+  return VALID_ATTR_TYPES.has(typeof val)
+}
+
+module.exports = isValidType

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "newrelic",
-  "version": "5.6.1",
+  "version": "5.6.2",
   "author": "New Relic Node.js agent team <nodejs@newrelic.com>",
   "licenses": [
     {