newrelic 4.4.0 → 4.7.0

package/lib/instrumentation/core/http-outbound.js

@@ -6,11 +6,19 @@ var urltils = require('../../util/urltils')
 var hashes = require('../../util/hashes')
 var logger = require('../../logger').child({component: 'outbound'})
 var shimmer = require('../../shimmer')
+var util = require('util')
+var url = require('url')
+var copy = require('../../util/copy')
 
 const DEFAULT_HOST = 'localhost'
 const DEFAULT_PORT = 80
 const DEFAULT_SSL_PORT = 443
 
+const NEWRELIC_ID_HEADER = 'x-newrelic-id'
+const NEWRELIC_TRACE_HEADER = 'newrelic'
+const NEWRELIC_TRANSACTION_HEADER = 'x-newrelic-transaction'
+const NEWRELIC_SYNTHETICS_HEADER = 'x-newrelic-synthetics'
+
 /**
  * Instruments an outbound HTTP request.
  *
@@ -21,6 +29,12 @@ const DEFAULT_SSL_PORT = 443
  * @return {http.ClientRequest} The instrumented outbound request.
  */
 module.exports = function instrumentOutbound(agent, opts, makeRequest) {
+  if (typeof opts === 'string') {
+    opts = url.parse(opts)
+  } else {
+    opts = copy.shallow(opts)
+  }
+
   let hostname = opts.hostname || opts.host || DEFAULT_HOST
   let port = opts.port || opts.defaultPort
   if (!port) {
@@ -32,7 +46,7 @@ module.exports = function instrumentOutbound(agent, opts, makeRequest) {
       'Invalid host name (%s) or port (%s) for outbound request.',
       hostname, port
     )
-    return makeRequest()
+    return makeRequest(opts)
   }
 
   // Technically we shouldn't append the port if this is an https request on 443
@@ -54,8 +68,48 @@ module.exports = function instrumentOutbound(agent, opts, makeRequest) {
   )
 
   function instrumentRequest(segment) {
+    const transaction = segment.transaction
+    const outboundHeaders = Object.create(null)
+
+    // FLAG: synthetics
+    if (
+      agent.config.feature_flag.synthetics &&
+      agent.config.encoding_key &&
+      transaction.syntheticsHeader
+    ) {
+      outboundHeaders[NEWRELIC_SYNTHETICS_HEADER] = transaction.syntheticsHeader
+    }
+
+    // If CAT is enabled, inject the transaction header.
+    // TODO: abstract header logic shared with TransactionShim#insertCATRequestHeaders
+    if (agent.config.cross_application_tracer.enabled) {
+      if (agent.config.distributed_tracing.enabled) {
+        _addDistributedHeaders(transaction, outboundHeaders)
+      } else if (agent.config.encoding_key) {
+        _addCATHeaders(agent, transaction, outboundHeaders)
+      } else {
+        logger.trace('No encoding key found, not adding CAT headers')
+      }
+    }
+
+    if (util.isArray(opts.headers)) {
+      opts.headers = opts.headers.slice()
+      Array.prototype.push.apply(
+        opts.headers,
+        Object.keys(outboundHeaders).map(function getHeaderTuples(key) {
+          return [key, outboundHeaders[key]]
+        })
+      )
+    } else {
+      opts.headers = Object.assign(
+        Object.create(null),
+        opts.headers,
+        outboundHeaders
+      )
+    }
+
     segment.start()
-    const request = makeRequest()
+    const request = makeRequest(opts)
     const parsed = urltils.scrubAndParseParameters(request.path)
     const proto = parsed.protocol || opts.protocol || 'http:'
     segment.name += parsed.path
@@ -129,7 +183,7 @@ function handleResponse(segment, hostname, req, res) {
   const agent = segment.transaction.agent
   if (
     agent.config.cross_application_tracer.enabled &&
-    !agent.config.feature_flag.distributed_tracing
+    !agent.config.distributed_tracing.enabled
   ) {
     pullCatHeaders(agent.config, segment, hostname, res.headers['x-newrelic-app-data'])
   }
@@ -202,3 +256,48 @@ function _makeNonEnumerable(obj, prop) {
     logger.debug(e, 'Failed to make %s non enumerable.', prop)
   }
 }
+
+function _addDistributedHeaders(tx, outboundHeaders) {
+  try {
+    const txData = tx.createDistributedTracePayload().httpSafe()
+    outboundHeaders[NEWRELIC_TRACE_HEADER] = txData
+
+    logger.trace(
+      'Added outbound request distributed tracing headers in transaction %s',
+      tx.id
+    )
+  } catch (err) {
+    logger.trace(err, 'Failed to create distributed trace payload')
+  }
+}
+
+function _addCATHeaders(agent, tx, outboundHeaders) {
+  if (agent.config.obfuscatedId) {
+    outboundHeaders[NEWRELIC_ID_HEADER] = agent.config.obfuscatedId
+  }
+
+  var pathHash = hashes.calculatePathHash(
+    agent.config.applications()[0],
+    tx.getFullName() || '',
+    tx.referringPathHash
+  )
+  tx.pushPathHash(pathHash)
+
+  try {
+    let txData = JSON.stringify([
+      tx.id,
+      false,
+      tx.tripId || tx.id,
+      pathHash
+    ])
+    txData = hashes.obfuscateNameUsingKey(txData, agent.config.encoding_key)
+    outboundHeaders[NEWRELIC_TRANSACTION_HEADER] = txData
+
+    logger.trace(
+      'Added outbound request CAT headers in transaction %s',
+      tx.id
+    )
+  } catch (err) {
+    logger.trace(err, 'Failed to create CAT payload')
+  }
+}

package/lib/instrumentation/core/http.js

@@ -11,7 +11,6 @@ var url = require('url')
 var urltils = require('../../util/urltils')
 var properties = require('../../util/properties')
 var psemver = require('../../util/process-version')
-var copy = require('../../util/copy')
 
 const NAMES = require('../../metrics/names')
 const DESTS = require('../../config/attribute-filter').DESTINATIONS
@@ -206,7 +205,7 @@ function wrapEmitWithTransaction(agent, emit, isHTTPS) {
       }
     }
     if (agent.config.cross_application_tracer.enabled) {
-      if (agent.config.feature_flag.distributed_tracing) {
+      if (agent.config.distributed_tracing.enabled) {
         const payload = request.headers[NEWRELIC_TRACE_HEADER]
         if (payload) {
           logger.trace(
@@ -499,54 +498,10 @@ function wrapRequest(agent, request) {
 
     const args = agent.tracer.slice(arguments)
     const context = this
-    const outboundHeaders = Object.create(null)
-
-    // FLAG: synthetics
-    if (
-      agent.config.feature_flag.synthetics &&
-      agent.config.encoding_key &&
-      transaction.syntheticsHeader
-    ) {
-      outboundHeaders[NEWRELIC_SYNTHETICS_HEADER] = transaction.syntheticsHeader
-    }
-
-    // If CAT is enabled, inject the transaction header.
-    // TODO: abstract header logic shared with TransactionShim#insertCATRequestHeaders
-    if (agent.config.cross_application_tracer.enabled) {
-      if (agent.config.feature_flag.distributed_tracing) {
-        _addDistributedHeaders(transaction, outboundHeaders)
-      } else if (agent.config.encoding_key) {
-        _addCATHeaders(agent, transaction, outboundHeaders)
-      } else {
-        logger.trace('No encoding key found, not adding CAT headers')
-      }
-    }
-
-    if (typeof options === 'string') {
-      options = url.parse(options)
-    } else {
-      options = copy.shallow(options)
-    }
-
-    if (util.isArray(options.headers)) {
-      options.headers = options.headers.slice()
-      Array.prototype.push.apply(
-        options.headers,
-        Object.keys(outboundHeaders).map(function getHeaderTuples(key) {
-          return [key, outboundHeaders[key]]
-        })
-      )
-    } else {
-      options.headers = Object.assign(
-        Object.create(null),
-        options.headers,
-        outboundHeaders
-      )
-    }
-    args[0] = options
 
     // hostname & port logic pulled directly from node's 0.10 lib/http.js
-    return instrumentOutbound(agent, options, function makeRequest() {
+    return instrumentOutbound(agent, options, function makeRequest(opts) {
+      args[0] = opts
       return request.apply(context, args)
     })
   }
@@ -738,7 +693,7 @@ module.exports = function initialize(agent, http, moduleName) {
  *
  * @param {string} header - The raw X-NewRelic-Synthetics header
  * @param {string} encKey - Encoding key handed down from the server
- * @param {̄Array} trustedIds - Array of accounts to trust the header from.
+ * @param {Array.<number>} trustedIds - Array of accounts to trust the header from.
  * @param {Transaction} transaction - Where the synthetics data is attached to.
  */
 function handleSyntheticsHeader(header, encKey, trustedIds, transaction) {
@@ -756,8 +711,8 @@ function handleSyntheticsHeader(header, encKey, trustedIds, transaction) {
  *
  * @param {string} header - The raw X-NewRelic-Synthetics header
  * @param {string} encKey - Encoding key handed down from the server
- * @param {̄Array} trustedIds - Array of accounts to trust the header from.
- * @return {Object or null} - On successful parse and verification an object of
+ * @param {Array.<number>} trustedIds - Array of accounts to trust the header from.
+ * @return {Object|null} - On successful parse and verification an object of
  *                            synthetics data is returned, otherwise null is
  *                            returned.
  */
@@ -877,48 +832,3 @@ function _collectHeaders(headers, nameMap, prefix, tx) {
     }
   }
 }
-
-function _addDistributedHeaders(tx, outboundHeaders) {
-  try {
-    const txData = tx.createDistributedTracePayload().httpSafe()
-    outboundHeaders[NEWRELIC_TRACE_HEADER] = txData
-
-    logger.trace(
-      'Added outbound request distributed tracing headers in transaction %s',
-      tx.id
-    )
-  } catch (err) {
-    logger.trace(err, 'Failed to create distributed trace payload')
-  }
-}
-
-function _addCATHeaders(agent, tx, outboundHeaders) {
-  if (agent.config.obfuscatedId) {
-    outboundHeaders[NEWRELIC_ID_HEADER] = agent.config.obfuscatedId
-  }
-
-  var pathHash = hashes.calculatePathHash(
-    agent.config.applications()[0],
-    tx.getFullName() || '',
-    tx.referringPathHash
-  )
-  tx.pushPathHash(pathHash)
-
-  try {
-    let txData = JSON.stringify([
-      tx.id,
-      false,
-      tx.tripId || tx.id,
-      pathHash
-    ])
-    txData = hashes.obfuscateNameUsingKey(txData, agent.config.encoding_key)
-    outboundHeaders[NEWRELIC_TRANSACTION_HEADER] = txData
-
-    logger.trace(
-      'Added outbound request CAT headers in transaction %s',
-      tx.id
-    )
-  } catch (err) {
-    logger.trace(err, 'Failed to create CAT payload')
-  }
-}

package/lib/instrumentation/hapi/hapi-17.js

@@ -10,6 +10,10 @@ module.exports = function initialize(agent, hapi, moduleName, shim) {
     return !(result instanceof Error) && (result !== args[1].continue)
   })
 
+  // 'Server' and 'server' both point to the same export,
+  // but we can't make any assumption about which will be used.
+  // Since we wrap the prototype, the second wrap should exit early.
+  shim.wrapReturn(hapi, 'server', serverFactoryWrapper)
   shim.wrapReturn(hapi, 'Server', serverFactoryWrapper)
 }
 

package/lib/metrics/recorders/distributed-trace.js

@@ -3,7 +3,7 @@
 const NAMES = require('../names')
 
 function recordDistributedTrace(tx, suffix, duration, exclusive) {
-  const distTraceReceived = !!tx.parentId
+  const distTraceReceived = !!tx.acceptedDistributedTrace
   const tag = [
     tx.parentType || 'Unknown',
     tx.parentAcct || 'Unknown',

package/lib/metrics/recorders/http.js

@@ -33,7 +33,7 @@ function recordWeb(segment, scope) {
     tx.measure(NAMES.QUEUETIME, null, tx.queueTime)
   }
 
-  if (config.feature_flag.distributed_tracing) {
+  if (config.distributed_tracing.enabled) {
     recordDistributedTrace(tx, 'Web', duration, exclusive)
   } else if (tx.incomingCatId) {
     tx.measure(

package/lib/metrics/recorders/other.js

@@ -34,7 +34,7 @@ function recordBackground(segment, scope) {
   )
   tx.measure(NAMES.OTHER_TRANSACTION.TOTAL_TIME, null, totalTime, exclusive)
 
-  if (tx.agent.config.feature_flag.distributed_tracing) {
+  if (tx.agent.config.distributed_tracing.enabled) {
     recordDistributedTrace(tx, 'Other', duration, exclusive)
   }
 }

package/lib/priority-queue.js

@@ -3,7 +3,7 @@
 var Heap = require('@tyriar/fibonacci-heap').FibonacciHeap
 
 function PriorityQueue(limit) {
-  this.limit = limit || 10
+  this.limit = limit == null ? 10 : limit
   this.seen = 0
   this._data = new Heap()
 
@@ -24,8 +24,11 @@ PriorityQueue.prototype.getMinimumPriority = function getMinimumPriority() {
 }
 
 PriorityQueue.prototype.add = function add(value, priority) {
-  priority = priority || Math.random()
   this.seen++
+  if (this.limit <= 0) {
+    return false
+  }
+  priority = priority || Math.random()
   if (this.length === this.limit) {
     return this._replace(value, priority)
   }

package/lib/shim/message-shim.js

@@ -333,10 +333,6 @@ function recordProduce(nodule, properties, recordNamer) {
     }
 
     var name = _nameMessageSegment(shim, msgDesc, shim._metrics.PRODUCE)
-    if (msgDesc.headers) {
-      shim.insertCATRequestHeaders(msgDesc.headers, true)
-    }
-
     if (!shim.agent.config.message_tracer.segment_parameters.enabled) {
       delete msgDesc.parameters
     } else if (msgDesc.routingKey) {
@@ -350,6 +346,11 @@ function recordProduce(nodule, properties, recordNamer) {
       promise: msgDesc.promise || false,
       callback: msgDesc.callback || null,
       recorder: genericRecorder,
+      inContext: function generateCATHeaders() {
+        if (msgDesc.headers) {
+          shim.insertCATRequestHeaders(msgDesc.headers, true)
+        }
+      },
       parameters: msgDesc.parameters || null
     }
   })

package/lib/shim/shim.js

@@ -946,7 +946,7 @@ function record(nodule, properties, recordNamer) {
       var promised = false
       var ret
       try {
-        ret = shim.applySegment(fn, segment, true, ctx, args)
+        ret = shim.applySegment(fn, segment, true, ctx, args, segDesc.inContext)
         if (segDesc.after && segDesc.promise && shim.isPromise(ret)) {
           promised = true
           return ret.then(function onThen(val) {
@@ -1286,7 +1286,7 @@ function storeSegment(obj, segment) {
  * Sets the given segment as the active one for the duration of the function's
  * execution.
  *
- * - `applySegment(func, segment, full, context, args)`
+ * - `applySegment(func, segment, full, context, args[, inContextCB])`
  *
  * @memberof Shim.prototype
  *
@@ -1305,9 +1305,15 @@ function storeSegment(obj, segment) {
  * @param {Array.<*>} args
  *  The arguments to be passed into the function.
  *
+ * @param {Function} [inContextCB]
+ *  The function used to do more instrumentation work. This function is
+ *  guaranteed to be executed with the segment associated with.
+ *
+ *
  * @return {*} Whatever value `func` returned.
  */
-function applySegment(func, segment, full, context, args) {
+/* eslint-disable max-params */
+function applySegment(func, segment, full, context, args, inContextCB) {
   // Exist fast for bad arguments.
   if (!this.isFunction(func)) {
     return
@@ -1327,6 +1333,10 @@ function applySegment(func, segment, full, context, args) {
     segment.start()
   }
 
+  if (typeof inContextCB === 'function') {
+    inContextCB()
+  }
+
   // Execute the function and then return the tracer segment to the old one.
   try {
     return func.apply(context, args)
@@ -1337,6 +1347,7 @@ function applySegment(func, segment, full, context, args) {
     tracer.segment = prevSegment
   }
 }
+/* eslint-enable max-params */
 
 /**
  * Creates a new segment.

package/lib/shim/specs/index.js

@@ -45,6 +45,7 @@ function WrapSpec(spec) {
 function SegmentSpec(spec) {
   this.name       = hasOwnProperty(spec, 'name') ? spec.name : null
   this.recorder   = hasOwnProperty(spec, 'recorder') ? spec.recorder : null
+  this.inContext  = hasOwnProperty(spec, 'inContext') ? spec.inContext : null
   this.parent     = hasOwnProperty(spec, 'parent') ? spec.parent : null
   this.parameters = hasOwnProperty(spec, 'parameters') ? spec.parameters : null
   this.internal   = hasOwnProperty(spec, 'internal') ? spec.internal : false

package/lib/shim/transaction-shim.js

@@ -287,7 +287,7 @@ function handleCATHeaders(headers, segment, transportType) {
     transportType = Transaction.TRANSPORT_TYPES.UNKNOWN
   }
 
-  if (this.agent.config.feature_flag.distributed_tracing) {
+  if (this.agent.config.distributed_tracing.enabled) {
     const payload = headers[DISTRIBUTED_TRACE_HEADER]
     if (payload) {
       tx.acceptDistributedTracePayload(payload, transportType)
@@ -351,7 +351,7 @@ function insertCATRequestHeaders(headers, useAlternateHeaderNames) {
     this.logger.trace('CAT disabled, not adding headers.')
     return
   }
-  var usingDistributedTracing = this.agent.config.feature_flag.distributed_tracing
+  var usingDistributedTracing = this.agent.config.distributed_tracing.enabled
   if (!this.agent.config.encoding_key && !usingDistributedTracing) {
     this.logger.warn('Missing encoding key, not adding CAT headers!')
     return
@@ -433,7 +433,7 @@ function insertCATReplyHeader(headers, useAlternateHeaderNames) {
   if (!config.cross_application_tracer.enabled) {
     this.logger.trace('CAT disabled, not adding reply header.')
     return
-  } else if (config.feature_flag.distributed_tracing) {
+  } else if (config.distributed_tracing.enabled) {
     this.logger.warn('CAT disabled, distributed tracing is enabled')
     return
   } else if (!config.encoding_key) {

package/lib/shimmer.js

@@ -205,6 +205,9 @@ var shimmer = module.exports = {
       if (original.__NR_unwrap) return logger.debug("%s already wrapped by agent.", fqmn)
 
       var wrapped = wrapper(original, method)
+      Object.keys(original).forEach((key) => {
+        wrapped[key] = original[key]
+      })
       wrapped.__NR_original = original
       wrapped.__NR_unwrap = function __NR_unwrap() {
         nodule[method] = original

package/lib/spans/aggregator.js

@@ -20,19 +20,18 @@ class SpanAggregator extends EventAggregator {
    * Attempts to add the given segment to the collection.
    *
    * @param {TraceSegment}  segment         - The segment to add.
-   * @param {string}        [parentId]      - The GUID of the parent span.
-   * @param {string}        [grandparentId] - The GUID of the grandparent span.
+   * @param {string}        [parentId=null] - The GUID of the parent span.
    *
    * @return {bool} True if the segment was added, or false if it was discarded.
    */
-  addSegment(segment, parentId, grandparentId) {
+  addSegment(segment, parentId) {
     // Check if the priority would be accepted before creating the event object.
     const tx = segment.transaction
     if (tx.priority < this._events.getMinimumPriority()) {
       ++this._events.seen
       return false
     }
-    const span = SpanEvent.fromSegment(segment, parentId || null, grandparentId || null)
+    const span = SpanEvent.fromSegment(segment, parentId || null)
     return this.addEvent(span, tx.priority)
   }
 }

package/lib/spans/span-event.js

@@ -1,9 +1,12 @@
 'use strict'
 
+const truncate = require('../util/byte-limit').truncate
+
 const NAMES = require('../metrics/names')
-const EXTERNAL_LIBRARY = 'http'
+const HTTP_LIBRARY = 'http'
+const SPAN_KIND_ATTRIBUTE = 'client'
 const CATEGORIES = {
-  EXTERNAL: 'external',
+  HTTP: 'http',
   DATASTORE: 'datastore',
   GENERIC: 'generic'
 }
@@ -25,8 +28,7 @@ class SpanEvent {
     this.traceId = null
     this.guid = null
     this.parentId = null
-    this.grandparentId = null
-    this.appLocalRootId = null
+    this.transactionId = null
     this.sampled = null
     this.priority = null
     this.name = null
@@ -45,8 +47,8 @@ class SpanEvent {
     return DatastoreSpanEvent
   }
 
-  static get ExternalSpanEvent() {
-    return ExternalSpanEvent
+  static get HttpSpanEvent() {
+    return HttpSpanEvent
   }
 
   /**
@@ -55,14 +57,15 @@ class SpanEvent {
    * The constructed span event will contain extra data depending on the
    * category of the segment.
    *
-   * @param {TraceSegment} segment - The segment to turn into a span event.
+   * @param {TraceSegment}  segment         - The segment to turn into a span event.
+   * @param {?string}       [parentId=null] - The ID of the segment's parent.
    *
    * @return {SpanEvent} The constructed event.
    */
-  static fromSegment(segment, parentId, grandparentId) {
+  static fromSegment(segment, parentId) {
     let span = null
-    if (ExternalSpanEvent.testSegment(segment)) {
-      span = new ExternalSpanEvent(segment.parameters)
+    if (HttpSpanEvent.testSegment(segment)) {
+      span = new HttpSpanEvent(segment.parameters)
     } else if (DatastoreSpanEvent.testSegment(segment)) {
       span = new DatastoreSpanEvent(segment.parameters)
     } else {
@@ -74,12 +77,16 @@ class SpanEvent {
     span.traceId = tx.traceId || tx.id
     span.guid = segment.id
     span.parentId = parentId || null
-    span.grandparentId = grandparentId || null
-    span.appLocalRootId = tx.id
+
+    span.transactionId = tx.id
     span.sampled = tx.sampled
     span.priority = tx.priority
     span.name = segment.name
 
+    if (tx.baseSegment === segment) {
+      span['nr.entryPoint'] = true
+    }
+
     // Timestamp in milliseconds, duration in seconds. Yay consistency!
     span.timestamp = segment.timer.start
     span.duration = segment.timer.getDurationInMillis() / 1000
@@ -88,8 +95,15 @@ class SpanEvent {
   }
 
   toJSON() {
+    const attrs = Object.create(null)
+    for (let key in this) {
+      if (this[key] != null) {
+        attrs[key] = this[key]
+      }
+    }
+
     return [
-      Object.assign(Object.create(null), this),
+      attrs,
       EMPTY_USER_ATTRS,
       EMPTY_AGENT_ATTRS
     ]
@@ -102,17 +116,18 @@ class SpanEvent {
  * @private
  * @class
  */
-class ExternalSpanEvent extends SpanEvent {
+class HttpSpanEvent extends SpanEvent {
   constructor(parameters) {
     super()
 
-    this.category = CATEGORIES.EXTERNAL
-    this.externalLibrary = parameters.library || EXTERNAL_LIBRARY
+    this.category = CATEGORIES.HTTP
+    this.component = parameters.library || HTTP_LIBRARY
+    this['span.kind'] = SPAN_KIND_ATTRIBUTE
     if (parameters.url) {
-      this.externalUri = parameters.url // Some day URI and URL will be consistent...
+      this['http.url'] = parameters.url
     }
     if (parameters.procedure) {
-      this.externalProcedure = parameters.procedure
+      this['http.method'] = parameters.procedure
     }
   }
 
@@ -132,23 +147,24 @@ class DatastoreSpanEvent extends SpanEvent {
     super()
 
     this.category = CATEGORIES.DATASTORE
+    this['span.kind'] = SPAN_KIND_ATTRIBUTE
     if (parameters.product) {
-      this.datastoreProduct = parameters.product
+      this.component = parameters.product
     }
-    if (parameters.collection) {
-      this.datastoreCollection = parameters.collection
+    if (parameters.sql_obfuscated) {
+      this['db.statement'] = _truncate(parameters.sql_obfuscated)
+    } else if (parameters.sql) {
+      this['db.statement'] = _truncate(parameters.sql)
     }
-    if (parameters.operation) {
-      this.datastoreOperation = parameters.operation
+    if (parameters.database_name) {
+      this['db.instance'] = parameters.database_name
     }
     if (parameters.host) {
-      this.datastoreHost = parameters.host
-    }
-    if (parameters.port_path_or_id) {
-      this.datastorePortPathOrId = parameters.port_path_or_id
-    }
-    if (parameters.database_name) {
-      this.datastoreName = parameters.database_name
+      this['peer.hostname'] = parameters.host
+
+      if (parameters.port_path_or_id) {
+        this['peer.address'] = `${parameters.host}:${parameters.port_path_or_id}`
+      }
     }
   }
 
@@ -157,4 +173,12 @@ class DatastoreSpanEvent extends SpanEvent {
   }
 }
 
+function _truncate(val) {
+  let truncated = truncate(val, 1997)
+  if (truncated !== val) {
+    truncated += '...'
+  }
+  return truncated
+}
+
 module.exports = SpanEvent