newrelic 12.18.0 → 12.18.2

package/NEWS.md

@@ -1,3 +1,33 @@
+### v12.18.2 (2025-04-30)
+
+#### Bug fixes
+
+* Updated `createSegment` to stop adding segments to trace when `max_trace_segments` is exceeded ([#3056](https://github.com/newrelic/node-newrelic/pull/3056)) ([8f3336e](https://github.com/newrelic/node-newrelic/commit/8f3336e98ac9f7d4ad0ded3a061774fd68053e76))
+
+#### Documentation
+
+* Updated compatibility report ([#3065](https://github.com/newrelic/node-newrelic/pull/3065)) ([#3063](https://github.com/newrelic/node-newrelic/pull/3063)) 
+
+### v12.18.1 (2025-04-29)
+
+#### Bug fixes
+
+* Only add `newrelic` header to outgoing headers if has a value ([#3052](https://github.com/newrelic/node-newrelic/pull/3052)) ([6ef0a90](https://github.com/newrelic/node-newrelic/commit/6ef0a904291fb4efc6d6f111b3ec93aac720c3ad))
+
+#### Code refactoring
+
+* Added defensive code when calculating exclusive time on a segment where it cannot locate the segment in the transaction trace tree ([#3051](https://github.com/newrelic/node-newrelic/pull/3051)) ([b4aa25e](https://github.com/newrelic/node-newrelic/commit/b4aa25e2df861dab732bb812bffe961c0cc3da36))
+* Updated how otel bridge trace propagator assigns traceparent/tracestate headers ([#3046](https://github.com/newrelic/node-newrelic/pull/3046)) ([6e317b8](https://github.com/newrelic/node-newrelic/commit/6e317b889c68a2e0e69b1d4d2fa9fe2846a0e94f))
+
+#### Documentation
+
+* Updated compatibility report ([#3054](https://github.com/newrelic/node-newrelic/pull/3054)) ([#3050](https://github.com/newrelic/node-newrelic/pull/3050)) ([#3026](https://github.com/newrelic/node-newrelic/pull/3026)) 
+
+#### Tests
+
+* Skipped regressions in pg-native versioned tests ([#3053](https://github.com/newrelic/node-newrelic/pull/3053)) ([6ce3670](https://github.com/newrelic/node-newrelic/commit/6ce36706adc2e17a80b759b51c23807d617ad04f))
+* Updated elasticsearch image for versioned tests ([#3038](https://github.com/newrelic/node-newrelic/pull/3038)) ([3d73f9f](https://github.com/newrelic/node-newrelic/commit/3d73f9faffd45d2d1465210d168822494439c577))
+
 ### v12.18.0 (2025-04-14)
 
 #### Features

package/lib/otel/trace-propagator.js

@@ -69,7 +69,7 @@ module.exports = class NewRelicTracePropagator {
       !isSpanContextValid(spanContext)
     ) { return }
 
-    context?.transaction?.insertDistributedTraceHeaders(carrier, spanContext)
+    context?.transaction?.insertDistributedTraceHeaders(carrier, setter, spanContext)
   }
 
   extract(context, carrier, getter) {

package/lib/transaction/index.js

@@ -906,10 +906,11 @@ function acceptDistributedTraceHeaders(transportType, headers) {
  * Inserts distributed trace headers into the provided headers map.
  *
  * @param {object} headers
+ * @param {object} setter - otel bridge setter to assign headers
  * @param {object} spanContext otel span context
  */
 Transaction.prototype.insertDistributedTraceHeaders = insertDistributedTraceHeaders
-function insertDistributedTraceHeaders(headers, spanContext) {
+function insertDistributedTraceHeaders(headers, setter, spanContext) {
   if (!headers) {
     logger.trace('insertDistributedTraceHeaders called without headers.')
     return
@@ -920,7 +921,7 @@ function insertDistributedTraceHeaders(headers, spanContext) {
   // Ensure we have priority before generating trace headers.
   this._calculatePriority()
 
-  this.traceContext.addTraceContextHeaders(headers, spanContext)
+  this.traceContext.addTraceContextHeaders(headers, setter, spanContext)
   this.isDistributedTrace = true
 
   logger.trace('Added outbound request w3c trace context headers in transaction %s', this.id)
@@ -932,8 +933,10 @@ function insertDistributedTraceHeaders(headers, spanContext) {
 
   try {
     const newrelicFormatData = this._createDistributedTracePayload().httpSafe()
-    headers[NEWRELIC_TRACE_HEADER] = newrelicFormatData
-    logger.trace('Added outbound request distributed tracing headers in transaction %s', this.id)
+    if (newrelicFormatData) {
+      headers[NEWRELIC_TRACE_HEADER] = newrelicFormatData
+      logger.trace('Added outbound request distributed tracing headers in transaction %s', this.id)
+    }
   } catch (error) {
     logger.trace(error, 'Failed to create distributed trace payload')
   }

package/lib/transaction/trace/exclusive-time-calculator.js

@@ -7,7 +7,10 @@
 
 class ExclusiveCalculator {
   constructor(root, trace) {
-    this.node = trace.getNode(root.id)
+    const node = trace.getNode(root.id)
+    // could not find segment in trace, typically because context propagation is broken
+    // add some defensive and essentially set the exclusive time to the segment duration
+    this.node = node ?? { children: [], segment: root }
     // use a second stack to do a post-order traversal
     this.parentStack = []
   }

package/lib/transaction/tracecontext.js

@@ -134,21 +134,30 @@ class TraceContext {
    * Takes a headers object and modifies it in place by adding Trace Context headers
    *
    * @param {object} headers - Headers for an HTTP request
+   * @param {object} setter - otel bridge setter to assign headers to outgoing payload. Doing this instead of assigning to headers because some libraries have special logic for handling outgoing headers(gcp-pubsub)
    * @param {object} spanContext if passed in, it'll use this to construct traceparent/tracestate. only used in otel bridge mode.
    */
-  addTraceContextHeaders(headers, spanContext) {
+  addTraceContextHeaders(headers, setter, spanContext) {
     if (!headers) {
       return
     }
 
     const traceParent = this.createTraceparent(spanContext)
-    headers[TRACE_CONTEXT_PARENT_HEADER] = traceParent
+    if (setter) {
+      setter.set(headers, TRACE_CONTEXT_PARENT_HEADER, traceParent)
+    } else {
+      headers[TRACE_CONTEXT_PARENT_HEADER] = traceParent
+    }
 
     logger.trace('traceparent added with %s', traceParent)
 
     const tracestate = this.createTracestate(spanContext)
     if (tracestate) {
-      headers[TRACE_CONTEXT_STATE_HEADER] = tracestate
+      if (setter) {
+        setter.set(headers, TRACE_CONTEXT_STATE_HEADER, tracestate)
+      } else {
+        headers[TRACE_CONTEXT_STATE_HEADER] = tracestate
+      }
       logger.trace('tracestate added with %s', tracestate)
     }
 

package/lib/transaction/tracer/index.js

@@ -135,7 +135,10 @@ function createSegment({ id, name, recorder, parent, transaction }) {
   if (recorder) {
     transaction.addRecorder(recorder.bind(null, segment))
   }
-  transaction.trace.segments.add(segment)
+
+  if (collect) {
+    transaction.trace.segments.add(segment)
+  }
 
   return segment
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "newrelic",
-  "version": "12.18.0",
+  "version": "12.18.2",
   "author": "New Relic Node.js agent team <nodejs@newrelic.com>",
   "license": "Apache-2.0",
   "contributors": [