newpr 1.0.18 → 1.0.20

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "newpr",
-  "version": "1.0.18",
+  "version": "1.0.20",
   "description": "AI-powered large PR review tool - understand PRs with 1000+ lines of changes",
   "module": "src/cli/index.ts",
   "type": "module",

package/src/cli/args.ts

@@ -57,7 +57,7 @@ Options (review mode):
   -v, --version         Show version
 
 Environment Variables:
-  OPENROUTER_API_KEY    Required. Your OpenRouter API key.
+  OPENROUTER_API_KEY    Optional. Used when configured; otherwise local agent fallback is used.
   GITHUB_TOKEN          Optional. Falls back to gh CLI token.
   NEWPR_MODEL           Default model override.
   NEWPR_MAX_FILES       Max files to analyze (default: 100).

package/src/config/index.ts

@@ -61,12 +61,7 @@ export async function loadConfig(
 ): Promise<NewprConfig> {
 	const stored = await (_readStore ?? readStoredConfig)();
 
-	const apiKey = process.env.OPENROUTER_API_KEY || stored.openrouter_api_key;
-	if (!apiKey) {
-		throw new Error(
-			"OPENROUTER_API_KEY is not set. Run `newpr auth` to configure, or set the environment variable.",
-		);
-	}
+	const apiKey = process.env.OPENROUTER_API_KEY || stored.openrouter_api_key || "";
 
 	const agentVal = stored.agent as NewprConfig["agent"];
 	const rawLang = process.env.NEWPR_LANGUAGE || stored.language || DEFAULT_CONFIG.language;

package/src/stack/feasibility.ts

@@ -30,7 +30,7 @@ export function checkFeasibility(input: FeasibilityInput): FeasibilityResult {
 	}
 
 	const deduped = deduplicateEdges(edges);
-	const result = topologicalSort(Array.from(allGroups), deduped, deltas);
+	const result = topologicalSort(Array.from(allGroups), deduped, deltas, ownership);
 
 	return result;
 }
@@ -137,6 +137,7 @@ function topologicalSort(
 	groups: string[],
 	edges: ConstraintEdge[],
 	deltas: DeltaEntry[],
+	ownership?: Map<string, string>,
 ): FeasibilityResult {
 	const inDegree = new Map<string, number>();
 	const adjacency = new Map<string, string[]>();
@@ -156,7 +157,7 @@ function topologicalSort(
 		edgeMap.set(`${edge.from}→${edge.to}`, edge);
 	}
 
-	const firstCommitDate = buildFirstCommitDateMap(groups, deltas);
+	const firstCommitDate = buildFirstCommitDateMap(groups, deltas, ownership);
 
 	const queue: string[] = [];
 	for (const [g, deg] of inDegree) {
@@ -200,6 +201,7 @@ function topologicalSort(
 function buildFirstCommitDateMap(
 	groups: string[],
 	deltas: DeltaEntry[],
+	ownership?: Map<string, string>,
 ): Map<string, string> {
 	const result = new Map<string, string>();
 	for (const g of groups) {
@@ -207,12 +209,11 @@ function buildFirstCommitDateMap(
 	}
 	for (const delta of deltas) {
 		for (const change of delta.changes) {
-			const g = change.path;
-			if (result.has(g)) {
-				const current = result.get(g);
-				if (!current || delta.date < current) {
-					result.set(g, delta.date);
-				}
+			const groupId = ownership?.get(change.path);
+			if (!groupId) continue;
+			const current = result.get(groupId);
+			if (current && delta.date < current) {
+				result.set(groupId, delta.date);
 			}
 		}
 	}

package/src/stack/partition.ts

@@ -193,7 +193,25 @@ function parsePartitionResponse(
 	const warnings: string[] = [];
 	const structuredWarnings: StackWarning[] = [];
 
-	const validGroupNames = new Set(groups.map((g) => g.name));
+	let sharedFoundation: FileGroup | undefined;
+	if (data.shared_foundation && typeof data.shared_foundation === "object") {
+		const sf = data.shared_foundation as Record<string, unknown>;
+		sharedFoundation = {
+			name: String(sf.name ?? "Shared Foundation"),
+			type: "chore",
+			description: String(sf.description ?? "Common infrastructure changes"),
+			files: Array.isArray(sf.files) ? sf.files.map(String) : [],
+		};
+	}
+
+	const groupNameLookup = new Map<string, string>();
+	for (const group of groups) {
+		groupNameLookup.set(group.name.toLowerCase(), group.name);
+	}
+	if (sharedFoundation) {
+		groupNameLookup.set(sharedFoundation.name.toLowerCase(), sharedFoundation.name);
+		groupNameLookup.set("shared foundation", sharedFoundation.name);
+	}
 
 	for (const item of assignments) {
 		const entry = item as Record<string, unknown>;
@@ -206,7 +224,26 @@ function parsePartitionResponse(
 			continue;
 		}
 
-		if (!validGroupNames.has(group)) {
+		const normalizedGroup = group.toLowerCase().replace(/["'`]/g, "").trim();
+		const isSharedFoundationAlias = /shared[\s_-]*foundation/.test(normalizedGroup);
+		let canonicalGroup = groupNameLookup.get(normalizedGroup);
+		if (!canonicalGroup && isSharedFoundationAlias) {
+			if (!sharedFoundation) {
+				sharedFoundation = {
+					name: "Shared Foundation",
+					type: "chore",
+					description: "Common infrastructure changes",
+					files: [],
+				};
+			}
+			groupNameLookup.set(sharedFoundation.name.toLowerCase(), sharedFoundation.name);
+			groupNameLookup.set("shared-foundation", sharedFoundation.name);
+			groupNameLookup.set("shared_foundation", sharedFoundation.name);
+			groupNameLookup.set("shared foundation", sharedFoundation.name);
+			canonicalGroup = sharedFoundation.name;
+		}
+
+		if (!canonicalGroup) {
 			warnings.push(`Unknown group "${group}" for file "${path}", skipping`);
 			structuredWarnings.push({
 				category: "system",
@@ -224,19 +261,22 @@ function parsePartitionResponse(
 			reattributed.push({
 				path,
 				from_groups: ambiguousEntry.groups,
-				to_group: group,
+				to_group: canonicalGroup,
 				reason,
 			});
 		} else if (isUnassigned) {
 			reattributed.push({
 				path,
 				from_groups: [],
-				to_group: group,
+				to_group: canonicalGroup,
 				reason,
 			});
 		}
 
-		ownership.set(path, group);
+		ownership.set(path, canonicalGroup);
+		if (sharedFoundation && canonicalGroup === sharedFoundation.name && !sharedFoundation.files.includes(path)) {
+			sharedFoundation.files.push(path);
+		}
 	}
 
 	const stillUnassigned = report.unassigned.filter((p) => !ownership.has(p));
@@ -274,18 +314,6 @@ function parsePartitionResponse(
 		});
 	}
 
-	let sharedFoundation: FileGroup | undefined;
-	if (data.shared_foundation && typeof data.shared_foundation === "object") {
-		const sf = data.shared_foundation as Record<string, unknown>;
-		sharedFoundation = {
-			name: String(sf.name ?? "Shared Foundation"),
-			type: "chore",
-			description: String(sf.description ?? "Common infrastructure changes"),
-			files: Array.isArray(sf.files) ? sf.files.map(String) : [],
-		};
-		validGroupNames.add(sharedFoundation.name);
-	}
-
 	return {
 		ownership,
 		reattributed,
@@ -294,5 +322,3 @@ function parsePartitionResponse(
 		structured_warnings: structuredWarnings,
 	};
 }
-
-

package/src/web/server/routes.ts

@@ -1658,7 +1658,8 @@ Before posting an inline comment, ALWAYS call \`get_file_diff\` first to find th
 		},
 
 		"POST /api/slides": async (req: Request) => {
-			if (!config.openrouter_api_key) return json({ error: "OpenRouter API key required" }, 400);
+			const apiKey = config.openrouter_api_key;
+			if (!apiKey) return json({ error: "OpenRouter API key required" }, 400);
 
 			const body = await req.json() as { sessionId?: string; language?: string; resume?: boolean };
 			const sessionId = body.sessionId;
@@ -1678,7 +1679,7 @@ Before posting an inline comment, ALWAYS call \`get_file_diff\` first to find th
 			(async () => {
 				try {
 					const deck = await generateSlides(
-						config.openrouter_api_key,
+						apiKey,
 						data,
 						config.model,
 						body.language ?? config.language,
@@ -1749,7 +1750,8 @@ Before posting an inline comment, ALWAYS call \`get_file_diff\` first to find th
 			const body = await req.json() as { sessionId?: string; resume?: boolean };
 			const sessionId = body.sessionId;
 			if (!sessionId) return json({ error: "Missing sessionId" }, 400);
-			if (!config.openrouter_api_key) return json({ error: "API key required" }, 400);
+			const apiKey = config.openrouter_api_key;
+			if (!apiKey) return json({ error: "API key required" }, 400);
 
 			const plugin = getPlugin(pluginId);
 			if (!plugin) return json({ error: `Unknown plugin: ${pluginId}` }, 404);
@@ -1770,7 +1772,7 @@ Before posting an inline comment, ALWAYS call \`get_file_diff\` first to find th
 			(async () => {
 				try {
 					const result = await plugin.generate(
-						{ apiKey: config.openrouter_api_key, sessionId, data, language: config.language },
+						{ apiKey, sessionId, data, language: config.language },
 						(event) => { job.message = event.message; job.current = event.current; job.total = event.total; },
 						existingData,
 					);

package/src/web/server/stack-manager.ts

@@ -442,22 +442,22 @@ async function runStackPipeline(
 
 		buildReattributionWarnings(partition, analysisSet, allStructuredWarnings);
 
-		const lastGroup = groupOrder[groupOrder.length - 1];
-		if (lastGroup) {
+		const backfillGroup = groupOrder[0] ?? groupOrder[groupOrder.length - 1];
+		if (backfillGroup) {
 			const backfilled: string[] = [];
 			for (const path of deltaFilePaths) {
 				if (!mergedOwnership.has(path)) {
-					mergedOwnership.set(path, lastGroup);
+					mergedOwnership.set(path, backfillGroup);
 					backfilled.push(path);
 				}
 			}
 			if (backfilled.length > 0) {
-				allWarnings.push(`Files still unassigned after AI classification, fallback to "${lastGroup}": ${backfilled.join(", ")}`);
+				allWarnings.push(`Files still unassigned after AI classification, fallback to "${backfillGroup}": ${backfilled.join(", ")}`);
 				allStructuredWarnings.push({
 					category: "assignment",
 					severity: "warn",
-					title: `${backfilled.length} file(s) fell back to last group`,
-					message: `AI could not classify these files — assigned to "${lastGroup}" as fallback`,
+					title: `${backfilled.length} file(s) fell back to first group`,
+					message: `AI could not classify these files — assigned to "${backfillGroup}" as fallback`,
 					details: backfilled,
 				});
 			}
@@ -476,6 +476,13 @@ async function runStackPipeline(
 		for (const [path, groupId] of balanced.ownership) {
 			mergedOwnership.set(path, groupId);
 		}
+		const balancedGroupFiles = new Map<string, string[]>();
+		for (const [path, groupId] of mergedOwnership) {
+			const files = balancedGroupFiles.get(groupId) ?? [];
+			files.push(path);
+			balancedGroupFiles.set(groupId, files);
+		}
+		currentGroups = currentGroups.map((g) => ({ ...g, files: (balancedGroupFiles.get(g.name) ?? g.files).sort() }));
 		allStructuredWarnings.push(...balanced.warnings);
 
 		if (session.maxGroups && session.maxGroups > 0 && currentGroups.length > session.maxGroups) {