newpr 1.0.18 → 1.0.19

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "newpr",
-  "version": "1.0.18",
+  "version": "1.0.19",
   "description": "AI-powered large PR review tool - understand PRs with 1000+ lines of changes",
   "module": "src/cli/index.ts",
   "type": "module",

package/src/stack/partition.ts

@@ -193,7 +193,25 @@ function parsePartitionResponse(
 	const warnings: string[] = [];
 	const structuredWarnings: StackWarning[] = [];
 
-	const validGroupNames = new Set(groups.map((g) => g.name));
+	let sharedFoundation: FileGroup | undefined;
+	if (data.shared_foundation && typeof data.shared_foundation === "object") {
+		const sf = data.shared_foundation as Record<string, unknown>;
+		sharedFoundation = {
+			name: String(sf.name ?? "Shared Foundation"),
+			type: "chore",
+			description: String(sf.description ?? "Common infrastructure changes"),
+			files: Array.isArray(sf.files) ? sf.files.map(String) : [],
+		};
+	}
+
+	const groupNameLookup = new Map<string, string>();
+	for (const group of groups) {
+		groupNameLookup.set(group.name.toLowerCase(), group.name);
+	}
+	if (sharedFoundation) {
+		groupNameLookup.set(sharedFoundation.name.toLowerCase(), sharedFoundation.name);
+		groupNameLookup.set("shared foundation", sharedFoundation.name);
+	}
 
 	for (const item of assignments) {
 		const entry = item as Record<string, unknown>;
@@ -206,7 +224,26 @@ function parsePartitionResponse(
 			continue;
 		}
 
-		if (!validGroupNames.has(group)) {
+		const normalizedGroup = group.toLowerCase().replace(/["'`]/g, "").trim();
+		const isSharedFoundationAlias = /shared[\s_-]*foundation/.test(normalizedGroup);
+		let canonicalGroup = groupNameLookup.get(normalizedGroup);
+		if (!canonicalGroup && isSharedFoundationAlias) {
+			if (!sharedFoundation) {
+				sharedFoundation = {
+					name: "Shared Foundation",
+					type: "chore",
+					description: "Common infrastructure changes",
+					files: [],
+				};
+			}
+			groupNameLookup.set(sharedFoundation.name.toLowerCase(), sharedFoundation.name);
+			groupNameLookup.set("shared-foundation", sharedFoundation.name);
+			groupNameLookup.set("shared_foundation", sharedFoundation.name);
+			groupNameLookup.set("shared foundation", sharedFoundation.name);
+			canonicalGroup = sharedFoundation.name;
+		}
+
+		if (!canonicalGroup) {
 			warnings.push(`Unknown group "${group}" for file "${path}", skipping`);
 			structuredWarnings.push({
 				category: "system",
@@ -224,19 +261,22 @@ function parsePartitionResponse(
 			reattributed.push({
 				path,
 				from_groups: ambiguousEntry.groups,
-				to_group: group,
+				to_group: canonicalGroup,
 				reason,
 			});
 		} else if (isUnassigned) {
 			reattributed.push({
 				path,
 				from_groups: [],
-				to_group: group,
+				to_group: canonicalGroup,
 				reason,
 			});
 		}
 
-		ownership.set(path, group);
+		ownership.set(path, canonicalGroup);
+		if (sharedFoundation && canonicalGroup === sharedFoundation.name && !sharedFoundation.files.includes(path)) {
+			sharedFoundation.files.push(path);
+		}
 	}
 
 	const stillUnassigned = report.unassigned.filter((p) => !ownership.has(p));
@@ -274,18 +314,6 @@ function parsePartitionResponse(
 		});
 	}
 
-	let sharedFoundation: FileGroup | undefined;
-	if (data.shared_foundation && typeof data.shared_foundation === "object") {
-		const sf = data.shared_foundation as Record<string, unknown>;
-		sharedFoundation = {
-			name: String(sf.name ?? "Shared Foundation"),
-			type: "chore",
-			description: String(sf.description ?? "Common infrastructure changes"),
-			files: Array.isArray(sf.files) ? sf.files.map(String) : [],
-		};
-		validGroupNames.add(sharedFoundation.name);
-	}
-
 	return {
 		ownership,
 		reattributed,
@@ -294,5 +322,3 @@ function parsePartitionResponse(
 		structured_warnings: structuredWarnings,
 	};
 }
-
-