newpr 1.0.15 → 1.0.16

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "newpr",
-  "version": "1.0.15",
+  "version": "1.0.16",
   "description": "AI-powered large PR review tool - understand PRs with 1000+ lines of changes",
   "module": "src/cli/index.ts",
   "type": "module",

package/src/stack/pr-title.ts

@@ -2,6 +2,8 @@ import type { LlmClient } from "../llm/client.ts";
 import type { StackGroup } from "./types.ts";
 
 const MAX_TITLE_LENGTH = 72;
+const KOREAN_NOUN_END_RE = /(추가|개선|수정|정리|분리|통합|구현|적용|도입|구성|지원|처리|보강|최적화|리팩터링|안정화|마이그레이션|업데이트|생성|검증|연동|변경|제거|작성|설정|관리|보호|강화|정의|확장|대응|복구|표시|유지|등록|삭제|작업)$/;
+const KOREAN_VERB_END_RE = /(합니다|하였다|했다|한다|되었다|됐다|되다|하다)$/;
 const TYPE_PREFIX: Record<string, string> = {
 	feature: "feat",
 	feat: "feat",
@@ -21,15 +23,63 @@ function normalizeTypePrefix(type: string): string {
 	return TYPE_PREFIX[type] ?? "chore";
 }
 
-function sanitizeTitle(raw: string): string {
-	let title = raw.trim().replace(/\.+$/, "");
+function isKoreanLanguage(languageHint: string | null): boolean {
+	if (!languageHint) return false;
+	return /korean|^ko$/i.test(languageHint);
+}
+
+function ensureNounFormDescription(description: string, languageHint: string | null): string {
+	let desc = description.trim().replace(/\.+$/, "");
+	if (!desc) return isKoreanLanguage(languageHint) ? "변경 작업" : "update";
+
+	const hasKoreanContext = /[가-힣]/.test(desc) || isKoreanLanguage(languageHint);
+	if (!hasKoreanContext) return desc;
+	if (KOREAN_NOUN_END_RE.test(desc)) return desc;
+
+	const verbTrimmed = desc.replace(KOREAN_VERB_END_RE, "").trim();
+	if (verbTrimmed) {
+		if (KOREAN_NOUN_END_RE.test(verbTrimmed)) return verbTrimmed;
+		return `${verbTrimmed} 작업`;
+	}
+
+	return "변경 작업";
+}
+
+function splitTitle(raw: string): { prefix: string; description: string } {
+	const idx = raw.indexOf(":");
+	if (idx < 0) return { prefix: "", description: raw.trim() };
+	return {
+		prefix: raw.slice(0, idx).trim(),
+		description: raw.slice(idx + 1).trim(),
+	};
+}
+
+function sanitizeTitle(raw: string, languageHint: string | null): string {
+	const parsed = splitTitle(raw);
+	const prefix = parsed.prefix;
+	let description = ensureNounFormDescription(parsed.description, languageHint);
+	let title = prefix ? `${prefix}: ${description}` : description;
+	title = title.trim().replace(/\.+$/, "");
+
 	if (title.length > MAX_TITLE_LENGTH) {
-		title = title.slice(0, MAX_TITLE_LENGTH).replace(/\s\S*$/, "").trimEnd();
+		if (prefix) {
+			const prefixText = `${prefix}: `;
+			const maxDesc = MAX_TITLE_LENGTH - prefixText.length;
+			description = description.slice(0, maxDesc).replace(/\s\S*$/, "").trimEnd();
+			description = ensureNounFormDescription(description, languageHint);
+			if (description.length > maxDesc) {
+				description = description.slice(0, maxDesc).trimEnd();
+			}
+			title = `${prefixText}${description || ensureNounFormDescription("", languageHint)}`;
+		} else {
+			title = title.slice(0, MAX_TITLE_LENGTH).replace(/\s\S*$/, "").trimEnd();
+		}
 	}
+
 	return title;
 }
 
-function fallbackTitle(g: StackGroup): string {
+function fallbackTitle(g: StackGroup, languageHint: string | null): string {
 	const desc = g.description || g.name;
 	const cleaned = desc.replace(/[^\p{L}\p{N}\s\-/.,()]/gu, " ").replace(/\s+/g, " ").trim();
 	const prefix = `${normalizeTypePrefix(g.type)}: `;
@@ -37,7 +87,7 @@ function fallbackTitle(g: StackGroup): string {
 	const truncated = cleaned.length > maxDesc
 		? cleaned.slice(0, maxDesc).replace(/\s\S*$/, "").trimEnd()
 		: cleaned;
-	return truncated ? `${prefix}${truncated}` : `${prefix}${g.name}`;
+	return sanitizeTitle(truncated ? `${prefix}${truncated}` : `${prefix}${g.name}`, languageHint);
 }
 
 export async function generatePrTitles(
@@ -70,7 +120,7 @@ export async function generatePrTitles(
 Rules:
 - Format: "type: description"
 - type must be one of: feat | fix | refactor | chore | docs | test | perf | style | ci
-- description: 5-12 words, imperative mood, no trailing period
+- description: 4-12 words, noun phrase only, must end with a noun, no trailing period
 - Target length: 40-72 characters total
 - Be specific about WHAT changed, not vague
 - Each title must be unique across the set
@@ -78,19 +128,20 @@ Rules:
 ${langRule}
 
 Good examples:
-- "feat: add JWT token refresh middleware for auth flow"
-- "fix: prevent null user crash on session expiry"
-- "refactor: extract shared validation logic into helpers"
-- "chore: migrate eslint config to flat format"
-- "feat: implement drag-and-drop reordering for canvas nodes"
-- "test: add integration tests for payment webhook handler"
-- "refactor: split monolithic API router into domain modules"
+- "feat: JWT token refresh middleware integration"
+- "fix: session expiry null user crash prevention"
+- "refactor: shared validation helper extraction"
+- "chore: eslint flat config migration"
+- "feat: canvas node drag-and-drop reorder support"
+- "test: payment webhook integration test coverage"
+- "refactor: monolithic API router module split"
 
 Bad examples:
 - "feat: auth" (too vague)
 - "fix: bug" (meaningless)
 - "refactor: code" (says nothing)
 - "feat: jwt" (just a keyword, not a title)
+- "feat: add JWT refresh middleware" (imperative verb)
 - "" (empty)
 
 Return ONLY a JSON array: [{"group_id": "...", "title": "..."}]`;
@@ -118,18 +169,18 @@ Generate a descriptive PR title (40-72 chars) for each group. Return JSON array:
 		}
 		for (const item of parsed) {
 			if (item.group_id && item.title?.trim()) {
-				titles.set(item.group_id, sanitizeTitle(item.title));
+				titles.set(item.group_id, sanitizeTitle(item.title, lang));
 			}
 		}
 	} catch {
 		for (const g of groups) {
-			titles.set(g.id, fallbackTitle(g));
+			titles.set(g.id, fallbackTitle(g, lang));
 		}
 	}
 
 	for (const g of groups) {
 		if (!titles.has(g.id) || !titles.get(g.id)) {
-			titles.set(g.id, fallbackTitle(g));
+			titles.set(g.id, fallbackTitle(g, lang));
 		}
 	}
 

package/src/web/client/hooks/useStack.ts

@@ -79,6 +79,7 @@ interface PublishResultData {
 		base_branch: string;
 		head_branch: string;
 	}>;
+	publishedAt?: number;
 }
 
 interface ServerStackState {
@@ -92,6 +93,7 @@ interface ServerStackState {
 	plan: PlanData | null;
 	execResult: ExecResultData | null;
 	verifyResult: VerifyResultData | null;
+	publishResult: PublishResultData | null;
 	startedAt: number;
 	finishedAt: number | null;
 }
@@ -130,6 +132,7 @@ function applyServerState(server: ServerStackState): Partial<StackState> {
 		plan: server.plan,
 		execResult: server.execResult,
 		verifyResult: server.verifyResult,
+		publishResult: server.publishResult,
 	};
 }
 
@@ -259,11 +262,15 @@ export function useStack(sessionId: string | null | undefined, options?: UseStac
 			if (!res.ok) throw new Error(data.error ?? "Publishing failed");
 
 			const publishResult = data.publish_result as PublishResultData;
+			const serverState = (data as { state?: ServerStackState }).state;
+			const nextPublishResult = serverState?.publishResult ?? publishResult;
 
 			setState((s) => ({
 				...s,
+				...(serverState ? applyServerState(serverState) : {}),
 				phase: "done",
-				publishResult,
+				publishResult: nextPublishResult,
+				progressMessage: null,
 			}));
 
 			if (options?.onTrackAnalysis && publishResult?.prs?.length > 0) {

package/src/web/client/panels/StackPanel.tsx

@@ -75,6 +75,14 @@ interface StackPanelProps {
 
 export function StackPanel({ sessionId, onTrackAnalysis }: StackPanelProps) {
 	const stack = useStack(sessionId, { onTrackAnalysis });
+	const publishedCount = stack.publishResult?.prs.length ?? 0;
+	const pushedCount = stack.publishResult?.branches.filter((b) => b.pushed).length ?? 0;
+	const publishFailures = stack.publishResult
+		? stack.publishResult.branches.filter((branch) => {
+			if (!branch.pushed) return true;
+			return !stack.publishResult?.prs.some((pr) => pr.head_branch === branch.name);
+		})
+		: [];
 
 	if (stack.phase === "idle") {
 		return (
@@ -263,30 +271,57 @@ export function StackPanel({ sessionId, onTrackAnalysis }: StackPanelProps) {
 				</button>
 			)}
 
-			{stack.publishResult && stack.publishResult.prs.length > 0 && (
-				<div className="space-y-1.5">
-					{stack.publishResult.prs.map((pr) => (
-						<a
-							key={pr.number}
-							href={pr.url}
-							target="_blank"
-							rel="noopener noreferrer"
-							className="group flex items-center gap-3 rounded-lg px-3.5 py-2.5 hover:bg-accent/30 transition-colors"
-						>
-							<GitPullRequestArrow className="h-3.5 w-3.5 text-green-600/60 dark:text-green-400/60 shrink-0" />
-							<div className="flex-1 min-w-0">
-								<div className="flex items-center gap-2">
-									<span className="text-[11px] font-medium truncate">{pr.title}</span>
-									<span className="text-[10px] text-muted-foreground/25 tabular-nums shrink-0">#{pr.number}</span>
-								</div>
-								<div className="flex items-center gap-1 mt-0.5">
-									<span className="text-[10px] font-mono text-muted-foreground/25">{pr.base_branch}</span>
-									<ArrowRight className="h-2.5 w-2.5 text-muted-foreground/20" />
-									<span className="text-[10px] font-mono text-muted-foreground/25">{pr.head_branch}</span>
+			{stack.publishResult && (
+				<div className="space-y-2 rounded-lg border border-border/70 bg-foreground/[0.015] p-2.5">
+					<div className="flex items-center justify-between px-1">
+						<div className="flex items-center gap-2">
+							<GitPullRequestArrow className="h-3.5 w-3.5 text-green-600/70 dark:text-green-400/70" />
+							<span className="text-[11px] font-medium text-foreground/80">Draft Publish Results</span>
+						</div>
+						<span className="text-[10px] text-muted-foreground/35 tabular-nums">{publishedCount}/{pushedCount} created</span>
+					</div>
+
+					{stack.publishResult.prs.length > 0 ? (
+						<div className="space-y-1.5">
+							{stack.publishResult.prs.map((pr) => (
+								<a
+									key={pr.number}
+									href={pr.url}
+									target="_blank"
+									rel="noopener noreferrer"
+									className="group flex items-center gap-3 rounded-lg px-2.5 py-2 hover:bg-accent/30 transition-colors"
+								>
+									<GitPullRequestArrow className="h-3.5 w-3.5 text-green-600/60 dark:text-green-400/60 shrink-0" />
+									<div className="flex-1 min-w-0">
+										<div className="flex items-center gap-2">
+											<span className="text-[11px] font-medium truncate">{pr.title}</span>
+											<span className="text-[10px] text-muted-foreground/25 tabular-nums shrink-0">#{pr.number}</span>
+										</div>
+										<div className="flex items-center gap-1 mt-0.5">
+											<span className="text-[10px] font-mono text-muted-foreground/25">{pr.base_branch}</span>
+											<ArrowRight className="h-2.5 w-2.5 text-muted-foreground/20" />
+											<span className="text-[10px] font-mono text-muted-foreground/25">{pr.head_branch}</span>
+										</div>
+									</div>
+								</a>
+							))}
+						</div>
+					) : (
+						<p className="text-[10px] text-muted-foreground/35 px-2.5 py-2">No draft PR URLs were returned.</p>
+					)}
+
+					{publishFailures.length > 0 && (
+						<div className="rounded-md bg-yellow-500/[0.06] px-2.5 py-2 space-y-1">
+							<p className="text-[10px] text-yellow-700/80 dark:text-yellow-300/80">
+								Some branches were pushed but PR creation did not complete.
+							</p>
+							{publishFailures.map((branch) => (
+								<div key={branch.name} className="text-[10px] font-mono text-yellow-700/70 dark:text-yellow-300/70 truncate">
+									{branch.name}
 								</div>
-							</div>
-						</a>
-					))}
+							))}
+						</div>
+					)}
 				</div>
 			)}
 		</div>

package/src/web/server/routes.ts

@@ -16,7 +16,7 @@ import { chatWithTools, createLlmClient, type ChatTool, type ChatStreamEvent } f
 import { detectAgents, runAgent } from "../../workspace/agent.ts";
 import { randomBytes } from "node:crypto";
 import { publishStack } from "../../stack/publish.ts";
-import { startStack, getStackState, cancelStack, subscribeStack, restoreCompletedStacks } from "./stack-manager.ts";
+import { startStack, getStackState, cancelStack, subscribeStack, restoreCompletedStacks, setStackPublishResult } from "./stack-manager.ts";
 import { getTelemetryConsent, setTelemetryConsent, telemetry } from "../../telemetry/index.ts";
 
 function json(data: unknown, status = 200): Response {
@@ -1921,8 +1921,9 @@ Before posting an inline comment, ALWAYS call \`get_file_diff\` first to find th
 					owner: state.context.owner,
 					repo: state.context.repo,
 				});
+				await setStackPublishResult(body.sessionId, result);
 
-				return json({ publish_result: result });
+				return json({ publish_result: result, state: getStackState(body.sessionId) });
 			} catch (err) {
 				const msg = err instanceof Error ? err.message : String(err);
 				return json({ error: msg }, 500);

package/src/web/server/stack-manager.ts

@@ -1,6 +1,6 @@
 import type { NewprConfig } from "../../types/config.ts";
 import type { FileGroup } from "../../types/output.ts";
-import type { StackWarning, FeasibilityResult, StackExecResult } from "../../stack/types.ts";
+import type { StackWarning, FeasibilityResult, StackExecResult, StackPublishResult } from "../../stack/types.ts";
 import type { StackPlan } from "../../stack/types.ts";
 import { loadSession } from "../../history/store.ts";
 import { saveStackSidecar, loadStackSidecar } from "../../history/store.ts";
@@ -68,6 +68,12 @@ export interface StackVerifyData {
 	structured_warnings: StackWarning[];
 }
 
+export interface StackPublishData {
+	branches: StackPublishResult["branches"];
+	prs: StackPublishResult["prs"];
+	publishedAt: number;
+}
+
 export interface StackStateSnapshot {
 	status: StackStatus;
 	phase: StackPhase | null;
@@ -79,6 +85,7 @@ export interface StackStateSnapshot {
 	plan: StackPlanData | null;
 	execResult: StackExecResult | null;
 	verifyResult: StackVerifyData | null;
+	publishResult: StackPublishData | null;
 	startedAt: number;
 	finishedAt: number | null;
 }
@@ -95,6 +102,7 @@ interface StackSession {
 	plan: StackPlanData | null;
 	execResult: StackExecResult | null;
 	verifyResult: StackVerifyData | null;
+	publishResult: StackPublishData | null;
 	events: StackEvent[];
 	subscribers: Set<(event: StackEvent | { type: "done" | "error"; data?: string }) => void>;
 	startedAt: number;
@@ -131,6 +139,7 @@ function toSnapshot(session: StackSession): StackStateSnapshot {
 		plan: session.plan,
 		execResult: session.execResult,
 		verifyResult: session.verifyResult,
+		publishResult: session.publishResult,
 		startedAt: session.startedAt,
 		finishedAt: session.finishedAt,
 	};
@@ -173,6 +182,7 @@ export function startStack(
 		plan: null,
 		execResult: null,
 		verifyResult: null,
+		publishResult: null,
 		events: [],
 		subscribers: new Set(),
 		startedAt: Date.now(),
@@ -235,12 +245,13 @@ export async function restoreCompletedStacks(sessionIds: string[]): Promise<void
 			context: snapshot.context,
 			partition: snapshot.partition,
 			feasibility: snapshot.feasibility,
-			plan: snapshot.plan,
-			execResult: snapshot.execResult,
-			verifyResult: snapshot.verifyResult,
-			events: [],
-			subscribers: new Set(),
-			startedAt: snapshot.startedAt,
+		plan: snapshot.plan,
+		execResult: snapshot.execResult,
+		verifyResult: snapshot.verifyResult,
+		publishResult: snapshot.publishResult ?? null,
+		events: [],
+		subscribers: new Set(),
+		startedAt: snapshot.startedAt,
 			finishedAt: snapshot.finishedAt ?? Date.now(),
 			abortController: new AbortController(),
 		};
@@ -248,6 +259,22 @@ export async function restoreCompletedStacks(sessionIds: string[]): Promise<void
 	}
 }
 
+export async function setStackPublishResult(
+	analysisSessionId: string,
+	result: StackPublishResult,
+): Promise<void> {
+	const session = sessions.get(analysisSessionId);
+	if (!session) return;
+
+	session.publishResult = {
+		branches: result.branches,
+		prs: result.prs,
+		publishedAt: Date.now(),
+	};
+
+	await saveStackSidecar(session.analysisSessionId, toSnapshot(session)).catch(() => {});
+}
+
 // ---------------------------------------------------------------------------
 // Pipeline
 // ---------------------------------------------------------------------------