newo 1.9.1 → 1.9.2

package/CHANGELOG.md

@@ -5,6 +5,21 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.9.2] - 2025-09-16
+
+### Fixed
+- **Pagination Safety**: Prevent infinite loops and hanging during conversation processing
+  - Added max pages limit (50 pages = 5000 acts per persona) to prevent infinite pagination
+  - Improved persona filtering for voice actors to avoid unnecessary API calls
+  - Better error handling and verbose logging for debugging conversation processing
+  - Graceful handling of personas without voice actors (adds with empty acts array)
+
+### Enhanced
+- **Performance Optimization**: Faster conversation processing with early exits
+  - Skip personas without newo_voice actors immediately
+  - Clear verbose logging for pagination progress
+  - Optimized control flow to prevent hanging during large conversation extraction
+
 ## [1.9.1] - 2025-09-16
 
 ### Fixed

package/dist/sync.js

@@ -1057,68 +1057,97 @@ export async function pullConversations(client, customer, options = {}, verbose
                 let actPage = 1;
                 const actsPerPage = 100; // Higher limit for acts
                 let hasMoreActs = true;
-                while (hasMoreActs) {
-                    // First try the chat history API as alternative
+                // Get user actor IDs from persona actors first
+                const userActors = persona.actors.filter(actor => actor.integration_idn === 'newo_voice' &&
+                    actor.connector_idn === 'newo_voice_connector');
+                if (userActors.length === 0) {
+                    if (verbose)
+                        console.log(`  👤 ${persona.name}: No voice actors found, skipping`);
+                    // No voice actors, can't get chat history - add persona with empty acts
+                    processedPersonas.push({
+                        id: persona.id,
+                        name: persona.name,
+                        phone,
+                        act_count: persona.act_count,
+                        acts: []
+                    });
+                    if (verbose)
+                        console.log(`  ✓ Processed ${persona.name}: 0 acts (no voice actors)`);
+                    return; // Return from the concurrency function
+                }
+                // Safety mechanism to prevent infinite loops
+                const maxPages = 50; // Limit to 50 pages (5000 acts max per persona)
+                while (hasMoreActs && actPage <= maxPages) {
                     try {
-                        // Get user actor IDs from persona actors
-                        const userActors = persona.actors.filter(actor => actor.integration_idn === 'newo_voice' &&
-                            actor.connector_idn === 'newo_voice_connector');
-                        if (userActors.length > 0) {
-                            const chatHistoryParams = {
+                        const chatHistoryParams = {
+                            user_actor_id: userActors[0].id,
+                            page: actPage,
+                            per: actsPerPage
+                        };
+                        if (verbose)
+                            console.log(`    📄 ${persona.name}: Fetching page ${actPage}...`);
+                        const chatResponse = await getChatHistory(client, chatHistoryParams);
+                        if (chatResponse.items && chatResponse.items.length > 0) {
+                            // Convert chat history format to acts format - create minimal ConversationAct objects
+                            const convertedActs = chatResponse.items.map((item) => ({
+                                id: item.id || `chat_${Math.random()}`,
+                                command_act_id: null,
+                                external_event_id: item.external_event_id || 'chat_history',
+                                arguments: [],
+                                reference_idn: (item.is_agent === true) ? 'agent_message' : 'user_message',
+                                runtime_context_id: item.runtime_context_id || 'chat_history',
+                                source_text: item.payload?.text || item.message || item.content || item.text || '',
+                                original_text: item.payload?.text || item.message || item.content || item.text || '',
+                                datetime: item.datetime || item.created_at || item.timestamp || new Date().toISOString(),
                                 user_actor_id: userActors[0].id,
-                                page: actPage,
-                                per: actsPerPage
-                            };
-                            const chatResponse = await getChatHistory(client, chatHistoryParams);
-                            if (chatResponse.items && chatResponse.items.length > 0) {
-                                // Convert chat history format to acts format - create minimal ConversationAct objects
-                                const convertedActs = chatResponse.items.map((item) => ({
-                                    id: item.id || `chat_${Math.random()}`,
-                                    command_act_id: null,
-                                    external_event_id: item.external_event_id || 'chat_history',
-                                    arguments: [],
-                                    reference_idn: (item.is_agent === true) ? 'agent_message' : 'user_message',
-                                    runtime_context_id: item.runtime_context_id || 'chat_history',
-                                    source_text: item.payload?.text || item.message || item.content || item.text || '',
-                                    original_text: item.payload?.text || item.message || item.content || item.text || '',
-                                    datetime: item.datetime || item.created_at || item.timestamp || new Date().toISOString(),
-                                    user_actor_id: userActors[0].id,
-                                    agent_actor_id: null,
-                                    user_persona_id: persona.id,
-                                    user_persona_name: persona.name,
-                                    agent_persona_id: item.agent_persona_id || 'unknown',
-                                    external_id: item.external_id || null,
-                                    integration_idn: 'newo_voice',
-                                    connector_idn: 'newo_voice_connector',
-                                    to_integration_idn: null,
-                                    to_connector_idn: null,
-                                    is_agent: Boolean(item.is_agent === true),
-                                    project_idn: null,
-                                    flow_idn: item.flow_idn || 'unknown',
-                                    skill_idn: item.skill_idn || 'unknown',
-                                    session_id: item.session_id || 'unknown',
-                                    recordings: item.recordings || [],
-                                    contact_information: item.contact_information || null
-                                }));
-                                allActs.push(...convertedActs);
-                                if (verbose && convertedActs.length > 0) {
-                                    console.log(`  👤 ${persona.name}: Chat History - ${convertedActs.length} messages (${allActs.length} total)`);
-                                }
-                                hasMoreActs = chatResponse.items.length === actsPerPage &&
-                                    chatResponse.metadata?.total !== undefined &&
-                                    allActs.length < chatResponse.metadata.total;
-                                actPage++;
-                                continue; // Skip the original acts API call
+                                agent_actor_id: null,
+                                user_persona_id: persona.id,
+                                user_persona_name: persona.name,
+                                agent_persona_id: item.agent_persona_id || 'unknown',
+                                external_id: item.external_id || null,
+                                integration_idn: 'newo_voice',
+                                connector_idn: 'newo_voice_connector',
+                                to_integration_idn: null,
+                                to_connector_idn: null,
+                                is_agent: Boolean(item.is_agent === true),
+                                project_idn: null,
+                                flow_idn: item.flow_idn || 'unknown',
+                                skill_idn: item.skill_idn || 'unknown',
+                                session_id: item.session_id || 'unknown',
+                                recordings: item.recordings || [],
+                                contact_information: item.contact_information || null
+                            }));
+                            allActs.push(...convertedActs);
+                            if (verbose && convertedActs.length > 0) {
+                                console.log(`  👤 ${persona.name}: Chat History - ${convertedActs.length} messages (${allActs.length} total)`);
                             }
+                            // Check if we should continue paginating
+                            const hasMetadata = chatResponse.metadata?.total !== undefined;
+                            const currentTotal = chatResponse.metadata?.total || 0;
+                            hasMoreActs = chatResponse.items.length === actsPerPage &&
+                                hasMetadata &&
+                                allActs.length < currentTotal;
+                            actPage++;
+                            if (verbose)
+                                console.log(`    📊 ${persona.name}: Page ${actPage - 1} done, ${allActs.length}/${currentTotal} total acts`);
+                        }
+                        else {
+                            // No more items
+                            hasMoreActs = false;
+                            if (verbose)
+                                console.log(`    📊 ${persona.name}: No more chat history items`);
                         }
                     }
                     catch (chatError) {
                         if (verbose)
                             console.log(`  ⚠️  Chat history failed for ${persona.name}: ${chatError instanceof Error ? chatError.message : String(chatError)}`);
-                        // No fallback - only use chat history API
                         hasMoreActs = false;
                     }
                 }
+                if (actPage > maxPages) {
+                    if (verbose)
+                        console.log(`  ⚠️  ${persona.name}: Reached max pages limit (${maxPages}), stopping pagination`);
+                }
                 // Sort acts by datetime ascending (chronological order)
                 allActs.sort((a, b) => new Date(a.datetime).getTime() - new Date(b.datetime).getTime());
                 // Process acts into simplified format - exclude redundant fields

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "newo",
-  "version": "1.9.1",
+  "version": "1.9.2",
   "description": "NEWO CLI: comprehensive sync for AI Agent skills, customer attributes, conversations, and metadata between NEWO platform and local files. Multi-customer workspaces, conversation history extraction, complete change tracking, Git-first workflows.",
   "type": "module",
   "bin": {

package/src/sync.ts

@@ -1234,24 +1234,41 @@ export async function pullConversations(
         const actsPerPage = 100; // Higher limit for acts
         let hasMoreActs = true;
 
-        while (hasMoreActs) {
-          // First try the chat history API as alternative
+        // Get user actor IDs from persona actors first
+        const userActors = persona.actors.filter(actor =>
+          actor.integration_idn === 'newo_voice' &&
+          actor.connector_idn === 'newo_voice_connector'
+        );
+
+        if (userActors.length === 0) {
+          if (verbose) console.log(`  👤 ${persona.name}: No voice actors found, skipping`);
+          // No voice actors, can't get chat history - add persona with empty acts
+          processedPersonas.push({
+            id: persona.id,
+            name: persona.name,
+            phone,
+            act_count: persona.act_count,
+            acts: []
+          });
+          if (verbose) console.log(`  ✓ Processed ${persona.name}: 0 acts (no voice actors)`);
+          return; // Return from the concurrency function
+        }
+
+        // Safety mechanism to prevent infinite loops
+        const maxPages = 50; // Limit to 50 pages (5000 acts max per persona)
+
+        while (hasMoreActs && actPage <= maxPages) {
           try {
-            // Get user actor IDs from persona actors
-            const userActors = persona.actors.filter(actor =>
-              actor.integration_idn === 'newo_voice' &&
-              actor.connector_idn === 'newo_voice_connector'
-            );
-
-            if (userActors.length > 0) {
-              const chatHistoryParams = {
-                user_actor_id: userActors[0]!.id,
-                page: actPage,
-                per: actsPerPage
-              };
-
-              const chatResponse = await getChatHistory(client, chatHistoryParams);
-              if (chatResponse.items && chatResponse.items.length > 0) {
+            const chatHistoryParams = {
+              user_actor_id: userActors[0]!.id,
+              page: actPage,
+              per: actsPerPage
+            };
+
+            if (verbose) console.log(`    📄 ${persona.name}: Fetching page ${actPage}...`);
+            const chatResponse = await getChatHistory(client, chatHistoryParams);
+
+            if (chatResponse.items && chatResponse.items.length > 0) {
                 // Convert chat history format to acts format - create minimal ConversationAct objects
                 const convertedActs: ConversationAct[] = chatResponse.items.map((item: any) => ({
                   id: item.id || `chat_${Math.random()}`,
@@ -1288,20 +1305,32 @@ export async function pullConversations(
                   console.log(`  👤 ${persona.name}: Chat History - ${convertedActs.length} messages (${allActs.length} total)`);
                 }
 
+                // Check if we should continue paginating
+                const hasMetadata = chatResponse.metadata?.total !== undefined;
+                const currentTotal = chatResponse.metadata?.total || 0;
+
                 hasMoreActs = chatResponse.items.length === actsPerPage &&
-                             chatResponse.metadata?.total !== undefined &&
-                             allActs.length < chatResponse.metadata.total;
+                             hasMetadata &&
+                             allActs.length < currentTotal;
+
                 actPage++;
-                continue; // Skip the original acts API call
+
+                if (verbose) console.log(`    📊 ${persona.name}: Page ${actPage - 1} done, ${allActs.length}/${currentTotal} total acts`);
+              } else {
+                // No more items
+                hasMoreActs = false;
+                if (verbose) console.log(`    📊 ${persona.name}: No more chat history items`);
               }
-            }
           } catch (chatError) {
             if (verbose) console.log(`  ⚠️  Chat history failed for ${persona.name}: ${chatError instanceof Error ? chatError.message : String(chatError)}`);
-            // No fallback - only use chat history API
             hasMoreActs = false;
           }
         }
 
+        if (actPage > maxPages) {
+          if (verbose) console.log(`  ⚠️  ${persona.name}: Reached max pages limit (${maxPages}), stopping pagination`);
+        }
+
         // Sort acts by datetime ascending (chronological order)
         allActs.sort((a, b) => new Date(a.datetime).getTime() - new Date(b.datetime).getTime());