neurondb 1.0.2 → 1.0.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "neurondb",
-  "version": "1.0.2",
+  "version": "1.0.3",
   "description": "N-Bash — Interactive SNL terminal and remote bash executor for NeuronDB",
   "bin": {
     "neuron": "./bin/cli.js",

package/src/config.js

@@ -28,6 +28,11 @@ export const BLOCKED_COMMANDS = [
   'iptables', 'ip6tables', 'nft', 'firewall-cmd',
   'systemctl', 'service', 'journalctl',
   'fdisk', 'parted', 'mkswap', 'swapon', 'swapoff',
+  // Interactive commands that hang (no stdout, wait for input)
+  'top', 'htop', 'btop', 'vi', 'vim', 'nvim', 'nano', 'pico', 'emacs',
+  'less', 'more', 'man', 'watch', 'tail -f', 'ssh', 'telnet', 'ftp',
+  'python', 'python3', 'node', 'irb', 'ruby', 'lua',  // REPLs without args
+  'mysql', 'psql', 'mongo', 'redis-cli',  // DB shells without args
 ];
 
 /** Blocked path prefixes — prevent access outside sandbox */

package/src/executor.js

@@ -10,6 +10,7 @@ import { validateCommand } from './sandbox.js';
  * Execute a bash command in the sandbox.
  * @param {string} command - The command to execute
  * @param {string} homeDir - The sandbox home directory (cwd)
+ * @param {number} [timeoutMs] - Timeout in milliseconds
  * @returns {Promise<{stdout: string, stderr: string, exit_code: number, duration_ms: number}>}
  */
 export function executeCommand(command, homeDir, timeoutMs) {
@@ -27,21 +28,22 @@ export function executeCommand(command, homeDir, timeoutMs) {
     }
 
     const startTime = Date.now();
+    const timeout = timeoutMs || EXEC_TIMEOUT_MS;
 
     const env = {
       HOME: homeDir,
       PATH: process.env.PATH || '/opt/homebrew/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin',
-      TERM: process.env.TERM || 'xterm-256color',
+      TERM: 'dumb', // Force non-interactive mode (prevents curses, color escapes)
       LANG: process.env.LANG || 'en_US.UTF-8',
       NODE_ENV: process.env.NODE_ENV || 'production',
     };
 
-    execFile('/bin/bash', ['-c', command], {
+    const child = execFile('/bin/bash', ['-c', command], {
       cwd: homeDir,
-      timeout: timeoutMs || EXEC_TIMEOUT_MS,
+      timeout,
       maxBuffer: EXEC_MAX_BUFFER,
       env,
-      killSignal: 'SIGTERM',
+      killSignal: 'SIGKILL', // Use SIGKILL — SIGTERM doesn't stop interactive commands
     }, (error, stdout, stderr) => {
       const duration_ms = Date.now() - startTime;
       let exit_code = 0;
@@ -49,7 +51,7 @@ export function executeCommand(command, homeDir, timeoutMs) {
       if (error) {
         exit_code = error.code != null ? error.code : (error.signal ? 128 : 1);
         if (error.killed) {
-          stderr = (stderr || '') + '\nProcess killed (timeout or memory limit)';
+          stderr = (stderr || '') + '\nProcess killed (timeout reached)';
           exit_code = 137;
         }
       }
@@ -61,5 +63,12 @@ export function executeCommand(command, homeDir, timeoutMs) {
         duration_ms,
       });
     });
+
+    // Safety net: force kill if still alive after timeout + 5s grace
+    const safetyTimer = setTimeout(() => {
+      try { child.kill('SIGKILL'); } catch {}
+    }, timeout + 5000);
+
+    child.on('exit', () => clearTimeout(safetyTimer));
   });
 }