netlify-cli 8.16.0 → 8.17.2

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "netlify-cli",
   "description": "Netlify command line tool",
-  "version": "8.16.0",
+  "version": "8.17.2",
   "author": "Netlify Inc.",
   "contributors": [
     "Mathias Biilmann <matt@netlify.com> (https://twitter.com/biilmann)",
@@ -63,7 +63,7 @@
     "test:dev:ava": "ava --verbose",
     "test:ci:ava:unit": "c8 -r json ava --no-worker-threads tests/unit/**/*.test.js tools/**/*.test.js",
     "test:ci:ava:integration": "c8 -r json ava --concurrency 1 --no-worker-threads tests/integration/**/*.test.js",
-    "test:affected": "node ./tools/affected-test.js",
+    "test:affected": "node ./tools/affected-test.mjs",
     "e2e": "node ./tools/e2e/run.mjs",
     "docs": "node ./site/scripts/docs.mjs",
     "watch": "c8 --reporter=lcov ava --watch",
@@ -73,7 +73,7 @@
     "postinstall": "node ./scripts/postinstall.js"
   },
   "config": {
-    "eslint": "--ignore-path .gitignore --cache --format=codeframe --max-warnings=0 \"{src,tools,scripts,site,tests,.github}/**/*.{mjs,cjs,js,md,html}\" \"*.{mjs,cjs,js,md,html}\" \".*.{mjs,cjs,js,md,html}\"",
+    "eslint": "--ignore-path .gitignore --cache --format=codeframe --max-warnings=0 \"{src,scripts,site,tests,.github}/**/*.{mjs,cjs,js,md,html}\" \"*.{mjs,cjs,js,md,html}\" \".*.{mjs,cjs,js,md,html}\"",
     "prettier": "--ignore-path .gitignore --loglevel=warn \"{src,tools,scripts,site,tests,.github}/**/*.{mjs,cjs,js,md,yml,json,html}\" \"*.{mjs,cjs,js,yml,json,html}\" \".*.{mjs,cjs,js,yml,json,html}\" \"!CHANGELOG.md\" \"!npm-shrinkwrap.json\" \"!.github/**/*.md\""
   },
   "dependencies": {
@@ -98,7 +98,7 @@
     "chokidar": "^3.0.2",
     "ci-info": "^3.0.0",
     "clean-deep": "^3.0.2",
-    "commander": "^8.3.0",
+    "commander": "^9.0.0",
     "concordance": "^5.0.0",
     "configstore": "^5.0.0",
     "content-type": "^1.0.4",
@@ -184,11 +184,11 @@
     "uuid": "^8.0.0",
     "wait-port": "^0.2.2",
     "winston": "^3.2.1",
-    "write-file-atomic": "^3.0.0"
+    "write-file-atomic": "^4.0.0"
   },
   "devDependencies": {
     "@babel/preset-react": "^7.12.13",
-    "@netlify/eslint-config-node": "^4.1.7",
+    "@netlify/eslint-config-node": "^5.1.2",
     "ava": "^4.0.0",
     "c8": "^7.11.0",
     "eslint-plugin-sort-destructure-keys": "^1.3.5",
@@ -200,7 +200,7 @@
     "ini": "^2.0.0",
     "mock-fs": "^5.1.2",
     "p-timeout": "^4.0.0",
-    "proxyquire": "^2.1.3",
+    "rewiremock": "^3.14.3",
     "seedrandom": "^3.0.5",
     "serialize-javascript": "^6.0.0",
     "sinon": "^13.0.0",
@@ -215,7 +215,7 @@
   },
   "ava": {
     "files": [
-      "tools/**/*.test.js",
+      "tools/**/*.test.mjs",
       "tests/**/*.test.js"
     ],
     "cache": true,

package/src/commands/dev/dev.js

@@ -11,8 +11,18 @@ const stripAnsiCc = require('strip-ansi-control-characters')
 const waitPort = require('wait-port')
 
 const { startFunctionsServer } = require('../../lib/functions/server')
-const { OneGraphCliClient, startOneGraphCLISession } = require('../../lib/one-graph/cli-client')
-const { getNetlifyGraphConfig } = require('../../lib/one-graph/cli-netlify-graph')
+const {
+  OneGraphCliClient,
+  loadCLISession,
+  persistNewOperationsDocForSession,
+  startOneGraphCLISession,
+} = require('../../lib/one-graph/cli-client')
+const {
+  defaultExampleOperationsDoc,
+  getGraphEditUrlBySiteId,
+  getNetlifyGraphConfig,
+  readGraphQLOperationsSourceFile,
+} = require('../../lib/one-graph/cli-netlify-graph')
 const {
   NETLIFYDEV,
   NETLIFYDEVERR,
@@ -349,9 +359,29 @@ const dev = async (options, command) => {
     await OneGraphCliClient.ensureAppForSite(netlifyToken, site.id)
     const netlifyGraphConfig = await getNetlifyGraphConfig({ command, options, settings })
 
-    log(`Starting Netlify Graph session, to edit your library run \`netlify graph:edit\` in another tab`)
+    let graphqlDocument = readGraphQLOperationsSourceFile(netlifyGraphConfig)
+
+    if (!graphqlDocument || graphqlDocument.trim().length === 0) {
+      graphqlDocument = defaultExampleOperationsDoc
+    }
+
+    await startOneGraphCLISession({ netlifyGraphConfig, netlifyToken, site, state })
+
+    // Should be created by startOneGraphCLISession
+    const oneGraphSessionId = loadCLISession(state)
 
-    startOneGraphCLISession({ netlifyGraphConfig, netlifyToken, site, state })
+    await persistNewOperationsDocForSession({
+      netlifyToken,
+      oneGraphSessionId,
+      operationsDoc: graphqlDocument,
+      siteId: site.id,
+    })
+
+    const graphEditUrl = getGraphEditUrlBySiteId({ siteId: site.id, oneGraphSessionId })
+
+    log(
+      `Starting Netlify Graph session, to edit your library visit ${graphEditUrl} or run \`netlify graph:edit\` in another tab`,
+    )
   }
 
   printBanner({ url })

package/src/commands/graph/graph-edit.js

@@ -3,7 +3,7 @@ const gitRepoInfo = require('git-repo-info')
 const { OneGraphCliClient, generateSessionName, loadCLISession } = require('../../lib/one-graph/cli-client')
 const {
   defaultExampleOperationsDoc,
-  getGraphEditUrlBySiteName,
+  getGraphEditUrlBySiteId,
   getNetlifyGraphConfig,
   readGraphQLOperationsSourceFile,
 } = require('../../lib/one-graph/cli-netlify-graph')
@@ -19,7 +19,7 @@ const { createCLISession, createPersistedQuery, ensureAppForSite, updateCLISessi
  * @returns
  */
 const graphEdit = async (options, command) => {
-  const { api, site, siteInfo, state } = command.netlify
+  const { site, state } = command.netlify
   const siteId = site.id
 
   if (!site.id) {
@@ -60,17 +60,7 @@ const graphEdit = async (options, command) => {
 
   await updateCLISessionMetadata(netlifyToken, siteId, oneGraphSessionId, { docId: persistedDoc.id })
 
-  let siteName = siteInfo.name
-
-  if (!siteName) {
-    const siteData = await api.getSite({ siteId })
-    siteName = siteData.name
-    if (!siteName) {
-      error(`No site name found for siteId ${siteId}`)
-    }
-  }
-
-  const graphEditUrl = getGraphEditUrlBySiteName({ siteName, oneGraphSessionId })
+  const graphEditUrl = getGraphEditUrlBySiteId({ siteId, oneGraphSessionId })
 
   await openBrowser({ url: graphEditUrl })
 }

package/src/functions-templates/javascript/stripe-charge/package-lock.json

@@ -9,7 +9,7 @@
       "version": "1.0.0",
       "license": "MIT",
       "dependencies": {
-        "stripe": "^8.201.0"
+        "stripe": "^8.202.0"
       }
     },
     "node_modules/@types/node": {
@@ -105,9 +105,9 @@
       }
     },
     "node_modules/stripe": {
-      "version": "8.201.0",
-      "resolved": "https://registry.npmjs.org/stripe/-/stripe-8.201.0.tgz",
-      "integrity": "sha512-pF0F1DdE9zt0U6Cb0XN+REpdFkUmaqp6C7OEVOCeUpTAafjjJqrdV/WmZd7Y5MwT8XvDAxB5/v3CAXwxAp0XNg==",
+      "version": "8.202.0",
+      "resolved": "https://registry.npmjs.org/stripe/-/stripe-8.202.0.tgz",
+      "integrity": "sha512-3YGHVnUatEn/At5+aRy+REdB2IyVa96/zls2xvQrKFTgaJzRu1MsJcK0GKg0p2B0y0VqlZo9gmdDEqphSHHvtA==",
       "dependencies": {
         "@types/node": ">=8.1.0",
         "qs": "^6.6.0"
@@ -184,9 +184,9 @@
       }
     },
     "stripe": {
-      "version": "8.201.0",
-      "resolved": "https://registry.npmjs.org/stripe/-/stripe-8.201.0.tgz",
-      "integrity": "sha512-pF0F1DdE9zt0U6Cb0XN+REpdFkUmaqp6C7OEVOCeUpTAafjjJqrdV/WmZd7Y5MwT8XvDAxB5/v3CAXwxAp0XNg==",
+      "version": "8.202.0",
+      "resolved": "https://registry.npmjs.org/stripe/-/stripe-8.202.0.tgz",
+      "integrity": "sha512-3YGHVnUatEn/At5+aRy+REdB2IyVa96/zls2xvQrKFTgaJzRu1MsJcK0GKg0p2B0y0VqlZo9gmdDEqphSHHvtA==",
       "requires": {
         "@types/node": ">=8.1.0",
         "qs": "^6.6.0"

package/src/functions-templates/javascript/stripe-subscription/package-lock.json

@@ -9,7 +9,7 @@
       "version": "1.0.0",
       "license": "MIT",
       "dependencies": {
-        "stripe": "^8.201.0"
+        "stripe": "^8.202.0"
       }
     },
     "node_modules/@types/node": {
@@ -105,9 +105,9 @@
       }
     },
     "node_modules/stripe": {
-      "version": "8.201.0",
-      "resolved": "https://registry.npmjs.org/stripe/-/stripe-8.201.0.tgz",
-      "integrity": "sha512-pF0F1DdE9zt0U6Cb0XN+REpdFkUmaqp6C7OEVOCeUpTAafjjJqrdV/WmZd7Y5MwT8XvDAxB5/v3CAXwxAp0XNg==",
+      "version": "8.202.0",
+      "resolved": "https://registry.npmjs.org/stripe/-/stripe-8.202.0.tgz",
+      "integrity": "sha512-3YGHVnUatEn/At5+aRy+REdB2IyVa96/zls2xvQrKFTgaJzRu1MsJcK0GKg0p2B0y0VqlZo9gmdDEqphSHHvtA==",
       "dependencies": {
         "@types/node": ">=8.1.0",
         "qs": "^6.6.0"
@@ -184,9 +184,9 @@
       }
     },
     "stripe": {
-      "version": "8.201.0",
-      "resolved": "https://registry.npmjs.org/stripe/-/stripe-8.201.0.tgz",
-      "integrity": "sha512-pF0F1DdE9zt0U6Cb0XN+REpdFkUmaqp6C7OEVOCeUpTAafjjJqrdV/WmZd7Y5MwT8XvDAxB5/v3CAXwxAp0XNg==",
+      "version": "8.202.0",
+      "resolved": "https://registry.npmjs.org/stripe/-/stripe-8.202.0.tgz",
+      "integrity": "sha512-3YGHVnUatEn/At5+aRy+REdB2IyVa96/zls2xvQrKFTgaJzRu1MsJcK0GKg0p2B0y0VqlZo9gmdDEqphSHHvtA==",
       "requires": {
         "@types/node": ">=8.1.0",
         "qs": "^6.6.0"

package/src/functions-templates/typescript/hello-world/package-lock.json

@@ -10,8 +10,8 @@
       "license": "MIT",
       "dependencies": {
         "@netlify/functions": "^0.11.0",
-        "@types/node": "^14.0.0",
-        "typescript": "^4.5.5"
+        "@types/node": "^14.18.10",
+        "typescript": "^4.0.0"
       }
     },
     "node_modules/@netlify/functions": {
@@ -26,9 +26,9 @@
       }
     },
     "node_modules/@types/node": {
-      "version": "14.18.9",
-      "resolved": "https://registry.npmjs.org/@types/node/-/node-14.18.9.tgz",
-      "integrity": "sha512-j11XSuRuAlft6vLDEX4RvhqC0KxNxx6QIyMXNb0vHHSNPXTPeiy3algESWmOOIzEtiEL0qiowPU3ewW9hHVa7Q=="
+      "version": "14.18.10",
+      "resolved": "https://registry.npmjs.org/@types/node/-/node-14.18.10.tgz",
+      "integrity": "sha512-6iihJ/Pp5fsFJ/aEDGyvT4pHGmCpq7ToQ/yf4bl5SbVAvwpspYJ+v3jO7n8UyjhQVHTy+KNszOozDdv+O6sovQ=="
     },
     "node_modules/is-promise": {
       "version": "4.0.0",
@@ -58,9 +58,9 @@
       }
     },
     "@types/node": {
-      "version": "14.18.9",
-      "resolved": "https://registry.npmjs.org/@types/node/-/node-14.18.9.tgz",
-      "integrity": "sha512-j11XSuRuAlft6vLDEX4RvhqC0KxNxx6QIyMXNb0vHHSNPXTPeiy3algESWmOOIzEtiEL0qiowPU3ewW9hHVa7Q=="
+      "version": "14.18.10",
+      "resolved": "https://registry.npmjs.org/@types/node/-/node-14.18.10.tgz",
+      "integrity": "sha512-6iihJ/Pp5fsFJ/aEDGyvT4pHGmCpq7ToQ/yf4bl5SbVAvwpspYJ+v3jO7n8UyjhQVHTy+KNszOozDdv+O6sovQ=="
     },
     "is-promise": {
       "version": "4.0.0",

package/src/lib/exec-fetcher.js

@@ -8,7 +8,7 @@ const terminalLink = require('terminal-link')
 
 // cannot directly import from ../utils as it would create a circular dependency.
 // the file `src/utils/live-tunnel.js` depends on this file
-const { NETLIFYDEVWARN, chalk, error, log } = require('../utils/command-helpers')
+const { NETLIFYDEVWARN, error, log } = require('../utils/command-helpers')
 const execa = require('../utils/execa')
 
 const isWindows = () => process.platform === 'win32'
@@ -127,9 +127,7 @@ const fetchLatestVersion = async ({ destination, execName, extension, latestVers
 
       const issueLink = terminalLink('Create a new CLI issue', createIssueLink.href)
 
-      error(`The operating system ${chalk.cyan(platform)} with the CPU architecture ${chalk.cyan(
-        arch,
-      )} is currently not supported!
+      error(`The operating system ${platform} with the CPU architecture ${arch} is currently not supported!
 
 Please open up an issue on our CLI repository so that we can support it:
 ${issueLink}`)

package/src/lib/one-graph/cli-client.js

@@ -1,13 +1,15 @@
 /* eslint-disable eslint-comments/disable-enable-pair */
 /* eslint-disable fp/no-loops */
+const crypto = require('crypto')
 const os = require('os')
+const path = require('path')
 
+const gitRepoInfo = require('git-repo-info')
 const { GraphQL, InternalConsole, OneGraphClient } = require('netlify-onegraph-internal')
 const { NetlifyGraph } = require('netlify-onegraph-internal')
 
 const { chalk, error, log, warn } = require('../../utils')
-
-const { createCLISession, createPersistedQuery, ensureAppForSite, updateCLISessionMetadata } = OneGraphClient
+const { watchDebounced } = require('../functions/watcher')
 
 const {
   generateFunctionsFile,
@@ -19,6 +21,7 @@ const {
 
 const { parse } = GraphQL
 const { defaultExampleOperationsDoc, extractFunctionsFromOperationDoc } = NetlifyGraph
+const { createCLISession, createPersistedQuery, ensureAppForSite, updateCLISessionMetadata } = OneGraphClient
 
 const internalConsole = {
   log,
@@ -27,6 +30,9 @@ const internalConsole = {
   debug: console.debug,
 }
 
+const witnessedIncomingDocumentHashes = []
+
+// Keep track of which document hashes we've received from the server so we can ignore events from the filesystem based on them
 InternalConsole.registerConsole(internalConsole)
 
 /**
@@ -108,6 +114,26 @@ const monitorCLISessionEvents = (input) => {
   return close
 }
 
+/**
+ * Monitor the operations document for changes
+ * @param {object} input
+ * @param {NetlifyGraphConfig} input.netlifyGraphConfig A standalone config object that contains all the information necessary for Netlify Graph to process events
+ * @param {function} input.onAdd A callback function to handle when the operations document is added
+ * @param {function} input.onChange A callback function to handle when the operations document is changed
+ * @param {function} input.onUnlink A callback function to handle when the operations document is unlinked
+ * @returns {Promise<watcher>}
+ */
+const monitorOperationFile = async ({ netlifyGraphConfig, onAdd, onChange, onUnlink }) => {
+  const filePath = path.resolve(...netlifyGraphConfig.graphQLOperationsSourceFilename)
+  const newWatcher = await watchDebounced([filePath], {
+    onAdd,
+    onChange,
+    onUnlink,
+  })
+
+  return newWatcher
+}
+
 /**
  * Fetch the schema for a site, and regenerate all of the downstream files
  * @param {object} input
@@ -146,7 +172,44 @@ const refetchAndGenerateFromOneGraph = async (input) => {
 }
 
 /**
- *
+ * Regenerate the function library based on the current operations document on disk
+ * @param {object} input
+ * @param {string} input.schema The GraphQL schema to use when generating code
+ * @param {NetlifyGraphConfig} input.netlifyGraphConfig A standalone config object that contains all the information necessary for Netlify Graph to process events
+ * @returns
+ */
+const regenerateFunctionsFileFromOperationsFile = (input) => {
+  const { netlifyGraphConfig, schema } = input
+
+  const appOperationsDoc = readGraphQLOperationsSourceFile(netlifyGraphConfig)
+
+  const hash = quickHash(appOperationsDoc)
+
+  if (witnessedIncomingDocumentHashes.includes(hash)) {
+    // We've already seen this document, so don't regenerate
+    return
+  }
+
+  const parsedDoc = parse(appOperationsDoc, {
+    noLocation: true,
+  })
+  const { fragments, functions } = extractFunctionsFromOperationDoc(parsedDoc)
+  generateFunctionsFile({ netlifyGraphConfig, schema, operationsDoc: appOperationsDoc, functions, fragments })
+}
+
+/**
+ * Compute a md5 hash of a string
+ * @param {string} input String to compute a quick md5 hash for
+ * @returns hex digest of the input string
+ */
+const quickHash = (input) => {
+  const hashSum = crypto.createHash('md5')
+  hashSum.update(input)
+  return hashSum.digest('hex')
+}
+
+/**
+ * Fetch a persisted operations doc by its id, write it to the system, and regenerate the library
  * @param {object} input
  * @param {string} input.siteId The site id to query against
  * @param {string} input.netlifyToken The (typically netlify) access token that is used for authentication, if any
@@ -155,7 +218,7 @@ const refetchAndGenerateFromOneGraph = async (input) => {
  * @param {NetlifyGraphConfig} input.netlifyGraphConfig A standalone config object that contains all the information necessary for Netlify Graph to process events
  * @returns
  */
-const updateGraphQLOperationsFile = async (input) => {
+const updateGraphQLOperationsFileFromPersistedDoc = async (input) => {
   const { docId, netlifyGraphConfig, netlifyToken, schema, siteId } = input
   const persistedDoc = await OneGraphClient.fetchPersistedQuery(netlifyToken, siteId, docId)
   if (!persistedDoc) {
@@ -166,12 +229,17 @@ const updateGraphQLOperationsFile = async (input) => {
   const doc = persistedDoc.query
 
   writeGraphQLOperationsSourceFile(netlifyGraphConfig, doc)
-  const appOperationsDoc = readGraphQLOperationsSourceFile(netlifyGraphConfig)
-  const parsedDoc = parse(appOperationsDoc, {
-    noLocation: true,
-  })
-  const { fragments, functions } = extractFunctionsFromOperationDoc(parsedDoc)
-  generateFunctionsFile({ netlifyGraphConfig, schema, operationsDoc: appOperationsDoc, functions, fragments })
+  regenerateFunctionsFileFromOperationsFile({ netlifyGraphConfig, schema })
+
+  const hash = quickHash(doc)
+
+  const relevantHasLength = 10
+
+  if (witnessedIncomingDocumentHashes.length > relevantHasLength) {
+    witnessedIncomingDocumentHashes.shift()
+  }
+
+  witnessedIncomingDocumentHashes.push(hash)
 }
 
 const handleCliSessionEvent = async ({ event, netlifyGraphConfig, netlifyToken, schema, siteId }) => {
@@ -184,7 +252,13 @@ const handleCliSessionEvent = async ({ event, netlifyGraphConfig, netlifyToken,
       await generateHandler(netlifyGraphConfig, schema, payload.operationId, payload)
       break
     case 'OneGraphNetlifyCliSessionPersistedLibraryUpdatedEvent':
-      await updateGraphQLOperationsFile({ netlifyToken, docId: payload.docId, netlifyGraphConfig, schema, siteId })
+      await updateGraphQLOperationsFileFromPersistedDoc({
+        netlifyToken,
+        docId: payload.docId,
+        netlifyGraphConfig,
+        schema,
+        siteId,
+      })
       break
     default: {
       warn(`Unrecognized event received, you may need to upgrade your CLI version`, __typename, payload)
@@ -193,6 +267,24 @@ const handleCliSessionEvent = async ({ event, netlifyGraphConfig, netlifyToken,
   }
 }
 
+const persistNewOperationsDocForSession = async ({ netlifyToken, oneGraphSessionId, operationsDoc, siteId }) => {
+  const { branch } = gitRepoInfo()
+
+  const payload = {
+    appId: siteId,
+    description: 'Temporary snapshot of local queries',
+    document: operationsDoc,
+    tags: ['netlify-cli', `session:${oneGraphSessionId}`, `git-branch:${branch}`, `local-change`],
+  }
+  const persistedDoc = await createPersistedQuery(netlifyToken, payload)
+  const newMetadata = await { docId: persistedDoc.id }
+  const result = await OneGraphClient.updateCLISessionMetadata(netlifyToken, siteId, oneGraphSessionId, newMetadata)
+
+  if (result.errors) {
+    warn('Unable to update session metadata with updated operations doc', result.errors)
+  }
+}
+
 /**
  * Load the CLI session id from the local state
  * @param {state} state
@@ -201,7 +293,7 @@ const handleCliSessionEvent = async ({ event, netlifyGraphConfig, netlifyToken,
 const loadCLISession = (state) => state.get('oneGraphSessionId')
 
 /**
- * Idemponentially save the CLI session id to the local state and start monitoring for CLI events and upstream schema changes
+ * Idemponentially save the CLI session id to the local state and start monitoring for CLI events, upstream schema changes, and local operation file changes
  * @param {object} input
  * @param {string} input.netlifyToken The (typically netlify) access token that is used for authentication, if any
  * @param {NetlifyGraphConfig} input.netlifyGraphConfig A standalone config object that contains all the information necessary for Netlify Graph to process events
@@ -223,6 +315,32 @@ const startOneGraphCLISession = async (input) => {
   const enabledServices = []
   const schema = await OneGraphClient.fetchOneGraphSchema(site.id, enabledServices)
 
+  monitorOperationFile({
+    netlifyGraphConfig,
+    onChange: async (filePath) => {
+      log('NetlifyGraph operation file changed at', filePath, 'updating function library...')
+      regenerateFunctionsFileFromOperationsFile({ netlifyGraphConfig, schema })
+      const newOperationsDoc = readGraphQLOperationsSourceFile(netlifyGraphConfig)
+      await persistNewOperationsDocForSession({
+        netlifyToken,
+        oneGraphSessionId,
+        operationsDoc: newOperationsDoc,
+        siteId: site.id,
+      })
+    },
+    onAdd: async (filePath) => {
+      log('NetlifyGraph operation file created at', filePath, 'creating function library...')
+      regenerateFunctionsFileFromOperationsFile({ netlifyGraphConfig, schema })
+      const newOperationsDoc = readGraphQLOperationsSourceFile(netlifyGraphConfig)
+      await persistNewOperationsDocForSession({
+        netlifyToken,
+        oneGraphSessionId,
+        operationsDoc: newOperationsDoc,
+        siteId: site.id,
+      })
+    },
+  })
+
   monitorCLISessionEvents({
     appId: site.id,
     netlifyToken,
@@ -273,6 +391,7 @@ module.exports = {
   generateSessionName,
   loadCLISession,
   monitorCLISessionEvents,
+  persistNewOperationsDocForSession,
   refetchAndGenerateFromOneGraph,
   startOneGraphCLISession,
 }

package/src/lib/one-graph/cli-netlify-graph.js

@@ -4,7 +4,7 @@ const process = require('process')
 
 const { GraphQL, InternalConsole, NetlifyGraph } = require('netlify-onegraph-internal')
 
-const { detectServerSettings, error, getFunctionsDir, log, warn } = require('../../utils')
+const { detectServerSettings, error, execa, getFunctionsDir, log, warn } = require('../../utils')
 
 const { printSchema } = GraphQL
 
@@ -241,6 +241,31 @@ const ensureFunctionsPath = (netlifyGraphConfig) => {
   fs.mkdirSync(fullPath, { recursive: true })
 }
 
+let disablePrettierDueToPreviousError = false
+
+const runPrettier = async (filePath) => {
+  if (disablePrettierDueToPreviousError) {
+    return
+  }
+
+  const command = `prettier --write ${filePath}`
+  try {
+    const commandProcess = execa.command(command, {
+      preferLocal: true,
+      // windowsHide needs to be false for child process to terminate properly on Windows
+      windowsHide: false,
+    })
+
+    await commandProcess
+  } catch (prettierError) {
+    if (!disablePrettierDueToPreviousError) {
+      disablePrettierDueToPreviousError = true
+      warn(prettierError)
+      warn("Error while running prettier, make sure you have installed it globally with 'npm i -g prettier'")
+    }
+  }
+}
+
 /**
  * Generate a library file with type definitions for a given NetlifyGraphConfig, operationsDoc, and schema, writing them to the filesystem
  * @param {object} context
@@ -267,6 +292,8 @@ const generateFunctionsFile = ({ fragments, functions, netlifyGraphConfig, opera
     typeDefinitionsSource,
     'utf8',
   )
+  runPrettier(path.resolve(...netlifyGraphConfig.netlifyGraphImplementationFilename))
+  runPrettier(path.resolve(...netlifyGraphConfig.netlifyGraphTypeDefinitionsFilename))
 }
 
 /**
@@ -384,6 +411,7 @@ const generateHandler = (netlifyGraphConfig, schema, operationId, handlerOptions
     const absoluteFilename = path.resolve(...filenameArr)
 
     fs.writeFileSync(absoluteFilename, content)
+    runPrettier(absoluteFilename)
   })
 }
 
@@ -405,6 +433,21 @@ const getGraphEditUrlBySiteName = ({ oneGraphSessionId, siteName }) => {
   return url
 }
 
+/**
+ * Get a url to the Netlify Graph UI for the current session by a site's id
+ * @param {object} options
+ * @param {string} options.siteId The name of the site as used in the Netlify UI url scheme
+ * @param {string} options.oneGraphSessionId The oneGraph session id to use when generating the graph-edit link
+ * @returns {string} The url to the Netlify Graph UI for the current session
+ */
+const getGraphEditUrlBySiteId = ({ oneGraphSessionId, siteId }) => {
+  const host = process.env.NETLIFY_APP_HOST || 'app.netlify.com'
+  // http because app.netlify.com will redirect to https, and localhost will still work for development
+  const url = `http://${host}/site-redirect/${siteId}/graph/explorer?cliSessionId=${oneGraphSessionId}`
+
+  return url
+}
+
 module.exports = {
   buildSchema,
   defaultExampleOperationsDoc: NetlifyGraph.defaultExampleOperationsDoc,
@@ -413,6 +456,7 @@ module.exports = {
   generateFunctionsFile,
   generateHandlerSource: NetlifyGraph.generateHandlerSource,
   generateHandler,
+  getGraphEditUrlBySiteId,
   getGraphEditUrlBySiteName,
   getNetlifyGraphConfig,
   parse,

package/src/utils/proxy.js

@@ -213,6 +213,10 @@ const serveRedirect = async function ({ match, options, proxy, req, res }) {
 
     const destURL = stripOrigin(dest)
 
+    if (isExternal(match)) {
+      return proxyToExternalUrl({ req, res, dest, destURL })
+    }
+
     if (isRedirect(match)) {
       res.writeHead(match.status, {
         Location: destURL,
@@ -222,10 +226,6 @@ const serveRedirect = async function ({ match, options, proxy, req, res }) {
       return
     }
 
-    if (isExternal(match)) {
-      return proxyToExternalUrl({ req, res, dest, destURL })
-    }
-
     const ct = req.headers['content-type'] ? contentType.parse(req).type : ''
     if (
       req.method === 'POST' &&