netlify-cli 17.5.0 → 17.5.2

package/src/lib/exec-fetcher.mjs

@@ -108,10 +108,10 @@ export const fetchLatestVersion = async ({ destination, execName, extension, lat
     };
     const options = getOptions();
     const fetch = latestVersion
-        // @ts-expect-error TS(2345) FIXME: Argument of type '{ headers: { Authorization: stri... Remove this comment to see the full error message
-        ? fetchVersion({ ...release, version: latestVersion }, options)
-        // @ts-expect-error TS(2345) FIXME: Argument of type '{ repository: string; package: s... Remove this comment to see the full error message
-        : fetchLatest(release, options);
+        ? // @ts-expect-error TS(2345) FIXME: Argument of type '{ headers: { Authorization: stri... Remove this comment to see the full error message
+            fetchVersion({ ...release, version: latestVersion }, options)
+        : // @ts-expect-error TS(2345) FIXME: Argument of type '{ repository: string; package: s... Remove this comment to see the full error message
+            fetchLatest(release, options);
     try {
         await fetch;
     }

package/src/lib/functions/form-submissions-handler.mjs

@@ -57,6 +57,7 @@ export const createFormSubmissionHandler = function ({ functionsRegistry, siteUr
         }
         else if (ct.type === 'multipart/form-data') {
             try {
+                ;
                 [fields, files] = await new Promise((resolve, reject) => {
                     const form = new multiparty.Form({ encoding: ct.parameters.charset || 'utf8' });
                     // @ts-expect-error TS(7006) FIXME: Parameter 'err' implicitly has an 'any' type.

package/src/lib/functions/registry.mjs

@@ -215,7 +215,6 @@ export class FunctionsRegistry {
         // we create a new watcher and watch them.
         if (srcFilesDiff.added.size !== 0) {
             const filesToWatch = [...srcFilesDiff.added, ...includedFiles];
-            // @ts-expect-error TS(2345) FIXME: Argument of type '{ onChange: () => void; }' is no... Remove this comment to see the full error message
             const newWatcher = await watchDebounced(filesToWatch, {
                 onChange: () => {
                     this.buildFunctionAndWatchFiles(func, false);

package/src/utils/build-info.mjs

@@ -86,7 +86,7 @@ command = "${chosenSettings.devCommand}"
 export const detectBuildSettings = async (command) => {
     const { project, workspacePackage } = command;
     const buildSettings = await project.getBuildSettings(project.workspace ? workspacePackage : '');
-    return buildSettings
+    return (buildSettings
         // @ts-expect-error TS(7006) FIXME: Parameter 'setting' implicitly has an 'any' type.
         .filter((setting) => {
         if (project.workspace && project.relativeBaseDirectory && setting.packagePath) {
@@ -95,5 +95,5 @@ export const detectBuildSettings = async (command) => {
         return true;
     })
         // @ts-expect-error TS(7006) FIXME: Parameter 'setting' implicitly has an 'any' type.
-        .filter((setting) => setting.devCommand);
+        .filter((setting) => setting.devCommand));
 };

package/src/utils/command-helpers.mjs

@@ -209,41 +209,23 @@ export const normalizeConfig = (config) => {
 const DEBOUNCE_WAIT = 100;
 /**
  * Adds a file watcher to a path or set of paths and debounces the events.
- *
- * @param {string | string[]} target
- * @param {Object} opts
- * @param {number} [opts.depth]
- * @param {Array<string|RegExp>} [opts.ignored]
- * @param {(paths: string[]) => any} [opts.onAdd]
- * @param {(paths: string[]) => any} [opts.onChange]
- * @param {(paths: string[]) => any} [opts.onUnlink]
  */
-export const watchDebounced = async (
-// @ts-expect-error TS(7006) FIXME: Parameter 'target' implicitly has an 'any' type.
-target, 
-// @ts-expect-error TS(7031) FIXME: Binding element 'depth' implicitly has an 'any' ty... Remove this comment to see the full error message
-{ depth, ignored = [], onAdd = () => { }, onChange = () => { }, onUnlink = () => { } }) => {
+export const watchDebounced = async (target, { depth, ignored = [], onAdd = noOp, onChange = noOp, onUnlink = noOp }) => {
     const baseIgnores = [/\/(node_modules|.git)\//];
     const watcher = chokidar.watch(target, { depth, ignored: [...baseIgnores, ...ignored], ignoreInitial: true });
     await once(watcher, 'ready');
-    // @ts-expect-error TS(7034) FIXME: Variable 'onChangeQueue' implicitly has type 'any[... Remove this comment to see the full error message
     let onChangeQueue = [];
-    // @ts-expect-error TS(7034) FIXME: Variable 'onAddQueue' implicitly has type 'any[]' ... Remove this comment to see the full error message
     let onAddQueue = [];
-    // @ts-expect-error TS(7034) FIXME: Variable 'onUnlinkQueue' implicitly has type 'any[... Remove this comment to see the full error message
     let onUnlinkQueue = [];
     const debouncedOnChange = debounce(() => {
-        // @ts-expect-error TS(2554) FIXME: Expected 0 arguments, but got 1.
         onChange(onChangeQueue);
         onChangeQueue = [];
     }, DEBOUNCE_WAIT);
     const debouncedOnAdd = debounce(() => {
-        // @ts-expect-error TS(2554) FIXME: Expected 0 arguments, but got 1.
         onAdd(onAddQueue);
         onAddQueue = [];
     }, DEBOUNCE_WAIT);
     const debouncedOnUnlink = debounce(() => {
-        // @ts-expect-error TS(2554) FIXME: Expected 0 arguments, but got 1.
         onUnlink(onUnlinkQueue);
         onUnlinkQueue = [];
     }, DEBOUNCE_WAIT);
@@ -271,3 +253,10 @@ target,
 // @ts-expect-error TS(7006) FIXME: Parameter 'text' implicitly has an 'any' type.
 export const getTerminalLink = (text, url) => terminalLink(text, url, { fallback: () => `${text} (${url})` });
 export const isNodeError = (err) => error instanceof Error;
+// FIXME: tsc is throwing the following error:
+// @ts-expect-error TS7060: This syntax is reserved in files with the .mts or .cts extension. Add a trailing comma or explicit constraint.
+// Adding a trailing comma to the generic type fixes the problem, but annoyingly Prettier is undoing that.
+export const nonNullable = (value) => value !== null && value !== undefined;
+export const noOp = () => {
+    // no-op
+};

package/src/utils/init/utils.mjs

@@ -21,7 +21,7 @@ const pluginsToAlwaysInstall = new Set(['@netlify/plugin-nextjs']);
  * @returns
  */
 export const getPluginsToAutoInstall = (pluginsInstalled = [], pluginsRecommended = []) => pluginsRecommended.reduce((acc, plugin) => pluginsInstalled.includes(plugin) && !pluginsToAlwaysInstall.has(plugin) ? acc : [...acc, plugin], 
-/** @type {string[]} */ ([]));
+/** @type {string[]} */ []);
 /**
  *
  * @param {Partial<import('@netlify/build-info').Settings>} settings

package/src/utils/shell.mjs

@@ -95,8 +95,8 @@ export const runCommand = (command, options = {}) => {
         }
         else {
             const errorMessage = result.failed
-                // @ts-expect-error TS(2339) FIXME: Property 'shortMessage' does not exist on type 'Ex... Remove this comment to see the full error message
-                ? `${NETLIFYDEVERR} ${result.shortMessage}`
+                ? // @ts-expect-error TS(2339) FIXME: Property 'shortMessage' does not exist on type 'Ex... Remove this comment to see the full error message
+                    `${NETLIFYDEVERR} ${result.shortMessage}`
                 : `${NETLIFYDEVWARN} "${command}" exited with code ${result.exitCode}`;
             log(`${errorMessage}. Shutting down Netlify Dev server`);
         }

package/src/utils/telemetry/telemetry.mjs

@@ -19,7 +19,7 @@ function send(type, payload) {
         data: payload,
         type,
     });
-    const args = /** @type {const} */ ([process.execPath, [requestFile, options]]);
+    const args = /** @type {const} */ [process.execPath, [requestFile, options]];
     if (process.env.NETLIFY_TEST_TELEMETRY_WAIT === 'true') {
         // @ts-expect-error TS(7005) FIXME: Variable 'execa' implicitly has an 'any' type.
         return execa(...args, {