netlify-cli 17.3.2 → 17.4.0

package/src/lib/exec-fetcher.mjs

@@ -1,92 +1,88 @@
-// @ts-check
-import path from 'path'
-import process from 'process'
-
-import { fetchLatest, fetchVersion, newerVersion, updateAvailable } from 'gh-release-fetch'
-import isExe from 'isexe'
-
-import { NETLIFYDEVWARN, error, getTerminalLink, log } from '../utils/command-helpers.mjs'
-import execa from '../utils/execa.mjs'
-
-const isWindows = () => process.platform === 'win32'
-
-const getRepository = ({ packageName }) => `netlify/${packageName}`
-
-export const getExecName = ({ execName }) => (isWindows() ? `${execName}.exe` : execName)
-
+import path from 'path';
+import process from 'process';
+import { fetchLatest, fetchVersion, newerVersion, updateAvailable } from 'gh-release-fetch';
+// @ts-expect-error TS(7016) FIXME: Could not find a declaration file for module 'isex... Remove this comment to see the full error message
+import isExe from 'isexe';
+import { NETLIFYDEVWARN, error, getTerminalLink, log } from '../utils/command-helpers.mjs';
+// @ts-expect-error TS(7034) FIXME: Variable 'execa' implicitly has type 'any' in some... Remove this comment to see the full error message
+import execa from '../utils/execa.mjs';
+const isWindows = () => process.platform === 'win32';
+// @ts-expect-error TS(7031) FIXME: Binding element 'packageName' implicitly has an 'a... Remove this comment to see the full error message
+const getRepository = ({ packageName }) => `netlify/${packageName}`;
+// @ts-expect-error TS(7031) FIXME: Binding element 'execName' implicitly has an 'any'... Remove this comment to see the full error message
+export const getExecName = ({ execName }) => (isWindows() ? `${execName}.exe` : execName);
 const getOptions = () => {
-  // this is used in out CI tests to avoid hitting GitHub API limit
-  // when calling gh-release-fetch
-  if (process.env.NETLIFY_TEST_GITHUB_TOKEN) {
-    return {
-      headers: { Authorization: `token ${process.env.NETLIFY_TEST_GITHUB_TOKEN}` },
+    // this is used in out CI tests to avoid hitting GitHub API limit
+    // when calling gh-release-fetch
+    if (process.env.NETLIFY_TEST_GITHUB_TOKEN) {
+        return {
+            headers: { Authorization: `token ${process.env.NETLIFY_TEST_GITHUB_TOKEN}` },
+        };
     }
-  }
-}
-
+};
+// @ts-expect-error TS(7031) FIXME: Binding element 'currentVersion' implicitly has an... Remove this comment to see the full error message
 const isVersionOutdated = async ({ currentVersion, latestVersion, packageName }) => {
-  if (latestVersion) {
-    return newerVersion(latestVersion, currentVersion)
-  }
-  const options = getOptions()
-  const outdated = await updateAvailable(getRepository({ packageName }), currentVersion, options)
-  return outdated
-}
-
-export const shouldFetchLatestVersion = async ({
-  binPath,
-  execArgs,
-  execName,
-  latestVersion,
-  packageName,
-  pattern,
-}) => {
-  const execPath = path.join(binPath, getExecName({ execName }))
-
-  const exists = await isExe(execPath, { ignoreErrors: true })
-  if (!exists) {
-    return true
-  }
-
-  const { stdout } = await execa(execPath, execArgs)
-
-  if (!stdout) {
-    return false
-  }
-
-  const match = stdout.match(new RegExp(pattern))
-  if (!match) {
-    return false
-  }
-
-  try {
-    const [, currentVersion] = match
-    const outdated = await isVersionOutdated({
-      packageName,
-      currentVersion,
-      latestVersion,
-    })
-    return outdated
-  } catch (error_) {
-    if (exists) {
-      log(NETLIFYDEVWARN, `failed checking for new version of '${packageName}'. Using existing version`)
-      return false
+    if (latestVersion) {
+        return newerVersion(latestVersion, currentVersion);
     }
-    throw error_
-  }
-}
-
+    const options = getOptions();
+    const outdated = await updateAvailable(getRepository({ packageName }), currentVersion, options);
+    return outdated;
+};
+export const shouldFetchLatestVersion = async ({ 
+// @ts-expect-error TS(7031) FIXME: Binding element 'binPath' implicitly has an 'any' ... Remove this comment to see the full error message
+binPath, 
+// @ts-expect-error TS(7031) FIXME: Binding element 'execArgs' implicitly has an 'any'... Remove this comment to see the full error message
+execArgs, 
+// @ts-expect-error TS(7031) FIXME: Binding element 'execName' implicitly has an 'any'... Remove this comment to see the full error message
+execName, 
+// @ts-expect-error TS(7031) FIXME: Binding element 'latestVersion' implicitly has an ... Remove this comment to see the full error message
+latestVersion, 
+// @ts-expect-error TS(7031) FIXME: Binding element 'packageName' implicitly has an 'a... Remove this comment to see the full error message
+packageName, 
+// @ts-expect-error TS(7031) FIXME: Binding element 'pattern' implicitly has an 'any' ... Remove this comment to see the full error message
+pattern, }) => {
+    const execPath = path.join(binPath, getExecName({ execName }));
+    const exists = await isExe(execPath, { ignoreErrors: true });
+    if (!exists) {
+        return true;
+    }
+    // @ts-expect-error TS(7005) FIXME: Variable 'execa' implicitly has an 'any' type.
+    const { stdout } = await execa(execPath, execArgs);
+    if (!stdout) {
+        return false;
+    }
+    const match = stdout.match(new RegExp(pattern));
+    if (!match) {
+        return false;
+    }
+    try {
+        const [, currentVersion] = match;
+        const outdated = await isVersionOutdated({
+            packageName,
+            currentVersion,
+            latestVersion,
+        });
+        return outdated;
+    }
+    catch (error_) {
+        if (exists) {
+            log(NETLIFYDEVWARN, `failed checking for new version of '${packageName}'. Using existing version`);
+            return false;
+        }
+        throw error_;
+    }
+};
 export const getArch = () => {
-  switch (process.arch) {
-    case 'x64':
-      return 'amd64'
-    case 'ia32':
-      return '386'
-    default:
-      return process.arch
-  }
-}
-
+    switch (process.arch) {
+        case 'x64':
+            return 'amd64';
+        case 'ia32':
+            return '386';
+        default:
+            return process.arch;
+    }
+};
 /**
  * Tries to get the latest release from the github releases to download the binary.
  * Is throwing an error if there is no binary that matches the system os or arch
@@ -98,45 +94,42 @@ export const getArch = () => {
  * @param {string} config.packageName
  * @param {string} [config.latestVersion ]
  */
+// @ts-expect-error TS(7031) FIXME: Binding element 'destination' implicitly has an 'a... Remove this comment to see the full error message
 export const fetchLatestVersion = async ({ destination, execName, extension, latestVersion, packageName }) => {
-  const win = isWindows()
-  const arch = getArch()
-  const platform = win ? 'windows' : process.platform
-  const pkgName = `${execName}-${platform}-${arch}.${extension}`
-
-  const release = {
-    repository: getRepository({ packageName }),
-    package: pkgName,
-    destination,
-    extract: true,
-  }
-
-  const options = getOptions()
-  const fetch = latestVersion
-    ? fetchVersion({ ...release, version: latestVersion }, options)
-    : fetchLatest(release, options)
-
-  try {
-    await fetch
-  } catch (error_) {
-    if (typeof error_ === 'object' && 'statusCode' in error_ && error_.statusCode === 404) {
-      const createIssueLink = new URL('https://github.com/netlify/cli/issues/new')
-      createIssueLink.searchParams.set('assignees', '')
-      createIssueLink.searchParams.set('labels', 'type: bug')
-      createIssueLink.searchParams.set('template', 'bug_report.md')
-      createIssueLink.searchParams.set(
-        'title',
-        `${execName} is not supported on ${platform} with CPU architecture ${arch}`,
-      )
-
-      const issueLink = getTerminalLink('Create a new CLI issue', createIssueLink.href)
-
-      error(`The operating system ${platform} with the CPU architecture ${arch} is currently not supported!
+    const win = isWindows();
+    const arch = getArch();
+    const platform = win ? 'windows' : process.platform;
+    const pkgName = `${execName}-${platform}-${arch}.${extension}`;
+    const release = {
+        repository: getRepository({ packageName }),
+        package: pkgName,
+        destination,
+        extract: true,
+    };
+    const options = getOptions();
+    const fetch = latestVersion
+        // @ts-expect-error TS(2345) FIXME: Argument of type '{ headers: { Authorization: stri... Remove this comment to see the full error message
+        ? fetchVersion({ ...release, version: latestVersion }, options)
+        // @ts-expect-error TS(2345) FIXME: Argument of type '{ repository: string; package: s... Remove this comment to see the full error message
+        : fetchLatest(release, options);
+    try {
+        await fetch;
+    }
+    catch (error_) {
+        // @ts-expect-error TS(2531) FIXME: Object is possibly 'null'.
+        if (typeof error_ === 'object' && 'statusCode' in error_ && error_.statusCode === 404) {
+            const createIssueLink = new URL('https://github.com/netlify/cli/issues/new');
+            createIssueLink.searchParams.set('assignees', '');
+            createIssueLink.searchParams.set('labels', 'type: bug');
+            createIssueLink.searchParams.set('template', 'bug_report.md');
+            createIssueLink.searchParams.set('title', `${execName} is not supported on ${platform} with CPU architecture ${arch}`);
+            const issueLink = getTerminalLink('Create a new CLI issue', createIssueLink.href);
+            error(`The operating system ${platform} with the CPU architecture ${arch} is currently not supported!
 
 Please open up an issue on our CLI repository so that we can support it:
-${issueLink}`)
+${issueLink}`);
+        }
+        // @ts-expect-error TS(2345) FIXME: Argument of type 'unknown' is not assignable to pa... Remove this comment to see the full error message
+        error(error_);
     }
-
-    error(error_)
-  }
-}
+};

package/src/lib/fs.mjs

@@ -1,43 +1,44 @@
-// @ts-check
-import { constants } from 'fs'
-import { access, stat } from 'fs/promises'
-
+import { constants } from 'fs';
+import { access, stat } from 'fs/promises';
+// @ts-expect-error TS(7006) FIXME: Parameter 'filePath' implicitly has an 'any' type.
 export const fileExistsAsync = async (filePath) => {
-  try {
-    await access(filePath, constants.F_OK)
-    return true
-  } catch {
-    return false
-  }
-}
-
+    try {
+        await access(filePath, constants.F_OK);
+        return true;
+    }
+    catch {
+        return false;
+    }
+};
 /**
  * calls stat async with a function and catches potential errors
  * @param {string} filePath
  * @param {keyof import('fs').StatsBase<number>} type For example `isDirectory` or `isFile`
  */
+// @ts-expect-error TS(7006) FIXME: Parameter 'filePath' implicitly has an 'any' type.
 const isType = async (filePath, type) => {
-  try {
-    const stats = await stat(filePath)
-    // @ts-ignore
-    return typeof stats[type] === 'function' ? stats[type]() : stats[type]
-  } catch (error_) {
-    if (error_.code === 'ENOENT') {
-      return false
+    try {
+        const stats = await stat(filePath);
+        // @ts-expect-error TS(7053) FIXME: Element implicitly has an 'any' type because expre... Remove this comment to see the full error message
+        return typeof stats[type] === 'function' ? stats[type]() : stats[type];
+    }
+    catch (error_) {
+        // @ts-expect-error TS(2571) FIXME: Object is of type 'unknown'.
+        if (error_.code === 'ENOENT') {
+            return false;
+        }
+        throw error_;
     }
-
-    throw error_
-  }
-}
-
+};
 /**
  * Checks if the provided filePath is a file
  * @param {string} filePath
  */
-export const isFileAsync = (filePath) => isType(filePath, 'isFile')
-
+// @ts-expect-error TS(7006) FIXME: Parameter 'filePath' implicitly has an 'any' type.
+export const isFileAsync = (filePath) => isType(filePath, 'isFile');
 /**
  * Checks if the provided filePath is a directory
  * @param {string} filePath
  */
-export const isDirectoryAsync = (filePath) => isType(filePath, 'isDirectory')
+// @ts-expect-error TS(7006) FIXME: Parameter 'filePath' implicitly has an 'any' type.
+export const isDirectoryAsync = (filePath) => isType(filePath, 'isDirectory');

package/src/lib/functions/background.mjs

@@ -1,22 +1,18 @@
-import { NETLIFYDEVERR, NETLIFYDEVLOG } from '../../utils/command-helpers.mjs'
-
-import { formatLambdaError, styleFunctionName } from './utils.mjs'
-
-const BACKGROUND_FUNCTION_STATUS_CODE = 202
-
+import { NETLIFYDEVERR, NETLIFYDEVLOG } from '../../utils/command-helpers.mjs';
+import { formatLambdaError, styleFunctionName } from './utils.mjs';
+const BACKGROUND_FUNCTION_STATUS_CODE = 202;
+// @ts-expect-error TS(7006) FIXME: Parameter 'functionName' implicitly has an 'any' t... Remove this comment to see the full error message
 export const handleBackgroundFunction = (functionName, response) => {
-  console.log(`${NETLIFYDEVLOG} Queueing background function ${styleFunctionName(functionName)} for execution`)
-  response.status(BACKGROUND_FUNCTION_STATUS_CODE)
-  response.end()
-}
-
+    console.log(`${NETLIFYDEVLOG} Queueing background function ${styleFunctionName(functionName)} for execution`);
+    response.status(BACKGROUND_FUNCTION_STATUS_CODE);
+    response.end();
+};
+// @ts-expect-error TS(7006) FIXME: Parameter 'functionName' implicitly has an 'any' t... Remove this comment to see the full error message
 export const handleBackgroundFunctionResult = (functionName, err) => {
-  if (err) {
-    console.log(
-      `${NETLIFYDEVERR} Error during background function ${styleFunctionName(functionName)} execution:`,
-      formatLambdaError(err),
-    )
-  } else {
-    console.log(`${NETLIFYDEVLOG} Done executing background function ${styleFunctionName(functionName)}`)
-  }
-}
+    if (err) {
+        console.log(`${NETLIFYDEVERR} Error during background function ${styleFunctionName(functionName)} execution:`, formatLambdaError(err));
+    }
+    else {
+        console.log(`${NETLIFYDEVLOG} Done executing background function ${styleFunctionName(functionName)}`);
+    }
+};

package/src/lib/functions/config.mjs

@@ -1,21 +1,24 @@
 // The function configuration keys returned by @netlify/config are not an exact
 // match to the properties that @netlify/zip-it-and-ship-it expects. We do that
 // translation here.
-export const normalizeFunctionsConfig = ({ functionsConfig = {}, projectRoot, siteEnv = {} }) =>
-  Object.entries(functionsConfig).reduce(
-    (result, [pattern, config]) => ({
-      ...result,
-      [pattern]: {
+// @ts-expect-error TS(7031) FIXME: Binding element 'projectRoot' implicitly has an 'a... Remove this comment to see the full error message
+export const normalizeFunctionsConfig = ({ functionsConfig = {}, projectRoot, siteEnv = {} }) => Object.entries(functionsConfig).reduce((result, [pattern, config]) => ({
+    ...result,
+    [pattern]: {
+        // @ts-expect-error TS(2571) FIXME: Object is of type 'unknown'.
         externalNodeModules: config.external_node_modules,
+        // @ts-expect-error TS(2571) FIXME: Object is of type 'unknown'.
         includedFiles: config.included_files,
         includedFilesBasePath: projectRoot,
+        // @ts-expect-error TS(2571) FIXME: Object is of type 'unknown'.
         ignoredNodeModules: config.ignored_node_modules,
+        // @ts-expect-error TS(2571) FIXME: Object is of type 'unknown'.
         nodeBundler: config.node_bundler === 'esbuild' ? 'esbuild_zisi' : config.node_bundler,
+        // @ts-expect-error TS(2339) FIXME: Property 'AWS_LAMBDA_JS_RUNTIME' does not exist on... Remove this comment to see the full error message
         nodeVersion: siteEnv.AWS_LAMBDA_JS_RUNTIME,
         processDynamicNodeImports: true,
+        // @ts-expect-error TS(2571) FIXME: Object is of type 'unknown'.
         schedule: config.schedule,
         zipGo: true,
-      },
-    }),
-    {},
-  )
+    },
+}), {});