netlify-cli 17.10.1 → 17.11.0

package/src/utils/deploy/deploy-site.js

@@ -42,7 +42,6 @@ skipFunctionsCache, statusCb = () => {
 }, syncFileLimit = DEFAULT_SYNC_LIMIT, tmpDir = temporaryDirectory(), 
 // @ts-expect-error TS(2525) FIXME: Initializer provides no value for this binding ele... Remove this comment to see the full error message
 workingDir, } = {}) => {
-    // @ts-expect-error TS(2554) FIXME: Expected 0 arguments, but got 1.
     statusCb({
         type: 'hashing',
         msg: `Hashing files...`,
@@ -85,7 +84,6 @@ workingDir, } = {}) => {
         functionsCount > 0 && `${functionsCount} functions`,
         edgeFunctionsCount > 0 && 'edge functions',
     ]);
-    // @ts-expect-error TS(2554) FIXME: Expected 0 arguments, but got 1.
     statusCb({
         type: 'hashing',
         msg: `Finished hashing ${stats}`,
@@ -108,7 +106,6 @@ instead of manual deployment.
 
 For more information, visit https://ntl.fyi/cli-native-modules.`);
     }
-    // @ts-expect-error TS(2554) FIXME: Expected 0 arguments, but got 1.
     statusCb({
         type: 'create-deploy',
         msg: 'CDN diffing files...',
@@ -132,7 +129,6 @@ For more information, visit https://ntl.fyi/cli-native-modules.`);
     if (deployParams.body.async)
         deploy = await waitForDiff(api, deploy.id, siteId, deployTimeout);
     const { required: requiredFiles, required_functions: requiredFns } = deploy;
-    // @ts-expect-error TS(2554) FIXME: Expected 0 arguments, but got 1.
     statusCb({
         type: 'create-deploy',
         msg: `CDN requesting ${requiredFiles.length} files${Array.isArray(requiredFns) ? ` and ${requiredFns.length} functions` : ''}`,
@@ -142,14 +138,12 @@ For more information, visit https://ntl.fyi/cli-native-modules.`);
     const functionsUploadList = getUploadList(requiredFns, fnShaMap);
     const uploadList = [...filesUploadList, ...functionsUploadList];
     await uploadFiles(api, deployId, uploadList, { concurrentUpload, statusCb, maxRetry });
-    // @ts-expect-error TS(2554) FIXME: Expected 0 arguments, but got 1.
     statusCb({
         type: 'wait-for-deploy',
         msg: 'Waiting for deploy to go live...',
         phase: 'start',
     });
     deploy = await waitForDeploy(api, deployId, siteId, deployTimeout);
-    // @ts-expect-error TS(2554) FIXME: Expected 0 arguments, but got 1.
     statusCb({
         type: 'wait-for-deploy',
         msg: draft ? 'Draft deploy is live!' : 'Deploy is live!',

package/src/utils/detect-server-settings.js

@@ -6,21 +6,9 @@ import getPort from 'get-port';
 import { detectFrameworkSettings } from './build-info.js';
 import { NETLIFYDEVWARN, chalk, log } from './command-helpers.js';
 import { acquirePort } from './dev.js';
-import { getInternalFunctionsDir } from './functions/functions.js';
 import { getPluginsToAutoInstall } from './init/utils.js';
-/** @param {string} str */
-// @ts-expect-error TS(7006) FIXME: Parameter 'str' implicitly has an 'any' type.
 const formatProperty = (str) => chalk.magenta(`'${str}'`);
-/** @param {string} str */
-// @ts-expect-error TS(7006) FIXME: Parameter 'str' implicitly has an 'any' type.
 const formatValue = (str) => chalk.green(`'${str}'`);
-/**
- * @param {object} options
- * @param {string} options.keyFile
- * @param {string} options.certFile
- * @returns {Promise<{ key: string, cert: string, keyFilePath: string, certFilePath: string }>}
- */
-// @ts-expect-error TS(7006) FIXME: Parameter 'options' implicitly has an 'any' type.
 const readHttpsSettings = async (options) => {
     if (typeof options !== 'object' || !options.keyFile || !options.certFile) {
         throw new TypeError(`https options should be an object with ${formatProperty('keyFile')} and ${formatProperty('certFile')} string properties`);
@@ -43,23 +31,13 @@ const readHttpsSettings = async (options) => {
 };
 /**
  * Validates a property inside the devConfig to be of a given type
- * @param {import('../commands/dev/types.js').DevConfig} devConfig The devConfig
- * @param {keyof import('../commands/dev/types.js').DevConfig} property The property to validate
- * @param {'string' | 'number'} type The type it should have
  */
-// @ts-expect-error TS(7006) FIXME: Parameter 'devConfig' implicitly has an 'any' type... Remove this comment to see the full error message
 function validateProperty(devConfig, property, type) {
     if (devConfig[property] && typeof devConfig[property] !== type) {
         const formattedProperty = formatProperty(property);
         throw new TypeError(`Invalid ${formattedProperty} option provided in config. The value of ${formattedProperty} option must be of type ${type}`);
     }
 }
-/**
- *
- * @param {object} config
- * @param {import('../commands/dev/types.js').DevConfig} config.devConfig
- */
-// @ts-expect-error TS(7031) FIXME: Binding element 'devConfig' implicitly has an 'any... Remove this comment to see the full error message
 const validateFrameworkConfig = ({ devConfig }) => {
     validateProperty(devConfig, 'command', 'string');
     validateProperty(devConfig, 'port', 'number');
@@ -68,12 +46,6 @@ const validateFrameworkConfig = ({ devConfig }) => {
         throw new Error(`${formatProperty('port')} and ${formatProperty('targetPort')} options cannot have same values. Please consult the documentation for more details: https://ntl.fyi/ports-and-netlify-dev`);
     }
 };
-/**
- * @param {object} config
- * @param {import('../commands/dev/types.js').DevConfig} config.devConfig
- * @param {number=} config.detectedPort
- */
-// @ts-expect-error TS(7031) FIXME: Binding element 'detectedPort' implicitly has an '... Remove this comment to see the full error message
 const validateConfiguredPort = ({ detectedPort, devConfig }) => {
     if (devConfig.port && devConfig.port === detectedPort) {
         const formattedPort = formatProperty('port');
@@ -84,21 +56,13 @@ const DEFAULT_PORT = 8888;
 const DEFAULT_STATIC_PORT = 3999;
 /**
  * Logs a message that it was unable to determine the dist directory and falls back to the workingDir
- * @param {string} workingDir
  */
-// @ts-expect-error TS(7006) FIXME: Parameter 'workingDir' implicitly has an 'any' typ... Remove this comment to see the full error message
 const getDefaultDist = (workingDir) => {
     log(`${NETLIFYDEVWARN} Unable to determine public folder to serve files from. Using current working directory`);
     log(`${NETLIFYDEVWARN} Setup a netlify.toml file with a [dev] section to specify your dev server settings.`);
     log(`${NETLIFYDEVWARN} See docs at: https://cli.netlify.com/netlify-dev#project-detection`);
     return workingDir;
 };
-/**
- * @param {object} config
- * @param {import('../commands/dev/types.js').DevConfig} config.devConfig
- * @returns {Promise<number>}
- */
-// @ts-expect-error TS(7031) FIXME: Binding element 'devConfig' implicitly has an 'any... Remove this comment to see the full error message
 const getStaticServerPort = async ({ devConfig }) => {
     const port = await acquirePort({
         configuredPort: devConfig.staticServerPort,
@@ -107,16 +71,7 @@ const getStaticServerPort = async ({ devConfig }) => {
     });
     return port;
 };
-/**
- *
- * @param {object} config
- * @param {import('../commands/dev/types.js').DevConfig} config.devConfig
- * @param {import('commander').OptionValues} config.flags
- * @param {string} config.workingDir
- * @returns {Promise<Omit<import('./types.js').BaseServerSettings, 'command'> & {command?: string}>}
- */
-// @ts-expect-error TS(7031) FIXME: Binding element 'devConfig' implicitly has an 'any... Remove this comment to see the full error message
-const handleStaticServer = async ({ devConfig, flags, workingDir }) => {
+const handleStaticServer = async ({ devConfig, flags, workingDir, }) => {
     validateProperty(devConfig, 'staticServerPort', 'number');
     if (flags.dir) {
         log(`${NETLIFYDEVWARN} Using simple static server because ${formatProperty('--dir')} flag was specified`);
@@ -139,11 +94,8 @@ const handleStaticServer = async ({ devConfig, flags, workingDir }) => {
 };
 /**
  * Retrieves the settings from a framework
- * @param {import('@netlify/build-info').Settings} [settings]
- * @returns {import('./types.js').BaseServerSettings | undefined}
  */
-// @ts-expect-error TS(7006) FIXME: Parameter 'settings' implicitly has an 'any' type.
-const getSettingsFromDetectedSettings = (settings) => {
+const getSettingsFromDetectedSettings = (command, settings) => {
     if (!settings) {
         return;
     }
@@ -155,23 +107,15 @@ const getSettingsFromDetectedSettings = (settings) => {
         framework: settings.framework.name,
         env: settings.env,
         pollingStrategies: settings.pollingStrategies,
-        plugins: getPluginsToAutoInstall(settings.plugins_from_config_file, settings.plugins_recommended),
+        plugins: getPluginsToAutoInstall(command, settings.plugins_from_config_file, settings.plugins_recommended),
+        clearPublishDirectory: settings.clearPublishDirectory,
     };
 };
-/**
- * @param {import('../commands/dev/types.js').DevConfig} devConfig
- */
-// @ts-expect-error TS(7006) FIXME: Parameter 'devConfig' implicitly has an 'any' type... Remove this comment to see the full error message
 const hasCommandAndTargetPort = (devConfig) => devConfig.command && devConfig.targetPort;
 /**
  * Creates settings for the custom framework
- * @param {object} config
- * @param {import('../commands/dev/types.js').DevConfig} config.devConfig
- * @param {string} config.workingDir
- * @returns {import('./types.js').BaseServerSettings}
  */
-// @ts-expect-error TS(7031) FIXME: Binding element 'devConfig' implicitly has an 'any... Remove this comment to see the full error message
-const handleCustomFramework = ({ devConfig, workingDir }) => {
+const handleCustomFramework = ({ devConfig, workingDir, }) => {
     if (!hasCommandAndTargetPort(devConfig)) {
         throw new Error(`${formatProperty('command')} and ${formatProperty('targetPort')} properties are required when ${formatProperty('framework')} is set to ${formatValue('#custom')}`);
     }
@@ -185,60 +129,36 @@ const handleCustomFramework = ({ devConfig, workingDir }) => {
 };
 /**
  * Merges the framework settings with the devConfig
- * @param {object} config
- * @param {import('../commands/dev/types.js').DevConfig} config.devConfig
- * @param {string} config.workingDir
- * @param {Partial<import('./types.js').BaseServerSettings>=} config.frameworkSettings
  */
-// @ts-expect-error TS(7031) FIXME: Binding element 'devConfig' implicitly has an 'any... Remove this comment to see the full error message
-const mergeSettings = async ({ devConfig, frameworkSettings = {}, workingDir }) => {
-    // @ts-expect-error TS(2339) FIXME: Property 'command' does not exist on type '{}'.
+const mergeSettings = async ({ devConfig, frameworkSettings = {}, workingDir, }) => {
     const command = devConfig.command || frameworkSettings.command;
-    // @ts-expect-error TS(2339) FIXME: Property 'frameworkPort' does not exist on type '{... Remove this comment to see the full error message
     const frameworkPort = devConfig.targetPort || frameworkSettings.frameworkPort;
-    // if the framework doesn't start a server, we use a static one
     const useStaticServer = !(command && frameworkPort);
     return {
-        // @ts-expect-error TS(2339) FIXME: Property 'baseDirectory' does not exist on type '{... Remove this comment to see the full error message
         baseDirectory: devConfig.base || frameworkSettings.baseDirectory,
         command,
         frameworkPort: useStaticServer ? await getStaticServerPort({ devConfig }) : frameworkPort,
-        // @ts-expect-error TS(2339) FIXME: Property 'dist' does not exist on type '{}'.
         dist: devConfig.publish || frameworkSettings.dist || getDefaultDist(workingDir),
-        // @ts-expect-error TS(2339) FIXME: Property 'framework' does not exist on type '{}'.
         framework: frameworkSettings.framework,
-        // @ts-expect-error TS(2339) FIXME: Property 'env' does not exist on type '{}'.
         env: frameworkSettings.env,
-        // @ts-expect-error TS(2339) FIXME: Property 'pollingStrategies' does not exist on typ... Remove this comment to see the full error message
         pollingStrategies: frameworkSettings.pollingStrategies || [],
         useStaticServer,
+        clearPublishDirectory: frameworkSettings.clearPublishDirectory,
     };
 };
 /**
  * Handles a forced framework and retrieves the settings for it
- * @param {object} config
- * @param {import('../commands/dev/types.js').DevConfig} config.devConfig
- * @param {import('@netlify/build-info').Project} config.project
- * @param {string} config.workingDir
- * @param {string=} config.workspacePackage
- * @returns {Promise<import('./types.js').BaseServerSettings>}
  */
-// @ts-expect-error TS(7031) FIXME: Binding element 'devConfig' implicitly has an 'any... Remove this comment to see the full error message
-const handleForcedFramework = async ({ devConfig, project, workingDir, workspacePackage }) => {
+const handleForcedFramework = async (options) => {
     // this throws if `devConfig.framework` is not a supported framework
-    const framework = await getFramework(devConfig.framework, project);
-    const settings = await getSettings(framework, project, workspacePackage || '');
-    const frameworkSettings = getSettingsFromDetectedSettings(settings);
-    return mergeSettings({ devConfig, workingDir, frameworkSettings });
+    const framework = await getFramework(options.devConfig.framework, options.project);
+    const settings = await getSettings(framework, options.project, options.workspacePackage || '');
+    const frameworkSettings = getSettingsFromDetectedSettings(options.command, settings);
+    return mergeSettings({ devConfig: options.devConfig, workingDir: options.workingDir, frameworkSettings });
 };
 /**
  * Get the server settings based on the flags and the devConfig
- * @param {import('../commands/dev/types.js').DevConfig} devConfig
- * @param {import('commander').OptionValues} flags
- * @param {import('../commands/base-command.js').default} command
- * @returns {Promise<import('./types.js').ServerSettings>}
  */
-// @ts-expect-error TS(7006) FIXME: Parameter 'devConfig' implicitly has an 'any' type... Remove this comment to see the full error message
 const detectServerSettings = async (devConfig, flags, command) => {
     validateProperty(devConfig, 'framework', 'string');
     /** @type {Partial<import('./types.js').BaseServerSettings>} */
@@ -251,7 +171,7 @@ const detectServerSettings = async (devConfig, flags, command) => {
         // this is the default CLI behavior
         const runDetection = !hasCommandAndTargetPort(devConfig);
         const frameworkSettings = runDetection
-            ? getSettingsFromDetectedSettings(await detectFrameworkSettings(command, 'dev'))
+            ? getSettingsFromDetectedSettings(command, await detectFrameworkSettings(command, 'dev'))
             : undefined;
         if (frameworkSettings === undefined && runDetection) {
             log(`${NETLIFYDEVWARN} No app server detected. Using simple static server`);
@@ -273,6 +193,7 @@ const detectServerSettings = async (devConfig, flags, command) => {
         validateFrameworkConfig({ devConfig });
         // this is when the user explicitly configures a framework, e.g. `framework = "gatsby"`
         settings = await handleForcedFramework({
+            command,
             devConfig,
             project: command.project,
             workingDir: command.workingDir,
@@ -288,25 +209,19 @@ const detectServerSettings = async (devConfig, flags, command) => {
     });
     // @ts-expect-error TS(2339) FIXME: Property 'functions' does not exist on type '{}'.
     const functionsDir = devConfig.functions || settings.functions;
-    // @ts-expect-error TS(2345) FIXME: Argument of type '{ base: any; }' is not assignabl... Remove this comment to see the full error message
-    const internalFunctionsDir = await getInternalFunctionsDir({ base: command.workingDir });
-    const shouldStartFunctionsServer = Boolean(functionsDir || internalFunctionsDir);
     return {
         ...settings,
         port: acquiredPort,
         jwtSecret: devConfig.jwtSecret || 'secret',
         jwtRolePath: devConfig.jwtRolePath || 'app_metadata.authorization.roles',
         functions: functionsDir,
-        ...(shouldStartFunctionsServer && { functionsPort: await getPort({ port: devConfig.functionsPort || 0 }) }),
+        functionsPort: await getPort({ port: devConfig.functionsPort || 0 }),
         ...(devConfig.https && { https: await readHttpsSettings(devConfig.https) }),
     };
 };
 /**
  * Returns a copy of the provided config with any plugins provided by the
  * server settings
- * @param {*} config
- * @param {Partial<import('./types.js').ServerSettings>} settings
- * @returns {*} Modified config
  */
 // @ts-expect-error TS(7006) FIXME: Parameter 'config' implicitly has an 'any' type.
 export const getConfigWithPlugins = (config, settings) => {
@@ -321,7 +236,6 @@ export const getConfigWithPlugins = (config, settings) => {
     // @ts-expect-error TS(7006) FIXME: Parameter 'plugin' implicitly has an 'any' type.
     const existingPluginNames = new Set(existingPlugins.map((plugin) => plugin.package));
     const newPlugins = settings.plugins
-        // @ts-expect-error TS(7006) FIXME: Parameter 'pluginName' implicitly has an 'any' typ... Remove this comment to see the full error message
         .map((pluginName) => {
         if (existingPluginNames.has(pluginName)) {
             return;

package/src/utils/execa.js

@@ -2,10 +2,7 @@ import { env } from 'process';
 import execaLib from 'execa';
 // This is a thin layer on top of `execa` that allows consumers to provide an
 // alternative path to the module location, making it easier to mock its logic
-// in tests (see `tests/utils/mock-execa.js`).
-/**
- * @type {import('execa')}
- */
+// in tests (see `tests/utils/moc
 // eslint-disable-next-line import/no-mutable-exports
 let execa;
 if (env.NETLIFY_CLI_EXECA_PATH) {

package/src/utils/feature-flags.js

@@ -7,14 +7,8 @@
  * Instead, we return that the feature flag is enabled if it isn't
  * specifically set to false in the response
  * @param {*} siteInfo
- * @param {string} flagName
  *
  * @returns {boolean}
  */
 // @ts-expect-error TS(7006) FIXME: Parameter 'flagName' implicitly has an 'any' type.
-export const isFeatureFlagEnabled = (flagName, siteInfo) => {
-    if (siteInfo.feature_flags && siteInfo.feature_flags[flagName] !== false) {
-        return true;
-    }
-    return false;
-};
+export const isFeatureFlagEnabled = (flagName, siteInfo) => Boolean(siteInfo.feature_flags && siteInfo.feature_flags[flagName] !== false);

package/src/utils/framework-server.js

@@ -1,3 +1,4 @@
+import { rm } from 'node:fs/promises';
 import waitPort from 'wait-port';
 import { startSpinner, stopSpinner } from '../lib/spinner.js';
 import { error, exit, log, NETLIFYDEVERR, NETLIFYDEVLOG } from './command-helpers.js';
@@ -5,19 +6,10 @@ import { runCommand } from './shell.js';
 import { startStaticServer } from './static-server.js';
 // 10 minutes
 const FRAMEWORK_PORT_TIMEOUT = 6e5;
-/**
- * @typedef StartReturnObject
- * @property {4 | 6 | undefined=} ipVersion The version the open port was found on
- */
 /**
  * Start a static server if the `useStaticServer` is provided or a framework specific server
- * @param {object} config
- * @param {import('./types.js').ServerSettings} config.settings
- * @param {string} config.cwd
- * @returns {Promise<StartReturnObject>}
  */
-// @ts-expect-error TS(7031) FIXME: Binding element 'cwd' implicitly has an 'any' type... Remove this comment to see the full error message
-export const startFrameworkServer = async function ({ cwd, settings }) {
+export const startFrameworkServer = async function ({ cwd, settings, }) {
     if (settings.useStaticServer) {
         if (settings.command) {
             runCommand(settings.command, { env: settings.env, cwd });
@@ -29,10 +21,14 @@ export const startFrameworkServer = async function ({ cwd, settings }) {
     const spinner = startSpinner({
         text: `Waiting for framework port ${settings.frameworkPort}. This can be configured using the 'targetPort' property in the netlify.toml`,
     });
+    if (settings.clearPublishDirectory && settings.dist) {
+        await rm(settings.dist, { recursive: true, force: true });
+    }
     runCommand(settings.command, { env: settings.env, spinner, cwd });
     let port;
     try {
         port = await waitPort({
+            // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
             port: settings.frameworkPort,
             host: 'localhost',
             output: 'silent',

package/src/utils/functions/functions.js

@@ -33,18 +33,11 @@ export const getFunctionsServePath = ({ base, packagePath = '' }) => {
 };
 /**
  * Retrieves the internal functions directory and creates it if ensureExists is provided
- * @param {object} config
- * @param {string} config.base
- * @param {boolean=} config.ensureExists
- * @param {string} config.packagePath
- * @returns
  */
-// @ts-expect-error TS(7031) FIXME: Binding element 'base' implicitly has an 'any' typ... Remove this comment to see the full error message
-export const getInternalFunctionsDir = async ({ base, ensureExists, packagePath = '' }) => {
+export const getInternalFunctionsDir = async ({ base, ensureExists, packagePath = '', }) => {
     const path = resolve(base, packagePath, getPathInProject([INTERNAL_FUNCTIONS_FOLDER]));
     if (ensureExists) {
         await fs.mkdir(path, { recursive: true });
     }
-    const isDirectory = await isDirectoryAsync(path);
-    return isDirectory ? path : null;
+    return path;
 };

package/src/utils/init/utils.js

@@ -7,35 +7,32 @@ import { normalizeBackslash } from '../../lib/path.js';
 import { detectBuildSettings } from '../build-info.js';
 import { chalk, error as failAndExit, log, warn } from '../command-helpers.js';
 import { getRecommendPlugins, getUIPlugins } from './plugins.js';
-// these plugins represent runtimes that are
-// expected to be "automatically" installed. Even though
-// they can be installed on package/toml, we always
-// want them installed in the site settings. When installed
-// there our build will automatically install the latest without
-// user management of the versioning.
-const pluginsToAlwaysInstall = new Set(['@netlify/plugin-nextjs']);
+const formatTitle = (title) => chalk.cyan(title);
 /**
  * Retrieve a list of plugins to auto install
- * @param {string[]=} pluginsInstalled
- * @param {string[]=} pluginsRecommended
+ * @param pluginsToAlwaysInstall these plugins represent runtimes that are
+ * expected to be "automatically" installed. Even though
+ * they can be installed on package/toml, we always
+ * want them installed in the site settings. When installed
+ * there our build will automatically install the latest without
+ * user management of the versioning.
+ * @param pluginsInstalled
+ * @param pluginsRecommended
  * @returns
  */
-export const getPluginsToAutoInstall = (pluginsInstalled = [], pluginsRecommended = []) => pluginsRecommended.reduce((acc, plugin) => pluginsInstalled.includes(plugin) && !pluginsToAlwaysInstall.has(plugin) ? acc : [...acc, plugin], 
-/** @type {string[]} */ []);
-/**
- *
- * @param {Partial<import('@netlify/build-info').Settings>} settings
- * @param {*} config
- * @param {import('../../commands/base-command.js').default} command
- */
-// @ts-expect-error TS(7006) FIXME: Parameter 'settings' implicitly has an 'any' type.
+export const getPluginsToAutoInstall = (command, pluginsInstalled = [], pluginsRecommended = []) => {
+    const nextRuntime = '@netlify/plugin-nextjs';
+    const pluginsToAlwaysInstall = new Set([nextRuntime]);
+    return pluginsRecommended.reduce((acc, plugin) => pluginsInstalled.includes(plugin) && !pluginsToAlwaysInstall.has(plugin) ? acc : [...acc, plugin], []);
+};
 const normalizeSettings = (settings, config, command) => {
-    const plugins = getPluginsToAutoInstall(settings.plugins_from_config_file, settings.plugins_recommended);
+    const plugins = getPluginsToAutoInstall(command, settings.plugins_from_config_file, settings.plugins_recommended);
     const recommendedPlugins = getRecommendPlugins(plugins, config);
     return {
         defaultBaseDir: settings.baseDirectory ?? command.project.relativeBaseDirectory ?? '',
         defaultBuildCmd: config.build.command || settings.buildCommand,
         defaultBuildDir: settings.dist,
+        // @ts-expect-error types need to be fixed on @netlify/build
         defaultFunctionsDir: config.build.functions || 'netlify/functions',
         recommendedPlugins,
     };
@@ -75,21 +72,14 @@ const getPromptInputs = ({ defaultBaseDir, defaultBuildCmd, defaultBuildDir }) =
     ].filter(Boolean);
     return inputs.filter(Boolean);
 };
-/**
- * @param {object} param0
- * @param {*} param0.config
- * @param {import('../../commands/base-command.js').default} param0.command
- */
-// @ts-expect-error TS(7031) FIXME: Binding element 'command' implicitly has an 'any' ... Remove this comment to see the full error message
 export const getBuildSettings = async ({ command, config }) => {
     const settings = await detectBuildSettings(command);
     // TODO: add prompt for asking to choose the build command
-    /** @type {Partial<import('@netlify/build-info').Settings>} */
     // eslint-disable-next-line unicorn/explicit-length-check
     const setting = settings.length > 0 ? settings[0] : {};
     const { defaultBaseDir, defaultBuildCmd, defaultBuildDir, defaultFunctionsDir, recommendedPlugins } = await normalizeSettings(setting, config, command);
     if (recommendedPlugins.length !== 0 && setting.framework?.name) {
-        log(`Configuring ${formatTitle(setting.framework?.name)} runtime...`);
+        log(`Configuring ${formatTitle(setting.framework.name)} runtime...`);
         log();
     }
     const { baseDir, buildCmd, buildDir } = await inquirer.prompt(getPromptInputs({
@@ -174,11 +164,6 @@ export const formatErrorMessage = ({ error, message }) => {
     const errorMessage = error.json ? `${error.message} - ${JSON.stringify(error.json)}` : error.message;
     return `${message} with error: ${chalk.red(errorMessage)}`;
 };
-/**
- * @param {string} title
- */
-// @ts-expect-error TS(7006) FIXME: Parameter 'title' implicitly has an 'any' type.
-const formatTitle = (title) => chalk.cyan(title);
 // @ts-expect-error TS(7031) FIXME: Binding element 'api' implicitly has an 'any' type... Remove this comment to see the full error message
 export const createDeployKey = async ({ api }) => {
     try {

package/src/utils/live-tunnel.js

@@ -6,7 +6,6 @@ import { v4 as uuidv4 } from 'uuid';
 import { fetchLatestVersion, shouldFetchLatestVersion } from '../lib/exec-fetcher.js';
 import { getPathInHome } from '../lib/settings.js';
 import { NETLIFYDEVERR, NETLIFYDEVLOG, chalk, log } from './command-helpers.js';
-// @ts-expect-error TS(7034) FIXME: Variable 'execa' implicitly has type 'any' in some... Remove this comment to see the full error message
 import execa from './execa.js';
 const PACKAGE_NAME = 'live-tunnel-client';
 const EXEC_NAME = PACKAGE_NAME;
@@ -45,7 +44,6 @@ const connectTunnel = function ({ localPort, netlifyApiToken, session }) {
         args.push('-v');
         log(execPath, args);
     }
-    // @ts-expect-error TS(7005) FIXME: Variable 'execa' implicitly has an 'any' type.
     const ps = execa(execPath, args, { stdio: 'inherit' });
     // @ts-expect-error TS(7006) FIXME: Parameter 'code' implicitly has an 'any' type.
     ps.on('close', (code) => process.exit(code));

package/src/utils/lm/requirements.js

@@ -1,9 +1,7 @@
 import semver from 'semver';
-// @ts-expect-error TS(7034) FIXME: Variable 'execa' implicitly has type 'any' in some... Remove this comment to see the full error message
 import execa from '../execa.js';
 export const checkLFSFilters = async function () {
     try {
-        // @ts-expect-error TS(7005) FIXME: Variable 'execa' implicitly has an 'any' type.
         const { stdout } = await execa('git', ['config', '--get-regexp', 'filter.lfs']);
         return stdout.length !== 0;
     }
@@ -13,7 +11,6 @@ export const checkLFSFilters = async function () {
 };
 const getHelperVersion = async function () {
     try {
-        // @ts-expect-error TS(7005) FIXME: Variable 'execa' implicitly has an 'any' type.
         const { stdout } = await execa('git-credential-netlify', ['version']);
         return stdout;
     }
@@ -28,7 +25,6 @@ export const checkHelperVersion = async function () {
 };
 export const checkGitVersion = async function () {
     try {
-        // @ts-expect-error TS(7005) FIXME: Variable 'execa' implicitly has an 'any' type.
         const { stdout } = await execa('git', ['--version']);
         return stdout.split(' ').pop();
     }
@@ -38,7 +34,6 @@ export const checkGitVersion = async function () {
 };
 const getLFSVersion = async function () {
     try {
-        // @ts-expect-error TS(7005) FIXME: Variable 'execa' implicitly has an 'any' type.
         const { stdout } = await execa('git-lfs', ['version']);
         return stdout;
     }

package/src/utils/sites/utils.js

@@ -35,7 +35,6 @@ export const validateTemplate = async ({ ghToken, templateName }) => {
     const data = await response.json();
     return { exists: true, isTemplate: data.is_template };
 };
-// @ts-expect-error TS(7006) FIXME: Parameter 'templateName' implicitly has an 'any' t... Remove this comment to see the full error message
 export const createRepo = async (templateName, ghToken, siteName) => {
     const resp = await fetch(`https://api.github.com/repos/${templateName}/generate`, {
         method: 'POST',

package/src/utils/telemetry/report-error.js

@@ -3,7 +3,6 @@ import { dirname, join } from 'path';
 import process, { version as nodejsVersion } from 'process';
 import { fileURLToPath } from 'url';
 import { isCI } from 'ci-info';
-// @ts-expect-error TS(7034) FIXME: Variable 'execa' implicitly has type 'any' in some... Remove this comment to see the full error message
 import execa from '../execa.js';
 import getGlobalConfig from '../get-global-config.js';
 import { cliVersion } from './utils.js';
@@ -46,7 +45,6 @@ export const reportError = async function (error, config = {}) {
     });
     // spawn detached child process to handle send and wait for the http request to finish
     // otherwise it can get canceled
-    // @ts-expect-error TS(7005) FIXME: Variable 'execa' implicitly has an 'any' type.
     await execa(process.execPath, [join(dirPath, 'request.js'), options], {
         detached: true,
         stdio: 'ignore',

package/src/utils/telemetry/telemetry.js

@@ -2,32 +2,24 @@ import { dirname, join } from 'path';
 import process, { version as nodejsVersion } from 'process';
 import { fileURLToPath } from 'url';
 import { isCI } from 'ci-info';
-// @ts-expect-error TS(7034) FIXME: Variable 'execa' implicitly has type 'any' in some... Remove this comment to see the full error message
 import execa from '../execa.js';
 import getGlobalConfig from '../get-global-config.js';
 import { isTelemetryDisabled, cliVersion } from './utils.js';
 import isValidEventName from './validation.js';
 const dirPath = dirname(fileURLToPath(import.meta.url));
-/**
- * @param {'track' | 'identify'} type
- * @param {object} payload
- */
-// @ts-expect-error TS(7006) FIXME: Parameter 'type' implicitly has an 'any' type.
 function send(type, payload) {
     const requestFile = join(dirPath, 'request.js');
     const options = JSON.stringify({
         data: payload,
         type,
     });
-    const args = /** @type {const} */ [process.execPath, [requestFile, options]];
+    const args = [process.execPath, [requestFile, options]];
     if (process.env.NETLIFY_TEST_TELEMETRY_WAIT === 'true') {
-        // @ts-expect-error TS(7005) FIXME: Variable 'execa' implicitly has an 'any' type.
         return execa(...args, {
             stdio: 'inherit',
         });
     }
     // spawn detached child process to handle send
-    // @ts-expect-error TS(7005) FIXME: Variable 'execa' implicitly has an 'any' type.
     execa(...args, {
         detached: true,
         stdio: 'ignore',
@@ -46,10 +38,7 @@ const eventConfig = {
 };
 /**
  * Tracks a custom event with the provided payload
- * @param {string} eventName
- * @param {{status?: string, duration?: number, [key: string]: unknown}} [payload]
  */
-// @ts-expect-error TS(7006) FIXME: Parameter 'eventName' implicitly has an 'any' type... Remove this comment to see the full error message
 export async function track(eventName, payload = {}) {
     if (isCI) {
         return;
@@ -69,7 +58,6 @@ export async function track(eventName, payload = {}) {
     if (!isValid(eventName, eventConfig)) {
         return false;
     }
-    // @ts-expect-error TS(2339) FIXME: Property 'duration' does not exist on type '{}'.
     const { duration, status, ...properties } = payload;
     const defaultData = {
         event: eventName,
@@ -81,14 +69,6 @@ export async function track(eventName, payload = {}) {
     };
     return send('track', defaultData);
 }
-/**
- * @param {object} payload
- * @param {string} payload.name
- * @param {string} payload.email
- * @param {string} payload.userId
- * @returns
- */
-// @ts-expect-error TS(7006) FIXME: Parameter 'payload' implicitly has an 'any' type.
 export async function identify(payload) {
     if (isCI) {
         return;