net-snmp 3.9.6 → 3.9.8

package/.github/FUNDING.yml

@@ -0,0 +1 @@
+github: [markabrahams]

package/README.md

@@ -3301,6 +3301,14 @@ Example programs are included under the module's `example` directory.
 
  * Add type constraint support for textual conventions
 
+## Version 3.9.7 - 13/07/2023
+
+ * Add tolerance for reading malformed 32-bit unsigned integers
+
+## Version 3.9.8 - 13/01/2024
+
+ * Fix subtree callback termination
+
 # License
 
 Copyright (c) 2020 Mark Abrahams <mark@abrahams.co.nz>

package/index.js

@@ -392,6 +392,7 @@ function readUint32 (buffer) {
 	if ( ! Number.isInteger(parsedInt) ) {
 		throw new TypeError('Value read as integer ' + parsedInt + ' is not an integer');
 	}
+	parsedInt = (parsedInt>>>0);
 	if ( parsedInt < MIN_UNSIGNED_INT32 || parsedInt > MAX_UNSIGNED_INT32 ) {
 		throw new RangeError('Read integer ' + parsedInt + ' is outside the unsigned 32-bit range');
 	}
@@ -2295,8 +2296,11 @@ function subtreeCb (req, varbinds) {
 		}
 	}
 
-	if (varbinds.length > 0)
-		req.feedCb (varbinds);
+	if (varbinds.length > 0) {
+		if (req.feedCb (varbinds)) {
+			done = 1;
+		}
+	}
 
 	if (done)
 		return true;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "net-snmp",
-  "version": "3.9.6",
+  "version": "3.9.8",
   "description": "JavaScript implementation of the Simple Network Management Protocol (SNMP)",
   "main": "index.js",
   "directories": {

package/test/varbinds.js

@@ -1,43 +1,49 @@
-/* eslint-disable no-unused-expressions */
-
-var ber    = require ('asn1-ber').Ber;
-var assert = require('assert');
-var snmp   = require('../');
+const ber    = require ('asn1-ber').Ber;
+const assert = require('assert');
+const snmp   = require('../');
 
 describe('parseInt()', function() {
 	describe('given a negative integer', function() {
-		var writer = new ber.Writer();
+		const writer = new ber.Writer();
 		writer.writeInt(-3);
-		var reader = new ber.Reader(writer.buffer);
+		const reader = new ber.Reader(writer.buffer);
 		it('returns a negative integer', function() {
-			assert.equal(-3, snmp.ObjectParser.readInt(reader));
+			assert.equal(snmp.ObjectParser.readInt32(reader), -3);
 		});
-	}),
+	});
 	describe('given a positive integer', function() {
-		var writer = new ber.Writer();
+		const writer = new ber.Writer();
 		writer.writeInt(3245689);
-		var reader = new ber.Reader(writer.buffer);
+		const reader = new ber.Reader(writer.buffer);
 		it('returns a positive integer', function() {
-			assert.equal(3245689, snmp.ObjectParser.readInt(reader));
+			assert.equal(snmp.ObjectParser.readInt32(reader), 3245689);
 		});
 	});
 });
 
 describe('parseUint()', function() {
 	describe('given a positive integer', function() {
-		var writer = new ber.Writer();
+		const writer = new ber.Writer();
 		writer.writeInt(3242425);
-		var reader = new ber.Reader(writer.buffer);
+		const reader = new ber.Reader(writer.buffer);
 		it('returns a positive integer', function() {
-			assert.equal(3242425, snmp.ObjectParser.readUint(reader));
+			assert.equal(snmp.ObjectParser.readUint32(reader), 3242425);
 		});
-	}),
+	});
 	describe('given a negative integer', function() {
-		var writer = new ber.Writer();
+		const writer = new ber.Writer();
 		writer.writeInt(-3);
-		var reader = new ber.Reader(writer.buffer);
+		const reader = new ber.Reader(writer.buffer);
+		it('returns a positive integer', function() {
+			assert.equal(snmp.ObjectParser.readUint32(reader), 4294967293);
+		});
+	});
+	describe('given a large integer', function() {
+		const writer = new ber.Writer();
+		writer.writeInt(4294967294);
+		const reader = new ber.Reader(writer.buffer);
 		it('returns a positive integer', function() {
-			assert.equal(253, snmp.ObjectParser.readUint(reader));
+			assert.equal(snmp.ObjectParser.readUint32(reader), 4294967294);
 		});
 	});
 });