net-snmp 3.8.4 → 3.9.1

package/README.md

@@ -517,6 +517,14 @@ supplemental information. An authentication error, for example -- code
 `ResponseInvalidCode.EAuthFailure` -- will contain a map in `info`
 with the attempted authentication data which failed to authenticate.
 
+## snmp.ProcessingError
+
+If a receiver or an agent receives a packet it is unable to decode,
+then it will produce a `ProcessingError` containing:
+* `rinfo` information on the origin of the packet,
+* a `buffer` containing the packet contents, and
+* an `error` containing the original error encountered during processing.
+
 # Using This Module: Command & Notification Generator
 
 This library provides a `Session` class to provide support for building
@@ -3231,6 +3239,14 @@ Example programs are included under the module's `example` directory.
 
  * Fix IpAddress byte array set request handling
 
+## Version 3.9.0 - 11/12/2022
+
+ * Add ProcessingError to handle agent/receiver decode failures
+
+## Version 3.9.1 - 16/03/2023
+
+ * Fix MIB parsing of unclosed brackets in comments
+
 # License
 
 Copyright (c) 2020 Mark Abrahams <mark@abrahams.co.nz>

package/example/snmp-receiver.js

@@ -15,7 +15,8 @@ var cb = function(error, trap) {
     var now = new Date().toLocaleString();
     var trapType;
     if (error) {
-        console.log(now + ": " + error.message);
+        console.log (now + ": " + error.message);
+        console.error (error);
     } else {
         trapType = snmp.PduType[trap.pdu.type] || "Unknown";
         if ( verbose ) {

package/index.js

@@ -315,6 +315,16 @@ function RequestTimedOutError (message) {
 }
 util.inherits (RequestTimedOutError, Error);
 
+function ProcessingError (message, error, rinfo, buffer) {
+	this.name = "ProcessingError";
+	this.message = message;
+	this.error = error;
+	this.rinfo = rinfo;
+	this.buffer = buffer;
+	Error.captureStackTrace(this, ProcessingError);
+}
+util.inherits (ProcessingError, Error);
+
 /*****************************************************************************
  ** OID and varbind helper functions
  **/
@@ -3071,8 +3081,15 @@ Receiver.prototype.getAuthorizer = function () {
 };
 
 Receiver.prototype.onMsg = function (buffer, rinfo) {
-	var message = Listener.processIncoming (buffer, this.authorizer, this.callback);
-	var reportMessage;
+
+	let message;
+
+	try {
+		message = Listener.processIncoming (buffer, this.authorizer, this.callback);
+	} catch (error) {
+		this.callback (new ProcessingError ("Failure to process incoming message", error, rinfo, buffer));
+		return;
+	}
 
 	if ( ! message ) {
 		return;
@@ -3090,7 +3107,7 @@ Receiver.prototype.onMsg = function (buffer, rinfo) {
 			this.callback (new RequestInvalidError ("Only discovery GetRequests are supported and this message does not have the reportable flag set"));
 			return;
 		}
-		reportMessage = message.createReportResponseMessage (this.engine, this.context);
+		let reportMessage = message.createReportResponseMessage (this.engine, this.context);
 		this.listener.send (reportMessage, rinfo);
 		return;
 	}
@@ -4536,8 +4553,15 @@ Agent.prototype.tableRowStatusHandlerInternal = function (createRequest) {
 };
 
 Agent.prototype.onMsg = function (buffer, rinfo) {
-	var message = Listener.processIncoming (buffer, this.authorizer, this.callback);
-	var reportMessage;
+
+	let message;
+
+	try {
+		message = Listener.processIncoming (buffer, this.authorizer, this.callback);
+	} catch (error) {
+		this.callback (new ProcessingError ("Failure to process incoming message", error, rinfo, buffer));
+		return;
+	}
 
 	if ( ! message ) {
 		return;
@@ -4546,7 +4570,7 @@ Agent.prototype.onMsg = function (buffer, rinfo) {
 	// SNMPv3 discovery
 	if ( message.version == Version3 && message.pdu.type == PduType.GetRequest &&
 			! message.hasAuthoritativeEngineID() && message.isReportable () ) {
-		reportMessage = message.createReportResponseMessage (this.engine, this.context);
+		let reportMessage = message.createReportResponseMessage (this.engine, this.context);
 		this.listener.send (reportMessage, rinfo);
 		return;
 	}

package/lib/mib.js

@@ -159,10 +159,10 @@ var MIB = function (dir) {
                     }
                     break;
                 case '{':
-                    if (this.CharBuffer.isEqual) { this.CharBuffer.isOID = true; }
+                    if ( ! this.CharBuffer.isComment && this.CharBuffer.isEqual ) { this.CharBuffer.isOID = true; }
                 case '[':
                 case '(':
-                    if ( ! this.CharBuffer.isString ) {
+                    if ( ! this.CharBuffer.isComment && ! this.CharBuffer.isString ) {
                         this.CharBuffer.nested++;
                         if ( char == '(') {
                             this.CharBuffer.inGroup++;
@@ -182,7 +182,7 @@ var MIB = function (dir) {
                 case '}':
                 case ']':
                 case ')':
-                    if ( ! this.CharBuffer.isString ) {
+                    if ( ! this.CharBuffer.isComment && ! this.CharBuffer.isString ) {
                         this.CharBuffer.nested--;
                         if (this.CharBuffer.nested < 0) {
                             this.CharBuffer.nested = 0;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "net-snmp",
-  "version": "3.8.4",
+  "version": "3.9.1",
   "description": "JavaScript implementation of the Simple Network Management Protocol (SNMP)",
   "main": "index.js",
   "directories": {