net-snmp 3.5.4 → 3.5.8

package/README.md

@@ -3150,6 +3150,22 @@ Example programs are included under the module's `example` directory.
 
  * Align accessible-for-notify row cell behaviour with not-accessible behaviour
 
+## Version 3.5.5 - 29/09/2021
+
+ * Add missing return in getbulk feedCb callback non-repeaters error condition
+
+## Version 3.5.6 - 20/10/2021
+
+ * Fix GetNext OID calculation for off-tree OIDs
+
+## Version 3.5.7 - 20/11/2021
+
+ * Fix handing of null varbinds in walk
+
+## Version 3.5.8 - 24/11/2021
+
+ * Fix processing of negative integers larger than 32 bits
+
 # License
 
 Copyright (c) 2020 Mark Abrahams <mark@abrahams.co.nz>

package/index.js

@@ -427,14 +427,16 @@ function readUint (buffer, isSigned) {
 		value *= 256;
 		value += buffer.readByte ();
 
-		if (isSigned && i <= 0) {
-			if ((value & 0x80) == 0x80)
-				signedBitSet = true;
-		}
+        if (isSigned && i <= 0) {
+            if ((value & 0x80) == 0x80) {
+                signedBitSet = true;
+            }
+        }
 	}
 	
-	if (signedBitSet)
-		value -= (1 << (i * 8));
+    if (signedBitSet) {
+        value -= 2 ** (i * 8);
+    }
 
 	return value;
 }
@@ -1923,6 +1925,7 @@ Session.prototype.getBulk = function () {
 					+ "response '" + pdu.varbinds.length + "' is less than "
 					+ "non-repeaters '" + nonRepeaters + "' in request",
 					ResponseInvalidCode.ENonRepeaterCountMismatch));
+			return;
 		} else {
 			for ( ; i < nonRepeaters; i++) {
 				if (isVarbindError (pdu.varbinds[i])) {
@@ -2641,7 +2644,7 @@ function walkCb (req, error, varbinds) {
 		}
 	}
 
-	if ( ! varbinds.length ) {
+	if ( ! varbinds || ! varbinds.length ) {
 		req.doneCb(null);
 		return;
 	}
@@ -3491,7 +3494,7 @@ MibNode.prototype.findChildImmediatelyBefore = function (index) {
 			}
 		}
 	}
-	return this.children[sortedChildrenKeys[sortedChildrenKeys.length]];
+	return this.children[sortedChildrenKeys[sortedChildrenKeys.length - 1]];
 };
 
 MibNode.prototype.isDescendant = function (address) {
@@ -3823,7 +3826,16 @@ Mib.prototype.getTreeNode = function (oid) {
 		var last = address.pop ();
 		var parent = this.lookupAddress (address);
 		if ( parent ) {
-			return (parent.findChildImmediatelyBefore (last) || parent);
+			node = parent.findChildImmediatelyBefore (last);
+			if ( !node )
+				return parent;
+			while ( true ) {
+				// Find the last descendant
+				var childrenAddresses = Object.keys (node.children).sort ( (a, b) => a - b);
+				if ( childrenAddresses.length == 0 )
+					return node;
+				node = node.children[childrenAddresses[childrenAddresses.length - 1]];
+			}
 		}
 	}
 	return this.root;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "net-snmp",
-  "version": "3.5.4",
+  "version": "3.5.8",
   "description": "JavaScript implementation of the Simple Network Management Protocol (SNMP)",
   "main": "index.js",
   "directories": {