net-snmp 3.19.0 → 3.19.2

package/README.md

@@ -3465,6 +3465,14 @@ Example programs are included under the module's `example` directory.
 
  * Remove deprecated isArray call and fix agent string constraints check
 
+## Version 3.19.1 - 03/03/2025
+
+ * Fix integer constraints check
+
+# Version 3.19.2 - 06/03/2025
+
+ * Fix integer and string constraints check on cast
+
 # License
 
 Copyright (c) 2020 Mark Abrahams <mark@abrahams.co.nz>

package/index.js

@@ -604,7 +604,7 @@ ObjectTypeUtil.castSetValue = function (type, value, constraints) {
 			if ( isNaN(parsedValue) ) {
 				throw new Error("Invalid Integer", value);
 			}
-			if ( constraints && ObjectTypeUtil.doesIntegerMeetConstraints (parsedValue, constraints) ) {
+			if ( constraints && ! ObjectTypeUtil.doesIntegerMeetConstraints (parsedValue, constraints) ) {
 				throw new Error("Integer does not meet constraints", value);
 			}
 			return parsedValue;
@@ -614,7 +614,7 @@ ObjectTypeUtil.castSetValue = function (type, value, constraints) {
 			if ( ! value instanceof Buffer && typeof value != "string" ) {
 				throw new Error("Invalid OctetString", value);
 			}
-			if ( constraints && ObjectTypeUtil.doesStringMeetConstraints (value, constraints) ) {
+			if ( constraints && ! ObjectTypeUtil.doesStringMeetConstraints (value, constraints) ) {
 				throw new Error("OctetString does not meet constraints", value);
 			}
 			if ( value instanceof Buffer ) {
@@ -672,7 +672,7 @@ ObjectTypeUtil.isValid = function (type, value, constraints) {
 			if ( isNaN(parsedValue) || ! Number.isInteger(parsedValue) || parsedValue < MIN_SIGNED_INT32 || parsedValue > MAX_SIGNED_INT32 ) {
 				return false;
 			}
-			if ( constraints && ObjectTypeUtil.doesIntegerMeetConstraints (parsedValue, constraints) ) {
+			if ( constraints && ! ObjectTypeUtil.doesIntegerMeetConstraints (parsedValue, constraints) ) {
 				return false;
 			}
 			return true;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "net-snmp",
-  "version": "3.19.0",
+  "version": "3.19.2",
   "description": "JavaScript implementation of the Simple Network Management Protocol (SNMP)",
   "main": "index.js",
   "directories": {

package/test/object-types.test.js

@@ -72,6 +72,17 @@ describe('Object Types', function() {
 				assert.equal(snmp.ObjectTypeUtil.isValid(snmp.ObjectType.Integer, 2147483648), false);
 			});
 		});
+		// Tests for constraints
+		describe('An integer at the bottom of the valid range is a valid Integer type', function() {
+			it('returns true', function() {
+				assert.equal(snmp.ObjectTypeUtil.isValid(snmp.ObjectType.Integer, 0, { ranges: [{ min: 0, max: 10 }] }), true);
+			});
+		});
+		describe('An integer outside the valid range is not an valid Integer type', function() {
+			it('returns false', function() {
+				assert.equal(snmp.ObjectTypeUtil.isValid(snmp.ObjectType.Integer, 11, { ranges: [{ min: 0, max: 10 }] }), false);
+			});
+		});
 	});
 
 	describe('isValid() - OctetString', function() {