net-snmp 3.14.1 → 3.15.1

package/README.md

@@ -3412,6 +3412,14 @@ Example programs are included under the module's `example` directory.
 
  * Add RFC-1215 to base MIB modules to provide TRAP-TYPE macro
 
+## Version 3.15.0 - 14/09/2024
+
+ * Change return of undefined or null MIB values to NoSuchInstance
+
+## Version 3.15.1 - 12/10/2024
+
+ * Fix bundler failure due to unnecessary string length assignment
+
 # License
 
 Copyright (c) 2020 Mark Abrahams <mark@abrahams.co.nz>

package/index.js

@@ -3771,17 +3771,16 @@ MibNode.prototype.getNextInstanceNode = function () {
 	var childrenAddresses;
 
 	var node = this;
-	if ( this.value != null ) {
-		// Need upwards traversal first
-		node = this;
+	// If we start on a leaf node, we need next (right) sibling or upwards traversal first
+	if ( ! node.children || Object.keys (node.children).length === 0 ) {
 		while ( node ) {
 			siblingIndex = node.address.slice(-1)[0];
 			node = node.parent;
 			if ( ! node ) {
-				// end of MIB
+				// End of MIB
 				return null;
 			} else {
-				// Move to next sibling
+				// Move to next sibling if we are not last child
 				childrenAddresses = Object.keys (node.children).sort ( (a, b) => a - b);
 				var siblingPosition = childrenAddresses.indexOf(siblingIndex.toString());
 				if ( siblingPosition + 1 < childrenAddresses.length ) {
@@ -3792,7 +3791,8 @@ MibNode.prototype.getNextInstanceNode = function () {
 		}
 	}
 	while ( node ) {
-		if ( node.value != null ) {
+		// Return if at leaf
+		if ( ! node.children || Object.keys (node.children).length === 0 ) {
 			return node;
 		}
 		// Descend to first child if not at leaf
@@ -5215,6 +5215,9 @@ Agent.prototype.request = function (socket, requestMessage, rinfo) {
 						responseVarbind.type = mibRequests[savedIndex].instanceNode.valueType;
 					}
 					responseVarbind.value = mibRequests[savedIndex].instanceNode.value;
+					if ( responseVarbind.value === undefined || responseVarbind.value === null ) {
+						responseVarbind.type = ObjectType.NoSuchInstance;
+					}
 				}
 				if ( providerNode && providerNode.provider && providerNode.provider.name ) {
 					responseVarbind.providerName = providerNode.provider.name;

package/lib/mib.js

@@ -48,14 +48,12 @@ var MIB = function (dir) {
                 column = (column - this.builder.length);
                 var symbol = this.builder.toString().trim();
                 this.builder = "";
-                this.builder.length = 0;
                 if (!this.Table[FileName]) {
                     this.Table[FileName] = [];
                 } else if (this.PreviousRow < row) {
                     this.RowIndex++;
                     this.ColumnIndex = 0;
                     this.PreviousRow = row;
-
                 }
                 var R = this.RowIndex;
                 var C = this.ColumnIndex;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "net-snmp",
-  "version": "3.14.1",
+  "version": "3.15.1",
   "description": "JavaScript implementation of the Simple Network Management Protocol (SNMP)",
   "main": "index.js",
   "directories": {