nestjs-doctor 0.3.2 → 0.4.1

package/README.md

@@ -13,7 +13,7 @@
 </p>
 
 <p align="center">
-  45 built-in rules across <b>security</b>, <b>performance</b>, <b>correctness</b>, and <b>architecture</b>. Outputs a <b>0-100 score</b> with actionable diagnostics. Zero config. Monorepo support. Built to catch the anti-patterns that AI-generated code loves to introduce.
+  42 built-in rules across <b>security</b>, <b>performance</b>, <b>correctness</b>, and <b>architecture</b>. Outputs a <b>0-100 score</b> with actionable diagnostics. Zero config. Monorepo support. Built to catch the anti-patterns that AI-generated code loves to introduce.
 </p>
 
 ---
@@ -153,8 +153,6 @@ Optional. Create `nestjs-doctor.config.json` in your project root:
     "performance": false
   },
   "thresholds": {
-    "godModuleProviders": 15,
-    "godModuleImports": 20,
     "godServiceMethods": 12,
     "godServiceDeps": 10
   }
@@ -166,13 +164,13 @@ Or use a `"nestjs-doctor"` key in `package.json`.
 | Key | Type | Description |
 |-----|------|-------------|
 | `include` | `string[]` | Glob patterns to scan (default: `["**/*.ts"]`) |
-| `exclude` | `string[]` | Glob patterns to skip (default includes `node_modules`, `dist`, `build`, `coverage`, `*.spec.ts`, `*.test.ts`, `*.e2e-spec.ts`, `*.e2e-test.ts`, `*.d.ts`, `test/`, `tests/`, `__tests__/`, `__mocks__/`, `__fixtures__/`) |
+| `exclude` | `string[]` | Glob patterns to skip (default includes `node_modules`, `dist`, `build`, `coverage`, `*.spec.ts`, `*.test.ts`, `*.e2e-spec.ts`, `*.e2e-test.ts`, `*.d.ts`, `test/`, `tests/`, `__tests__/`, `__mocks__/`, `__fixtures__/`, `mock/`, `mocks/`, `*.mock.ts`, `seeder/`, `seeders/`, `*.seed.ts`, `*.seeder.ts`) |
 | `minScore` | `number` | Minimum passing score (0-100). Exits with code 1 if below threshold |
 | `ignore.rules` | `string[]` | Rule IDs to suppress |
 | `ignore.files` | `string[]` | Glob patterns for files whose diagnostics are hidden |
 | `rules` | `Record<string, boolean>` | Enable/disable individual rules |
 | `categories` | `Record<string, boolean>` | Enable/disable entire categories |
-| `thresholds` | `object` | Customize limits for god-module / god-service rules |
+| `thresholds` | `object` | Customize limits for god-service rules |
 
 ---
 
@@ -234,7 +232,7 @@ mono.combined;      // Merged DiagnoseResult
 
 ---
 
-## Rules (45)
+## Rules (42)
 
 ### Security (9)
 
@@ -250,7 +248,7 @@ mono.combined;      // Merged DiagnoseResult
 | `no-exposed-stack-trace` | warning | `error.stack` exposed in responses |
 | `require-auth-guard` | info | Controller without `@UseGuards()` |
 
-### Correctness (13)
+### Correctness (14)
 
 | Rule | Severity | What it catches |
 |------|----------|-----------------|
@@ -264,11 +262,12 @@ mono.combined;      // Merged DiagnoseResult
 | `prefer-readonly-injection` | warning | Constructor DI params missing `readonly` |
 | `require-lifecycle-interface` | warning | Lifecycle method without corresponding interface |
 | `no-empty-handlers` | warning | HTTP handler with empty body |
-| `no-async-without-await` | warning | Async function/method with no `await` |
+| `no-async-without-await` | warning | Async function/method with no `await` or redundant `async` on `new Promise()` return |
+| `prefer-await-in-handlers` | warning | Async HTTP handler missing await — risks broken exception filters and lost stack traces |
 | `no-duplicate-module-metadata` | warning | Duplicate entries in `@Module()` arrays |
 | `no-missing-module-decorator` | warning | Class named `*Module` without `@Module()` |
 
-### Architecture (13)
+### Architecture (12)
 
 | Rule | Severity | What it catches |
 |------|----------|-----------------|
@@ -278,7 +277,6 @@ mono.combined;      // Merged DiagnoseResult
 | `no-circular-module-deps` | error | Cycles in `@Module()` import graph |
 | `no-manual-instantiation` | error | `new SomeService()` for injectable classes |
 | `no-orm-in-services` | warning | Services using ORM directly (should use repositories) |
-| `no-god-module` | warning | >10 providers or >15 imports |
 | `no-god-service` | warning | >10 public methods or >8 dependencies |
 | `require-feature-modules` | warning | AppModule declaring too many providers directly |
 | `prefer-constructor-injection` | warning | `@Inject()` property injection |
@@ -286,18 +284,15 @@ mono.combined;      // Merged DiagnoseResult
 | `prefer-interface-injection` | info | Concrete service-to-service injection |
 | `no-barrel-export-internals` | info | Re-exporting repositories from barrel files |
 
-### Performance (10)
+### Performance (7)
 
 | Rule | Severity | What it catches |
 |------|----------|-----------------|
 | `no-sync-io` | warning | `readFileSync`, `writeFileSync`, etc. |
-| `no-query-in-loop` | warning | `await` inside loops (N+1 pattern) |
 | `no-blocking-constructor` | warning | Loops/await in Injectable/Controller constructors |
 | `no-dynamic-require` | warning | `require()` with non-literal argument |
 | `no-unused-providers` | warning | Provider never injected anywhere |
-| `no-logging-in-loops` | info | `console.*` / `this.logger.*` in loops |
 | `no-unnecessary-async` | info | Async method with no `await` |
-| `prefer-pagination` | info | `findMany()` / `find()` without pagination args |
 | `no-unused-module-exports` | info | Module exports unused by importers |
 | `no-orphan-modules` | info | Module never imported by any other module |
 

package/dist/api/index.cjs

@@ -220,7 +220,8 @@ function resolveProviders(project, files) {
 			if (!name) continue;
 			const ctor = cls.getConstructors()[0];
 			const dependencies = ctor ? ctor.getParameters().map((p) => {
-				return extractSimpleTypeName(p.getType().getText());
+				const typeNode = p.getTypeNode();
+				return extractSimpleTypeName(typeNode ? typeNode.getText() : p.getType().getText());
 			}) : [];
 			const publicMethodCount = cls.getMethods().filter((m) => {
 				const scope = m.getScope();
@@ -309,7 +310,7 @@ function isModule(cls) {
 
 //#endregion
 //#region src/rules/architecture/no-business-logic-in-controllers.ts
-const HTTP_DECORATORS$1 = new Set([
+const HTTP_DECORATORS$3 = new Set([
 	"Get",
 	"Post",
 	"Put",
@@ -331,7 +332,7 @@ const noBusinessLogicInControllers = {
 		for (const cls of context.sourceFile.getClasses()) {
 			if (!isController(cls)) continue;
 			for (const method of cls.getMethods()) {
-				if (!method.getDecorators().some((d) => HTTP_DECORATORS$1.has(d.getName()))) continue;
+				if (!method.getDecorators().some((d) => HTTP_DECORATORS$3.has(d.getName()))) continue;
 				const body = method.getBody();
 				if (!body) continue;
 				const ifStatements = body.getDescendantsOfKind(ts_morph.SyntaxKind.IfStatement);
@@ -395,41 +396,6 @@ const noCircularModuleDeps = {
 	}
 };
 
-//#endregion
-//#region src/rules/architecture/no-god-module.ts
-const DEFAULT_MAX_PROVIDERS = 10;
-const DEFAULT_MAX_IMPORTS = 15;
-const noGodModule = {
-	meta: {
-		id: "architecture/no-god-module",
-		category: "architecture",
-		severity: "warning",
-		description: "Modules with too many providers or imports should be split into smaller feature modules",
-		help: "Split this module into smaller, focused feature modules.",
-		scope: "project"
-	},
-	check(context) {
-		const maxProviders = context.config.thresholds?.godModuleProviders ?? DEFAULT_MAX_PROVIDERS;
-		const maxImports = context.config.thresholds?.godModuleImports ?? DEFAULT_MAX_IMPORTS;
-		for (const mod of context.moduleGraph.modules.values()) {
-			if (mod.providers.length > maxProviders) context.report({
-				filePath: mod.filePath,
-				message: `Module '${mod.name}' has ${mod.providers.length} providers (max: ${maxProviders}). Consider splitting into smaller modules.`,
-				help: this.meta.help,
-				line: mod.classDeclaration.getStartLineNumber(),
-				column: 1
-			});
-			if (mod.imports.length > maxImports) context.report({
-				filePath: mod.filePath,
-				message: `Module '${mod.name}' has ${mod.imports.length} imports (max: ${maxImports}). Consider grouping into feature modules.`,
-				help: this.meta.help,
-				line: mod.classDeclaration.getStartLineNumber(),
-				column: 1
-			});
-		}
-	}
-};
-
 //#endregion
 //#region src/rules/architecture/no-god-service.ts
 const DEFAULT_MAX_METHODS = 10;
@@ -812,6 +778,23 @@ const requireModuleBoundaries = {
 
 //#endregion
 //#region src/rules/correctness/no-async-without-await.ts
+const HTTP_DECORATORS$2 = new Set([
+	"Get",
+	"Post",
+	"Put",
+	"Delete",
+	"Patch",
+	"All",
+	"Head",
+	"Options"
+]);
+function returnsNewPromise$1(body) {
+	return body.getDescendantsOfKind(ts_morph.SyntaxKind.ReturnStatement).some((ret) => {
+		const expr = ret.getExpression();
+		if (!expr || expr.getKind() !== ts_morph.SyntaxKind.NewExpression) return false;
+		return expr.asKindOrThrow(ts_morph.SyntaxKind.NewExpression).getExpression().getText() === "Promise";
+	});
+}
 const noAsyncWithoutAwait = {
 	meta: {
 		id: "correctness/no-async-without-await",
@@ -823,6 +806,9 @@ const noAsyncWithoutAwait = {
 	check(context) {
 		for (const cls of context.sourceFile.getClasses()) for (const method of cls.getMethods()) {
 			if (!method.isAsync()) continue;
+			if (isController(cls)) {
+				if (method.getDecorators().some((d) => HTTP_DECORATORS$2.has(d.getName()))) continue;
+			}
 			const body = method.getBody();
 			if (!body) continue;
 			if (body.getDescendantsOfKind(ts_morph.SyntaxKind.AwaitExpression).filter((expr) => {
@@ -832,13 +818,23 @@ const noAsyncWithoutAwait = {
 					parent = parent.getParent();
 				}
 				return true;
-			}).length === 0) context.report({
-				filePath: context.filePath,
-				message: `Async method '${method.getName()}()' has no await expression.`,
-				help: this.meta.help,
-				line: method.getStartLineNumber(),
-				column: 1
-			});
+			}).length === 0) {
+				const name = method.getName();
+				if (returnsNewPromise$1(body)) context.report({
+					filePath: context.filePath,
+					message: `Async method '${name}()' returns a Promise directly — remove the async keyword.`,
+					help: "The async keyword is unnecessary when you are already constructing a Promise manually. Remove async to avoid double-wrapping.",
+					line: method.getStartLineNumber(),
+					column: 1
+				});
+				else context.report({
+					filePath: context.filePath,
+					message: `Async method '${name}()' has no await expression.`,
+					help: this.meta.help,
+					line: method.getStartLineNumber(),
+					column: 1
+				});
+			}
 		}
 		for (const fn of context.sourceFile.getFunctions()) {
 			if (!fn.isAsync()) continue;
@@ -851,13 +847,23 @@ const noAsyncWithoutAwait = {
 					parent = parent.getParent();
 				}
 				return true;
-			}).length === 0) context.report({
-				filePath: context.filePath,
-				message: `Async function '${fn.getName() ?? "anonymous"}()' has no await expression.`,
-				help: this.meta.help,
-				line: fn.getStartLineNumber(),
-				column: 1
-			});
+			}).length === 0) {
+				const name = fn.getName() ?? "anonymous";
+				if (returnsNewPromise$1(body)) context.report({
+					filePath: context.filePath,
+					message: `Async function '${name}()' returns a Promise directly — remove the async keyword.`,
+					help: "The async keyword is unnecessary when you are already constructing a Promise manually. Remove async to avoid double-wrapping.",
+					line: fn.getStartLineNumber(),
+					column: 1
+				});
+				else context.report({
+					filePath: context.filePath,
+					message: `Async function '${name}()' has no await expression.`,
+					help: this.meta.help,
+					line: fn.getStartLineNumber(),
+					column: 1
+				});
+			}
 		}
 	}
 };
@@ -956,7 +962,7 @@ const noDuplicateRoutes = {
 
 //#endregion
 //#region src/rules/correctness/no-empty-handlers.ts
-const HTTP_DECORATORS = new Set([
+const HTTP_DECORATORS$1 = new Set([
 	"Get",
 	"Post",
 	"Put",
@@ -978,7 +984,7 @@ const noEmptyHandlers = {
 		for (const cls of context.sourceFile.getClasses()) {
 			if (!isController(cls)) continue;
 			for (const method of cls.getMethods()) {
-				if (!method.getDecorators().some((d) => HTTP_DECORATORS.has(d.getName()))) continue;
+				if (!method.getDecorators().some((d) => HTTP_DECORATORS$1.has(d.getName()))) continue;
 				const body = method.getBody();
 				if (!body) continue;
 				if (body.getStatements().length === 0) context.report({
@@ -1169,6 +1175,69 @@ const noMissingPipeMethod = {
 	}
 };
 
+//#endregion
+//#region src/rules/correctness/prefer-await-in-handlers.ts
+const HTTP_DECORATORS = new Set([
+	"Get",
+	"Post",
+	"Put",
+	"Delete",
+	"Patch",
+	"All",
+	"Head",
+	"Options"
+]);
+function returnsNewPromise(body) {
+	return body.getDescendantsOfKind(ts_morph.SyntaxKind.ReturnStatement).some((ret) => {
+		const expr = ret.getExpression();
+		if (!expr || expr.getKind() !== ts_morph.SyntaxKind.NewExpression) return false;
+		return expr.asKindOrThrow(ts_morph.SyntaxKind.NewExpression).getExpression().getText() === "Promise";
+	});
+}
+const preferAwaitInHandlers = {
+	meta: {
+		id: "correctness/prefer-await-in-handlers",
+		category: "correctness",
+		severity: "warning",
+		description: "Async HTTP handler missing await — risks broken exception filters and lost stack traces",
+		help: "Add await when calling services. This ensures exception filters trigger correctly, stack traces point to the handler, and error handling is consistent across handlers."
+	},
+	check(context) {
+		for (const cls of context.sourceFile.getClasses()) {
+			if (!isController(cls)) continue;
+			for (const method of cls.getMethods()) {
+				if (!(method.getDecorators().some((d) => HTTP_DECORATORS.has(d.getName())) && method.isAsync())) continue;
+				const body = method.getBody();
+				if (!body) continue;
+				if (body.getDescendantsOfKind(ts_morph.SyntaxKind.AwaitExpression).filter((expr) => {
+					let parent = expr.getParent();
+					while (parent && parent !== body) {
+						if (parent.getKind() === ts_morph.SyntaxKind.ArrowFunction || parent.getKind() === ts_morph.SyntaxKind.FunctionExpression || parent.getKind() === ts_morph.SyntaxKind.FunctionDeclaration) return false;
+						parent = parent.getParent();
+					}
+					return true;
+				}).length === 0) {
+					const name = method.getName();
+					if (returnsNewPromise(body)) context.report({
+						filePath: context.filePath,
+						message: `Handler '${name}()' returns a Promise directly — remove async and return the promise, or await the resolved value.`,
+						help: this.meta.help,
+						line: method.getStartLineNumber(),
+						column: 1
+					});
+					else context.report({
+						filePath: context.filePath,
+						message: `Async handler '${name}()' does not await any expression.`,
+						help: this.meta.help,
+						line: method.getStartLineNumber(),
+						column: 1
+					});
+				}
+			}
+		}
+	}
+};
+
 //#endregion
 //#region src/rules/correctness/prefer-readonly-injection.ts
 const preferReadonlyInjection = {
@@ -1334,56 +1403,6 @@ const noDynamicRequire = {
 	}
 };
 
-//#endregion
-//#region src/rules/performance/no-logging-in-loops.ts
-const LOOP_KINDS$1 = new Set([
-	ts_morph.SyntaxKind.ForStatement,
-	ts_morph.SyntaxKind.ForOfStatement,
-	ts_morph.SyntaxKind.ForInStatement,
-	ts_morph.SyntaxKind.WhileStatement,
-	ts_morph.SyntaxKind.DoStatement
-]);
-const CONSOLE_METHODS = new Set([
-	"log",
-	"warn",
-	"error",
-	"info",
-	"debug",
-	"trace"
-]);
-const noLoggingInLoops = {
-	meta: {
-		id: "performance/no-logging-in-loops",
-		category: "performance",
-		severity: "info",
-		description: "Logging inside loops can degrade performance and flood log output",
-		help: "Move logging outside the loop, aggregate results, or use conditional logging."
-	},
-	check(context) {
-		const callExpressions = context.sourceFile.getDescendantsOfKind(ts_morph.SyntaxKind.CallExpression);
-		for (const call of callExpressions) {
-			const exprText = call.getExpression().getText();
-			const isConsoleCall = exprText.startsWith("console.") && CONSOLE_METHODS.has(exprText.split(".")[1]);
-			const isLoggerCall = exprText.startsWith("this.logger.") && CONSOLE_METHODS.has(exprText.split(".")[2]);
-			if (!(isConsoleCall || isLoggerCall)) continue;
-			let parent = call.getParent();
-			while (parent) {
-				if (LOOP_KINDS$1.has(parent.getKind())) {
-					context.report({
-						filePath: context.filePath,
-						message: `Logging call '${exprText}()' inside a loop.`,
-						help: this.meta.help,
-						line: call.getStartLineNumber(),
-						column: 1
-					});
-					break;
-				}
-				parent = parent.getParent();
-			}
-		}
-	}
-};
-
 //#endregion
 //#region src/rules/performance/no-orphan-modules.ts
 const noOrphanModules = {
@@ -1411,44 +1430,6 @@ const noOrphanModules = {
 	}
 };
 
-//#endregion
-//#region src/rules/performance/no-query-in-loop.ts
-const LOOP_KINDS = new Set([
-	ts_morph.SyntaxKind.ForStatement,
-	ts_morph.SyntaxKind.ForOfStatement,
-	ts_morph.SyntaxKind.ForInStatement,
-	ts_morph.SyntaxKind.WhileStatement,
-	ts_morph.SyntaxKind.DoStatement
-]);
-const noQueryInLoop = {
-	meta: {
-		id: "performance/no-query-in-loop",
-		category: "performance",
-		severity: "warning",
-		description: "Await expressions inside loops cause N+1 query patterns — batch or parallelize instead",
-		help: "Use Promise.all(), batch queries, or database-level operations (e.g., WHERE IN) instead of awaiting in a loop."
-	},
-	check(context) {
-		const awaitExpressions = context.sourceFile.getDescendantsOfKind(ts_morph.SyntaxKind.AwaitExpression);
-		for (const awaitExpr of awaitExpressions) {
-			let parent = awaitExpr.getParent();
-			while (parent) {
-				if (LOOP_KINDS.has(parent.getKind())) {
-					context.report({
-						filePath: context.filePath,
-						message: "Await expression inside a loop — potential N+1 query pattern.",
-						help: this.meta.help,
-						line: awaitExpr.getStartLineNumber(),
-						column: 1
-					});
-					break;
-				}
-				parent = parent.getParent();
-			}
-		}
-	}
-};
-
 //#endregion
 //#region src/rules/performance/no-sync-io.ts
 const SYNC_IO_METHODS = new Set([
@@ -1550,6 +1531,7 @@ const noUnusedModuleExports = {
 					if (!provider) continue;
 					for (const dep of provider.dependencies) usedProviders.add(dep);
 				}
+				if (importer.exports.includes(mod.name)) for (const exp of mod.exports) usedProviders.add(exp);
 				for (const controllerName of importer.controllers) for (const filePath of context.files) {
 					const sourceFile = context.project.getSourceFile(filePath);
 					if (!sourceFile) continue;
@@ -1558,20 +1540,24 @@ const noUnusedModuleExports = {
 						const ctor = cls.getConstructors()[0];
 						if (!ctor) continue;
 						for (const param of ctor.getParameters()) {
-							const typeText = param.getType().getText();
+							const typeNode = param.getTypeNode();
+							const typeText = typeNode ? typeNode.getText() : param.getType().getText();
 							const simpleName = typeText.split(".").pop()?.split("<")[0] ?? typeText;
 							usedProviders.add(simpleName);
 						}
 					}
 				}
 			}
-			for (const exportedName of mod.exports) if (!usedProviders.has(exportedName)) context.report({
-				filePath: mod.filePath,
-				message: `Module '${mod.name}' exports '${exportedName}' but no importing module uses it.`,
-				help: this.meta.help,
-				line: mod.classDeclaration.getStartLineNumber(),
-				column: 1
-			});
+			for (const exportedName of mod.exports) {
+				if (context.moduleGraph.modules.has(exportedName)) continue;
+				if (!usedProviders.has(exportedName)) context.report({
+					filePath: mod.filePath,
+					message: `Module '${mod.name}' exports '${exportedName}' but no importing module uses it.`,
+					help: this.meta.help,
+					line: mod.classDeclaration.getStartLineNumber(),
+					column: 1
+				});
+			}
 		}
 	}
 };
@@ -1605,7 +1591,8 @@ const noUnusedProviders = {
 				const ctor = cls.getConstructors()[0];
 				if (!ctor) continue;
 				for (const param of ctor.getParameters()) {
-					const typeText = param.getType().getText();
+					const typeNode = param.getTypeNode();
+					const typeText = typeNode ? typeNode.getText() : param.getType().getText();
 					const simpleName = typeText.split(".").pop()?.split("<")[0] ?? typeText;
 					allDependencies.add(simpleName);
 				}
@@ -1632,57 +1619,6 @@ const noUnusedProviders = {
 	}
 };
 
-//#endregion
-//#region src/rules/performance/prefer-pagination.ts
-const FIND_MANY_METHODS = new Set(["findMany", "find"]);
-const PAGINATION_ARGS = new Set([
-	"take",
-	"skip",
-	"limit",
-	"offset",
-	"page",
-	"perPage",
-	"pageSize"
-]);
-const preferPagination = {
-	meta: {
-		id: "performance/prefer-pagination",
-		category: "performance",
-		severity: "info",
-		description: "Database findMany/find queries should include pagination to avoid loading excessive data",
-		help: "Add pagination arguments (take/skip, limit/offset) to the query."
-	},
-	check(context) {
-		const callExpressions = context.sourceFile.getDescendantsOfKind(ts_morph.SyntaxKind.CallExpression);
-		for (const call of callExpressions) {
-			const methodName = call.getExpression().getText().split(".").pop() ?? "";
-			if (!FIND_MANY_METHODS.has(methodName)) continue;
-			const args = call.getArguments();
-			if (args.length === 0) {
-				context.report({
-					filePath: context.filePath,
-					message: `'${methodName}()' called without pagination arguments.`,
-					help: this.meta.help,
-					line: call.getStartLineNumber(),
-					column: 1
-				});
-				continue;
-			}
-			const firstArg = args[0];
-			if (firstArg.getKind() !== ts_morph.SyntaxKind.ObjectLiteralExpression) continue;
-			const obj = firstArg.asKind(ts_morph.SyntaxKind.ObjectLiteralExpression);
-			if (!obj) continue;
-			if (!obj.getProperties().map((p) => p.getText().split(":")[0].trim()).some((p) => PAGINATION_ARGS.has(p))) context.report({
-				filePath: context.filePath,
-				message: `'${methodName}()' called without pagination arguments.`,
-				help: this.meta.help,
-				line: call.getStartLineNumber(),
-				column: 1
-			});
-		}
-	}
-};
-
 //#endregion
 //#region src/rules/security/no-csrf-disabled.ts
 const noCsrfDisabled = {
@@ -2075,7 +2011,6 @@ const allRules = [
 	requireModuleBoundaries,
 	noBarrelExportInternals,
 	noCircularModuleDeps,
-	noGodModule,
 	noGodService,
 	requireFeatureModules,
 	preferReadonlyInjection,
@@ -2087,6 +2022,7 @@ const allRules = [
 	noMissingFilterCatch,
 	noMissingInterceptorMethod,
 	noAsyncWithoutAwait,
+	preferAwaitInHandlers,
 	noDuplicateModuleMetadata,
 	noMissingModuleDecorator,
 	requireInjectDecorator,
@@ -2101,11 +2037,8 @@ const allRules = [
 	noExposedStackTrace,
 	noDangerousRedirects,
 	noSyncIo,
-	noQueryInLoop,
-	noLoggingInLoops,
 	noUnnecessaryAsync,
 	noBlockingConstructor,
-	preferPagination,
 	noDynamicRequire,
 	noUnusedProviders,
 	noUnusedModuleExports,
@@ -2198,7 +2131,14 @@ const DEFAULT_CONFIG = {
 		"**/tests/**",
 		"**/__tests__/**",
 		"**/__mocks__/**",
-		"**/__fixtures__/**"
+		"**/__fixtures__/**",
+		"**/mock/**",
+		"**/mocks/**",
+		"**/*.mock.ts",
+		"**/seeder/**",
+		"**/seeders/**",
+		"**/*.seed.ts",
+		"**/*.seeder.ts"
 	]
 };
 

package/dist/api/index.d.cts

@@ -56,8 +56,6 @@ interface NestjsDoctorConfig {
   minScore?: number;
   rules?: Record<string, RuleOverride | boolean>;
   thresholds?: {
-    godModuleProviders?: number;
-    godModuleImports?: number;
     godServiceMethods?: number;
     godServiceDeps?: number;
   };

package/dist/api/index.d.cts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.cts","names":[],"sources":["../../src/engine/module-graph.ts","../../src/engine/type-resolver.ts","../../src/types/diagnostic.ts","../../src/types/config.ts","../../src/rules/types.ts","../../src/rules/index.ts","../../src/types/errors.ts","../../src/types/result.ts","../../src/api/index.ts"],"mappings":";;;UASiB,UAAA;EAChB,gBAAA,EAAkB,gBAAA;EAClB,WAAA;EACA,OAAA;EACA,QAAA;EACA,OAAA;EACA,IAAA;EACA,SAAA;AAAA;AAAA,UAGgB,WAAA;EAChB,KAAA,EAAO,GAAA,SAAY,GAAA;EACnB,OAAA,EAAS,GAAA,SAAY,UAAA;EACrB,gBAAA,EAAkB,GAAA,SAAY,UAAA;AAAA;;;UCjBd,YAAA;EAChB,gBAAA,EAAkB,gBAAA;EAClB,YAAA;EACA,QAAA;EACA,IAAA;EACA,iBAAA;AAAA;;;KCVW,QAAA;AAAA,KACA,QAAA;AAAA,UAMK,UAAA;EAChB,QAAA,EAAU,QAAA;EACV,MAAA;EACA,QAAA;EACA,IAAA;EACA,IAAA;EACA,OAAA;EACA,IAAA;EACA,QAAA,EAAU,QAAA;AAAA;;;UCbM,YAAA;EAChB,OAAA;EACA,QAAA,GAAW,QAAA;AAAA;AAAA,UAGK,wBAAA;EAChB,KAAA;EACA,KAAA;AAAA;AAAA,UAGgB,kBAAA;EAChB,UAAA,GAAa,OAAA,CAAQ,MAAA,CAAO,QAAA;EAC5B,OAAA;EACA,MAAA,GAAS,wBAAA;EACT,OAAA;EACA,QAAA;EACA,KAAA,GAAQ,MAAA,SAAe,YAAA;EACvB,UAAA;IACC,kBAAA;IACA,gBAAA;IACA,iBAAA;IACA,cAAA;EAAA;AAAA;;;KCjBU,SAAA;AAAA,UAEK,QAAA;EAChB,QAAA,EAAU,QAAA;EACV,WAAA;EACA,IAAA;EACA,EAAA;EACA,KAAA,GAAQ,SAAA;EACR,QAAA,EAAU,QAAA;AAAA;AAAA,UAGM,WAAA;EAChB,QAAA;EACA,MAAA,CAAO,UAAA,EAAY,IAAA,CAAK,UAAA;EACxB,UAAA,EAAY,UAAA;AAAA;AAAA,UAGI,kBAAA;EAChB,MAAA,EAAQ,kBAAA;EACR,KAAA;EACA,WAAA,EAAa,WAAA;EACb,OAAA,EAAS,OAAA;EACT,SAAA,EAAW,GAAA,SAAY,YAAA;EACvB,MAAA,CAAO,UAAA,EAAY,IAAA,CAAK,UAAA;AAAA;AAAA,UAGR,IAAA;EAChB,KAAA,CAAM,OAAA,EAAS,WAAA;EACf,IAAA,EAAM,QAAA;AAAA;AAAA,UAGU,WAAA;EAChB,KAAA,CAAM,OAAA,EAAS,kBAAA;EACf,IAAA,EAAM,QAAA;AAAA;AAAA,KAGK,OAAA,GAAU,IAAA,GAAO,WAAA;;;iBCkEb,QAAA,CAAA,GAAY,OAAA;;;cC5Gf,iBAAA,SAA0B,KAAA;cAC1B,OAAA;AAAA;AAAA,cAMA,kBAAA,SAA2B,iBAAA;cAC3B,OAAA;AAAA;AAAA,cAMA,SAAA,SAAkB,iBAAA;cAClB,OAAA;AAAA;AAAA,cAMA,eAAA,SAAwB,iBAAA;cACxB,OAAA;AAAA;;;UCpBI,KAAA;EAChB,KAAA;EACA,KAAA;AAAA;AAAA,UAGgB,WAAA;EAChB,SAAA;EACA,SAAA;EACA,WAAA;EACA,IAAA;EACA,WAAA;EACA,GAAA;AAAA;AAAA,UAGgB,eAAA;EAChB,UAAA,EAAY,MAAA,CAAO,QAAA;EACnB,MAAA;EACA,IAAA;EACA,KAAA;EACA,QAAA;AAAA;AAAA,UAGgB,aAAA;EAChB,KAAA;EACA,MAAA;AAAA;AAAA,UAGgB,cAAA;EAChB,WAAA,EAAa,UAAA;EACb,SAAA;EACA,OAAA,EAAS,WAAA;EACT,UAAA,EAAY,aAAA;EACZ,KAAA,EAAO,KAAA;EACP,OAAA,EAAS,eAAA;AAAA;AAAA,UAGO,gBAAA;EAChB,IAAA;EACA,MAAA,EAAQ,cAAA;AAAA;AAAA,UAGQ,cAAA;EAChB,QAAA,EAAU,cAAA;EACV,SAAA;EACA,UAAA;EACA,WAAA,EAAa,gBAAA;AAAA;;;;;;;;;;;iBCiBQ,QAAA,CACrB,IAAA,UACA,OAAA;EAAW,MAAA;AAAA,IAAsB,OAAA,CAFJ,cAAA;AR7C9B;;;;;;;;;;;AAAA,iBQgEsB,gBAAA,CACrB,IAAA,UACA,OAAA;EAAW,MAAA;AAAA,IAAsB,OAAA,CAFI,cAAA"}
+{"version":3,"file":"index.d.cts","names":[],"sources":["../../src/engine/module-graph.ts","../../src/engine/type-resolver.ts","../../src/types/diagnostic.ts","../../src/types/config.ts","../../src/rules/types.ts","../../src/rules/index.ts","../../src/types/errors.ts","../../src/types/result.ts","../../src/api/index.ts"],"mappings":";;;UASiB,UAAA;EAChB,gBAAA,EAAkB,gBAAA;EAClB,WAAA;EACA,OAAA;EACA,QAAA;EACA,OAAA;EACA,IAAA;EACA,SAAA;AAAA;AAAA,UAGgB,WAAA;EAChB,KAAA,EAAO,GAAA,SAAY,GAAA;EACnB,OAAA,EAAS,GAAA,SAAY,UAAA;EACrB,gBAAA,EAAkB,GAAA,SAAY,UAAA;AAAA;;;UCjBd,YAAA;EAChB,gBAAA,EAAkB,gBAAA;EAClB,YAAA;EACA,QAAA;EACA,IAAA;EACA,iBAAA;AAAA;;;KCVW,QAAA;AAAA,KACA,QAAA;AAAA,UAMK,UAAA;EAChB,QAAA,EAAU,QAAA;EACV,MAAA;EACA,QAAA;EACA,IAAA;EACA,IAAA;EACA,OAAA;EACA,IAAA;EACA,QAAA,EAAU,QAAA;AAAA;;;UCbM,YAAA;EAChB,OAAA;EACA,QAAA,GAAW,QAAA;AAAA;AAAA,UAGK,wBAAA;EAChB,KAAA;EACA,KAAA;AAAA;AAAA,UAGgB,kBAAA;EAChB,UAAA,GAAa,OAAA,CAAQ,MAAA,CAAO,QAAA;EAC5B,OAAA;EACA,MAAA,GAAS,wBAAA;EACT,OAAA;EACA,QAAA;EACA,KAAA,GAAQ,MAAA,SAAe,YAAA;EACvB,UAAA;IACC,iBAAA;IACA,cAAA;EAAA;AAAA;;;KCfU,SAAA;AAAA,UAEK,QAAA;EAChB,QAAA,EAAU,QAAA;EACV,WAAA;EACA,IAAA;EACA,EAAA;EACA,KAAA,GAAQ,SAAA;EACR,QAAA,EAAU,QAAA;AAAA;AAAA,UAGM,WAAA;EAChB,QAAA;EACA,MAAA,CAAO,UAAA,EAAY,IAAA,CAAK,UAAA;EACxB,UAAA,EAAY,UAAA;AAAA;AAAA,UAGI,kBAAA;EAChB,MAAA,EAAQ,kBAAA;EACR,KAAA;EACA,WAAA,EAAa,WAAA;EACb,OAAA,EAAS,OAAA;EACT,SAAA,EAAW,GAAA,SAAY,YAAA;EACvB,MAAA,CAAO,UAAA,EAAY,IAAA,CAAK,UAAA;AAAA;AAAA,UAGR,IAAA;EAChB,KAAA,CAAM,OAAA,EAAS,WAAA;EACf,IAAA,EAAM,QAAA;AAAA;AAAA,UAGU,WAAA;EAChB,KAAA,CAAM,OAAA,EAAS,kBAAA;EACf,IAAA,EAAM,QAAA;AAAA;AAAA,KAGK,OAAA,GAAU,IAAA,GAAO,WAAA;;;iBC4Db,QAAA,CAAA,GAAY,OAAA;;;cCtGf,iBAAA,SAA0B,KAAA;cAC1B,OAAA;AAAA;AAAA,cAMA,kBAAA,SAA2B,iBAAA;cAC3B,OAAA;AAAA;AAAA,cAMA,SAAA,SAAkB,iBAAA;cAClB,OAAA;AAAA;AAAA,cAMA,eAAA,SAAwB,iBAAA;cACxB,OAAA;AAAA;;;UCpBI,KAAA;EAChB,KAAA;EACA,KAAA;AAAA;AAAA,UAGgB,WAAA;EAChB,SAAA;EACA,SAAA;EACA,WAAA;EACA,IAAA;EACA,WAAA;EACA,GAAA;AAAA;AAAA,UAGgB,eAAA;EAChB,UAAA,EAAY,MAAA,CAAO,QAAA;EACnB,MAAA;EACA,IAAA;EACA,KAAA;EACA,QAAA;AAAA;AAAA,UAGgB,aAAA;EAChB,KAAA;EACA,MAAA;AAAA;AAAA,UAGgB,cAAA;EAChB,WAAA,EAAa,UAAA;EACb,SAAA;EACA,OAAA,EAAS,WAAA;EACT,UAAA,EAAY,aAAA;EACZ,KAAA,EAAO,KAAA;EACP,OAAA,EAAS,eAAA;AAAA;AAAA,UAGO,gBAAA;EAChB,IAAA;EACA,MAAA,EAAQ,cAAA;AAAA;AAAA,UAGQ,cAAA;EAChB,QAAA,EAAU,cAAA;EACV,SAAA;EACA,UAAA;EACA,WAAA,EAAa,gBAAA;AAAA;;;;;;;;;;;iBCiBQ,QAAA,CACrB,IAAA,UACA,OAAA;EAAW,MAAA;AAAA,IAAsB,OAAA,CAFJ,cAAA;AR7C9B;;;;;;;;;;;AAAA,iBQgEsB,gBAAA,CACrB,IAAA,UACA,OAAA;EAAW,MAAA;AAAA,IAAsB,OAAA,CAFI,cAAA"}

package/dist/api/index.d.mts

@@ -56,8 +56,6 @@ interface NestjsDoctorConfig {
   minScore?: number;
   rules?: Record<string, RuleOverride | boolean>;
   thresholds?: {
-    godModuleProviders?: number;
-    godModuleImports?: number;
     godServiceMethods?: number;
     godServiceDeps?: number;
   };

package/dist/api/index.d.mts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.mts","names":[],"sources":["../../src/engine/module-graph.ts","../../src/engine/type-resolver.ts","../../src/types/diagnostic.ts","../../src/types/config.ts","../../src/rules/types.ts","../../src/rules/index.ts","../../src/types/errors.ts","../../src/types/result.ts","../../src/api/index.ts"],"mappings":";;;UASiB,UAAA;EAChB,gBAAA,EAAkB,gBAAA;EAClB,WAAA;EACA,OAAA;EACA,QAAA;EACA,OAAA;EACA,IAAA;EACA,SAAA;AAAA;AAAA,UAGgB,WAAA;EAChB,KAAA,EAAO,GAAA,SAAY,GAAA;EACnB,OAAA,EAAS,GAAA,SAAY,UAAA;EACrB,gBAAA,EAAkB,GAAA,SAAY,UAAA;AAAA;;;UCjBd,YAAA;EAChB,gBAAA,EAAkB,gBAAA;EAClB,YAAA;EACA,QAAA;EACA,IAAA;EACA,iBAAA;AAAA;;;KCVW,QAAA;AAAA,KACA,QAAA;AAAA,UAMK,UAAA;EAChB,QAAA,EAAU,QAAA;EACV,MAAA;EACA,QAAA;EACA,IAAA;EACA,IAAA;EACA,OAAA;EACA,IAAA;EACA,QAAA,EAAU,QAAA;AAAA;;;UCbM,YAAA;EAChB,OAAA;EACA,QAAA,GAAW,QAAA;AAAA;AAAA,UAGK,wBAAA;EAChB,KAAA;EACA,KAAA;AAAA;AAAA,UAGgB,kBAAA;EAChB,UAAA,GAAa,OAAA,CAAQ,MAAA,CAAO,QAAA;EAC5B,OAAA;EACA,MAAA,GAAS,wBAAA;EACT,OAAA;EACA,QAAA;EACA,KAAA,GAAQ,MAAA,SAAe,YAAA;EACvB,UAAA;IACC,kBAAA;IACA,gBAAA;IACA,iBAAA;IACA,cAAA;EAAA;AAAA;;;KCjBU,SAAA;AAAA,UAEK,QAAA;EAChB,QAAA,EAAU,QAAA;EACV,WAAA;EACA,IAAA;EACA,EAAA;EACA,KAAA,GAAQ,SAAA;EACR,QAAA,EAAU,QAAA;AAAA;AAAA,UAGM,WAAA;EAChB,QAAA;EACA,MAAA,CAAO,UAAA,EAAY,IAAA,CAAK,UAAA;EACxB,UAAA,EAAY,UAAA;AAAA;AAAA,UAGI,kBAAA;EAChB,MAAA,EAAQ,kBAAA;EACR,KAAA;EACA,WAAA,EAAa,WAAA;EACb,OAAA,EAAS,OAAA;EACT,SAAA,EAAW,GAAA,SAAY,YAAA;EACvB,MAAA,CAAO,UAAA,EAAY,IAAA,CAAK,UAAA;AAAA;AAAA,UAGR,IAAA;EAChB,KAAA,CAAM,OAAA,EAAS,WAAA;EACf,IAAA,EAAM,QAAA;AAAA;AAAA,UAGU,WAAA;EAChB,KAAA,CAAM,OAAA,EAAS,kBAAA;EACf,IAAA,EAAM,QAAA;AAAA;AAAA,KAGK,OAAA,GAAU,IAAA,GAAO,WAAA;;;iBCkEb,QAAA,CAAA,GAAY,OAAA;;;cC5Gf,iBAAA,SAA0B,KAAA;cAC1B,OAAA;AAAA;AAAA,cAMA,kBAAA,SAA2B,iBAAA;cAC3B,OAAA;AAAA;AAAA,cAMA,SAAA,SAAkB,iBAAA;cAClB,OAAA;AAAA;AAAA,cAMA,eAAA,SAAwB,iBAAA;cACxB,OAAA;AAAA;;;UCpBI,KAAA;EAChB,KAAA;EACA,KAAA;AAAA;AAAA,UAGgB,WAAA;EAChB,SAAA;EACA,SAAA;EACA,WAAA;EACA,IAAA;EACA,WAAA;EACA,GAAA;AAAA;AAAA,UAGgB,eAAA;EAChB,UAAA,EAAY,MAAA,CAAO,QAAA;EACnB,MAAA;EACA,IAAA;EACA,KAAA;EACA,QAAA;AAAA;AAAA,UAGgB,aAAA;EAChB,KAAA;EACA,MAAA;AAAA;AAAA,UAGgB,cAAA;EAChB,WAAA,EAAa,UAAA;EACb,SAAA;EACA,OAAA,EAAS,WAAA;EACT,UAAA,EAAY,aAAA;EACZ,KAAA,EAAO,KAAA;EACP,OAAA,EAAS,eAAA;AAAA;AAAA,UAGO,gBAAA;EAChB,IAAA;EACA,MAAA,EAAQ,cAAA;AAAA;AAAA,UAGQ,cAAA;EAChB,QAAA,EAAU,cAAA;EACV,SAAA;EACA,UAAA;EACA,WAAA,EAAa,gBAAA;AAAA;;;;;;;;;;;iBCiBQ,QAAA,CACrB,IAAA,UACA,OAAA;EAAW,MAAA;AAAA,IAAsB,OAAA,CAFJ,cAAA;AR7C9B;;;;;;;;;;;AAAA,iBQgEsB,gBAAA,CACrB,IAAA,UACA,OAAA;EAAW,MAAA;AAAA,IAAsB,OAAA,CAFI,cAAA"}
+{"version":3,"file":"index.d.mts","names":[],"sources":["../../src/engine/module-graph.ts","../../src/engine/type-resolver.ts","../../src/types/diagnostic.ts","../../src/types/config.ts","../../src/rules/types.ts","../../src/rules/index.ts","../../src/types/errors.ts","../../src/types/result.ts","../../src/api/index.ts"],"mappings":";;;UASiB,UAAA;EAChB,gBAAA,EAAkB,gBAAA;EAClB,WAAA;EACA,OAAA;EACA,QAAA;EACA,OAAA;EACA,IAAA;EACA,SAAA;AAAA;AAAA,UAGgB,WAAA;EAChB,KAAA,EAAO,GAAA,SAAY,GAAA;EACnB,OAAA,EAAS,GAAA,SAAY,UAAA;EACrB,gBAAA,EAAkB,GAAA,SAAY,UAAA;AAAA;;;UCjBd,YAAA;EAChB,gBAAA,EAAkB,gBAAA;EAClB,YAAA;EACA,QAAA;EACA,IAAA;EACA,iBAAA;AAAA;;;KCVW,QAAA;AAAA,KACA,QAAA;AAAA,UAMK,UAAA;EAChB,QAAA,EAAU,QAAA;EACV,MAAA;EACA,QAAA;EACA,IAAA;EACA,IAAA;EACA,OAAA;EACA,IAAA;EACA,QAAA,EAAU,QAAA;AAAA;;;UCbM,YAAA;EAChB,OAAA;EACA,QAAA,GAAW,QAAA;AAAA;AAAA,UAGK,wBAAA;EAChB,KAAA;EACA,KAAA;AAAA;AAAA,UAGgB,kBAAA;EAChB,UAAA,GAAa,OAAA,CAAQ,MAAA,CAAO,QAAA;EAC5B,OAAA;EACA,MAAA,GAAS,wBAAA;EACT,OAAA;EACA,QAAA;EACA,KAAA,GAAQ,MAAA,SAAe,YAAA;EACvB,UAAA;IACC,iBAAA;IACA,cAAA;EAAA;AAAA;;;KCfU,SAAA;AAAA,UAEK,QAAA;EAChB,QAAA,EAAU,QAAA;EACV,WAAA;EACA,IAAA;EACA,EAAA;EACA,KAAA,GAAQ,SAAA;EACR,QAAA,EAAU,QAAA;AAAA;AAAA,UAGM,WAAA;EAChB,QAAA;EACA,MAAA,CAAO,UAAA,EAAY,IAAA,CAAK,UAAA;EACxB,UAAA,EAAY,UAAA;AAAA;AAAA,UAGI,kBAAA;EAChB,MAAA,EAAQ,kBAAA;EACR,KAAA;EACA,WAAA,EAAa,WAAA;EACb,OAAA,EAAS,OAAA;EACT,SAAA,EAAW,GAAA,SAAY,YAAA;EACvB,MAAA,CAAO,UAAA,EAAY,IAAA,CAAK,UAAA;AAAA;AAAA,UAGR,IAAA;EAChB,KAAA,CAAM,OAAA,EAAS,WAAA;EACf,IAAA,EAAM,QAAA;AAAA;AAAA,UAGU,WAAA;EAChB,KAAA,CAAM,OAAA,EAAS,kBAAA;EACf,IAAA,EAAM,QAAA;AAAA;AAAA,KAGK,OAAA,GAAU,IAAA,GAAO,WAAA;;;iBC4Db,QAAA,CAAA,GAAY,OAAA;;;cCtGf,iBAAA,SAA0B,KAAA;cAC1B,OAAA;AAAA;AAAA,cAMA,kBAAA,SAA2B,iBAAA;cAC3B,OAAA;AAAA;AAAA,cAMA,SAAA,SAAkB,iBAAA;cAClB,OAAA;AAAA;AAAA,cAMA,eAAA,SAAwB,iBAAA;cACxB,OAAA;AAAA;;;UCpBI,KAAA;EAChB,KAAA;EACA,KAAA;AAAA;AAAA,UAGgB,WAAA;EAChB,SAAA;EACA,SAAA;EACA,WAAA;EACA,IAAA;EACA,WAAA;EACA,GAAA;AAAA;AAAA,UAGgB,eAAA;EAChB,UAAA,EAAY,MAAA,CAAO,QAAA;EACnB,MAAA;EACA,IAAA;EACA,KAAA;EACA,QAAA;AAAA;AAAA,UAGgB,aAAA;EAChB,KAAA;EACA,MAAA;AAAA;AAAA,UAGgB,cAAA;EAChB,WAAA,EAAa,UAAA;EACb,SAAA;EACA,OAAA,EAAS,WAAA;EACT,UAAA,EAAY,aAAA;EACZ,KAAA,EAAO,KAAA;EACP,OAAA,EAAS,eAAA;AAAA;AAAA,UAGO,gBAAA;EAChB,IAAA;EACA,MAAA,EAAQ,cAAA;AAAA;AAAA,UAGQ,cAAA;EAChB,QAAA,EAAU,cAAA;EACV,SAAA;EACA,UAAA;EACA,WAAA,EAAa,gBAAA;AAAA;;;;;;;;;;;iBCiBQ,QAAA,CACrB,IAAA,UACA,OAAA;EAAW,MAAA;AAAA,IAAsB,OAAA,CAFJ,cAAA;AR7C9B;;;;;;;;;;;AAAA,iBQgEsB,gBAAA,CACrB,IAAA,UACA,OAAA;EAAW,MAAA;AAAA,IAAsB,OAAA,CAFI,cAAA"}