nestjs-doctor 0.3.1 → 0.4.0

package/README.md

@@ -13,7 +13,7 @@
 </p>
 
 <p align="center">
-  45 built-in rules across <b>security</b>, <b>performance</b>, <b>correctness</b>, and <b>architecture</b>. Outputs a <b>0-100 score</b> with actionable diagnostics. Zero config. Monorepo support. Built to catch the anti-patterns that AI-generated code loves to introduce.
+  46 built-in rules across <b>security</b>, <b>performance</b>, <b>correctness</b>, and <b>architecture</b>. Outputs a <b>0-100 score</b> with actionable diagnostics. Zero config. Monorepo support. Built to catch the anti-patterns that AI-generated code loves to introduce.
 </p>
 
 ---
@@ -166,7 +166,7 @@ Or use a `"nestjs-doctor"` key in `package.json`.
 | Key | Type | Description |
 |-----|------|-------------|
 | `include` | `string[]` | Glob patterns to scan (default: `["**/*.ts"]`) |
-| `exclude` | `string[]` | Glob patterns to skip (default includes `node_modules`, `dist`, `build`, `coverage`, `*.spec.ts`, `*.test.ts`, `*.e2e-spec.ts`, `*.e2e-test.ts`, `*.d.ts`, `test/`, `tests/`, `__tests__/`, `__mocks__/`, `__fixtures__/`) |
+| `exclude` | `string[]` | Glob patterns to skip (default includes `node_modules`, `dist`, `build`, `coverage`, `*.spec.ts`, `*.test.ts`, `*.e2e-spec.ts`, `*.e2e-test.ts`, `*.d.ts`, `test/`, `tests/`, `__tests__/`, `__mocks__/`, `__fixtures__/`, `mock/`, `mocks/`, `*.mock.ts`, `seeder/`, `seeders/`, `*.seed.ts`, `*.seeder.ts`) |
 | `minScore` | `number` | Minimum passing score (0-100). Exits with code 1 if below threshold |
 | `ignore.rules` | `string[]` | Rule IDs to suppress |
 | `ignore.files` | `string[]` | Glob patterns for files whose diagnostics are hidden |
@@ -234,7 +234,7 @@ mono.combined;      // Merged DiagnoseResult
 
 ---
 
-## Rules (45)
+## Rules (46)
 
 ### Security (9)
 
@@ -250,7 +250,7 @@ mono.combined;      // Merged DiagnoseResult
 | `no-exposed-stack-trace` | warning | `error.stack` exposed in responses |
 | `require-auth-guard` | info | Controller without `@UseGuards()` |
 
-### Correctness (13)
+### Correctness (14)
 
 | Rule | Severity | What it catches |
 |------|----------|-----------------|
@@ -264,7 +264,8 @@ mono.combined;      // Merged DiagnoseResult
 | `prefer-readonly-injection` | warning | Constructor DI params missing `readonly` |
 | `require-lifecycle-interface` | warning | Lifecycle method without corresponding interface |
 | `no-empty-handlers` | warning | HTTP handler with empty body |
-| `no-async-without-await` | warning | Async function/method with no `await` |
+| `no-async-without-await` | warning | Async function/method with no `await` or redundant `async` on `new Promise()` return |
+| `prefer-await-in-handlers` | warning | Async HTTP handler missing await — risks broken exception filters and lost stack traces |
 | `no-duplicate-module-metadata` | warning | Duplicate entries in `@Module()` arrays |
 | `no-missing-module-decorator` | warning | Class named `*Module` without `@Module()` |
 

package/dist/api/index.cjs

@@ -309,7 +309,7 @@ function isModule(cls) {
 
 //#endregion
 //#region src/rules/architecture/no-business-logic-in-controllers.ts
-const HTTP_DECORATORS$1 = new Set([
+const HTTP_DECORATORS$3 = new Set([
 	"Get",
 	"Post",
 	"Put",
@@ -331,7 +331,7 @@ const noBusinessLogicInControllers = {
 		for (const cls of context.sourceFile.getClasses()) {
 			if (!isController(cls)) continue;
 			for (const method of cls.getMethods()) {
-				if (!method.getDecorators().some((d) => HTTP_DECORATORS$1.has(d.getName()))) continue;
+				if (!method.getDecorators().some((d) => HTTP_DECORATORS$3.has(d.getName()))) continue;
 				const body = method.getBody();
 				if (!body) continue;
 				const ifStatements = body.getDescendantsOfKind(ts_morph.SyntaxKind.IfStatement);
@@ -467,6 +467,18 @@ const noGodService = {
 
 //#endregion
 //#region src/rules/architecture/no-manual-instantiation.ts
+const DI_ONLY_SUFFIXES = [
+	"Service",
+	"Repository",
+	"Gateway",
+	"Resolver"
+];
+const CONTEXT_AWARE_SUFFIXES = [
+	"Guard",
+	"Interceptor",
+	"Pipe",
+	"Filter"
+];
 const noManualInstantiation = {
 	meta: {
 		id: "architecture/no-manual-instantiation",
@@ -479,7 +491,16 @@ const noManualInstantiation = {
 		const newExpressions = context.sourceFile.getDescendantsOfKind(ts_morph.SyntaxKind.NewExpression);
 		for (const expr of newExpressions) {
 			const exprText = expr.getExpression().getText();
-			if (exprText.endsWith("Service") || exprText.endsWith("Repository") || exprText.endsWith("Guard") || exprText.endsWith("Interceptor") || exprText.endsWith("Pipe") || exprText.endsWith("Filter") || exprText.endsWith("Gateway") || exprText.endsWith("Resolver")) context.report({
+			const isDiOnly = DI_ONLY_SUFFIXES.some((s) => exprText.endsWith(s));
+			const isContextAware = CONTEXT_AWARE_SUFFIXES.some((s) => exprText.endsWith(s));
+			if (!(isDiOnly || isContextAware)) continue;
+			if (isContextAware) {
+				if (expr.getFirstAncestorByKind(ts_morph.SyntaxKind.Decorator)) continue;
+				const inMethod = expr.getFirstAncestorByKind(ts_morph.SyntaxKind.MethodDeclaration);
+				const inConstructor = expr.getFirstAncestorByKind(ts_morph.SyntaxKind.Constructor);
+				if (!(inMethod || inConstructor)) continue;
+			}
+			context.report({
 				filePath: context.filePath,
 				message: `Manual instantiation of '${exprText}' detected. Use dependency injection instead.`,
 				help: this.meta.help,
@@ -791,6 +812,23 @@ const requireModuleBoundaries = {
 
 //#endregion
 //#region src/rules/correctness/no-async-without-await.ts
+const HTTP_DECORATORS$2 = new Set([
+	"Get",
+	"Post",
+	"Put",
+	"Delete",
+	"Patch",
+	"All",
+	"Head",
+	"Options"
+]);
+function returnsNewPromise$1(body) {
+	return body.getDescendantsOfKind(ts_morph.SyntaxKind.ReturnStatement).some((ret) => {
+		const expr = ret.getExpression();
+		if (!expr || expr.getKind() !== ts_morph.SyntaxKind.NewExpression) return false;
+		return expr.asKindOrThrow(ts_morph.SyntaxKind.NewExpression).getExpression().getText() === "Promise";
+	});
+}
 const noAsyncWithoutAwait = {
 	meta: {
 		id: "correctness/no-async-without-await",
@@ -802,6 +840,9 @@ const noAsyncWithoutAwait = {
 	check(context) {
 		for (const cls of context.sourceFile.getClasses()) for (const method of cls.getMethods()) {
 			if (!method.isAsync()) continue;
+			if (isController(cls)) {
+				if (method.getDecorators().some((d) => HTTP_DECORATORS$2.has(d.getName()))) continue;
+			}
 			const body = method.getBody();
 			if (!body) continue;
 			if (body.getDescendantsOfKind(ts_morph.SyntaxKind.AwaitExpression).filter((expr) => {
@@ -811,13 +852,23 @@ const noAsyncWithoutAwait = {
 					parent = parent.getParent();
 				}
 				return true;
-			}).length === 0) context.report({
-				filePath: context.filePath,
-				message: `Async method '${method.getName()}()' has no await expression.`,
-				help: this.meta.help,
-				line: method.getStartLineNumber(),
-				column: 1
-			});
+			}).length === 0) {
+				const name = method.getName();
+				if (returnsNewPromise$1(body)) context.report({
+					filePath: context.filePath,
+					message: `Async method '${name}()' returns a Promise directly — remove the async keyword.`,
+					help: "The async keyword is unnecessary when you are already constructing a Promise manually. Remove async to avoid double-wrapping.",
+					line: method.getStartLineNumber(),
+					column: 1
+				});
+				else context.report({
+					filePath: context.filePath,
+					message: `Async method '${name}()' has no await expression.`,
+					help: this.meta.help,
+					line: method.getStartLineNumber(),
+					column: 1
+				});
+			}
 		}
 		for (const fn of context.sourceFile.getFunctions()) {
 			if (!fn.isAsync()) continue;
@@ -830,13 +881,23 @@ const noAsyncWithoutAwait = {
 					parent = parent.getParent();
 				}
 				return true;
-			}).length === 0) context.report({
-				filePath: context.filePath,
-				message: `Async function '${fn.getName() ?? "anonymous"}()' has no await expression.`,
-				help: this.meta.help,
-				line: fn.getStartLineNumber(),
-				column: 1
-			});
+			}).length === 0) {
+				const name = fn.getName() ?? "anonymous";
+				if (returnsNewPromise$1(body)) context.report({
+					filePath: context.filePath,
+					message: `Async function '${name}()' returns a Promise directly — remove the async keyword.`,
+					help: "The async keyword is unnecessary when you are already constructing a Promise manually. Remove async to avoid double-wrapping.",
+					line: fn.getStartLineNumber(),
+					column: 1
+				});
+				else context.report({
+					filePath: context.filePath,
+					message: `Async function '${name}()' has no await expression.`,
+					help: this.meta.help,
+					line: fn.getStartLineNumber(),
+					column: 1
+				});
+			}
 		}
 	}
 };
@@ -935,7 +996,7 @@ const noDuplicateRoutes = {
 
 //#endregion
 //#region src/rules/correctness/no-empty-handlers.ts
-const HTTP_DECORATORS = new Set([
+const HTTP_DECORATORS$1 = new Set([
 	"Get",
 	"Post",
 	"Put",
@@ -957,7 +1018,7 @@ const noEmptyHandlers = {
 		for (const cls of context.sourceFile.getClasses()) {
 			if (!isController(cls)) continue;
 			for (const method of cls.getMethods()) {
-				if (!method.getDecorators().some((d) => HTTP_DECORATORS.has(d.getName()))) continue;
+				if (!method.getDecorators().some((d) => HTTP_DECORATORS$1.has(d.getName()))) continue;
 				const body = method.getBody();
 				if (!body) continue;
 				if (body.getStatements().length === 0) context.report({
@@ -1148,6 +1209,69 @@ const noMissingPipeMethod = {
 	}
 };
 
+//#endregion
+//#region src/rules/correctness/prefer-await-in-handlers.ts
+const HTTP_DECORATORS = new Set([
+	"Get",
+	"Post",
+	"Put",
+	"Delete",
+	"Patch",
+	"All",
+	"Head",
+	"Options"
+]);
+function returnsNewPromise(body) {
+	return body.getDescendantsOfKind(ts_morph.SyntaxKind.ReturnStatement).some((ret) => {
+		const expr = ret.getExpression();
+		if (!expr || expr.getKind() !== ts_morph.SyntaxKind.NewExpression) return false;
+		return expr.asKindOrThrow(ts_morph.SyntaxKind.NewExpression).getExpression().getText() === "Promise";
+	});
+}
+const preferAwaitInHandlers = {
+	meta: {
+		id: "correctness/prefer-await-in-handlers",
+		category: "correctness",
+		severity: "warning",
+		description: "Async HTTP handler missing await — risks broken exception filters and lost stack traces",
+		help: "Add await when calling services. This ensures exception filters trigger correctly, stack traces point to the handler, and error handling is consistent across handlers."
+	},
+	check(context) {
+		for (const cls of context.sourceFile.getClasses()) {
+			if (!isController(cls)) continue;
+			for (const method of cls.getMethods()) {
+				if (!(method.getDecorators().some((d) => HTTP_DECORATORS.has(d.getName())) && method.isAsync())) continue;
+				const body = method.getBody();
+				if (!body) continue;
+				if (body.getDescendantsOfKind(ts_morph.SyntaxKind.AwaitExpression).filter((expr) => {
+					let parent = expr.getParent();
+					while (parent && parent !== body) {
+						if (parent.getKind() === ts_morph.SyntaxKind.ArrowFunction || parent.getKind() === ts_morph.SyntaxKind.FunctionExpression || parent.getKind() === ts_morph.SyntaxKind.FunctionDeclaration) return false;
+						parent = parent.getParent();
+					}
+					return true;
+				}).length === 0) {
+					const name = method.getName();
+					if (returnsNewPromise(body)) context.report({
+						filePath: context.filePath,
+						message: `Handler '${name}()' returns a Promise directly — remove async and return the promise, or await the resolved value.`,
+						help: this.meta.help,
+						line: method.getStartLineNumber(),
+						column: 1
+					});
+					else context.report({
+						filePath: context.filePath,
+						message: `Async handler '${name}()' does not await any expression.`,
+						help: this.meta.help,
+						line: method.getStartLineNumber(),
+						column: 1
+					});
+				}
+			}
+		}
+	}
+};
+
 //#endregion
 //#region src/rules/correctness/prefer-readonly-injection.ts
 const preferReadonlyInjection = {
@@ -2066,6 +2190,7 @@ const allRules = [
 	noMissingFilterCatch,
 	noMissingInterceptorMethod,
 	noAsyncWithoutAwait,
+	preferAwaitInHandlers,
 	noDuplicateModuleMetadata,
 	noMissingModuleDecorator,
 	requireInjectDecorator,
@@ -2177,7 +2302,14 @@ const DEFAULT_CONFIG = {
 		"**/tests/**",
 		"**/__tests__/**",
 		"**/__mocks__/**",
-		"**/__fixtures__/**"
+		"**/__fixtures__/**",
+		"**/mock/**",
+		"**/mocks/**",
+		"**/*.mock.ts",
+		"**/seeder/**",
+		"**/seeders/**",
+		"**/*.seed.ts",
+		"**/*.seeder.ts"
 	]
 };
 

package/dist/api/index.d.cts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.cts","names":[],"sources":["../../src/engine/module-graph.ts","../../src/engine/type-resolver.ts","../../src/types/diagnostic.ts","../../src/types/config.ts","../../src/rules/types.ts","../../src/rules/index.ts","../../src/types/errors.ts","../../src/types/result.ts","../../src/api/index.ts"],"mappings":";;;UASiB,UAAA;EAChB,gBAAA,EAAkB,gBAAA;EAClB,WAAA;EACA,OAAA;EACA,QAAA;EACA,OAAA;EACA,IAAA;EACA,SAAA;AAAA;AAAA,UAGgB,WAAA;EAChB,KAAA,EAAO,GAAA,SAAY,GAAA;EACnB,OAAA,EAAS,GAAA,SAAY,UAAA;EACrB,gBAAA,EAAkB,GAAA,SAAY,UAAA;AAAA;;;UCjBd,YAAA;EAChB,gBAAA,EAAkB,gBAAA;EAClB,YAAA;EACA,QAAA;EACA,IAAA;EACA,iBAAA;AAAA;;;KCVW,QAAA;AAAA,KACA,QAAA;AAAA,UAMK,UAAA;EAChB,QAAA,EAAU,QAAA;EACV,MAAA;EACA,QAAA;EACA,IAAA;EACA,IAAA;EACA,OAAA;EACA,IAAA;EACA,QAAA,EAAU,QAAA;AAAA;;;UCbM,YAAA;EAChB,OAAA;EACA,QAAA,GAAW,QAAA;AAAA;AAAA,UAGK,wBAAA;EAChB,KAAA;EACA,KAAA;AAAA;AAAA,UAGgB,kBAAA;EAChB,UAAA,GAAa,OAAA,CAAQ,MAAA,CAAO,QAAA;EAC5B,OAAA;EACA,MAAA,GAAS,wBAAA;EACT,OAAA;EACA,QAAA;EACA,KAAA,GAAQ,MAAA,SAAe,YAAA;EACvB,UAAA;IACC,kBAAA;IACA,gBAAA;IACA,iBAAA;IACA,cAAA;EAAA;AAAA;;;KCjBU,SAAA;AAAA,UAEK,QAAA;EAChB,QAAA,EAAU,QAAA;EACV,WAAA;EACA,IAAA;EACA,EAAA;EACA,KAAA,GAAQ,SAAA;EACR,QAAA,EAAU,QAAA;AAAA;AAAA,UAGM,WAAA;EAChB,QAAA;EACA,MAAA,CAAO,UAAA,EAAY,IAAA,CAAK,UAAA;EACxB,UAAA,EAAY,UAAA;AAAA;AAAA,UAGI,kBAAA;EAChB,MAAA,EAAQ,kBAAA;EACR,KAAA;EACA,WAAA,EAAa,WAAA;EACb,OAAA,EAAS,OAAA;EACT,SAAA,EAAW,GAAA,SAAY,YAAA;EACvB,MAAA,CAAO,UAAA,EAAY,IAAA,CAAK,UAAA;AAAA;AAAA,UAGR,IAAA;EAChB,KAAA,CAAM,OAAA,EAAS,WAAA;EACf,IAAA,EAAM,QAAA;AAAA;AAAA,UAGU,WAAA;EAChB,KAAA,CAAM,OAAA,EAAS,kBAAA;EACf,IAAA,EAAM,QAAA;AAAA;AAAA,KAGK,OAAA,GAAU,IAAA,GAAO,WAAA;;;iBCkEb,QAAA,CAAA,GAAY,OAAA;;;cC5Gf,iBAAA,SAA0B,KAAA;cAC1B,OAAA;AAAA;AAAA,cAMA,kBAAA,SAA2B,iBAAA;cAC3B,OAAA;AAAA;AAAA,cAMA,SAAA,SAAkB,iBAAA;cAClB,OAAA;AAAA;AAAA,cAMA,eAAA,SAAwB,iBAAA;cACxB,OAAA;AAAA;;;UCpBI,KAAA;EAChB,KAAA;EACA,KAAA;AAAA;AAAA,UAGgB,WAAA;EAChB,SAAA;EACA,SAAA;EACA,WAAA;EACA,IAAA;EACA,WAAA;EACA,GAAA;AAAA;AAAA,UAGgB,eAAA;EAChB,UAAA,EAAY,MAAA,CAAO,QAAA;EACnB,MAAA;EACA,IAAA;EACA,KAAA;EACA,QAAA;AAAA;AAAA,UAGgB,aAAA;EAChB,KAAA;EACA,MAAA;AAAA;AAAA,UAGgB,cAAA;EAChB,WAAA,EAAa,UAAA;EACb,SAAA;EACA,OAAA,EAAS,WAAA;EACT,UAAA,EAAY,aAAA;EACZ,KAAA,EAAO,KAAA;EACP,OAAA,EAAS,eAAA;AAAA;AAAA,UAGO,gBAAA;EAChB,IAAA;EACA,MAAA,EAAQ,cAAA;AAAA;AAAA,UAGQ,cAAA;EAChB,QAAA,EAAU,cAAA;EACV,SAAA;EACA,UAAA;EACA,WAAA,EAAa,gBAAA;AAAA;;;;;;;;;;;iBCiBQ,QAAA,CACrB,IAAA,UACA,OAAA;EAAW,MAAA;AAAA,IAAsB,OAAA,CAFJ,cAAA;AR7C9B;;;;;;;;;;;AAAA,iBQgEsB,gBAAA,CACrB,IAAA,UACA,OAAA;EAAW,MAAA;AAAA,IAAsB,OAAA,CAFI,cAAA"}
+{"version":3,"file":"index.d.cts","names":[],"sources":["../../src/engine/module-graph.ts","../../src/engine/type-resolver.ts","../../src/types/diagnostic.ts","../../src/types/config.ts","../../src/rules/types.ts","../../src/rules/index.ts","../../src/types/errors.ts","../../src/types/result.ts","../../src/api/index.ts"],"mappings":";;;UASiB,UAAA;EAChB,gBAAA,EAAkB,gBAAA;EAClB,WAAA;EACA,OAAA;EACA,QAAA;EACA,OAAA;EACA,IAAA;EACA,SAAA;AAAA;AAAA,UAGgB,WAAA;EAChB,KAAA,EAAO,GAAA,SAAY,GAAA;EACnB,OAAA,EAAS,GAAA,SAAY,UAAA;EACrB,gBAAA,EAAkB,GAAA,SAAY,UAAA;AAAA;;;UCjBd,YAAA;EAChB,gBAAA,EAAkB,gBAAA;EAClB,YAAA;EACA,QAAA;EACA,IAAA;EACA,iBAAA;AAAA;;;KCVW,QAAA;AAAA,KACA,QAAA;AAAA,UAMK,UAAA;EAChB,QAAA,EAAU,QAAA;EACV,MAAA;EACA,QAAA;EACA,IAAA;EACA,IAAA;EACA,OAAA;EACA,IAAA;EACA,QAAA,EAAU,QAAA;AAAA;;;UCbM,YAAA;EAChB,OAAA;EACA,QAAA,GAAW,QAAA;AAAA;AAAA,UAGK,wBAAA;EAChB,KAAA;EACA,KAAA;AAAA;AAAA,UAGgB,kBAAA;EAChB,UAAA,GAAa,OAAA,CAAQ,MAAA,CAAO,QAAA;EAC5B,OAAA;EACA,MAAA,GAAS,wBAAA;EACT,OAAA;EACA,QAAA;EACA,KAAA,GAAQ,MAAA,SAAe,YAAA;EACvB,UAAA;IACC,kBAAA;IACA,gBAAA;IACA,iBAAA;IACA,cAAA;EAAA;AAAA;;;KCjBU,SAAA;AAAA,UAEK,QAAA;EAChB,QAAA,EAAU,QAAA;EACV,WAAA;EACA,IAAA;EACA,EAAA;EACA,KAAA,GAAQ,SAAA;EACR,QAAA,EAAU,QAAA;AAAA;AAAA,UAGM,WAAA;EAChB,QAAA;EACA,MAAA,CAAO,UAAA,EAAY,IAAA,CAAK,UAAA;EACxB,UAAA,EAAY,UAAA;AAAA;AAAA,UAGI,kBAAA;EAChB,MAAA,EAAQ,kBAAA;EACR,KAAA;EACA,WAAA,EAAa,WAAA;EACb,OAAA,EAAS,OAAA;EACT,SAAA,EAAW,GAAA,SAAY,YAAA;EACvB,MAAA,CAAO,UAAA,EAAY,IAAA,CAAK,UAAA;AAAA;AAAA,UAGR,IAAA;EAChB,KAAA,CAAM,OAAA,EAAS,WAAA;EACf,IAAA,EAAM,QAAA;AAAA;AAAA,UAGU,WAAA;EAChB,KAAA,CAAM,OAAA,EAAS,kBAAA;EACf,IAAA,EAAM,QAAA;AAAA;AAAA,KAGK,OAAA,GAAU,IAAA,GAAO,WAAA;;;iBCoEb,QAAA,CAAA,GAAY,OAAA;;;cC9Gf,iBAAA,SAA0B,KAAA;cAC1B,OAAA;AAAA;AAAA,cAMA,kBAAA,SAA2B,iBAAA;cAC3B,OAAA;AAAA;AAAA,cAMA,SAAA,SAAkB,iBAAA;cAClB,OAAA;AAAA;AAAA,cAMA,eAAA,SAAwB,iBAAA;cACxB,OAAA;AAAA;;;UCpBI,KAAA;EAChB,KAAA;EACA,KAAA;AAAA;AAAA,UAGgB,WAAA;EAChB,SAAA;EACA,SAAA;EACA,WAAA;EACA,IAAA;EACA,WAAA;EACA,GAAA;AAAA;AAAA,UAGgB,eAAA;EAChB,UAAA,EAAY,MAAA,CAAO,QAAA;EACnB,MAAA;EACA,IAAA;EACA,KAAA;EACA,QAAA;AAAA;AAAA,UAGgB,aAAA;EAChB,KAAA;EACA,MAAA;AAAA;AAAA,UAGgB,cAAA;EAChB,WAAA,EAAa,UAAA;EACb,SAAA;EACA,OAAA,EAAS,WAAA;EACT,UAAA,EAAY,aAAA;EACZ,KAAA,EAAO,KAAA;EACP,OAAA,EAAS,eAAA;AAAA;AAAA,UAGO,gBAAA;EAChB,IAAA;EACA,MAAA,EAAQ,cAAA;AAAA;AAAA,UAGQ,cAAA;EAChB,QAAA,EAAU,cAAA;EACV,SAAA;EACA,UAAA;EACA,WAAA,EAAa,gBAAA;AAAA;;;;;;;;;;;iBCiBQ,QAAA,CACrB,IAAA,UACA,OAAA;EAAW,MAAA;AAAA,IAAsB,OAAA,CAFJ,cAAA;AR7C9B;;;;;;;;;;;AAAA,iBQgEsB,gBAAA,CACrB,IAAA,UACA,OAAA;EAAW,MAAA;AAAA,IAAsB,OAAA,CAFI,cAAA"}

package/dist/api/index.d.mts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.mts","names":[],"sources":["../../src/engine/module-graph.ts","../../src/engine/type-resolver.ts","../../src/types/diagnostic.ts","../../src/types/config.ts","../../src/rules/types.ts","../../src/rules/index.ts","../../src/types/errors.ts","../../src/types/result.ts","../../src/api/index.ts"],"mappings":";;;UASiB,UAAA;EAChB,gBAAA,EAAkB,gBAAA;EAClB,WAAA;EACA,OAAA;EACA,QAAA;EACA,OAAA;EACA,IAAA;EACA,SAAA;AAAA;AAAA,UAGgB,WAAA;EAChB,KAAA,EAAO,GAAA,SAAY,GAAA;EACnB,OAAA,EAAS,GAAA,SAAY,UAAA;EACrB,gBAAA,EAAkB,GAAA,SAAY,UAAA;AAAA;;;UCjBd,YAAA;EAChB,gBAAA,EAAkB,gBAAA;EAClB,YAAA;EACA,QAAA;EACA,IAAA;EACA,iBAAA;AAAA;;;KCVW,QAAA;AAAA,KACA,QAAA;AAAA,UAMK,UAAA;EAChB,QAAA,EAAU,QAAA;EACV,MAAA;EACA,QAAA;EACA,IAAA;EACA,IAAA;EACA,OAAA;EACA,IAAA;EACA,QAAA,EAAU,QAAA;AAAA;;;UCbM,YAAA;EAChB,OAAA;EACA,QAAA,GAAW,QAAA;AAAA;AAAA,UAGK,wBAAA;EAChB,KAAA;EACA,KAAA;AAAA;AAAA,UAGgB,kBAAA;EAChB,UAAA,GAAa,OAAA,CAAQ,MAAA,CAAO,QAAA;EAC5B,OAAA;EACA,MAAA,GAAS,wBAAA;EACT,OAAA;EACA,QAAA;EACA,KAAA,GAAQ,MAAA,SAAe,YAAA;EACvB,UAAA;IACC,kBAAA;IACA,gBAAA;IACA,iBAAA;IACA,cAAA;EAAA;AAAA;;;KCjBU,SAAA;AAAA,UAEK,QAAA;EAChB,QAAA,EAAU,QAAA;EACV,WAAA;EACA,IAAA;EACA,EAAA;EACA,KAAA,GAAQ,SAAA;EACR,QAAA,EAAU,QAAA;AAAA;AAAA,UAGM,WAAA;EAChB,QAAA;EACA,MAAA,CAAO,UAAA,EAAY,IAAA,CAAK,UAAA;EACxB,UAAA,EAAY,UAAA;AAAA;AAAA,UAGI,kBAAA;EAChB,MAAA,EAAQ,kBAAA;EACR,KAAA;EACA,WAAA,EAAa,WAAA;EACb,OAAA,EAAS,OAAA;EACT,SAAA,EAAW,GAAA,SAAY,YAAA;EACvB,MAAA,CAAO,UAAA,EAAY,IAAA,CAAK,UAAA;AAAA;AAAA,UAGR,IAAA;EAChB,KAAA,CAAM,OAAA,EAAS,WAAA;EACf,IAAA,EAAM,QAAA;AAAA;AAAA,UAGU,WAAA;EAChB,KAAA,CAAM,OAAA,EAAS,kBAAA;EACf,IAAA,EAAM,QAAA;AAAA;AAAA,KAGK,OAAA,GAAU,IAAA,GAAO,WAAA;;;iBCkEb,QAAA,CAAA,GAAY,OAAA;;;cC5Gf,iBAAA,SAA0B,KAAA;cAC1B,OAAA;AAAA;AAAA,cAMA,kBAAA,SAA2B,iBAAA;cAC3B,OAAA;AAAA;AAAA,cAMA,SAAA,SAAkB,iBAAA;cAClB,OAAA;AAAA;AAAA,cAMA,eAAA,SAAwB,iBAAA;cACxB,OAAA;AAAA;;;UCpBI,KAAA;EAChB,KAAA;EACA,KAAA;AAAA;AAAA,UAGgB,WAAA;EAChB,SAAA;EACA,SAAA;EACA,WAAA;EACA,IAAA;EACA,WAAA;EACA,GAAA;AAAA;AAAA,UAGgB,eAAA;EAChB,UAAA,EAAY,MAAA,CAAO,QAAA;EACnB,MAAA;EACA,IAAA;EACA,KAAA;EACA,QAAA;AAAA;AAAA,UAGgB,aAAA;EAChB,KAAA;EACA,MAAA;AAAA;AAAA,UAGgB,cAAA;EAChB,WAAA,EAAa,UAAA;EACb,SAAA;EACA,OAAA,EAAS,WAAA;EACT,UAAA,EAAY,aAAA;EACZ,KAAA,EAAO,KAAA;EACP,OAAA,EAAS,eAAA;AAAA;AAAA,UAGO,gBAAA;EAChB,IAAA;EACA,MAAA,EAAQ,cAAA;AAAA;AAAA,UAGQ,cAAA;EAChB,QAAA,EAAU,cAAA;EACV,SAAA;EACA,UAAA;EACA,WAAA,EAAa,gBAAA;AAAA;;;;;;;;;;;iBCiBQ,QAAA,CACrB,IAAA,UACA,OAAA;EAAW,MAAA;AAAA,IAAsB,OAAA,CAFJ,cAAA;AR7C9B;;;;;;;;;;;AAAA,iBQgEsB,gBAAA,CACrB,IAAA,UACA,OAAA;EAAW,MAAA;AAAA,IAAsB,OAAA,CAFI,cAAA"}
+{"version":3,"file":"index.d.mts","names":[],"sources":["../../src/engine/module-graph.ts","../../src/engine/type-resolver.ts","../../src/types/diagnostic.ts","../../src/types/config.ts","../../src/rules/types.ts","../../src/rules/index.ts","../../src/types/errors.ts","../../src/types/result.ts","../../src/api/index.ts"],"mappings":";;;UASiB,UAAA;EAChB,gBAAA,EAAkB,gBAAA;EAClB,WAAA;EACA,OAAA;EACA,QAAA;EACA,OAAA;EACA,IAAA;EACA,SAAA;AAAA;AAAA,UAGgB,WAAA;EAChB,KAAA,EAAO,GAAA,SAAY,GAAA;EACnB,OAAA,EAAS,GAAA,SAAY,UAAA;EACrB,gBAAA,EAAkB,GAAA,SAAY,UAAA;AAAA;;;UCjBd,YAAA;EAChB,gBAAA,EAAkB,gBAAA;EAClB,YAAA;EACA,QAAA;EACA,IAAA;EACA,iBAAA;AAAA;;;KCVW,QAAA;AAAA,KACA,QAAA;AAAA,UAMK,UAAA;EAChB,QAAA,EAAU,QAAA;EACV,MAAA;EACA,QAAA;EACA,IAAA;EACA,IAAA;EACA,OAAA;EACA,IAAA;EACA,QAAA,EAAU,QAAA;AAAA;;;UCbM,YAAA;EAChB,OAAA;EACA,QAAA,GAAW,QAAA;AAAA;AAAA,UAGK,wBAAA;EAChB,KAAA;EACA,KAAA;AAAA;AAAA,UAGgB,kBAAA;EAChB,UAAA,GAAa,OAAA,CAAQ,MAAA,CAAO,QAAA;EAC5B,OAAA;EACA,MAAA,GAAS,wBAAA;EACT,OAAA;EACA,QAAA;EACA,KAAA,GAAQ,MAAA,SAAe,YAAA;EACvB,UAAA;IACC,kBAAA;IACA,gBAAA;IACA,iBAAA;IACA,cAAA;EAAA;AAAA;;;KCjBU,SAAA;AAAA,UAEK,QAAA;EAChB,QAAA,EAAU,QAAA;EACV,WAAA;EACA,IAAA;EACA,EAAA;EACA,KAAA,GAAQ,SAAA;EACR,QAAA,EAAU,QAAA;AAAA;AAAA,UAGM,WAAA;EAChB,QAAA;EACA,MAAA,CAAO,UAAA,EAAY,IAAA,CAAK,UAAA;EACxB,UAAA,EAAY,UAAA;AAAA;AAAA,UAGI,kBAAA;EAChB,MAAA,EAAQ,kBAAA;EACR,KAAA;EACA,WAAA,EAAa,WAAA;EACb,OAAA,EAAS,OAAA;EACT,SAAA,EAAW,GAAA,SAAY,YAAA;EACvB,MAAA,CAAO,UAAA,EAAY,IAAA,CAAK,UAAA;AAAA;AAAA,UAGR,IAAA;EAChB,KAAA,CAAM,OAAA,EAAS,WAAA;EACf,IAAA,EAAM,QAAA;AAAA;AAAA,UAGU,WAAA;EAChB,KAAA,CAAM,OAAA,EAAS,kBAAA;EACf,IAAA,EAAM,QAAA;AAAA;AAAA,KAGK,OAAA,GAAU,IAAA,GAAO,WAAA;;;iBCoEb,QAAA,CAAA,GAAY,OAAA;;;cC9Gf,iBAAA,SAA0B,KAAA;cAC1B,OAAA;AAAA;AAAA,cAMA,kBAAA,SAA2B,iBAAA;cAC3B,OAAA;AAAA;AAAA,cAMA,SAAA,SAAkB,iBAAA;cAClB,OAAA;AAAA;AAAA,cAMA,eAAA,SAAwB,iBAAA;cACxB,OAAA;AAAA;;;UCpBI,KAAA;EAChB,KAAA;EACA,KAAA;AAAA;AAAA,UAGgB,WAAA;EAChB,SAAA;EACA,SAAA;EACA,WAAA;EACA,IAAA;EACA,WAAA;EACA,GAAA;AAAA;AAAA,UAGgB,eAAA;EAChB,UAAA,EAAY,MAAA,CAAO,QAAA;EACnB,MAAA;EACA,IAAA;EACA,KAAA;EACA,QAAA;AAAA;AAAA,UAGgB,aAAA;EAChB,KAAA;EACA,MAAA;AAAA;AAAA,UAGgB,cAAA;EAChB,WAAA,EAAa,UAAA;EACb,SAAA;EACA,OAAA,EAAS,WAAA;EACT,UAAA,EAAY,aAAA;EACZ,KAAA,EAAO,KAAA;EACP,OAAA,EAAS,eAAA;AAAA;AAAA,UAGO,gBAAA;EAChB,IAAA;EACA,MAAA,EAAQ,cAAA;AAAA;AAAA,UAGQ,cAAA;EAChB,QAAA,EAAU,cAAA;EACV,SAAA;EACA,UAAA;EACA,WAAA,EAAa,gBAAA;AAAA;;;;;;;;;;;iBCiBQ,QAAA,CACrB,IAAA,UACA,OAAA;EAAW,MAAA;AAAA,IAAsB,OAAA,CAFJ,cAAA;AR7C9B;;;;;;;;;;;AAAA,iBQgEsB,gBAAA,CACrB,IAAA,UACA,OAAA;EAAW,MAAA;AAAA,IAAsB,OAAA,CAFI,cAAA"}

package/dist/api/index.mjs

@@ -280,7 +280,7 @@ function isModule(cls) {
 
 //#endregion
 //#region src/rules/architecture/no-business-logic-in-controllers.ts
-const HTTP_DECORATORS$1 = new Set([
+const HTTP_DECORATORS$3 = new Set([
 	"Get",
 	"Post",
 	"Put",
@@ -302,7 +302,7 @@ const noBusinessLogicInControllers = {
 		for (const cls of context.sourceFile.getClasses()) {
 			if (!isController(cls)) continue;
 			for (const method of cls.getMethods()) {
-				if (!method.getDecorators().some((d) => HTTP_DECORATORS$1.has(d.getName()))) continue;
+				if (!method.getDecorators().some((d) => HTTP_DECORATORS$3.has(d.getName()))) continue;
 				const body = method.getBody();
 				if (!body) continue;
 				const ifStatements = body.getDescendantsOfKind(SyntaxKind.IfStatement);
@@ -438,6 +438,18 @@ const noGodService = {
 
 //#endregion
 //#region src/rules/architecture/no-manual-instantiation.ts
+const DI_ONLY_SUFFIXES = [
+	"Service",
+	"Repository",
+	"Gateway",
+	"Resolver"
+];
+const CONTEXT_AWARE_SUFFIXES = [
+	"Guard",
+	"Interceptor",
+	"Pipe",
+	"Filter"
+];
 const noManualInstantiation = {
 	meta: {
 		id: "architecture/no-manual-instantiation",
@@ -450,7 +462,16 @@ const noManualInstantiation = {
 		const newExpressions = context.sourceFile.getDescendantsOfKind(SyntaxKind.NewExpression);
 		for (const expr of newExpressions) {
 			const exprText = expr.getExpression().getText();
-			if (exprText.endsWith("Service") || exprText.endsWith("Repository") || exprText.endsWith("Guard") || exprText.endsWith("Interceptor") || exprText.endsWith("Pipe") || exprText.endsWith("Filter") || exprText.endsWith("Gateway") || exprText.endsWith("Resolver")) context.report({
+			const isDiOnly = DI_ONLY_SUFFIXES.some((s) => exprText.endsWith(s));
+			const isContextAware = CONTEXT_AWARE_SUFFIXES.some((s) => exprText.endsWith(s));
+			if (!(isDiOnly || isContextAware)) continue;
+			if (isContextAware) {
+				if (expr.getFirstAncestorByKind(SyntaxKind.Decorator)) continue;
+				const inMethod = expr.getFirstAncestorByKind(SyntaxKind.MethodDeclaration);
+				const inConstructor = expr.getFirstAncestorByKind(SyntaxKind.Constructor);
+				if (!(inMethod || inConstructor)) continue;
+			}
+			context.report({
 				filePath: context.filePath,
 				message: `Manual instantiation of '${exprText}' detected. Use dependency injection instead.`,
 				help: this.meta.help,
@@ -762,6 +783,23 @@ const requireModuleBoundaries = {
 
 //#endregion
 //#region src/rules/correctness/no-async-without-await.ts
+const HTTP_DECORATORS$2 = new Set([
+	"Get",
+	"Post",
+	"Put",
+	"Delete",
+	"Patch",
+	"All",
+	"Head",
+	"Options"
+]);
+function returnsNewPromise$1(body) {
+	return body.getDescendantsOfKind(SyntaxKind.ReturnStatement).some((ret) => {
+		const expr = ret.getExpression();
+		if (!expr || expr.getKind() !== SyntaxKind.NewExpression) return false;
+		return expr.asKindOrThrow(SyntaxKind.NewExpression).getExpression().getText() === "Promise";
+	});
+}
 const noAsyncWithoutAwait = {
 	meta: {
 		id: "correctness/no-async-without-await",
@@ -773,6 +811,9 @@ const noAsyncWithoutAwait = {
 	check(context) {
 		for (const cls of context.sourceFile.getClasses()) for (const method of cls.getMethods()) {
 			if (!method.isAsync()) continue;
+			if (isController(cls)) {
+				if (method.getDecorators().some((d) => HTTP_DECORATORS$2.has(d.getName()))) continue;
+			}
 			const body = method.getBody();
 			if (!body) continue;
 			if (body.getDescendantsOfKind(SyntaxKind.AwaitExpression).filter((expr) => {
@@ -782,13 +823,23 @@ const noAsyncWithoutAwait = {
 					parent = parent.getParent();
 				}
 				return true;
-			}).length === 0) context.report({
-				filePath: context.filePath,
-				message: `Async method '${method.getName()}()' has no await expression.`,
-				help: this.meta.help,
-				line: method.getStartLineNumber(),
-				column: 1
-			});
+			}).length === 0) {
+				const name = method.getName();
+				if (returnsNewPromise$1(body)) context.report({
+					filePath: context.filePath,
+					message: `Async method '${name}()' returns a Promise directly — remove the async keyword.`,
+					help: "The async keyword is unnecessary when you are already constructing a Promise manually. Remove async to avoid double-wrapping.",
+					line: method.getStartLineNumber(),
+					column: 1
+				});
+				else context.report({
+					filePath: context.filePath,
+					message: `Async method '${name}()' has no await expression.`,
+					help: this.meta.help,
+					line: method.getStartLineNumber(),
+					column: 1
+				});
+			}
 		}
 		for (const fn of context.sourceFile.getFunctions()) {
 			if (!fn.isAsync()) continue;
@@ -801,13 +852,23 @@ const noAsyncWithoutAwait = {
 					parent = parent.getParent();
 				}
 				return true;
-			}).length === 0) context.report({
-				filePath: context.filePath,
-				message: `Async function '${fn.getName() ?? "anonymous"}()' has no await expression.`,
-				help: this.meta.help,
-				line: fn.getStartLineNumber(),
-				column: 1
-			});
+			}).length === 0) {
+				const name = fn.getName() ?? "anonymous";
+				if (returnsNewPromise$1(body)) context.report({
+					filePath: context.filePath,
+					message: `Async function '${name}()' returns a Promise directly — remove the async keyword.`,
+					help: "The async keyword is unnecessary when you are already constructing a Promise manually. Remove async to avoid double-wrapping.",
+					line: fn.getStartLineNumber(),
+					column: 1
+				});
+				else context.report({
+					filePath: context.filePath,
+					message: `Async function '${name}()' has no await expression.`,
+					help: this.meta.help,
+					line: fn.getStartLineNumber(),
+					column: 1
+				});
+			}
 		}
 	}
 };
@@ -906,7 +967,7 @@ const noDuplicateRoutes = {
 
 //#endregion
 //#region src/rules/correctness/no-empty-handlers.ts
-const HTTP_DECORATORS = new Set([
+const HTTP_DECORATORS$1 = new Set([
 	"Get",
 	"Post",
 	"Put",
@@ -928,7 +989,7 @@ const noEmptyHandlers = {
 		for (const cls of context.sourceFile.getClasses()) {
 			if (!isController(cls)) continue;
 			for (const method of cls.getMethods()) {
-				if (!method.getDecorators().some((d) => HTTP_DECORATORS.has(d.getName()))) continue;
+				if (!method.getDecorators().some((d) => HTTP_DECORATORS$1.has(d.getName()))) continue;
 				const body = method.getBody();
 				if (!body) continue;
 				if (body.getStatements().length === 0) context.report({
@@ -1119,6 +1180,69 @@ const noMissingPipeMethod = {
 	}
 };
 
+//#endregion
+//#region src/rules/correctness/prefer-await-in-handlers.ts
+const HTTP_DECORATORS = new Set([
+	"Get",
+	"Post",
+	"Put",
+	"Delete",
+	"Patch",
+	"All",
+	"Head",
+	"Options"
+]);
+function returnsNewPromise(body) {
+	return body.getDescendantsOfKind(SyntaxKind.ReturnStatement).some((ret) => {
+		const expr = ret.getExpression();
+		if (!expr || expr.getKind() !== SyntaxKind.NewExpression) return false;
+		return expr.asKindOrThrow(SyntaxKind.NewExpression).getExpression().getText() === "Promise";
+	});
+}
+const preferAwaitInHandlers = {
+	meta: {
+		id: "correctness/prefer-await-in-handlers",
+		category: "correctness",
+		severity: "warning",
+		description: "Async HTTP handler missing await — risks broken exception filters and lost stack traces",
+		help: "Add await when calling services. This ensures exception filters trigger correctly, stack traces point to the handler, and error handling is consistent across handlers."
+	},
+	check(context) {
+		for (const cls of context.sourceFile.getClasses()) {
+			if (!isController(cls)) continue;
+			for (const method of cls.getMethods()) {
+				if (!(method.getDecorators().some((d) => HTTP_DECORATORS.has(d.getName())) && method.isAsync())) continue;
+				const body = method.getBody();
+				if (!body) continue;
+				if (body.getDescendantsOfKind(SyntaxKind.AwaitExpression).filter((expr) => {
+					let parent = expr.getParent();
+					while (parent && parent !== body) {
+						if (parent.getKind() === SyntaxKind.ArrowFunction || parent.getKind() === SyntaxKind.FunctionExpression || parent.getKind() === SyntaxKind.FunctionDeclaration) return false;
+						parent = parent.getParent();
+					}
+					return true;
+				}).length === 0) {
+					const name = method.getName();
+					if (returnsNewPromise(body)) context.report({
+						filePath: context.filePath,
+						message: `Handler '${name}()' returns a Promise directly — remove async and return the promise, or await the resolved value.`,
+						help: this.meta.help,
+						line: method.getStartLineNumber(),
+						column: 1
+					});
+					else context.report({
+						filePath: context.filePath,
+						message: `Async handler '${name}()' does not await any expression.`,
+						help: this.meta.help,
+						line: method.getStartLineNumber(),
+						column: 1
+					});
+				}
+			}
+		}
+	}
+};
+
 //#endregion
 //#region src/rules/correctness/prefer-readonly-injection.ts
 const preferReadonlyInjection = {
@@ -2037,6 +2161,7 @@ const allRules = [
 	noMissingFilterCatch,
 	noMissingInterceptorMethod,
 	noAsyncWithoutAwait,
+	preferAwaitInHandlers,
 	noDuplicateModuleMetadata,
 	noMissingModuleDecorator,
 	requireInjectDecorator,
@@ -2148,7 +2273,14 @@ const DEFAULT_CONFIG = {
 		"**/tests/**",
 		"**/__tests__/**",
 		"**/__mocks__/**",
-		"**/__fixtures__/**"
+		"**/__fixtures__/**",
+		"**/mock/**",
+		"**/mocks/**",
+		"**/*.mock.ts",
+		"**/seeder/**",
+		"**/seeders/**",
+		"**/*.seed.ts",
+		"**/*.seeder.ts"
 	]
 };