nerdsystem 0.0.26 → 0.0.27

package/dist/commands/init.js

@@ -192,4 +192,4 @@ export async function init(dir, args) {
     log.ok(`Ready. Next:\n  cd ${dir}\n  pnpm install\n  nerd dev\n\nThen open the folder in your coding agent and ask it to build the first feature; the nerdsystem skill walks it through.\nDeploys go to ${project.url}`);
 }
 // Kept in sync with packages/sdk/package.json by the release script.
-const SDK_VERSION = "0.0.26";
+const SDK_VERSION = "0.0.27";

package/dist/commands/platform-review.d.ts

@@ -16,6 +16,8 @@ export type ReviewOutcome = {
     platformRead: boolean;
     /** Whose review the findings on file come from. */
     kind: "platform" | "session";
+    /** Findings recorded as real and deliberately left as they are. Counted, not listed: there is nothing to do about them. */
+    leftAsIs: number;
 } | {
     status: "skipped";
     reason: string;

package/dist/commands/platform-review.js

@@ -33,16 +33,22 @@ export async function platformReview(api, sourcePath, dashboard) {
     }
     const kind = review.kind === "session" ? "session" : "platform";
     if (review.status !== "done")
-        return { status: "declined", findings: [], dashboard, platformRead, kind };
+        return { status: "declined", findings: [], dashboard, platformRead, kind, leftAsIs: 0 };
     const findings = [];
+    let leftAsIs = 0;
     for (const f of review.findings ?? []) {
         const rule = typeof f.rule_id === "string" && f.rule_id.startsWith("review/") ? RULES[f.rule_id] : undefined;
         // A type this version of nerd does not know is left out rather than shown with words from elsewhere.
         if (!rule || typeof f.file !== "string" || !/^[\w./@-]{1,200}$/.test(f.file) || !Number.isInteger(f.line))
             continue;
+        // Recorded as deliberately left: not open, and not something to act on after a deploy.
+        if (f.leftAsIs === true) {
+            leftAsIs++;
+            continue;
+        }
         findings.push({ rule_id: f.rule_id, severity: rule.severity, audience: rule.audience, file: f.file, line: f.line, risk: rule.risk, fix: rule.fix });
     }
-    return { status: "done", findings, dashboard, platformRead, kind };
+    return { status: "done", findings, dashboard, platformRead, kind, leftAsIs };
 }
 export function printReview(r) {
     if (r.status === "skipped") {
@@ -54,11 +60,12 @@ export function printReview(r) {
         return;
     }
     const whose = r.platformRead ? "nerdsystem read the code itself after this deploy" : r.kind === "session" ? "from the review this app's agent last reported" : "from nerdsystem's last own read of the code";
+    const left = r.leftAsIs ? `; ${r.leftAsIs} known and left as ${r.leftAsIs === 1 ? "it is" : "they are"}` : "";
     if (!r.findings.length) {
-        log.ok(`Review: nothing open (${whose}). A plain-language summary for the person is at ${r.dashboard}`);
+        log.ok(`Review: nothing open (${whose}${left}). A plain-language summary for the person is at ${r.dashboard}`);
         return;
     }
-    log.warn(`Review: ${r.findings.length} thing(s) open (${whose}). A review is a second opinion and can be wrong, so check each one against the code before changing anything. Say what you did about them in the next \`nerd review report\`.`);
+    log.warn(`Review: ${r.findings.length} thing(s) open (${whose}${left}). A review is a second opinion and can be wrong, so check each one against the code before changing anything. Say what you did about them in the next \`nerd review report\`.`);
     for (const f of r.findings) {
         log.info(`    ${f.severity === "info" ? "·" : "!"} ${f.rule_id} ${f.file}:${f.line}${f.audience === "human" ? "  (for the person to decide)" : ""}`);
         log.info(`      ${f.risk}`);

package/dist/commands/session-review.js

@@ -115,14 +115,14 @@ export function checklistText(c) {
     if (c.open.length) {
         lines.push("Open from earlier reviews. Check each against the code as it is now and answer it in the report:");
         for (const f of c.open)
-            lines.push(`- ${f.rule_id} at ${f.file}:${f.line}${f.origin === "platform" ? "  (from nerdsystem's own read)" : ""}${f.leftAsIs ? "  (recorded as left as it is; it stays that way unless you report it differently)" : ""}`);
+            lines.push(`- ${f.rule_id} at ${f.file}:${f.line}${f.origin === "platform" ? "  (first raised by nerdsystem's own read)" : ""}${f.leftAsIs ? "  (recorded as left as it is; it stays that way unless you report it differently)" : ""}`);
         lines.push("");
     }
     lines.push("What to look for:");
     for (const r of c.rules) {
         lines.push(`- ${r.rule_id}: ${r.title}${r.audience === "human" ? " [for the person to decide]" : ""}`, `  Look for: ${r.lookFor}`, `  Fix: ${r.fix}`);
     }
-    lines.push("", `The report, written to ${c.reportFile}:`, JSON.stringify(c.format, null, 2), "", "- findings: what is still in the code after your fixes and still needs someone to act or decide, each with the rule, the file, and the line that shows it. Leave it empty when there is nothing. A finding marked [for the person to decide] stays here until they have answered.", "- leftAsIs: what is real and deliberately left as it is, because the person decided so or because the rule's own advice is not to change working code for it. It is shown to the owner, kept on later reports, and not announced again to each new session.", "- fixed: what this review found and you then fixed, including findings from the open list above. If you fixed only part of one, list what remains under findings (or leftAsIs) at the line that still shows it, and do not list it as fixed.", "- dismissed: only for a finding from nerdsystem's own read that you checked against the code and that does not apply. The owner sees this as your judgement, so use it when you are sure.", "- A finding from nerdsystem's own read that the report does not mention stays open.", "- summary, does, missing are for the owner and are shown on their dashboard as written. Plain words only.", "", "Report what you found, not what would look good. The report is stored as this agent's own review, it never decides whether a deploy goes out, and a clean report that nerdsystem's own read later contradicts is recorded as a miss.");
+    lines.push("", `The report, written to ${c.reportFile}:`, JSON.stringify(c.format, null, 2), "", "- findings: what is still in the code after your fixes and still needs someone to act or decide, each with the rule, the file, and the line that shows it. Leave it empty when there is nothing. A finding marked [for the person to decide] stays here until they have answered.", "- leftAsIs: what is real and deliberately left as it is, because the person decided so or because the rule's own advice is not to change working code for it. Any finding can go here, whoever first raised it. It is shown to the owner, kept on later reports, and not announced again to each new session.", "- fixed: what this review found and you then fixed, including findings from the open list above. If you fixed only part of one, list what remains under findings (or leftAsIs) at the line that still shows it, and do not list it as fixed.", "- dismissed: only for a finding from nerdsystem's own read that you checked against the code and that does not apply. The owner sees this as your judgement, so use it when you are sure.", "- A finding from nerdsystem's own read that the report does not mention stays open.", "- summary, does, missing are for the owner and are shown on their dashboard as written. Plain words only.", "", "Report what you found, not what would look good. The report is stored as this agent's own review, it never decides whether a deploy goes out, and a clean report that nerdsystem's own read later contradicts is recorded as a miss.");
     return lines.join("\n");
 }
 /** `nerd review checklist`: what the agent reads before it reviews. */

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nerdsystem",
-  "version": "0.0.26",
+  "version": "0.0.27",
   "description": "nerd: start, check, and deploy a web app on nerdsystem from the terminal or a coding agent.",
   "type": "module",
   "bin": {