neoagent 3.2.1-beta.1 → 3.2.1-beta.11

package/server/routes/settings.js

@@ -40,6 +40,14 @@ const AGENT_SETTING_KEYS = new Set([
   'cost_mode',
   'chat_history_window',
   'tool_replay_budget_chars',
+  'tool_replay_budget_file_chars',
+  'tool_replay_budget_browser_chars',
+  'tool_replay_budget_command_chars',
+  'max_iterations',
+  'max_consecutive_read_only_iterations',
+  'max_consecutive_tool_failures',
+  'max_model_failure_recoveries',
+  'compaction_threshold',
   'subagent_max_iterations',
   'subagent_max_children_per_run',
   'assistant_behavior_notes',
@@ -194,16 +202,19 @@ async function resetEnvBackedSettingValue(req, key) {
 // Get supported models metadata
 router.get('/meta/models', async (req, res) => {
   const agentId = resolveAgentId(req.session.userId, getAgentIdFromRequest(req));
-  const models = await getSupportedModels(req.session.userId, agentId);
+  const models = await getSupportedModels(req.session.userId, agentId, { signal: req.signal });
   res.json({ models });
 });
 
 router.get('/meta/ai-providers', async (req, res) => {
   const agentId = resolveAgentId(req.session.userId, getAgentIdFromRequest(req));
-  const [providers, models] = await Promise.all([
-    getProviderHealthCatalog(req.session.userId, agentId),
-    getSupportedModels(req.session.userId, agentId),
-  ]);
+  const providers = await getProviderHealthCatalog(req.session.userId, agentId, {
+    signal: req.signal,
+  });
+  const models = await getSupportedModels(req.session.userId, agentId, {
+    providerCatalog: providers,
+    signal: req.signal,
+  });
 
   const modelCounts = models.reduce((acc, model) => {
     acc[model.provider] = (acc[model.provider] || 0) + 1;
@@ -335,6 +346,10 @@ router.put('/', async (req, res) => {
   });
 
   tx(Object.entries(normalizedBody));
+  if (Object.prototype.hasOwnProperty.call(normalizedBody, 'assistant_behavior_notes')) {
+    const { invalidateSystemPromptCache } = require('../services/ai/systemPrompt');
+    invalidateSystemPromptCache(userId, agentId);
+  }
 
   if (Object.keys(normalizedBody).some((key) => VOICE_SETTING_KEYS.has(key))) {
     const manager = req.app?.locals?.messagingManager;

package/server/routes/social_reach.js

@@ -25,7 +25,7 @@ router.get('/status', async (req, res) => {
     if (!service || typeof service.getStatus !== 'function') {
       return res.status(503).json({ error: 'Social reach service is unavailable.' });
     }
-    return res.json(await service.getStatus(req.session.userId));
+    return res.json(await service.getStatus(req.session.userId, { signal: req.signal }));
   } catch (error) {
     return sendError(res, error);
   }
@@ -37,7 +37,11 @@ router.post('/read', async (req, res) => {
     if (!service || typeof service.read !== 'function') {
       return res.status(503).json({ error: 'Social reach service is unavailable.' });
     }
-    return res.json(await service.read(req.session.userId, req.body || {}));
+    return res.json(await service.read(
+      req.session.userId,
+      req.body || {},
+      { signal: req.signal },
+    ));
   } catch (error) {
     return sendError(res, error);
   }
@@ -49,7 +53,11 @@ router.post('/search', async (req, res) => {
     if (!service || typeof service.search !== 'function') {
       return res.status(503).json({ error: 'Social reach service is unavailable.' });
     }
-    return res.json(await service.search(req.session.userId, req.body || {}));
+    return res.json(await service.search(
+      req.session.userId,
+      req.body || {},
+      { signal: req.signal },
+    ));
   } catch (error) {
     return sendError(res, error);
   }
@@ -67,6 +75,7 @@ router.post('/cookies/import', async (req, res) => {
     }
     return res.json(await service.importCookiesFromExtension(req.session.userId, platform, {
       tokenId: req.body?.tokenId || req.body?.token_id || null,
+      signal: req.signal,
     }));
   } catch (error) {
     return sendError(res, error);

package/server/routes/social_video.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const express = require('express');
 const { requireAuth } = require('../middleware/auth');
 const { getAgentIdFromRequest, resolveAgentId } = require('../services/agents/manager');
@@ -18,6 +20,7 @@ router.get('/health', async (req, res) => {
     }
     const health = await service.getHealthStatus({
       forceRefresh: req.query?.refresh === '1' || req.query?.refresh === 'true',
+      signal: req.signal,
     });
     return res.json(health);
   } catch (error) {
@@ -46,6 +49,7 @@ router.post('/extract', async (req, res) => {
       includeFrame: req.body?.include_frame !== false,
       forceStt: req.body?.force_stt === true,
       agentId,
+      signal: req.signal,
     });
 
     if (result?.setup?.ready === false) {

package/server/services/agents/manager.js

@@ -77,7 +77,7 @@ function ensureMainAgent(userId) {
     userId,
     MAIN_AGENT_SLUG,
     'Main',
-    'Default personal assistant and fallback agent.',
+    'Default personal AI contact and fallback agent.',
     'Handle general requests. Delegate to specialist agents only when their responsibilities clearly match.',
     '',
   );

package/server/services/ai/capabilityHealth.js

@@ -39,6 +39,9 @@ async function getBrowserHealth(userId, app, engine) {
   const runtimeSettings = typeof runtimeManager?.getSettings === 'function'
     ? runtimeManager.getSettings(userId)
     : null;
+  const runtimeSnapshot = typeof runtimeManager?.getCapabilitySnapshot === 'function'
+    ? runtimeManager.getCapabilitySnapshot(userId)
+    : null;
   const extensionStatus = runtimeSettings?.browser_backend === 'extension'
     ? app?.locals?.browserExtensionRegistry?.getStatus(userId)
     : null;
@@ -63,122 +66,81 @@ async function getBrowserHealth(userId, app, engine) {
       });
     }
   }
-  let controller = null;
-  let resolutionError = null;
-
-  if (runtimeManager && typeof runtimeManager.getBrowserProviderForUser === 'function') {
-    try {
-      controller = await runtimeManager.getBrowserProviderForUser(userId);
-    } catch (err) {
-      resolutionError = err;
-    }
-  }
-
-  if (!controller) {
-    resolutionError = resolutionError || new Error('Browser provider is unavailable. VM runtime is required.');
-  }
-
-  if (!controller && resolutionError) {
+  if (!runtimeManager) {
     return capabilityEntry({
-      configured: true,
-      healthy: false,
-      degraded: true,
-      summary: `Browser controller resolution failed: ${resolutionError.message}`,
-      details: {
-        error: resolutionError.message,
-      },
+      summary: 'Browser runtime is not available in this environment.',
     });
   }
-  let pageInfo = null;
-  let launched = false;
-  let error = null;
 
-  try {
-    launched = typeof controller?.isLaunched === 'function'
-      ? await Promise.resolve(controller.isLaunched())
-      : false;
-    pageInfo = typeof controller?.getPageInfo === 'function' ? await controller.getPageInfo() : null;
-  } catch (err) {
-    error = err.message;
-  }
+  // Capability reporting runs on every agent turn. It must never resolve a
+  // provider because the VM provider performs image builds and container boot.
+  // Tool execution remains the authoritative health check and starts/restarts
+  // the runtime only when the model actually uses a browser tool.
+  const preferredBackend = runtimeSettings?.browser_backend
+    || runtimeSnapshot?.browser?.preferredBackend
+    || 'vm';
+  const vmInitialized = runtimeSnapshot?.browser?.vmInitialized === true;
+  const extensionConnected = extensionStatus?.connected === true
+    || runtimeSnapshot?.browser?.extensionConnected === true;
+  const extensionPreferredButOffline = preferredBackend === 'extension' && !extensionConnected;
 
   return capabilityEntry({
-    connected: launched,
+    connected: vmInitialized || extensionConnected,
     configured: true,
-    healthy: !error,
-    degraded: Boolean(error) || runtimeSettings?.browser_backend === 'extension',
-    summary: error
-      ? `Browser runtime error: ${error}`
-      : runtimeSettings?.browser_backend === 'extension'
-        ? `No extension device is active. Falling back to the vm browser runtime.`
-        : (launched ? 'Browser runtime is ready.' : 'Browser runtime is available but not launched.'),
+    healthy: true,
+    degraded: extensionPreferredButOffline,
+    summary: extensionPreferredButOffline
+      ? 'No extension device is active. The VM browser will start on first use.'
+      : vmInitialized
+        ? 'Browser VM session is initialized.'
+        : 'Browser runtime is available and will start on first use.',
     details: {
-      preferredBackend: runtimeSettings?.browser_backend || null,
-      backend: runtimeSettings?.browser_backend === 'extension'
-        ? 'vm'
-        : runtimeSettings?.browser_backend || null,
-      extensionConnected: extensionStatus?.connected === true,
+      preferredBackend,
+      backend: extensionConnected ? 'extension' : 'vm',
+      extensionConnected,
       activeTokenCount: Array.isArray(extensionStatus?.tokens)
         ? extensionStatus.tokens.filter((token) => token.status === 'active').length
         : 0,
-      launched,
-      pageInfo,
+      runtimeInitialized: vmInitialized,
     },
   });
 }
 
 async function getAndroidHealth(userId, app, engine) {
   const runtimeManager = app?.locals?.runtimeManager || engine?.runtimeManager || null;
-  let controller = null;
-  let resolutionError = null;
-
-  if (runtimeManager && typeof runtimeManager.getAndroidProviderForUser === 'function') {
-    try {
-      controller = await runtimeManager.getAndroidProviderForUser(userId);
-    } catch (err) {
-      resolutionError = err;
-    }
-  }
-
-  if (!controller) {
-    resolutionError = resolutionError || new Error('Android provider is unavailable. VM runtime is required.');
-  }
-
-  if (!controller || typeof controller.getStatus !== 'function') {
+  if (!runtimeManager) {
     return capabilityEntry({
-      degraded: Boolean(resolutionError),
-      summary: resolutionError
-        ? `Android controller resolution failed: ${resolutionError.message}`
-        : 'Android controller is not available.',
-      details: resolutionError ? { error: resolutionError.message } : {},
+      summary: 'Android runtime is not available in this environment.',
     });
   }
 
-  try {
-    const status = await controller.getStatus();
-    const bootstrapped = status.bootstrapped === true;
-    const canBootstrap = status.canBootstrap === true;
-    return capabilityEntry({
-      connected: Array.isArray(status.devices) && status.devices.some((device) => device.status === 'device'),
-      configured: canBootstrap || bootstrapped,
-      healthy: canBootstrap || bootstrapped,
-      degraded: Boolean(status.lastStartError),
-      summary: status.lastStartError
-        ? `Android tooling reported: ${status.lastStartError}`
-        : bootstrapped
-          ? 'Android environment is ready on this host.'
-          : (canBootstrap ? 'Android environment can be bootstrapped on this host.' : 'Android tooling cannot bootstrap on this host.'),
-      details: status,
-    });
-  } catch (err) {
-    return capabilityEntry({
-      configured: true,
-      healthy: false,
-      degraded: true,
-      summary: `Android status check failed: ${err.message}`,
-      details: { error: err.message },
-    });
-  }
+  // Like browser health, Android health is a snapshot. Creating a controller or
+  // running adb here makes unrelated chat turns pay runtime startup/status costs.
+  const runtimeSnapshot = typeof runtimeManager.getCapabilitySnapshot === 'function'
+    ? runtimeManager.getCapabilitySnapshot(userId)
+    : null;
+  const status = runtimeSnapshot?.android?.status || null;
+  const bootstrapped = status?.bootstrapped === true;
+  const starting = status?.starting === true;
+  const lastStartError = String(status?.lastStartError || '').trim();
+  return capabilityEntry({
+    connected: bootstrapped,
+    configured: true,
+    healthy: !lastStartError,
+    degraded: Boolean(lastStartError),
+    summary: lastStartError
+      ? `Android tooling reported: ${lastStartError}`
+      : bootstrapped
+        ? 'Android environment is ready.'
+        : starting
+          ? 'Android environment is starting.'
+          : 'Android runtime is available and will initialize on first use.',
+    details: status || {
+      initialized: runtimeSnapshot?.android?.initialized === true,
+      bootstrapped: false,
+      starting: false,
+    },
+  });
 }
 
 function getMessagingHealth(userId, app, engine, agentId = null) {
@@ -342,7 +304,9 @@ function getTaskHealth(userId, agentId = null) {
 }
 
 async function getCapabilityHealth({ userId, agentId = null, app, engine }) {
-  const providers = await getProviderHealthCatalog(userId, agentId);
+  const providers = await getProviderHealthCatalog(userId, agentId, {
+    probeLocal: false,
+  });
 
   return {
     providers,
@@ -363,6 +327,8 @@ async function getCapabilityHealth({ userId, agentId = null, app, engine }) {
 }
 
 module.exports = {
+  getAndroidHealth,
+  getBrowserHealth,
   getCapabilityHealth,
   summarizeCapabilityHealth,
 };

package/server/services/ai/compaction.js

@@ -1,4 +1,4 @@
-async function compact(messages, provider, model, contextWindow = null) {
+async function compact(messages, provider, model, contextWindow = null, options = {}) {
   const systemMsg = messages.find(m => m.role === 'system');
   const nonSystem = messages.filter(m => m.role !== 'system');
   const beforeTokens = estimateTokenCount(messages);
@@ -26,7 +26,11 @@ async function compact(messages, provider, model, contextWindow = null) {
   ];
 
   try {
-    const response = await provider.chat(summaryPrompt, [], { model, maxTokens: 1600 });
+    const response = await provider.chat(summaryPrompt, [], {
+      model,
+      maxTokens: 1600,
+      signal: options.signal,
+    });
     const summary = response.content || 'Previous conversation context (summary unavailable).';
 
     const compactedMessages = [];
@@ -44,6 +48,7 @@ async function compact(messages, provider, model, contextWindow = null) {
     }
     return compactedMessages;
   } catch (err) {
+    if (options.signal?.aborted) throw err;
     console.error('Compaction failed:', err.message);
     const trimmed = [];
     if (systemMsg) trimmed.push(systemMsg);

package/server/services/ai/history.js

@@ -1,5 +1,8 @@
+'use strict';
+
 const db = require('../../db/database');
 const { resolveAgentId } = require('../agents/manager');
+const { throwIfAborted } = require('../../utils/abort');
 
 const WEB_SUMMARY_KEY = 'web_chat_summary';
 const WEB_SUMMARY_COUNT_KEY = 'web_chat_summary_count';
@@ -109,13 +112,21 @@ function serializeHistoryForSummary(messages) {
   }).join('\n');
 }
 
-async function summarizeMessages(provider, model, existingSummary, messages, label = 'conversation') {
+async function summarizeMessages(
+  provider,
+  model,
+  existingSummary,
+  messages,
+  label = 'conversation',
+  options = {},
+) {
   if (!messages.length) return existingSummary || '';
+  throwIfAborted(options.signal, 'Conversation summary refresh aborted.');
 
   const prompt = [
     {
       role: 'system',
-      content: 'Compress conversation context. Preserve user goals, constraints, preferences, decisions, promised follow-ups, recurring schedules, important facts, tool outcomes, and unresolved issues. Keep concrete details (names, dates, times, statuses) and avoid vague wording. Keep the same personality context. Output plain text only.'
+      content: 'Compress conversation context. Preserve user goals, constraints, preferences, decisions, promised follow-ups, recurring schedules, important facts, tool outcomes, unresolved issues, and any user-stated communication preferences. Keep concrete details (names, dates, times, statuses) and avoid vague wording. Output plain text only.'
     },
     {
       role: 'user',
@@ -127,7 +138,12 @@ async function summarizeMessages(provider, model, existingSummary, messages, lab
     }
   ];
 
-  const response = await provider.chat(prompt, [], { model, maxTokens: 900 });
+  const response = await provider.chat(prompt, [], {
+    model,
+    maxTokens: 900,
+    signal: options.signal,
+  });
+  throwIfAborted(options.signal, 'Conversation summary refresh aborted.');
   return clampSummary(response.content || existingSummary || '');
 }
 
@@ -183,7 +199,15 @@ async function refreshWebChatSummary(userId, provider, model, recentLimit, force
     'SELECT role, content FROM conversation_history WHERE user_id = ? AND agent_id = ? ORDER BY created_at ASC LIMIT ? OFFSET ?'
   ).all(userId, agentId, newMessages, count);
 
-  const nextSummary = clampSummary(await summarizeMessages(provider, model, summary, normalizeHistoryRows(rows), 'web chat'));
+  const nextSummary = clampSummary(await summarizeMessages(
+    provider,
+    model,
+    summary,
+    normalizeHistoryRows(rows),
+    'web chat',
+    options,
+  ));
+  throwIfAborted(options.signal, 'Web chat summary refresh aborted.');
   const upsert = db.prepare(
     'INSERT INTO agent_settings (user_id, agent_id, key, value) VALUES (?, ?, ?, ?) ON CONFLICT(user_id, agent_id, key) DO UPDATE SET value = excluded.value'
   );
@@ -214,7 +238,14 @@ function getConversationContext(conversationId, recentLimit) {
   };
 }
 
-async function refreshConversationSummary(conversationId, provider, model, recentLimit, force = false) {
+async function refreshConversationSummary(
+  conversationId,
+  provider,
+  model,
+  recentLimit,
+  force = false,
+  options = {},
+) {
   const convo = db.prepare(
     'SELECT summary, summary_message_count FROM conversations WHERE id = ?'
   ).get(conversationId);
@@ -233,7 +264,15 @@ async function refreshConversationSummary(conversationId, provider, model, recen
     'SELECT role, content, tool_calls, tool_call_id, name FROM conversation_messages WHERE conversation_id = ? ORDER BY created_at ASC LIMIT ? OFFSET ?'
   ).all(conversationId, newMessages, currentCount);
 
-  const nextSummary = clampSummary(await summarizeMessages(provider, model, convo.summary || '', normalizeHistoryRows(rows), 'thread'));
+  const nextSummary = clampSummary(await summarizeMessages(
+    provider,
+    model,
+    convo.summary || '',
+    normalizeHistoryRows(rows),
+    'thread',
+    options,
+  ));
+  throwIfAborted(options.signal, 'Conversation summary refresh aborted.');
   db.prepare(
     "UPDATE conversations SET summary = ?, summary_message_count = ?, last_summary = datetime('now') WHERE id = ?"
   ).run(nextSummary, targetCount, conversationId);

package/server/services/ai/integrated_tools/http_request.js

@@ -0,0 +1,8 @@
+'use strict';
+
+const safeRequest = require('../../network/safe_request');
+
+module.exports = {
+  ...safeRequest,
+  executeHttpRequest: safeRequest.executeSafeHttpRequest,
+};