neoagent 2.0.3 → 2.0.5

package/server/routes/auth.js

@@ -13,6 +13,30 @@ const authLimiter = rateLimit({
   legacyHeaders: false
 });
 
+function establishSession(req, res, user) {
+  req.session.regenerate((regenerateError) => {
+    if (regenerateError) {
+      console.error('Auth session regenerate error:', regenerateError);
+      return res.status(500).json({ error: 'Session error' });
+    }
+
+    req.session.userId = user.id;
+    req.session.username = user.username;
+    req.session.save((saveError) => {
+      if (saveError) {
+        console.error('Auth session save error:', saveError);
+        return res.status(500).json({ error: 'Session save error' });
+      }
+
+      return res.json({
+        success: true,
+        redirect: '/app',
+        user: { id: user.id, username: user.username }
+      });
+    });
+  });
+}
+
 router.get('/api/auth/status', (req, res) => {
   const count = db.prepare('SELECT COUNT(*) as count FROM users').get();
   res.json({ hasUser: count.count > 0 });
@@ -36,14 +60,9 @@ router.post('/api/auth/register', authLimiter, async (req, res) => {
     const hash = await bcrypt.hash(password, 12);
     const result = db.prepare('INSERT INTO users (username, password) VALUES (?, ?)').run(username, hash);
 
-    req.session.regenerate((err) => {
-      if (err) return res.status(500).json({ error: 'Session error' });
-      req.session.userId = result.lastInsertRowid;
-      req.session.username = username;
-      req.session.save((err) => {
-        if (err) return res.status(500).json({ error: 'Session save error' });
-        res.json({ success: true, redirect: '/app', user: { id: result.lastInsertRowid, username } });
-      });
+    establishSession(req, res, {
+      id: result.lastInsertRowid,
+      username
     });
   } catch (err) {
     console.error('Register error:', err);
@@ -68,17 +87,14 @@ router.post('/api/auth/login', authLimiter, async (req, res) => {
       return res.status(401).json({ error: 'Invalid credentials' });
     }
 
-    db.prepare('UPDATE users SET last_login = datetime(\'now\') WHERE id = ?').run(user.id);
+    try {
+      db.prepare('UPDATE users SET last_login = datetime(\'now\') WHERE id = ?').run(user.id);
+    } catch (updateError) {
+      // Keep login functional even if analytics-style metadata cannot be written.
+      console.warn('Login last_login update failed:', updateError);
+    }
 
-    req.session.regenerate((err) => {
-      if (err) return res.status(500).json({ error: 'Session error' });
-      req.session.userId = user.id;
-      req.session.username = user.username;
-      req.session.save((err) => {
-        if (err) return res.status(500).json({ error: 'Session save error' });
-        res.json({ success: true, redirect: '/app', user: { id: user.id, username: user.username } });
-      });
-    });
+    establishSession(req, res, user);
   } catch (err) {
     console.error('Login error:', err);
     res.status(500).json({ error: 'Login failed' });

package/server/services/health/ingestion.js

@@ -137,12 +137,30 @@ function ingestHealthSync(userId, body = {}) {
   return ingestHealthSyncTx(userId, body);
 }
 
+function hydrateRun(row) {
+  if (!row) return null;
+  return {
+    ...row,
+    summary: (() => {
+      try { return JSON.parse(row.summary_json || '{}'); } catch { return {}; }
+    })(),
+  };
+}
+
 function getHealthSyncStatus(userId) {
   const lastRun = db.prepare(`
     SELECT id, source, provider, sync_window_start, sync_window_end, record_count, summary_json, created_at
     FROM health_sync_runs
     WHERE user_id = ?
-    ORDER BY created_at DESC
+    ORDER BY created_at DESC, rowid DESC
+    LIMIT 1
+  `).get(userId);
+
+  const lastNonEmptyRun = db.prepare(`
+    SELECT id, source, provider, sync_window_start, sync_window_end, record_count, summary_json, created_at
+    FROM health_sync_runs
+    WHERE user_id = ? AND record_count > 0
+    ORDER BY created_at DESC, rowid DESC
     LIMIT 1
   `).get(userId);
 
@@ -155,12 +173,8 @@ function getHealthSyncStatus(userId) {
   `).all(userId);
 
   return {
-    lastRun: lastRun ? {
-      ...lastRun,
-      summary: (() => {
-        try { return JSON.parse(lastRun.summary_json || '{}'); } catch { return {}; }
-      })(),
-    } : null,
+    lastRun: hydrateRun(lastRun),
+    lastNonEmptyRun: hydrateRun(lastNonEmptyRun),
     metrics: metrics.map((metric) => ({
       metricType: metric.metric_type,
       sampleCount: Number(metric.sample_count || 0),