neo4j-driver 4.4.0-beta02 → 4.4.0

package/lib/browser/neo4j-web.js

@@ -5692,6 +5692,9 @@ var ChannelConnection = /** @class */ (function (_super) {
     };
     ChannelConnection.prototype._resetOnFailure = function () {
         var _this = this;
+        if (!this.isOpen()) {
+            return;
+        }
         this._protocol.reset({
             onError: function () {
                 _this._protocol.resetFailure();
@@ -8012,9 +8015,29 @@ var Pool = /** @class */ (function () {
      * @returns {Promise<void>} A promise that is resolved when the resources are purged
      */
     Pool.prototype.close = function () {
-        var _this = this;
-        this._closed = true;
-        return Promise.all(Object.keys(this._pools).map(function (key) { return _this._purgeKey(key); }));
+        return __awaiter(this, void 0, void 0, function () {
+            var _this = this;
+            return __generator(this, function (_a) {
+                switch (_a.label) {
+                    case 0:
+                        this._closed = true;
+                        return [4 /*yield*/, Promise.all(Object.keys(this._pools).map(function (key) { return _this._purgeKey(key); }))];
+                    case 1: 
+                    /**
+                     * The lack of Promise consuming was making the driver do not close properly in the scenario
+                     * captured at result.test.js:it('should handle missing onCompleted'). The test was timing out
+                     * because while wainting for the driver close.
+                     *
+                     * Consuming the Promise.all or by calling then or by awaiting in the result inside this method solved
+                     * the issue somehow.
+                     *
+                     * PS: the return of this method was already awaited at PooledConnectionProvider.close, but the await bellow
+                     * seems to be need also.
+                     */
+                    return [2 /*return*/, _a.sent()];
+                }
+            });
+        });
     };
     /**
      * Keep the idle resources for the provided addresses and purge the rest.
@@ -11665,10 +11688,13 @@ var ConnectionHolder = /** @class */ (function () {
         this._connectionPromise = this._connectionPromise
             .then(function (connection) {
             if (connection) {
-                return connection
-                    .resetAndFlush()
-                    .catch(ignoreError)
-                    .then(function () { return connection._release(); });
+                if (connection.isOpen()) {
+                    return connection
+                        .resetAndFlush()
+                        .catch(ignoreError)
+                        .then(function () { return connection._release(); });
+                }
+                return connection._release();
             }
             else {
                 return Promise.resolve();
@@ -15213,8 +15239,10 @@ var Session = /** @class */ (function () {
         return this._transactionExecutor.execute(function () { return _this._beginTransaction(accessMode, transactionConfig); }, transactionWork);
     };
     /**
+     * Sets the resolved database name in the session context.
      * @private
      * @param {string|undefined} database The resolved database name
+     * @returns {void}
      */
     Session.prototype._onDatabaseNameResolved = function (database) {
         if (!this._databaseNameResolved) {