neo4j-driver 4.3.2 → 4.3.6

package/lib/browser/neo4j-web.js

@@ -129,6 +129,13 @@ var BoltProtocol = /** @class */ (function () {
         enumerable: false,
         configurable: true
     });
+    Object.defineProperty(BoltProtocol.prototype, "currentFailure", {
+        get: function () {
+            return this._responseHandler.currentFailure;
+        },
+        enumerable: false,
+        configurable: true
+    });
     /**
      * Get the packer.
      * @return {Packer} the protocol's packer.
@@ -1693,6 +1700,13 @@ var ResponseHandler = /** @class */ (function () {
                 this._observer.onError(neo4j_driver_core_1.newError('Unknown Bolt protocol message: ' + msg));
         }
     };
+    Object.defineProperty(ResponseHandler.prototype, "currentFailure", {
+        get: function () {
+            return this._currentFailure;
+        },
+        enumerable: false,
+        configurable: true
+    });
     /*
      * Pop next pending observer form the list of observers and make it current observer.
      * @protected
@@ -4771,7 +4785,8 @@ var RoutingConnectionProvider = /** @class */ (function (_super) {
     };
     RoutingConnectionProvider.prototype._createSessionForRediscovery = function (routerAddress, bookmark) {
         return __awaiter(this, void 0, void 0, function () {
-            var connection, connectionProvider, protocolVersion, error_4;
+            var connection, databaseSpecificErrorHandler, connectionProvider, protocolVersion, error_4;
+            var _this = this;
             return __generator(this, function (_a) {
                 switch (_a.label) {
                     case 0:
@@ -4779,7 +4794,11 @@ var RoutingConnectionProvider = /** @class */ (function (_super) {
                         return [4 /*yield*/, this._connectionPool.acquire(routerAddress)];
                     case 1:
                         connection = _a.sent();
-                        connectionProvider = new connection_provider_single_1.default(connection);
+                        databaseSpecificErrorHandler = connection_1.ConnectionErrorHandler.create({
+                            errorCode: SESSION_EXPIRED,
+                            handleAuthorizationExpired: function (error, address) { return _this._handleAuthorizationExpired(error, address); }
+                        });
+                        connectionProvider = new connection_provider_single_1.default(new connection_1.DelegateConnection(connection, databaseSpecificErrorHandler));
                         protocolVersion = connection.protocol().version;
                         if (protocolVersion < 4.0) {
                             return [2 /*return*/, new neo4j_driver_core_1.Session({
@@ -5363,7 +5382,7 @@ var ChannelConnection = /** @class */ (function (_super) {
      */
     ChannelConnection.prototype._handleFatalError = function (error) {
         this._isBroken = true;
-        this._error = this.handleAndTransformError(error, this._address);
+        this._error = this.handleAndTransformError(this._protocol.currentFailure || error, this._address);
         if (this._log.isErrorEnabled()) {
             this._log.error("experienced a fatal error " + neo4j_driver_core_1.json.stringify(this._error));
         }
@@ -5406,6 +5425,9 @@ var ChannelConnection = /** @class */ (function (_super) {
     };
     ChannelConnection.prototype._resetOnFailure = function () {
         var _this = this;
+        if (!this.isOpen()) {
+            return;
+        }
         this._protocol.reset({
             onError: function () {
                 _this._protocol.resetFailure();
@@ -6835,7 +6857,7 @@ var Unpacker = /** @class */ (function () {
         var prevNode = nodes[0];
         for (var i = 0; i < sequence.length; i += 2) {
             var nextNode = nodes[sequence[i + 1]];
-            var relIndex = sequence[i];
+            var relIndex = neo4j_driver_core_1.toNumber(sequence[i]);
             var rel = void 0;
             if (relIndex > 0) {
                 rel = rels[relIndex - 1];
@@ -7725,9 +7747,29 @@ var Pool = /** @class */ (function () {
      * @returns {Promise<void>} A promise that is resolved when the resources are purged
      */
     Pool.prototype.close = function () {
-        var _this = this;
-        this._closed = true;
-        return Promise.all(Object.keys(this._pools).map(function (key) { return _this._purgeKey(key); }));
+        return __awaiter(this, void 0, void 0, function () {
+            var _this = this;
+            return __generator(this, function (_a) {
+                switch (_a.label) {
+                    case 0:
+                        this._closed = true;
+                        return [4 /*yield*/, Promise.all(Object.keys(this._pools).map(function (key) { return _this._purgeKey(key); }))];
+                    case 1: 
+                    /**
+                     * The lack of Promise consuming was making the driver do not close properly in the scenario
+                     * captured at result.test.js:it('should handle missing onCompleted'). The test was timing out
+                     * because while wainting for the driver close.
+                     *
+                     * Consuming the Promise.all or by calling then or by awaiting in the result inside this method solved
+                     * the issue somehow.
+                     *
+                     * PS: the return of this method was already awaited at PooledConnectionProvider.close, but the await bellow
+                     * seems to be need also.
+                     */
+                    return [2 /*return*/, _a.sent()];
+                }
+            });
+        });
     };
     /**
      * Keep the idle resources for the provided addresses and purge the rest.
@@ -9579,7 +9621,7 @@ var Node = /** @class */ (function () {
      * @protected
      * @param {Integer|number} identity - Unique identity
      * @param {Array<string>} labels - Array for all labels
-     * @param {Object} properties - Map with node properties
+     * @param {Properties} properties - Map with node properties
      */
     function Node(identity, labels, properties) {
         /**
@@ -9594,7 +9636,7 @@ var Node = /** @class */ (function () {
         this.labels = labels;
         /**
          * Properties of the node.
-         * @type {Object}
+         * @type {Properties}
          */
         this.properties = properties;
     }
@@ -9643,7 +9685,7 @@ var Relationship = /** @class */ (function () {
      * @param {Integer|number} start - Identity of start Node
      * @param {Integer|number} end - Identity of end Node
      * @param {string} type - Relationship type
-     * @param {Object} properties - Map with relationship properties
+     * @param {Properties} properties - Map with relationship properties
      */
     function Relationship(identity, start, end, type, properties) {
         /**
@@ -9668,7 +9710,7 @@ var Relationship = /** @class */ (function () {
         this.type = type;
         /**
          * Properties of the relationship.
-         * @type {Object}
+         * @type {Properties}
          */
         this.properties = properties;
     }
@@ -9713,7 +9755,7 @@ var UnboundRelationship = /** @class */ (function () {
      * @protected
      * @param {Integer|number} identity - Unique identity
      * @param {string} type - Relationship type
-     * @param {Object} properties - Map with relationship properties
+     * @param {Properties} properties - Map with relationship properties
      */
     function UnboundRelationship(identity, type, properties) {
         /**
@@ -9728,7 +9770,7 @@ var UnboundRelationship = /** @class */ (function () {
         this.type = type;
         /**
          * Properties of the relationship.
-         * @type {Object}
+         * @type {Properties}
          */
         this.properties = properties;
     }
@@ -11246,10 +11288,13 @@ var ConnectionHolder = /** @class */ (function () {
         this._connectionPromise = this._connectionPromise
             .then(function (connection) {
             if (connection) {
-                return connection
-                    .resetAndFlush()
-                    .catch(ignoreError)
-                    .then(function () { return connection._release(); });
+                if (connection.isOpen()) {
+                    return connection
+                        .resetAndFlush()
+                        .catch(ignoreError)
+                        .then(function () { return connection._release(); });
+                }
+                return connection._release();
             }
             else {
                 return Promise.resolve();
@@ -27803,7 +27848,7 @@ exports["default"] = void 0;
 // This is set up this way to keep the version in the code in
 // sync with the npm package version, and to allow the build
 // system to control version names at packaging time.
-var _default = '4.3.2';
+var _default = '4.3.6';
 exports["default"] = _default;
 
 },{}]},{},[296])(296)