neo.mjs 7.0.6 → 7.1.0

package/resources/data/deck/learnneo/pages/{TodoList.md → tutorials/TodoList.md}

@@ -175,64 +175,54 @@ class MainContainer extends Container {
         className: 'Neo.examples.todoList.version2.MainContainer',
         style    : {padding: '20px'},
 
-        // custom configs
-        idCounter: 3,
-        store    : null
-    }
-
-    construct(config) {
-        super.construct(config);
-
-        let me = this;
-
-        me.store = Neo.create({
-            module: TodoListStore
-        });
-
-        me.items = [{
+        items: [{
             module       : List,
             displayField : 'text',
             flex         : 1,
-            store        : me.store,
+            reference    : 'todo-list',
+            store        : TodoListStore,
             style        : {padding: '5px'},
             useCheckBoxes: true
         }, {
             module: Toolbar,
-            flex  : 'none',
             dock  : 'bottom',
+            flex  : 'none',
             items : [{
                 module       : TextField,
                 flex         : 1,
                 labelPosition: 'inline',
                 labelText    : 'Item Text',
-                reference    : 'addItemField'
+                reference    : 'add-item-field'
             }, '->', {
-                handler     : me.onAddButtonClick,
-                handlerScope: me,
-                scope       : me,
-                style       : {height: '27px', marginLeft: '1em'},
-                text        : 'Add Item'
+                handler: 'up.onAddButtonClick',
+                style  : {height: '27px', marginLeft: '1em'},
+                text   : 'Add Item'
             }]
-        }];
+        }]
     }
 
-    onAddButtonClick() {
+    idCounter = 0
+
+    /**
+     *
+     */
+    onConstructed() {
+        super.onConstructed();
+        this.idCounter = this.getReference('todo-list').store.getCount()
+    }
+
+    onAddButtonClick(data) {
         let me    = this,
-            field = me.down({reference: 'addItemField'}),
-            data;
+            field = me.getReference('add-item-field');
 
         if (field.value) {
             me.idCounter++;
 
-            data = me.store.data;
-
-            data.push({
+            me.getReference('todo-list').store.add({
                 id  : me.idCounter,
                 done: false,
                 text: field.value
-            });
-
-            me.store.data = data
+            })
         }
     }
 }

package/resources/data/deck/learnneo/tree.json

@@ -1,50 +1,47 @@
 {"data": [
-    {"name":  "Welcome!",                                   "parentId": null,                "isLeaf":  true, "id": "Welcome" },
-    {"name": "Benefits",                                    "parentId": null,                "isLeaf": false, "id": "WhyNeo"},
-        {"name": "Introduction ",                           "parentId": "WhyNeo",            "isLeaf": true,  "id": "WhyNeo-Intro"},
-        {"name": "Off the Main Thread",                     "parentId": "WhyNeo",            "isLeaf": true,  "id": "benefits.Multi-Threading"},
-        {"name": "Extreme Speed",                           "parentId": "WhyNeo",            "isLeaf": true,  "id": "WhyNeo-Speed"},
-        {"name": "Multi-Window Applications",               "parentId": "WhyNeo",            "isLeaf": true,  "id": "WhyNeo-Multi-Window"},
-        {"name": "Quick Application Development",           "parentId": "WhyNeo",            "isLeaf": true,  "id": "WhyNeo-Quick"},
-        {"name": "Complexity and Effort",                   "parentId": "WhyNeo",            "isLeaf": true,  "id": "WhyNeo-Effort"},
-        {"name": "Forms Engine",                            "parentId": "WhyNeo",            "isLeaf": true,  "id": "benefits.FormsEngine"},
-        {"name": "Features and Benefits Summary",           "parentId": "WhyNeo",            "isLeaf": true,  "id": "WhyNeo-Features"},
-    {"name": "Getting Started",                             "parentId": null,                "isLeaf": false, "id": "GettingStarted", "collapsed":  true},
-        {"name": "Setup",                                   "parentId": "GettingStarted",    "isLeaf": true,  "id": "Setup"},
-        {"name": "Workspaces and Applications",             "parentId": "GettingStarted",    "isLeaf": true,  "id": "2023-10-14T19-25-08-153Z"},
-        {"name": "Describing a View",                       "parentId": "GettingStarted",    "isLeaf": true,  "id": "DescribingTheUI"},
-        {"name": "Events",                                  "parentId": "GettingStarted",    "isLeaf": true,  "id": "Events"},
-        {"name": "Component References",                    "parentId": "GettingStarted",    "isLeaf": true,  "id": "References"},
-        {"name": "Extending Classes",                       "parentId": "GettingStarted",    "isLeaf": true,  "id": "Extending"},
-        {"name": "Config",                                  "parentId": "GettingStarted",    "isLeaf": true,  "id": "Config"},
-        {"name": "Shared Bindable Data",                    "parentId": "GettingStarted",    "isLeaf": true,  "id": "ComponentModels"},
-    {"name": "Tutorials",                                   "parentId": null,                "isLeaf": false, "expanded": false, "id": "Tutorials",  "collapsed":  true},
-        {"name": "Rock Scissors Paper",                     "parentId": "Tutorials",         "isLeaf": true,  "expanded": false, "id": "RSP", "hidden":  true},
-        {"name": "Earthquakes",                             "parentId": "Tutorials",         "isLeaf": true,  "expanded": false, "id": "Earthquakes", "collapsed":  true},
-        {"name": "Todo List",                               "parentId": "Tutorials",         "isLeaf": true,  "expanded": false, "id": "TodoList"},
-    {"name": "Guides",                                      "parentId": null,                "isLeaf": false, "expanded": false, "id": "InDepth",  "collapsed":  true},
-        {"name": "Config",                                  "parentId": "InDepth",           "isLeaf": false, "id": "Config"},
-        {"name": "Instance Lifecycle",                      "parentId": "InDepth",           "isLeaf": false, "id": "InstanceLifecycle", "hidden":  true},
-        {"name": "User Input (Forms)",                      "parentId": "InDepth",           "isLeaf": false, "id": "Forms",  "hidden":  true},
-        {"name": "Component and Container Basics",          "parentId": "InDepth",           "isLeaf": true,  "id": "ComponentsAndContainers"},
-        {"name": "Layouts",                                 "parentId": "InDepth",           "isLeaf": false, "id": "Layouts", "hidden":  true},
-        {"name": "View Models",                             "parentId": "InDepth",           "isLeaf": true,  "id": "GuideViewModels"},
-        {"name": "Custom Components",                       "parentId": "InDepth",           "isLeaf": true,  "id": "CustomComponents", "hidden":  true},
-        {"name": "Events",                                  "parentId": "InDepth",           "isLeaf": true,  "expanded": false, "id": "GuideEvents"},
-        {"name": "Tables (Stores)",                         "parentId": "InDepth",           "isLeaf": false, "id": "Tables", "hidden":  true},
-        {"name": "Shared Bindable Data (Component Models)", "parentId": "InDepth",           "isLeaf": false, "id": "InDepthComponentModels", "hidden":  true},
-        {"name": "Multi-Window Applications",               "parentId": "InDepth",           "isLeaf": false, "id": "MultiWindow", "hidden":  true},
-        {"name": "Main Thread Addons",                      "parentId": "InDepth",           "isLeaf": false, "id": "MainThreadAddons", "hidden":  true},
-            {"name": "Introduction",                        "parentId": "MainThreadAddons",  "isLeaf": true,  "id": "MainThreadAddonIntro"},
-            {"name": "Example",                             "parentId": "MainThreadAddons",  "isLeaf": true,  "id": "MainThreadAddonExample"},
-        {"name": "Mixins",                                  "parentId": "InDepth",           "isLeaf": false, "id": "Mixins", "hidden":  true},
-    {"name": "JavaScript Classes",                          "parentId": null,                "isLeaf": false, "id": "JavaScriptClasses", "hidden":  true},
-        {"name": "Classes, Properties, and Methods",        "parentId": "JavaScriptClasses", "isLeaf": true,  "id": "2023-10-07T19-18-28-517Z"},
-        {"name": "Overriding Methods",                      "parentId": "JavaScriptClasses", "isLeaf": true,  "id": "2023-10-08T20-20-07-934Z"},
-        {"name": "Other JavaScript Class Features",         "parentId": "JavaScriptClasses", "isLeaf": true,  "id": "2023-10-08T20-20-37-336Z"},
-        {"name": "Super",                                   "parentId": "JavaScriptClasses", "isLeaf": true,  "id": "2023-10-08T21-58-25-809Z"},
-        {"name": "New Node",                                "parentId": "JavaScriptClasses", "isLeaf": true,  "id": "2023-10-31T13-59-37-550Z"},
-    {"name": "Appendix",                                    "parentId": null,                                 "id": "appendix",  "hidden":  true, "collapsed":  true},
-        {"name": "Stylesheet",                              "parentId": "appendix",          "isLeaf": true,  "id": "stylesheet"},
-        {"name": "Test",                                    "parentId": "appendix",          "isLeaf": true,  "id": "TestLivePreview"}
+    {"name": "Welcome!",                                    "parentId": null,                                 "id": "Welcome" },
+    {"name": "Benefits",                                    "parentId": null,                "isLeaf": false, "id": "Benefits"},
+        {"name": "Introduction ",                           "parentId": "Benefits",                           "id": "benefits.Introduction"},
+        {"name": "Off the Main Thread",                     "parentId": "Benefits",                           "id": "benefits.Multi-Threading"},
+        {"name": "Extreme Speed",                           "parentId": "Benefits",                           "id": "benefits.Speed"},
+        {"name": "Multi-Window Applications",               "parentId": "Benefits",                           "id": "benefits.Multi-Window"},
+        {"name": "Quick Application Development",           "parentId": "Benefits",                           "id": "benefits.Quick"},
+        {"name": "Complexity and Effort",                   "parentId": "Benefits",                           "id": "benefits.Effort"},
+        {"name": "Forms Engine",                            "parentId": "Benefits",                           "id": "benefits.FormsEngine"},
+        {"name": "Features and Benefits Summary",           "parentId": "Benefits",                           "id": "benefits.Features"},
+    {"name": "Getting Started",                             "parentId": null,                "isLeaf": false, "id": "GettingStarted", "collapsed": true},
+        {"name": "Setup",                                   "parentId": "GettingStarted",                     "id": "gettingstarted.Setup"},
+        {"name": "Workspaces and Applications",             "parentId": "GettingStarted",                     "id": "gettingstarted.Workspaces"},
+        {"name": "Describing a View",                       "parentId": "GettingStarted",                     "id": "gettingstarted.DescribingTheUI"},
+        {"name": "Events",                                  "parentId": "GettingStarted",                     "id": "gettingstarted.Events"},
+        {"name": "Component References",                    "parentId": "GettingStarted",                     "id": "gettingstarted.References"},
+        {"name": "Extending Classes",                       "parentId": "GettingStarted",                     "id": "gettingstarted.Extending"},
+        {"name": "Config",                                  "parentId": "GettingStarted",                     "id": "gettingstarted.Config"},
+        {"name": "Shared Bindable Data",                    "parentId": "GettingStarted",                     "id": "gettingstarted.ComponentModels"},
+    {"name": "Tutorials",                                   "parentId": null,                "isLeaf": false, "id": "Tutorials",  "collapsed": true},
+        {"name": "Rock Scissors Paper",                     "parentId": "Tutorials",                          "id": "tutorials.RSP", "hidden": true},
+        {"name": "Earthquakes",                             "parentId": "Tutorials",                          "id": "tutorials.Earthquakes"},
+        {"name": "Todo List",                               "parentId": "Tutorials",                          "id": "tutorials.TodoList"},
+    {"name": "Guides",                                      "parentId": null,                "isLeaf": false, "id": "InDepth",  "collapsed": true},
+        {"name": "Instance Lifecycle",                      "parentId": "InDepth",                            "id": "guides.InstanceLifecycle", "hidden": true},
+        {"name": "User Input (Forms)",                      "parentId": "InDepth",                            "id": "guides.Forms",  "hidden": true},
+        {"name": "Component and Container Basics",          "parentId": "InDepth",                            "id": "guides.ComponentsAndContainers"},
+        {"name": "Layouts",                                 "parentId": "InDepth",           "isLeaf": false, "id": "guides.Layouts", "hidden": true},
+        {"name": "Shared Bindable Data (Component Models)", "parentId": "InDepth",                            "id": "guides.ViewModels"},
+        {"name": "Custom Components",                       "parentId": "InDepth",                            "id": "guides.CustomComponents", "hidden": true},
+        {"name": "Events",                                  "parentId": "InDepth",           "isLeaf": false, "id": "GuideEvents"},
+            {"name": "Custom Events",                       "parentId": "GuideEvents",                        "id": "guides.events.CustomEvents"},
+            {"name": "DOM Events",                          "parentId": "GuideEvents",                        "id": "guides.events.DomEvents"},
+        {"name": "Tables (Stores)",                         "parentId": "InDepth",                            "id": "guides.Tables", "hidden": true},
+        {"name": "Multi-Window Applications",               "parentId": "InDepth",                            "id": "guides.MultiWindow", "hidden":  true},
+        {"name": "Main Thread Addons",                      "parentId": "InDepth",           "isLeaf": false, "id": "MainThreadAddons", "hidden": true},
+            {"name": "Introduction",                        "parentId": "MainThreadAddons",                   "id": "guides.MainThreadAddonIntro"},
+            {"name": "Example",                             "parentId": "MainThreadAddons",                   "id": "guides.MainThreadAddonExample"},
+        {"name": "Mixins",                                  "parentId": "InDepth",                            "id": "guides.Mixins", "hidden": true},
+    {"name": "JavaScript Classes",                          "parentId": null,                "isLeaf": false, "id": "JavaScript", "hidden": true},
+        {"name": "Classes, Properties, and Methods",        "parentId": "JavaScript",                         "id": "javascript.Classes"},
+        {"name": "Overriding Methods",                      "parentId": "JavaScript",                         "id": "javascript.Overrides"},
+        {"name": "Other JavaScript Class Features",         "parentId": "JavaScript",                         "id": "javascript.ClassFeatures"},
+        {"name": "Super",                                   "parentId": "JavaScript",                         "id": "javascript.Super"},
+        {"name": "New Node",                                "parentId": "JavaScript",                         "id": "javascript.NewNode"}
 ]}

package/src/DefaultConfig.mjs

@@ -262,12 +262,12 @@ const DefaultConfig = {
     useVdomWorker: true,
     /**
      * buildScripts/injectPackageVersion.mjs will update this value
-     * @default '7.0.6'
+     * @default '7.1.0'
      * @memberOf! module:Neo
      * @name config.version
      * @type String
      */
-    version: '7.0.6'
+    version: '7.1.0'
 };
 
 Object.assign(DefaultConfig, {

package/src/code/LivePreview.mjs

@@ -4,6 +4,7 @@ import TabContainer from '../tab/Container.mjs';
 
 const
     classDeclarationRegex = /class\s+([a-zA-Z$_][a-zA-Z0-9$_]*)\s*(?:extends\s+[a-zA-Z$_][a-zA-Z0-9$_]*)?\s*{[\s\S]*?}/g,
+    classNameRegex        = /className\s*:\s*['"]([^'"]+)['"]/g,
     exportRegex           = /export\s+(?:default\s+)?(?:const|let|var|class|function|async\s+function|generator\s+function|async\s+generator\s+function|(\{[\s\S]*?\}))/g,
     importRegex           = /import\s+([\w-]+)\s+from\s+['"]([^'"]+)['"]/;
 
@@ -294,6 +295,18 @@ class LivePreview extends Container {
 
         container.removeAll();
 
+        // We must ensure that classes inside the editor won't get cached, since this disables run-time changes
+        // See: https://github.com/neomjs/neo/issues/5863
+        me.findClassNames(codeString).forEach(item => {
+            let nsArray   = item.split('.'),
+                className = nsArray.pop(),
+                ns        = Neo.ns(nsArray);
+
+            if (ns) {
+                delete ns[className]
+            }
+        });
+
         try {
             new Function('container', codeString)(container);
         } catch (error) {
@@ -304,6 +317,21 @@ class LivePreview extends Container {
         }
     }
 
+    /**
+     * @param {String} sourceCode
+     * @returns {String[]}
+     */
+    findClassNames(sourceCode) {
+        let classNames = [],
+            match;
+
+        while ((match = classNameRegex.exec(sourceCode)) !== null) {
+            classNames.push(match[1])
+        }
+
+        return classNames
+    }
+
     /**
      * @param {String} sourceCode
      * @returns {String|null}
@@ -312,7 +340,6 @@ class LivePreview extends Container {
         let lastClassName = null,
             match;
 
-        // Iterate through all matches of the regular expression
         while ((match = classDeclarationRegex.exec(sourceCode)) !== null) {
             // Update the last class name found
             lastClassName = match[1]

package/src/collection/Base.mjs

@@ -76,6 +76,7 @@ class Base extends CoreBase {
         /**
          * A map containing the key & reference of each collection item for faster access
          * @member {Map} map_=null
+         * @protected
          */
         map_: null,
         /**

package/src/controller/Component.mjs

@@ -1,5 +1,6 @@
-import Base   from './Base.mjs';
-import Logger from '../util/Logger.mjs';
+import Base              from './Base.mjs';
+import {resolveCallback} from '../util/Function.mjs';
+import Logger            from '../util/Logger.mjs';
 
 /**
  * @class Neo.controller.Component
@@ -71,7 +72,7 @@ class Component extends Base {
 
     /**
      * @param {String} handlerName
-     * @param {Neo.component.Base} component
+     * @param {Neo.component.Base} [component]
      * @returns {Neo.controller.Component|Boolean|null}
      */
     getHandlerScope(handlerName, component) {
@@ -81,7 +82,7 @@ class Component extends Base {
         if (component) {
             // Look for ths function *name* first in the Component itself.
             // If we find it, return true so calling code knows not to continue to search.
-            const handlerCb = component.resolveCallback(handlerName, component);
+            const handlerCb = resolveCallback(handlerName, component);
 
             // Handler fn is resolved in the Component or its own parent chain.
             // Return a status indicating that we do not need an early binding
@@ -91,8 +92,7 @@ class Component extends Base {
         }
 
         return Neo.isFunction(me[handlerName]) ?
-            me : parent ?
-            parent.getHandlerScope(handlerName) : null
+            me : parent?.getHandlerScope(handlerName) || null
     }
 
     /**
@@ -114,7 +114,7 @@ class Component extends Base {
             {parent} = me;
 
         if (parent) {
-            return parent;
+            return parent
         }
 
         return me.component.parent?.getController() || null
@@ -238,9 +238,9 @@ class Component extends Base {
                     if (eventHandler) {
                         scope = me.getHandlerScope(eventHandler);
 
-                        if (!scope) {
-                            Logger.logError('Unknown domEvent handler for', eventHandler, component)
-                        } else {
+                        // There can be string based listeners like 'up.onClick', which will resolved inside manager.DomEvents
+                        // => Do nothing in case there is no match inside the controller hierarchy.
+                        if (scope) {
                             domListener[key] = scope[eventHandler].bind(scope)
                         }
                     }

package/src/core/Observable.mjs

@@ -1,4 +1,5 @@
-import Base from './Base.mjs';
+import Base              from './Base.mjs';
+import {resolveCallback} from '../util/Function.mjs';
 
 /**
  * @class Neo.core.Observable
@@ -136,7 +137,7 @@ class Observable extends Base {
      */
     callback(fn, scope=this, args) {
         if (fn) {
-            const handler = this.resolveCallback(fn, scope);
+            const handler = resolveCallback(fn, scope);
             handler.fn.apply(handler.scope, args)
         }
     }
@@ -172,7 +173,7 @@ class Observable extends Base {
 
                 // Resolve function name on the scope (or me), or, if it starts with 'up.'
                 // look in the ownership hierarchy from me.
-                const cb = me.resolveCallback(handler.fn, handler.scope || me);
+                const cb = resolveCallback(handler.fn, handler.scope || me);
 
                 // remove the listener if the scope no longer exists
                 if (cb.scope && !cb.scope.id) {
@@ -338,30 +339,6 @@ class Observable extends Base {
 
     // }
 
-    /**
-     * Locate a callable function by name in the passed scope.
-     *
-     * If the name starts with 'up.', the parent Component chain is searched.
-     *
-     * This is used by Observable.fire and by 'handler' function calls to resolve
-     * string function names in the Component's own hierarchy.
-     * @param {Function|String} fn A function, or the name of a function to find in the passed scope object/
-     * @param {Object} scope The scope to find the function in if it is specified as a string.
-     * @returns {Object}
-     */
-    resolveCallback(fn, scope=this) {
-        if (typeof fn === 'string') {
-            if (!scope[fn] && fn.startsWith('up.')) {
-                fn = fn.slice(3);
-                while (!scope[fn] && (scope = scope.parent));
-            }
-
-            fn = scope[fn]
-        }
-
-        return {fn, scope}
-    }
-
     /**
      * Alias for removeListener
      * @param {Object|String} name

package/src/grid/View.mjs

@@ -23,6 +23,27 @@ class View extends Component {
         baseCls: ['neo-grid-view']
     }
 
+    /**
+     * @param config
+     */
+    construct(config) {
+        super.construct(config);
+
+        let me = this;
+
+        me.addDomListeners([{
+            click   : me.onCellClick,
+            dblclick: me.onCellDoubleClick,
+            delegate: '.neo-grid-cell',
+            scope   : me
+        }, {
+            click   : me.onRowClick,
+            dblclick: me.onRowDoubleClick,
+            delegate: '.neo-grid-row',
+            scope   : me
+        }])
+    }
+
     /**
      * @param {Array} inputData
      */
@@ -169,6 +190,39 @@ class View extends Component {
         super.destroy(updateParentVdom, silent)
     }
 
+    /**
+     * @param {Object} data
+     * @param {String} eventName
+     */
+    fireCellEvent(data, eventName) {
+        let me        = this,
+            {id}      = data.target,
+            dataField = me.getCellDataField(id),
+            record    = me.getRecord(id);
+
+        me.parent.fire(eventName, {id: me, data, dataField, record})
+    }
+
+    /**
+     * @param {Object} data
+     * @param {String} eventName
+     */
+    fireRowEvent(data, eventName) {
+        let me     = this,
+            {id}   = data.target,
+            record = me.getRecord(id);
+
+        me.parent.fire(eventName, {id: me, data, record})
+    }
+
+    /**
+     * @param {String} cellId
+     * @returns {String}
+     */
+    getCellDataField(cellId) {
+        return cellId.split('__')[2]
+    }
+
     /**
      * @param {Object} record
      * @param {String} field
@@ -232,6 +286,34 @@ class View extends Component {
         return ['neo-grid-row']
     }
 
+    /**
+     * @param {Object} data
+     */
+    onCellClick(data) {
+        this.fireCellEvent(data, 'cellClick')
+    }
+
+    /**
+     * @param {Object} data
+     */
+    onCellDoubleClick(data) {
+        this.fireCellEvent(data, 'cellDoubleClick')
+    }
+
+    /**
+     * @param {Object} data
+     */
+    onRowClick(data) {
+        this.fireRowEvent(data, 'rowClick')
+    }
+
+    /**
+     * @param {Object} data
+     */
+    onRowDoubleClick(data) {
+        this.fireRowEvent(data, 'rowDoubleClick')
+    }
+
     /**
      * Gets triggered after changing the value of a record field.
      * E.g. myRecord.foo = 'bar';

package/src/list/Base.mjs

@@ -409,6 +409,22 @@ class Base extends Component {
         me.cls        = cls
     }
 
+    /**
+     * Triggered after the windowId config got changed
+     * @param {Number} value
+     * @param {Number} oldValue
+     * @protected
+     */
+    afterSetWindowId(value, oldValue) {
+        super.afterSetWindowId(value, oldValue);
+
+        let {navigator} = this;
+
+        if (navigator) {
+            navigator.windowId = value
+        }
+    }
+
     /**
      * Triggered before the selectionModel config gets changed.
      * @param {Neo.selection.Model} value

package/src/main/addon/DragDrop.mjs

@@ -153,8 +153,8 @@ class DragDrop extends Base {
 
         Promise.all(imports).then(modules => {
             // create the Mouse- and / or TouchSensor
-            Neo.create({
-                module: modules[0].default
+            modules.forEach(module => {
+                Neo.create({module: module.default})
             })
         })
     }
@@ -461,6 +461,7 @@ class DragDrop extends Base {
             node;
 
         delete data.appName;
+        delete data.windowId;
 
         if (data.boundaryContainerId) {
             node = DomAccess.getElementOrBody(data.boundaryContainerId);