neo.mjs 4.3.8 → 4.3.10

package/src/list/Base.mjs

@@ -374,13 +374,9 @@ class Base extends Component {
                 listItem && vdom.cn.push(listItem);
             });
 
-            if (silent) {
-                me._vdom = vdom;
-            } else {
-                me.promiseVdomUpdate().then(() => {
-                    me.fire('createItems');
-                });
-            }
+            !silent && me.promiseVdomUpdate().then(() => {
+                me.fire('createItems');
+            });
         }
     }
 
@@ -538,13 +534,12 @@ class Base extends Component {
      */
     onStoreRecordChange(data) {
         let me    = this,
-            index = data.index,
-            vdom  = me.vdom;
+            index = data.index;
 
         // ignore changes for records which have not been added to the list yet
         if (index > -1) {
-            vdom.cn[index] = me.createItem(data.record, index);
-            me.vdom = vdom;
+            me.vdom.cn[index] = me.createItem(data.record, index);
+            me.update();
         }
     }
 

package/src/list/plugin/Animate.mjs

@@ -265,15 +265,10 @@ class Animate extends Base {
             }
         });
 
-        if (hasAddedItems) {
-            owner.vdom = vdom;
-        }
+        hasAddedItems && owner.update();
 
         // ensure to get into the next animation frame
         setTimeout(() => {
-            // get the latest version of the vdom, since this is a delayed callback
-            vdom = owner.vdom;
-
             // new items are already added into the vdom, while old items are not yet removed
             // => we need a map to ensure getting the correct index
             map = vdom.cn.map(e => e.id);
@@ -309,8 +304,7 @@ class Animate extends Base {
                 }
             });
 
-            owner.vdom = vdom;
-
+            owner.update();
             me.triggerTransitionCallback();
         }, 50);
     }
@@ -359,9 +353,8 @@ class Animate extends Base {
             });
 
             if (hasChange) {
-                owner.vdom.cn = newVdomCn;
-
-                owner.vdom = vdom;
+                vdom.cn = newVdomCn;
+                owner.update();
 
                 // we need to ensure to get this call into the next animation frame
                 setTimeout(() => {
@@ -398,7 +391,7 @@ class Animate extends Base {
                 item.style.transform = `translate(${position.x}px, ${position.y}px)`;
             });
 
-            owner.vdom = vdom;
+            owner.update();
         }
     }
 

package/src/plugin/Resizable.mjs

@@ -499,9 +499,7 @@ class Resizable extends Base {
                 else if (dir.includes('r')  && right)           {if (!me.nodeRight)       {h = me.addNode('right');}}
                 else if (dir.includes('t')  && top)             {if (!me.nodeTop)         {h = me.addNode('top');}}
 
-                if (h) {
-                    owner.vdom = vdom;
-                }
+                h && owner.update();
             }
         }
     }
@@ -533,12 +531,11 @@ class Resizable extends Base {
      * see: /issues/1139
      */
     removeAllNodes() {
-        let me   = this,
-            vdom = me.owner.vdom;
+        let me = this;
 
         if (me.currentNodeName) {
             me.removeNode(me.currentNodeName);
-            me.owner.vdom = vdom;
+            me.owner.update();
 
             me.currentNodeName = null;
             me.targetNode      = null;

package/src/selection/Model.mjs

@@ -98,7 +98,6 @@ class Model extends Base {
     deselect(item, silent, itemCollection, selectedCls) {
         let me   = this,
             view = me.view,
-            vdom = view.vdom,
             node = view.getVdomChild(item), // todo: support for nodes (right now limited to ids)
             cls;
 
@@ -110,9 +109,7 @@ class Model extends Base {
 
         NeoArray.remove(itemCollection || me.items, item);
 
-        if (!silent) {
-            view.vdom = vdom;
-        }
+        !silent && view.update();
     }
 
     /**
@@ -121,15 +118,14 @@ class Model extends Base {
     deselectAll(silent) {
         let me    = this,
             items = [...me.items],
-            view  = me.view,
-            vdom  = view.vdom;
+            view  = me.view;
 
         items.forEach(item => {
             me.deselect(item, true);
         });
 
         if (!silent && items.length > 0) {
-            view.vdom = vdom;
+            view.update();
         }
     }
 

package/src/selection/grid/CellColumnModel.mjs

@@ -50,16 +50,13 @@ class CellColumnModel extends CellModel {
     deselectAllCells(silent) {
         let me      = this,
             cellIds = [...me.selectedColumnCellIds],
-            view    = me.view,
-            vdom    = view.vdom;
+            view    = me.view;
 
         cellIds.forEach(cellId => {
             me.deselect(cellId, true, me.selectedColumnCellIds, me.selectedColumnCellCls);
         });
 
-        if (!silent) {
-            view.vdom = vdom;
-        }
+        !silent && view.update();
     }
 
     /**

package/src/selection/grid/CellColumnRowModel.mjs

@@ -50,16 +50,13 @@ class CellColumnRowModel extends CellRowModel {
     deselectAllCells(silent) {
         let me      = this,
             cellIds = [...me.selectedColumnCellIds],
-            view    = me.view,
-            vdom    = view.vdom;
+            view    = me.view;
 
         cellIds.forEach(cellId => {
             me.deselect(cellId, true, me.selectedColumnCellIds, me.selectedColumnCellCls);
         });
 
-        if (!silent) {
-            view.vdom = vdom;
-        }
+        !silent && view.update();
     }
 
     /**

package/src/selection/grid/CellRowModel.mjs

@@ -46,16 +46,13 @@ class CellRowModel extends CellModel {
     deselectAllRows(silent) {
         let me     = this,
             rowIds = [...me.selectedRowIds],
-            view   = me.view,
-            vdom   = view.vdom;
+            view   = me.view;
 
         rowIds.forEach(rowId => {
             me.deselectRow(rowId, true);
         });
 
-        if (!silent) {
-            view.vdom = vdom;
-        }
+        !silent && view.update();
     }
 
     /**
@@ -65,7 +62,6 @@ class CellRowModel extends CellModel {
     deselectRow(rowId, silent) {
         let me   = this,
             view = me.view,
-            vdom = view.vdom,
             node = view.getVdomChild(rowId),
             cls;
 
@@ -77,9 +73,7 @@ class CellRowModel extends CellModel {
 
         NeoArray.remove(me.selectedRowIds, rowId);
 
-        if (!silent) {
-            view.vdom = vdom;
-        }
+        !silent && view.update();
     }
 
     /**
@@ -133,7 +127,6 @@ class CellRowModel extends CellModel {
     selectRow(id, silent) {
         let me       = this,
             view     = me.view,
-            vdom     = view.vdom,
             vdomNode = id && view.getVdomChild(id),
             cls;
 
@@ -145,9 +138,7 @@ class CellRowModel extends CellModel {
             me.selectedRowIds.push(id);
         }
 
-        if (!silent) {
-            view.vdom = vdom;
-        }
+        !silent && view.update();
     }
 
     /**

package/src/selection/table/CellColumnModel.mjs

@@ -50,16 +50,13 @@ class CellColumnModel extends CellModel {
     deselectAllCells(silent) {
         let me      = this,
             cellIds = [...me.selectedColumnCellIds],
-            view    = me.view,
-            vdom    = view.vdom;
+            view    = me.view;
 
         cellIds.forEach(cellId => {
             me.deselect(cellId, true, me.selectedColumnCellIds, me.selectedColumnCellCls);
         });
 
-        if (!silent) {
-            view.vdom = vdom;
-        }
+        !silent && view.update();
     }
 
     /**

package/src/selection/table/CellColumnRowModel.mjs

@@ -50,16 +50,13 @@ class CellColumnRowModel extends CellRowModel {
     deselectAllCells(silent) {
         let me      = this,
             cellIds = [...me.selectedColumnCellIds],
-            view    = me.view,
-            vdom    = view.vdom;
+            view    = me.view;
 
         cellIds.forEach(cellId => {
             me.deselect(cellId, true, me.selectedColumnCellIds, me.selectedColumnCellCls);
         });
 
-        if (!silent) {
-            view.vdom = vdom;
-        }
+        !silent && view.update();
     }
 
     /**

package/src/selection/table/CellRowModel.mjs

@@ -46,16 +46,13 @@ class CellRowModel extends CellModel {
     deselectAllRows(silent) {
         let me     = this,
             rowIds = [...me.selectedRowIds],
-            view   = me.view,
-            vdom   = view.vdom;
+            view   = me.view;
 
         rowIds.forEach(rowId => {
             me.deselectRow(rowId, true);
         });
 
-        if (!silent) {
-            view.vdom = vdom;
-        }
+        !silent && view.update();
     }
 
     /**
@@ -65,7 +62,6 @@ class CellRowModel extends CellModel {
     deselectRow(rowId, silent) {
         let me   = this,
             view = me.view,
-            vdom = view.vdom,
             node = view.getVdomChild(rowId),
             cls;
 
@@ -77,9 +73,7 @@ class CellRowModel extends CellModel {
 
         NeoArray.remove(me.selectedRowIds, rowId);
 
-        if (!silent) {
-            view.vdom = vdom;
-        }
+        !silent && view.update();
     }
 
     /**
@@ -133,7 +127,6 @@ class CellRowModel extends CellModel {
     selectRow(id, silent) {
         let me       = this,
             view     = me.view,
-            vdom     = view.vdom,
             vdomNode = id && view.getVdomChild(id),
             cls;
 
@@ -145,9 +138,7 @@ class CellRowModel extends CellModel {
             me.selectedRowIds.push(id);
         }
 
-        if (!silent) {
-            view.vdom = vdom;
-        }
+        !silent && view.update();
     }
 
     /**

package/src/sitemap/Component.mjs

@@ -165,7 +165,7 @@ class Component extends Base {
             column.cn.push(item);
         }
 
-        me.vdom = vdom;
+        me.update();
     }
 
     /**

package/src/tab/Strip.mjs

@@ -45,16 +45,14 @@ class Strip extends Component {
      */
     afterSetUseActiveTabIndicator(value, oldValue) {
         if (oldValue !== undefined) {
-            let me   = this,
-                vdom = me.vdom;
+            let me = this;
 
-            vdom.cn[0].removeDom = !value;
+            me.vdom.cn[0].removeDom = !value;
 
             if (me.mounted && value) {
-                me._vdom = vdom; // silent update
                 me.getActiveTabRectThenMove();
             } else {
-                me.vdom = vdom;
+                me.update();
             }
         }
     }
@@ -109,11 +107,10 @@ class Strip extends Component {
     moveActiveIndicator(rects) {
         let me   = this,
             rect = rects[1] || rects[0],
-            activeTabIndicator, tabContainer, vdom;
+            activeTabIndicator, tabContainer;
 
         if (me.useActiveTabIndicator) {
-            vdom               = me.vdom;
-            activeTabIndicator = vdom.cn[0];
+            activeTabIndicator = me.vdom.cn[0];
             tabContainer       = me.getTabContainer();
 
             switch (tabContainer.tabBarPosition) {
@@ -140,18 +137,18 @@ class Strip extends Component {
             // in case there is a dynamic change (oldValue), call this method again
             if (rects[1]) {
                 activeTabIndicator.style.opacity = 0;
-                me.vdom = vdom;
+                me.update();
 
                 setTimeout(() => {
                     me.moveActiveIndicator([rects[0]]);
                 }, 50)
             } else {
                 activeTabIndicator.style.opacity = 1;
-                me.vdom = vdom;
+                me.update();
 
                 setTimeout(() => {
                     activeTabIndicator.style.opacity = 0;
-                    me.vdom = vdom;
+                    me.update();
                 }, 300);
             }
         }

package/src/tab/header/Toolbar.mjs

@@ -56,8 +56,7 @@ class Toolbar extends BaseToolbar {
      */
     afterSetUseActiveTabIndicator(value, oldValue) {
         if (oldValue !== undefined) {
-            let me   = this,
-                vdom = me.vdom;
+            let me = this;
 
             me.items.forEach(item => {
                 // silent updates
@@ -65,7 +64,7 @@ class Toolbar extends BaseToolbar {
                 item.updateUseActiveTabIndicator(true);
             });
 
-            me.vdom = vdom;
+            me.update();
         }
     }
 

package/src/table/header/Button.mjs

@@ -136,8 +136,7 @@ class Button extends BaseButton {
      * @protected
      */
     afterSetDraggable(value, oldValue) {
-        let me   = this,
-            vdom = me.vdom;
+        let me = this;
 
         if (value === true) {
             me.getVdomRoot().draggable = true;
@@ -145,7 +144,7 @@ class Button extends BaseButton {
             delete me.getVdomRoot().draggable;
         }
 
-        me.vdom = vdom;
+        me.update();
     }
 
     /**
@@ -195,8 +194,7 @@ class Button extends BaseButton {
      * @protected
      */
     afterSetShowHeaderFilter(value, oldValue) {
-        let me   = this,
-            vdom = me.vdom;
+        let me = this;
 
         if (value) {
             if (!me.filterField) {
@@ -228,7 +226,7 @@ class Button extends BaseButton {
             me.filterField.vdom.removeDom = true;
         }
 
-        me.vdom = vdom;
+        me.update();
     }
 
     /**

package/src/table/header/Toolbar.mjs

@@ -51,8 +51,7 @@ class Toolbar extends BaseToolbar {
      */
     afterSetShowHeaderFilters(value, oldValue) {
         if (oldValue !== undefined) {
-            let me   = this,
-                vdom = me.vdom;
+            let me = this;
 
             me.items.forEach(item => {
                 item.setSilent({
@@ -60,7 +59,7 @@ class Toolbar extends BaseToolbar {
                 });
             });
 
-            me.vdom = vdom;
+            me.update();
         }
     }
 
@@ -78,7 +77,6 @@ class Toolbar extends BaseToolbar {
             dockRightWidth = 0,
             items          = me.items,
             len            = items.length,
-            vdom           = me.vdom,
             style;
 
         items.forEach((item, index) => {
@@ -116,7 +114,7 @@ class Toolbar extends BaseToolbar {
             }
         });
 
-        me.vdom = vdom;
+        me.update();
     }
 
     /**

package/src/tree/List.mjs

@@ -265,7 +265,6 @@ class Tree extends Base {
         let me         = this,
             isFiltered = true,
             valueRegEx = new RegExp(value, 'gi'),
-            vdom       = me.vdom,
             childReturnValue, directMatch, node;
 
         if (!value) {
@@ -275,7 +274,7 @@ class Tree extends Base {
         me.store.items.forEach(item => {
             if (item.parentId === parentId) {
                 directMatch = false;
-                node        = me.getVdomChild(me.getItemId(item.id), vdom);
+                node        = me.getVdomChild(me.getItemId(item.id), me.vdom);
 
                 node.cn[0].innerHTML = item[property].replace(valueRegEx, match => {
                     directMatch = true;
@@ -298,7 +297,7 @@ class Tree extends Base {
 
         if (parentId === null) {
             me.expandAll(true);
-            me.vdom = vdom;
+            me.update();
         }
 
         return isFiltered;
@@ -328,11 +327,10 @@ class Tree extends Base {
     onConstructed() {
         super.onConstructed();
 
-        let me   = this,
-            vdom = me.vdom;
+        let me = this;
 
         if (me.showCollapseExpandAllIcons) {
-            vdom.cn.unshift({
+            me.vdom.cn.unshift({
                 cls: ['neo-treelist-menu-item', 'neo-treelist-collapse-all-icon'],
                 cn : [{
                     tag: 'span',
@@ -346,7 +344,7 @@ class Tree extends Base {
                 }]
             });
 
-            me.vdom = vdom;
+            me.update();
         }
     }
 
@@ -356,7 +354,6 @@ class Tree extends Base {
      */
     onItemClick(node, data) {
         let me    = this,
-            vdom  = me.vdom,
             items = me.store.items,
             i     = 0,
             len   = items.length,
@@ -377,7 +374,7 @@ class Tree extends Base {
         if (item) {
             if (item.cls?.includes('neo-list-folder')) {
                 NeoArray.toggle(item.cls, 'neo-folder-open');
-                me.vdom = vdom;
+                me.update();
             } else {
                 me.onLeafItemClick(record);
 

package/src/vdom/Helper.mjs

@@ -439,7 +439,7 @@ class Helper extends Base {
 
                                 Object.entries(value).forEach(([key, value]) => {
                                     if (!(oldVnode.attributes.hasOwnProperty(key) && oldVnode.attributes[key] === value)) {
-                                        if (!Neo.isString(value) && Neo.isEmpty(value)) {
+                                        if (value !== null && !Neo.isString(value) && Neo.isEmpty(value)) {
                                             // ignore empty arrays & objects
                                         } else {
                                             attributes[key] = value;