neo.mjs 4.0.34 → 4.0.37

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "neo.mjs",
-    "version": "4.0.34",
+    "version": "4.0.37",
     "description": "The webworkers driven UI framework",
     "type": "module",
     "repository": {

package/src/component/Base.mjs

@@ -753,9 +753,7 @@ class Base extends CoreBase {
      * @protected
      */
     beforeSetModel(value, oldValue) {
-        if (oldValue) {
-            oldValue.destroy();
-        }
+        oldValue?.destroy();
 
         if (value) {
             let me            = this,
@@ -852,12 +850,11 @@ class Base extends CoreBase {
 
         me.domListeners = [];
 
-        me.controller?.destroy();
-        me.controller = null;
+        me.controller = null; // triggers destroy()
 
         me.reference && me.getController()?.removeReference(me); // remove own reference from parent controllers
 
-        me.model?.destroy();
+        me.model = null; // triggers destroy()
 
         me.bind && parentModel?.removeBindings(me.id);
 

package/src/controller/Base.mjs

@@ -36,6 +36,15 @@ class Base extends CoreBase {
         HashHistory.on('change', this.onHashChange, this);
     }
 
+    /**
+     * @param args
+     */
+    destroy(...args) {
+        HashHistory.un('change', this.onHashChange, this);
+
+        super.destroy(...args);
+    }
+
     /**
      * Placeholder method which gets triggered when the hash inside the browser url changes
      * @param {Object} value

package/src/controller/Component.mjs

@@ -218,6 +218,8 @@ class Component extends Base {
                 break;
             }
         }
+
+        me.getParent()?.removeReference(component);
     }
 }
 

package/src/core/Observable.mjs

@@ -111,7 +111,12 @@ class Observable extends Base {
                     eventConfig.fn = eventConfig.scope[eventConfig.fn];
                 }
 
-                eventConfig.fn.apply(eventConfig.scope || me, eventConfig.data ? args.concat(eventConfig.data) : args);
+                // remove the listener, in case the scope no longer exists
+                if (eventConfig.scope && !eventConfig.scope.id) {
+                    listeners[name].splice(i, 1);
+                } else {
+                    eventConfig.fn.apply(eventConfig.scope || me, eventConfig.data ? args.concat(eventConfig.data) : args);
+                }
             }
         }
     }

package/src/util/Array.mjs

@@ -95,9 +95,7 @@ class NeoArray extends Base {
         items.forEach(item => {
             index = arr.indexOf(item);
 
-            if (index > -1) {
-                arr.splice(index, 1);
-            }
+            index > -1 && arr.splice(index, 1);
         });
     }