neo.mjs 2.3.19 → 3.0.0

package/src/Neo.mjs

@@ -87,7 +87,7 @@ Neo = self.Neo = Object.assign({
 
                     // only apply properties which have no setters inside the prototype chain
                     // those will get applied on create (Neo.core.Base -> initConfig)
-                    else if (!hasPropertySetter(element, key)) {
+                    else if (!Neo.hasPropertySetter(element, key)) {
                         Object.defineProperty(element, key, {
                             enumerable: true,
                             value     : value,
@@ -333,8 +333,9 @@ Neo = self.Neo = Object.assign({
             cls = Neo.ns(className);
         }
 
-        instance = new cls(config);
+        instance = new cls();
 
+        instance.construct(config);
         instance.onConstructed();
         instance.onAfterConstructed();
         instance.init();
@@ -344,6 +345,28 @@ Neo = self.Neo = Object.assign({
 
     emptyFn() {},
 
+    /**
+     * Checks if there is a set method for a given property key inside the prototype chain
+     * @memberOf module:Neo
+     * @param {Neo.core.Base} proto The top level prototype of a class
+     * @param {String} key the property key to test
+     * @returns {Boolean}
+     */
+    hasPropertySetter(proto, key) {
+        let descriptor;
+
+        while (proto.__proto__) {
+            descriptor = Object.getOwnPropertyDescriptor(proto, key);
+
+            if (typeof descriptor === 'object' && typeof descriptor.set === 'function') {
+                return true;
+            }
+            proto = proto.__proto__;
+        }
+
+        return false;
+    },
+
     /**
      * Deep-merges a source object into a target object
      * @memberOf module:Neo
@@ -526,7 +549,7 @@ function applyMixins(cls, mixins) {
  * @tutorial 02_ClassSystem
  */
 function autoGenerateGetSet(proto, key) {
-    if (hasPropertySetter(proto, key)) {
+    if (Neo.hasPropertySetter(proto, key)) {
         throw('Config ' + key + '_ (' + proto.className + ') already has a set method, use beforeGet, beforeSet & afterSet instead');
     }
 
@@ -622,28 +645,6 @@ function exists(className) {
     }
 }
 
-/**
- * Checks if there is a set method for a given property key inside the prototype chain
- * @param {Neo.core.Base} proto The top level prototype of a class
- * @param {String} key the property key to test
- * @returns {Boolean}
- * @private
- */
-function hasPropertySetter(proto, key) {
-    let descriptor;
-
-    while (proto.__proto__) {
-        descriptor = Object.getOwnPropertyDescriptor(proto, key);
-
-        if (typeof descriptor === 'object' && typeof descriptor.set === 'function') {
-            return true;
-        }
-        proto = proto.__proto__;
-    }
-
-    return false;
-}
-
 /**
  *
  * @param {Neo.core.Base} proto

package/src/button/Split.mjs

@@ -51,8 +51,8 @@ class Split extends Button {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         let me   = this,
             vdom = me.vdom;

package/src/calendar/view/EditEventContainer.mjs

@@ -77,8 +77,8 @@ class EditEventContainer extends FormContainer {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         // focus trap, see: https://github.com/neomjs/neo/issues/2306
         this.vdom.tabIndex = -1;

package/src/calendar/view/MainContainer.mjs

@@ -171,8 +171,8 @@ class MainContainer extends Container {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         let me = this;
 

package/src/calendar/view/MainContainerModel.mjs

@@ -107,8 +107,8 @@ class MainContainerModel extends Component {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         let me        = this,
             component = me.component;

package/src/calendar/view/SettingsContainer.mjs

@@ -36,8 +36,8 @@ class SettingsContainer extends Container {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         let me = this;
 

package/src/calendar/view/YearComponent.mjs

@@ -175,8 +175,8 @@ class YearComponent extends Component {
     /**
      * @param config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         let me           = this,
             domListeners = me.domListeners;

package/src/calendar/view/calendars/EditContainer.mjs

@@ -48,8 +48,8 @@ class EditContainer extends FormContainer {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         // focus trap, see: https://github.com/neomjs/neo/issues/2306
         this.vdom.tabIndex = -1;

package/src/calendar/view/month/Component.mjs

@@ -157,8 +157,8 @@ class Component extends BaseComponent {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         let me           = this,
             domListeners = me.domListeners;

package/src/calendar/view/week/Component.mjs

@@ -216,8 +216,8 @@ class Component extends BaseComponent {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         let me           = this,
             domListeners = me.domListeners;

package/src/calendar/view/week/TimeAxisComponent.mjs

@@ -64,8 +64,8 @@ class TimeAxisComponent extends Component {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         let me = this;
 

package/src/calendar/view/week/plugin/DragDrop.mjs

@@ -24,8 +24,8 @@ class DragDrop extends Base {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         let me           = this,
             columnOpts   = {scope: me, delegate: '.neo-c-w-column'},

package/src/collection/Base.mjs

@@ -108,8 +108,8 @@ class Base extends CoreBase {
     /**
      * @param config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         let me           = this,
             symbolConfig = {enumerable: false, writable: true};

package/src/component/Chip.mjs

@@ -60,8 +60,8 @@ class Chip extends Component {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         let me = this,
             domListeners;

package/src/component/Circle.mjs

@@ -120,8 +120,8 @@ class Circle extends Component {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         Neo.main.DomEvents.registerPreventDefaultTargets({
             name: 'contextmenu',

package/src/component/DateSelector.mjs

@@ -140,8 +140,8 @@ class DateSelector extends Component {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         let me           = this,
             domListeners = me.domListeners;

package/src/component/Gallery.mjs

@@ -169,8 +169,8 @@ class Gallery extends Component {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         let me           = this,
             domListeners = Neo.clone(me.domListeners, true),

package/src/component/Helix.mjs

@@ -250,8 +250,8 @@ class Helix extends Component {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         let me           = this,
             domListeners = Neo.clone(me.domListeners, true);

package/src/component/Splitter.mjs

@@ -71,8 +71,8 @@ class Splitter extends Component {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         let me           = this,
             domListeners = me.domListeners;

package/src/component/mwc/Button.mjs

@@ -58,8 +58,8 @@ class Button extends Component {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         if (!Neo.config.mainThreadAddons.includes('Mwc')) {
             console.error('Please include "Mwc" into the mainThreadAddons of your neo-config.json file.');

package/src/component/mwc/TextField.mjs

@@ -65,8 +65,8 @@ class TextField extends Component {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         if (!Neo.config.mainThreadAddons.includes('Mwc')) {
             console.error('Please include "Mwc" into the mainThreadAddons of your neo-config.json file.');

package/src/container/Panel.mjs

@@ -50,8 +50,8 @@ class Panel extends Container {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         let me = this;
 

package/src/controller/Application.mjs

@@ -48,13 +48,13 @@ class Application extends Base {
     /**
      * @param {Object} config
      */
-    constructor(config) {
+    construct(config) {
         // to guarantee that the main view can access Neo.apps at any point,
         // we need to trigger its assignment at the end of the ctor.
         let mainView = config.mainView;
         delete config.mainView;
 
-        super(config);
+        super.construct(config);
 
         let me = this;
 

package/src/controller/Base.mjs

@@ -30,8 +30,8 @@ class Base extends CoreBase {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         HashHistory.on('change', this.onHashChange, this);
     }

package/src/controller/Component.mjs

@@ -38,8 +38,8 @@ class Component extends Base {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         let me        = this,
             component = me.component,

package/src/core/Base.mjs

@@ -74,7 +74,7 @@ class Base {
      * Applies the observable mixin if needed, grants remote access if needed.
      * @param {Object} config={}
      */
-    constructor(config={}) {
+    construct(config={}) {
         let me = this;
 
         Object.defineProperties(me, {
@@ -99,6 +99,9 @@ class Base {
 
         me.getStaticConfig('observable') && me.initObservable(config);
 
+        // assign class field values prior to configs
+        config = me.setFields(config);
+
         me.initConfig(config);
 
         Object.defineProperty(me, 'configsApplied', {
@@ -376,6 +379,8 @@ class Base {
     set(values={}) {
         let me = this;
 
+        values = me.setFields(values);
+
         // If the initial config processing is still running,
         // finish this one first before dropping new values into the configSymbol.
         // see: https://github.com/neomjs/neo/issues/2201
@@ -388,6 +393,25 @@ class Base {
         me.processConfigs(true);
     }
 
+    /**
+     * We want to assign class fields first and remove them from the config object,
+     * so that afterSet(), beforeGet() and beforeSet() methods can get the new values right away
+     * @param {Object} config
+     * @returns {Object}
+     */
+    setFields(config) {
+        let configNames = this.constructor.config;
+
+        Object.entries(config).forEach(([key, value]) => {
+            if (!configNames.hasOwnProperty(key) && !Neo.hasPropertySetter(this, key)) {
+                this[key] = value;
+                delete config[key];
+            }
+        });
+
+        return config;
+    }
+
     /**
      * Sets the value of a static config by a given key
      * @param {String} key The key of a staticConfig defined inside static getStaticConfig

package/src/core/IdGenerator.mjs

@@ -42,7 +42,7 @@ class IdGenerator {
     /**
      * @param config
      */
-    constructor(config) {
+    construct(config) {
         let me = this;
 
         me.idCounter = {};

package/src/data/Store.mjs

@@ -79,8 +79,8 @@ class Store extends Base {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         let me = this;
 

package/src/dialog/Base.mjs

@@ -125,8 +125,8 @@ class Base extends Panel {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         let me = this;
 

package/src/draggable/DragProxyComponent.mjs

@@ -37,8 +37,8 @@ class DragProxyComponent extends Base {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         let me = this;
 

package/src/draggable/DragZone.mjs

@@ -152,8 +152,8 @@ class DragZone extends Base {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         if (!Neo.main.addon.DragDrop) {
             console.error('You can not use Neo.draggable.DragZone without adding Neo.main.addon.DragDrop to the main thread addons', this.id);

package/src/draggable/DropZone.mjs

@@ -25,8 +25,8 @@ class DropZone extends Base {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         let me           = this,
             owner        = me.owner,

package/src/draggable/list/DragZone.mjs

@@ -29,8 +29,8 @@ class DragZone extends BaseDragZone {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         let me           = this,
             owner        = me.owner,

package/src/draggable/toolbar/DragZone.mjs

@@ -23,8 +23,8 @@ class DragZone extends BaseDragZone {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         let me           = this,
             owner        = me.owner,

package/src/filter/ToggleOperatorsButton.mjs

@@ -30,8 +30,8 @@ class ToggleOperatorsButton extends Button {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         let me = this;
 

package/src/form/field/CheckBox.mjs

@@ -72,8 +72,8 @@ class CheckBox extends Base {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         let me           = this,
             domListeners = me.domListeners;

package/src/form/field/Color.mjs

@@ -47,8 +47,8 @@ class Color extends Select {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         let me           = this,
             vdom         = me.vdom,

package/src/form/field/Date.mjs

@@ -62,8 +62,8 @@ class DateField extends Picker {
     /**
      * @param config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         let me = this;
 

package/src/form/field/Display.mjs

@@ -31,8 +31,8 @@ class Display extends Text {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         let me      = this,
             vdom    = me.vdom,

package/src/form/field/Range.mjs

@@ -48,8 +48,8 @@ class Range extends Number {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         let me           = this,
             domListeners = me.domListeners,

package/src/form/field/Select.mjs

@@ -105,8 +105,8 @@ class Select extends Picker {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         let me = this;
 

package/src/form/field/Text.mjs

@@ -123,8 +123,8 @@ class Text extends Base {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         let me           = this,
             domListeners = me.domListeners;

package/src/form/field/Time.mjs

@@ -84,8 +84,8 @@ class Time extends Picker {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         let me           = this,
             clearTrigger = me.getTrigger('clear');

package/src/form/field/trigger/Base.mjs

@@ -82,8 +82,8 @@ class Base extends Component {
     /**
      * @param {Object} config
      */
-    constructor(config) {
-        super(config);
+    construct(config) {
+        super.construct(config);
 
         let me             = this,
             domListeners   = me.domListeners || [],