neo.mjs 10.1.0 → 10.1.1

package/.github/RELEASE_NOTES/v10.1.1.md

@@ -0,0 +1,13 @@
+# Neo.mjs v10.1.1 Release Notes
+
+This is a patch release that addresses a critical regression bug affecting drag-and-drop operations in grids.
+
+## Bug Fixes
+
+### Grid Column Drag & Drop
+
+-   Fixed a bug in `Neo.collection.Base` where the `move()` method would fail to correctly swap adjacent items. This was caused by an unsafe, nested `splice()` operation that could lead to unpredictable behavior.
+-   The direct impact of this bug was the failure of drag-and-drop for grid column reordering, which is a significant regression.
+-   The `move()` method has been refactored to use a safer, two-step approach, ensuring the stability of all collection-based move operations.
+
+This fix restores the expected drag-and-drop functionality for grid columns.

package/ServiceWorker.mjs

@@ -20,9 +20,9 @@ class ServiceWorker extends ServiceBase {
          */
         singleton: true,
         /**
-         * @member {String} version='10.1.0'
+         * @member {String} version='10.1.1'
          */
-        version: '10.1.0'
+        version: '10.1.1'
     }
 
     /**

package/apps/portal/view/home/FooterContainer.mjs

@@ -108,7 +108,7 @@ class FooterContainer extends Container {
             }, {
                 module: Component,
                 cls   : ['neo-version'],
-                text  : 'v10.1.0'
+                text  : 'v10.1.1'
             }]
         }],
         /**

package/package.json

@@ -1,6 +1,6 @@
 {
     "name"           : "neo.mjs",
-    "version"        : "10.1.0",
+    "version"        : "10.1.1",
     "description"    : "Neo.mjs: The multi-threaded UI framework for building ultra-fast, desktop-like web applications with uncompromised responsiveness, inherent security, and a transpilation-free dev mode.",
     "type"           : "module",
     "repository"     : {

package/src/DefaultConfig.mjs

@@ -299,12 +299,12 @@ const DefaultConfig = {
     useVdomWorker: true,
     /**
      * buildScripts/injectPackageVersion.mjs will update this value
-     * @default '10.1.0'
+     * @default '10.1.1'
      * @memberOf! module:Neo
      * @name config.version
      * @type String
      */
-    version: '10.1.0'
+    version: '10.1.1'
 };
 
 Object.assign(DefaultConfig, {

package/src/collection/Base.mjs

@@ -1051,16 +1051,21 @@ class Collection extends Base {
      */
     move(fromIndex, toIndex) {
         if (fromIndex === toIndex) {
-            return
+            return;
         }
 
-        let {items} = this;
+        let items = this._items;
 
         if (fromIndex >= items.length) {
             fromIndex = items.length - 1
         }
 
-        items.splice(toIndex, 0, items.splice(fromIndex, 1)[0])
+        // The splice operations are intentionally separated.
+        // Using the common one-liner `items.splice(toIndex, 0, items.splice(fromIndex, 1)[0])`
+        // can lead to unpredictable side effects, as the inner splice can alter the array
+        // before the outer splice's index is resolved. This two-step approach is safer.
+        const item = items.splice(fromIndex, 1)[0];
+        items.splice(toIndex, 0, item)
     }
 
     /**

package/test/siesta/tests/CollectionBase.mjs

@@ -275,4 +275,50 @@ StartTest(t => {
             {id: 'e'}
         ], 'collection.getRange()');
     });
+
+    t.it('Move collection items', t => {
+        let moveCollection = Neo.create(Collection, {
+            items: [
+                {id: 'a'},
+                {id: 'b'},
+                {id: 'c'},
+                {id: 'd'},
+                {id: 'e'}
+            ]
+        });
+
+        t.isDeeplyStrict(moveCollection.getRange(), [{id: 'a'}, {id: 'b'}, {id: 'c'}, {id: 'd'}, {id: 'e'}], 'Initial order');
+
+        // Move item forward
+        moveCollection.move(1, 2);
+        t.isDeeplyStrict(moveCollection.getRange(), [{id: 'a'}, {id: 'c'}, {id: 'b'}, {id: 'd'}, {id: 'e'}], 'Move item forward (1 -> 2)');
+
+        // Swap adjacent items (backward)
+        moveCollection.move(2, 1);
+        t.isDeeplyStrict(moveCollection.getRange(), [{id: 'a'}, {id: 'b'}, {id: 'c'}, {id: 'd'}, {id: 'e'}], 'Swap adjacent items back (2 -> 1)');
+
+        // Move item backward
+        moveCollection.move(3, 1);
+        t.isDeeplyStrict(moveCollection.getRange(), [{id: 'a'}, {id: 'd'}, {id: 'b'}, {id: 'c'}, {id: 'e'}], 'Move item backward (3 -> 1)');
+
+        // Move item forward
+        moveCollection.move(1, 3);
+        t.isDeeplyStrict(moveCollection.getRange(), [{id: 'a'}, {id: 'b'}, {id: 'c'}, {id: 'd'}, {id: 'e'}], 'Move item forward (1 -> 3)');
+
+        // Swap adjacent items (forward)
+        moveCollection.move(0, 1);
+        t.isDeeplyStrict(moveCollection.getRange(), [{id: 'b'}, {id: 'a'}, {id: 'c'}, {id: 'd'}, {id: 'e'}], 'Swap adjacent items (0 -> 1)');
+
+        // Swap adjacent items (backward)
+        moveCollection.move(1, 0);
+        t.isDeeplyStrict(moveCollection.getRange(), [{id: 'a'}, {id: 'b'}, {id: 'c'}, {id: 'd'}, {id: 'e'}], 'Swap adjacent items back (1 -> 0)');
+
+        // Move to end
+        moveCollection.move(0, 4);
+        t.isDeeplyStrict(moveCollection.getRange(), [{id: 'b'}, {id: 'c'}, {id: 'd'}, {id: 'e'}, {id: 'a'}], 'Move to end (0 -> 4)');
+
+        // Move to start
+        moveCollection.move(4, 0);
+        t.isDeeplyStrict(moveCollection.getRange(), [{id: 'a'}, {id: 'b'}, {id: 'c'}, {id: 'd'}, {id: 'e'}], 'Move to start (4 -> 0)');
+    });
 });