neo.mjs 10.0.2 → 10.1.1

package/.github/RELEASE_NOTES/v10.1.0.md

@@ -0,0 +1,17 @@
+**Neo.mjs v10.1.0 Release Notes**
+
+This release includes important fixes and minor improvements, primarily focusing on VDOM optimization, collection performance, and selection model improvements.
+
+**Key Updates:**
+
+*   **VDOM Optimization & `neo-ignore` Refinement (Addresses #7114):**
+    The internal handling of the `neo-ignore` flag has been significantly improved. Previously, `neo-ignore` could interfere with the VDOM's structural integrity, potentially leading to rendering anomalies, **especially in complex layouts like grids, where elements might overlap**. Now, a dedicated `neoIgnore: true` flag is added to VDOM nodes, preserving the original `componentId` and `id`. This ensures the VDOM engine can correctly identify and skip sub-trees during diffing, leading to more robust and efficient asymmetric VDOM updates and resolving visual rendering issues **such as those observed in grid components**.
+
+*   **Collection Performance Enhancements (Addresses #7115):**
+    Several methods within `src/collection/Base.mjs` (e.g., `clear`, `findBy`, `pop`, `remove`) have been optimized by replacing `this.getCount()` method calls with direct access to `this.count`. This change streamlines collection operations, leading to improved performance.
+
+*   **Enhanced Selection Model (Addresses #7116):**
+    The `src/selection/Model.mjs` has been updated to provide more comprehensive data during selection changes. A new `getController()` method has been added, and the `selectionChange` event now includes the `records` array, offering richer context for selection handling and better integration with view controllers.
+
+*   **Minor Fixes & Improvements (Addresses #7117):**
+    This release also includes minor cleanups and documentation improvements, such as an updated JSDoc comment in `src/grid/Body.mjs` and the removal of a debug `console.log` statement in `src/main/DeltaUpdates.mjs`.

package/.github/RELEASE_NOTES/v10.1.1.md

@@ -0,0 +1,13 @@
+# Neo.mjs v10.1.1 Release Notes
+
+This is a patch release that addresses a critical regression bug affecting drag-and-drop operations in grids.
+
+## Bug Fixes
+
+### Grid Column Drag & Drop
+
+-   Fixed a bug in `Neo.collection.Base` where the `move()` method would fail to correctly swap adjacent items. This was caused by an unsafe, nested `splice()` operation that could lead to unpredictable behavior.
+-   The direct impact of this bug was the failure of drag-and-drop for grid column reordering, which is a significant regression.
+-   The `move()` method has been refactored to use a safer, two-step approach, ensuring the stability of all collection-based move operations.
+
+This fix restores the expected drag-and-drop functionality for grid columns.

package/ServiceWorker.mjs

@@ -20,9 +20,9 @@ class ServiceWorker extends ServiceBase {
          */
         singleton: true,
         /**
-         * @member {String} version='10.0.2'
+         * @member {String} version='10.1.1'
          */
-        version: '10.0.2'
+        version: '10.1.1'
     }
 
     /**

package/apps/portal/index.html

@@ -16,7 +16,7 @@
         "@type": "Organization",
         "name": "Neo.mjs"
       },
-      "datePublished": "2025-07-26",
+      "datePublished": "2025-07-27",
       "publisher": {
         "@type": "Organization",
         "name": "Neo.mjs"

package/apps/portal/view/home/FooterContainer.mjs

@@ -108,7 +108,7 @@ class FooterContainer extends Container {
             }, {
                 module: Component,
                 cls   : ['neo-version'],
-                text  : 'v10.0.2'
+                text  : 'v10.1.1'
             }]
         }],
         /**

package/package.json

@@ -1,6 +1,6 @@
 {
     "name"           : "neo.mjs",
-    "version"        : "10.0.2",
+    "version"        : "10.1.1",
     "description"    : "Neo.mjs: The multi-threaded UI framework for building ultra-fast, desktop-like web applications with uncompromised responsiveness, inherent security, and a transpilation-free dev mode.",
     "type"           : "module",
     "repository"     : {

package/src/DefaultConfig.mjs

@@ -299,12 +299,12 @@ const DefaultConfig = {
     useVdomWorker: true,
     /**
      * buildScripts/injectPackageVersion.mjs will update this value
-     * @default '10.0.2'
+     * @default '10.1.1'
      * @memberOf! module:Neo
      * @name config.version
      * @type String
      */
-    version: '10.0.2'
+    version: '10.1.1'
 };
 
 Object.assign(DefaultConfig, {

package/src/collection/Base.mjs

@@ -412,7 +412,7 @@ class Collection extends Base {
      * Removes all items and clears the map
      */
     clear() {
-        this.splice(0, this.getCount())
+        this.splice(0, this.count)
     }
 
     /**
@@ -429,7 +429,7 @@ class Collection extends Base {
     clearSilent() {
         let me = this;
 
-        me._items.splice(0, me.getCount());
+        me._items.splice(0, me.count);
         me.map.clear()
     }
 
@@ -817,10 +817,10 @@ class Collection extends Base {
      * @param {Object} fn.item The current collection item
      * @param {Object} scope=this The scope in which the passed function gets executed
      * @param {Number} start=0 The start index
-     * @param {Number} end=this.getCount() The end index (up to, last value excluded)
+     * @param {Number} end=this.count The end index (up to, last value excluded)
      * @returns {Array} Returns an empty Array in case no items are found
      */
-    findBy(fn, scope=this, start=0, end=this.getCount()) {
+    findBy(fn, scope=this, start=0, end=this.count) {
         let me    = this,
             items = [],
             i     = start;
@@ -1041,7 +1041,7 @@ class Collection extends Base {
      * @returns {Object}
      */
     last() {
-        return this._items[this.getCount() -1]
+        return this._items[this.count -1]
     }
 
     /**
@@ -1051,16 +1051,21 @@ class Collection extends Base {
      */
     move(fromIndex, toIndex) {
         if (fromIndex === toIndex) {
-            return
+            return;
         }
 
-        let {items} = this;
+        let items = this._items;
 
         if (fromIndex >= items.length) {
             fromIndex = items.length - 1
         }
 
-        items.splice(toIndex, 0, items.splice(fromIndex, 1)[0])
+        // The splice operations are intentionally separated.
+        // Using the common one-liner `items.splice(toIndex, 0, items.splice(fromIndex, 1)[0])`
+        // can lead to unpredictable side effects, as the inner splice can alter the array
+        // before the outer splice's index is resolved. This two-step approach is safer.
+        const item = items.splice(fromIndex, 1)[0];
+        items.splice(toIndex, 0, item)
     }
 
     /**
@@ -1102,7 +1107,7 @@ class Collection extends Base {
      * @returns {Object} The removed element from the collection; undefined if the collection is empty.
      */
     pop() {
-        let mutation = this.splice(this.getCount() -1, 1);
+        let mutation = this.splice(this.count -1, 1);
         return mutation.removedItems[0]
     }
 
@@ -1122,7 +1127,7 @@ class Collection extends Base {
      */
     remove(key) {
         this.splice(0, Array.isArray(key) ? key : [key]);
-        return this.getCount()
+        return this.count
     }
 
     /**
@@ -1132,7 +1137,7 @@ class Collection extends Base {
      */
     removeAt(index) {
         this.splice(index, 1);
-        return this.getCount()
+        return this.count
     }
 
     /**
@@ -1310,7 +1315,7 @@ class Collection extends Base {
      */
     unshift(item) {
         this.splice(0, 0, item);
-        return this.getCount()
+        return this.count
     }
 }
 

package/src/grid/Body.mjs

@@ -954,7 +954,7 @@ class GridBody extends Component {
     /**
      * @param {Object}         data
      * @param {Object[]}       data.fields Each field object contains the keys: name, oldValue, value
-     * @param {Neo.data.Model} data.model The model instance of the changed record
+     * @param {Neo.data.Model} data.model  The model instance of the changed record
      * @param {Object}         data.record
      */
     onStoreRecordChange({fields, record}) {

package/src/main/DeltaUpdates.mjs

@@ -370,10 +370,6 @@ class DeltaUpdates extends Base {
         let me   = this,
             node = DomAccess.getElementOrBody(delta.id);
 
-        if (!node) {
-            console.log('node not found', delta.id);
-        }
-
         if (node) {
             Object.entries(delta).forEach(([prop, value]) => {
                 switch (prop) {

package/src/selection/Model.mjs

@@ -157,6 +157,14 @@ class Model extends Base {
         super.destroy(...args)
     }
 
+    /**
+     * Important for mapping listeners to view controllers
+     * @returns {Neo.controller.Component|null}
+     */
+    getController() {
+        return this.view.getController()
+    }
+
     /**
      * @returns {Array} this.items
      */
@@ -226,8 +234,9 @@ class Model extends Base {
             items = [items]
         }
 
-        let me     = this,
-            {view} = me;
+        let me      = this,
+            {view}  = me,
+            records = [...items]; // Potential records
 
         // We hold vdom ids for now, so all incoming selections must be converted.
         items = items.map(item => item.isRecord ? view.getItemId(item) : Neo.isObject(item) ? item.id : item);
@@ -256,6 +265,7 @@ class Model extends Base {
             view.onSelect?.(items);
 
             me.fire('selectionChange', {
+                records,
                 selection: itemCollection
             })
         }

package/src/util/vdom/TreeBuilder.mjs

@@ -51,7 +51,7 @@ class TreeBuilder extends Base {
                 if (currentItem.componentId) {
                     // Prune the branch only if we are at the boundary AND the child is not part of a merged update
                     if (depth === 1 && !mergedChildIds?.has(currentItem.componentId)) {
-                        output[childKey].push({componentId: 'neo-ignore', id: item.id || item.componentId});
+                        output[childKey].push({...currentItem, neoIgnore: true});
                         return // Stop processing this branch
                     }
                     // Expand the branch if it's part of a merged update, or if the depth requires it

package/src/vdom/Helper.mjs

@@ -255,7 +255,8 @@ class Helper extends Base {
                 // Case 2: Both nodes are placeholders for the same component
                 (childNode.componentId && childNode.componentId === oldChildNode.componentId)
             )) {
-                if (childNode.componentId === 'neo-ignore') {
+                if (childNode.neoIgnore) {
+                    delete childNode.neoIgnore;
                     continue
                 }
 

package/test/siesta/tests/CollectionBase.mjs

@@ -275,4 +275,50 @@ StartTest(t => {
             {id: 'e'}
         ], 'collection.getRange()');
     });
+
+    t.it('Move collection items', t => {
+        let moveCollection = Neo.create(Collection, {
+            items: [
+                {id: 'a'},
+                {id: 'b'},
+                {id: 'c'},
+                {id: 'd'},
+                {id: 'e'}
+            ]
+        });
+
+        t.isDeeplyStrict(moveCollection.getRange(), [{id: 'a'}, {id: 'b'}, {id: 'c'}, {id: 'd'}, {id: 'e'}], 'Initial order');
+
+        // Move item forward
+        moveCollection.move(1, 2);
+        t.isDeeplyStrict(moveCollection.getRange(), [{id: 'a'}, {id: 'c'}, {id: 'b'}, {id: 'd'}, {id: 'e'}], 'Move item forward (1 -> 2)');
+
+        // Swap adjacent items (backward)
+        moveCollection.move(2, 1);
+        t.isDeeplyStrict(moveCollection.getRange(), [{id: 'a'}, {id: 'b'}, {id: 'c'}, {id: 'd'}, {id: 'e'}], 'Swap adjacent items back (2 -> 1)');
+
+        // Move item backward
+        moveCollection.move(3, 1);
+        t.isDeeplyStrict(moveCollection.getRange(), [{id: 'a'}, {id: 'd'}, {id: 'b'}, {id: 'c'}, {id: 'e'}], 'Move item backward (3 -> 1)');
+
+        // Move item forward
+        moveCollection.move(1, 3);
+        t.isDeeplyStrict(moveCollection.getRange(), [{id: 'a'}, {id: 'b'}, {id: 'c'}, {id: 'd'}, {id: 'e'}], 'Move item forward (1 -> 3)');
+
+        // Swap adjacent items (forward)
+        moveCollection.move(0, 1);
+        t.isDeeplyStrict(moveCollection.getRange(), [{id: 'b'}, {id: 'a'}, {id: 'c'}, {id: 'd'}, {id: 'e'}], 'Swap adjacent items (0 -> 1)');
+
+        // Swap adjacent items (backward)
+        moveCollection.move(1, 0);
+        t.isDeeplyStrict(moveCollection.getRange(), [{id: 'a'}, {id: 'b'}, {id: 'c'}, {id: 'd'}, {id: 'e'}], 'Swap adjacent items back (1 -> 0)');
+
+        // Move to end
+        moveCollection.move(0, 4);
+        t.isDeeplyStrict(moveCollection.getRange(), [{id: 'b'}, {id: 'c'}, {id: 'd'}, {id: 'e'}, {id: 'a'}], 'Move to end (0 -> 4)');
+
+        // Move to start
+        moveCollection.move(4, 0);
+        t.isDeeplyStrict(moveCollection.getRange(), [{id: 'a'}, {id: 'b'}, {id: 'c'}, {id: 'd'}, {id: 'e'}], 'Move to start (4 -> 0)');
+    });
 });