nccgs 1.0.0 → 1.1.1

package/tests/framework.test.mjs

@@ -1,4 +1,5 @@
 import assert from "node:assert/strict";
+import crypto from "node:crypto";
 import fs from "node:fs";
 import os from "node:os";
 import path from "node:path";
@@ -9,6 +10,8 @@ import { fileURLToPath } from "node:url";
 const root = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "..");
 const studio = JSON.parse(fs.readFileSync(path.join(root, ".claude/nccgs/studio.json"), "utf8"));
 const workflows = JSON.parse(fs.readFileSync(path.join(root, ".claude/nccgs/workflow-catalog.json"), "utf8"));
+const frameworkVersion = fs.readFileSync(path.join(root, "VERSION"), "utf8").trim();
+const sha256 = (value) => crypto.createHash("sha256").update(value).digest("hex");
 
 test("studio roles are unique and workflow references resolve", () => {
   const roles = new Set(studio.agents.map((agent) => agent.name));
@@ -24,6 +27,12 @@ test("quality profile assigns all model classes", () => {
   }
 });
 
+test("migrate-project defaults to a single full run", () => {
+  const skill = fs.readFileSync(path.join(root, ".claude/skills/migrate-project/SKILL.md"), "utf8");
+  assert.match(skill, /Default to `full`/);
+  assert.match(skill, /review, plan, apply, and verify in one invocation/i);
+});
+
 test("model configurator can remove and restore model pins", () => {
   const temp = fs.mkdtempSync(path.join(os.tmpdir(), "nccgs-model-test-"));
   try {
@@ -104,7 +113,7 @@ test("installer preserves project truth, merges settings, and applies inherit pr
     assert.ok(fs.existsSync(path.join(temp, ".nccgs/backups")));
     const installStatePath = path.join(temp, ".claude/nccgs/install-state.json");
     const installState = JSON.parse(fs.readFileSync(installStatePath, "utf8"));
-    assert.equal(installState.frameworkVersion, "1.0.0");
+    assert.equal(installState.frameworkVersion, frameworkVersion);
     assert.equal(installState.modelProfile, "inherit");
 
     const obsoleteRelative = ".claude/agents/nccgs-obsolete.md";
@@ -119,3 +128,117 @@ test("installer preserves project truth, merges settings, and applies inherit pr
     fs.rmSync(temp, { recursive: true, force: true });
   }
 });
+
+test("update replaces untouched files, preserves local overrides, and doctor gates review", () => {
+  const temp = fs.mkdtempSync(path.join(os.tmpdir(), "nccgs-idempotent-update-test-"));
+  try {
+    for (const marker of ["Assets", "Packages", "ProjectSettings"]) fs.mkdirSync(path.join(temp, marker));
+    const install = spawnSync(process.execPath, [path.join(root, "scripts/cli.mjs"), "install", "--model-profile", "quality"], { cwd: temp, encoding: "utf8" });
+    assert.equal(install.status, 0, install.stderr || install.stdout);
+
+    const managedRelative = ".claude/nccgs/constitution.md";
+    const managedPath = path.join(temp, ...managedRelative.split("/"));
+    const statePath = path.join(temp, ".claude/nccgs/install-state.json");
+    const state = JSON.parse(fs.readFileSync(statePath, "utf8"));
+    const oldManagedContent = "managed by NCCGS 1.0.0\n";
+    fs.writeFileSync(managedPath, oldManagedContent, "utf8");
+    state.frameworkVersion = "1.0.0";
+    state.files.find((item) => item.relative === managedRelative).sha256 = sha256(oldManagedContent);
+    fs.writeFileSync(statePath, `${JSON.stringify(state, null, 2)}\n`, "utf8");
+
+    const update = spawnSync(process.execPath, [path.join(root, "scripts/cli.mjs"), "update"], { cwd: temp, encoding: "utf8" });
+    assert.equal(update.status, 0, update.stderr || update.stdout);
+    assert.match(update.stdout, new RegExp(`1\\.0\\.0 -> ${frameworkVersion.replace(/\./g, "\\.")}`));
+    assert.match(update.stdout, /automatic update/);
+    assert.match(update.stdout, /No project migration required/);
+    assert.equal(fs.readFileSync(managedPath, "utf8"), fs.readFileSync(path.join(root, managedRelative), "utf8"));
+
+    let doctor = spawnSync(process.execPath, [path.join(root, "scripts/cli.mjs"), "doctor"], { cwd: temp, encoding: "utf8" });
+    assert.equal(doctor.status, 0, doctor.stderr || doctor.stdout);
+    assert.match(doctor.stdout, /NCCGS doctor passed/);
+
+    fs.writeFileSync(managedPath, "project-local override\n", "utf8");
+    const preserved = spawnSync(process.execPath, [path.join(root, "scripts/cli.mjs"), "update"], { cwd: temp, encoding: "utf8" });
+    assert.equal(preserved.status, 0, preserved.stderr || preserved.stdout);
+    assert.match(preserved.stdout, /preserved override/);
+    assert.match(preserved.stdout, /Project migration required/);
+    assert.equal(fs.readFileSync(managedPath, "utf8"), "project-local override\n");
+
+    const overridePath = path.join(temp, ".nccgs/framework-overrides.json");
+    const overrides = JSON.parse(fs.readFileSync(overridePath, "utf8"));
+    const override = overrides.overrides.find((item) => item.path === managedRelative);
+    assert.equal(override.status, "pending_review");
+    assert.equal(override.disposition, "preserve");
+
+    doctor = spawnSync(process.execPath, [path.join(root, "scripts/cli.mjs"), "doctor"], { cwd: temp, encoding: "utf8" });
+    assert.equal(doctor.status, 1);
+    assert.match(doctor.stderr, /awaits \/migrate-project review/);
+
+    const approve = spawnSync(process.execPath, [path.join(temp, ".claude/nccgs/tools/approve-overrides.mjs"), "--project", temp, "--approve-pending"], { cwd: temp, encoding: "utf8" });
+    assert.equal(approve.status, 0, approve.stderr || approve.stdout);
+    doctor = spawnSync(process.execPath, [path.join(root, "scripts/cli.mjs"), "doctor"], { cwd: temp, encoding: "utf8" });
+    assert.equal(doctor.status, 0, doctor.stderr || doctor.stdout);
+  } finally {
+    fs.rmSync(temp, { recursive: true, force: true });
+  }
+});
+
+test("doctor accepts a legacy CRLF raw hash after Git normalizes the file to LF", () => {
+  const temp = fs.mkdtempSync(path.join(os.tmpdir(), "nccgs-eol-test-"));
+  try {
+    for (const marker of ["Assets", "Packages", "ProjectSettings"]) fs.mkdirSync(path.join(temp, marker));
+    const install = spawnSync(process.execPath, [path.join(root, "scripts/cli.mjs"), "install"], { cwd: temp, encoding: "utf8" });
+    assert.equal(install.status, 0, install.stderr || install.stdout);
+
+    const relative = ".claude/nccgs/constitution.md";
+    const file = path.join(temp, ...relative.split("/"));
+    const lf = fs.readFileSync(file, "utf8").replace(/\r\n?/g, "\n");
+    fs.writeFileSync(file, lf, "utf8");
+    const statePath = path.join(temp, ".claude/nccgs/install-state.json");
+    const state = JSON.parse(fs.readFileSync(statePath, "utf8"));
+    const record = state.files.find((item) => item.relative === relative);
+    record.sha256 = sha256(lf.replace(/\n/g, "\r\n"));
+    delete record.canonicalSha256;
+    state.schemaVersion = 2;
+    fs.writeFileSync(statePath, `${JSON.stringify(state, null, 2)}\n`, "utf8");
+
+    const doctor = spawnSync(process.execPath, [path.join(root, "scripts/cli.mjs"), "doctor"], { cwd: temp, encoding: "utf8" });
+    assert.equal(doctor.status, 0, doctor.stderr || doctor.stdout);
+  } finally {
+    fs.rmSync(temp, { recursive: true, force: true });
+  }
+});
+
+test("update preserves an intentionally missing managed file until migration review", () => {
+  const temp = fs.mkdtempSync(path.join(os.tmpdir(), "nccgs-absent-override-test-"));
+  try {
+    for (const marker of ["Assets", "Packages", "ProjectSettings"]) fs.mkdirSync(path.join(temp, marker));
+    const install = spawnSync(process.execPath, [path.join(root, "scripts/cli.mjs"), "install"], { cwd: temp, encoding: "utf8" });
+    assert.equal(install.status, 0, install.stderr || install.stdout);
+
+    const relative = ".claude/skills/status/SKILL.md";
+    const file = path.join(temp, ...relative.split("/"));
+    fs.unlinkSync(file);
+    const update = spawnSync(process.execPath, [path.join(root, "scripts/cli.mjs"), "update"], { cwd: temp, encoding: "utf8" });
+    assert.equal(update.status, 0, update.stderr || update.stdout);
+    assert.ok(!fs.existsSync(file));
+    const manifest = JSON.parse(fs.readFileSync(path.join(temp, ".nccgs/framework-overrides.json"), "utf8"));
+    const override = manifest.overrides.find((item) => item.path === relative);
+    assert.equal(override.disposition, "absent");
+    assert.equal(override.status, "pending_review");
+  } finally {
+    fs.rmSync(temp, { recursive: true, force: true });
+  }
+});
+
+test("update refuses a project without an NCCGS install state", () => {
+  const temp = fs.mkdtempSync(path.join(os.tmpdir(), "nccgs-update-missing-test-"));
+  try {
+    for (const marker of ["Assets", "Packages", "ProjectSettings"]) fs.mkdirSync(path.join(temp, marker));
+    const result = spawnSync(process.execPath, [path.join(root, "scripts/cli.mjs"), "update"], { cwd: temp, encoding: "utf8" });
+    assert.equal(result.status, 2);
+    assert.match(result.stderr, /not installed/);
+  } finally {
+    fs.rmSync(temp, { recursive: true, force: true });
+  }
+});