navigation-stack 0.4.0 → 0.5.0

package/test/session/WebBrowserSession.test.js

@@ -62,7 +62,7 @@ describe('WebBrowserSession', () => {
     session.start(parseInputLocation(window.location));
 
     expect(location).to.deep.include({
-      operation: 'INIT',
+      operation: 'init',
       pathname: '/initial',
       search: '?bar=baz',
       query: {
@@ -78,7 +78,7 @@ describe('WebBrowserSession', () => {
     session = new WebBrowserSession();
 
     expect(() =>
-      session.navigate('PUSH', {
+      session.navigate('push', {
         pathname: '/new',
         search: '?search',
         hash: '#hash',
@@ -103,14 +103,14 @@ describe('WebBrowserSession', () => {
 
     expect(listener).to.have.been.calledOnce();
     expect(listener.firstCall.args[0]).to.deep.include({
-      operation: 'INIT',
+      operation: 'init',
       pathname: '/initial',
       index: 0,
       delta: 0,
     });
     listener.resetHistory();
 
-    session.navigate('PUSH', {
+    session.navigate('push', {
       pathname: '/new',
       search: '?search',
       hash: '#hash',
@@ -124,7 +124,7 @@ describe('WebBrowserSession', () => {
       hash: '#hash',
     });
     expect(newLocation).to.deep.include({
-      operation: 'PUSH',
+      operation: 'push',
       pathname: '/new',
       search: '?search',
       hash: '#hash',
@@ -135,21 +135,21 @@ describe('WebBrowserSession', () => {
 
     expect(listener).to.have.been.calledOnce();
     expect(listener.firstCall.args[0]).to.deep.include({
-      operation: 'PUSH',
+      operation: 'push',
       pathname: '/new',
       index: 1,
       delta: 1,
     });
     listener.resetHistory();
 
-    session.navigate('PUSH', {
+    session.navigate('push', {
       pathname: '/new-2',
       search: '',
       hash: '',
     });
 
     expect(location).to.include({
-      operation: 'PUSH',
+      operation: 'push',
       pathname: '/new-2',
       index: 2,
       delta: 1,
@@ -157,7 +157,7 @@ describe('WebBrowserSession', () => {
 
     expect(listener).to.have.been.calledOnce();
     expect(listener.firstCall.args[0]).to.deep.include({
-      operation: 'PUSH',
+      operation: 'push',
       pathname: '/new-2',
       index: 2,
       delta: 1,
@@ -166,14 +166,14 @@ describe('WebBrowserSession', () => {
 
     expect(window.location.pathname).to.equal('/new-2');
 
-    session.navigate('REPLACE', {
+    session.navigate('replace', {
       pathname: '/new-3',
       search: '',
       hash: '',
     });
 
     expect(location).to.include({
-      operation: 'REPLACE',
+      operation: 'replace',
       pathname: '/new-3',
       index: 2,
       delta: 0,
@@ -184,7 +184,7 @@ describe('WebBrowserSession', () => {
 
     expect(listener).to.have.been.calledOnce();
     expect(listener.firstCall.args[0]).to.deep.include({
-      operation: 'REPLACE',
+      operation: 'replace',
       pathname: '/new-3',
       index: 2,
       delta: 0,
@@ -202,7 +202,7 @@ describe('WebBrowserSession', () => {
 
     expect(listener).to.have.been.calledOnce();
     expect(listener.firstCall.args[0]).to.deep.include({
-      operation: 'SHIFT',
+      operation: 'shift',
       pathname: '/new',
       search: '?search',
       hash: '#hash',
@@ -219,7 +219,7 @@ describe('WebBrowserSession', () => {
 
     expect(listener).to.have.been.calledOnce();
     expect(listener.firstCall.args[0]).to.deep.include({
-      operation: 'SHIFT',
+      operation: 'shift',
       pathname: '/initial',
       index: 0,
       delta: -1,
@@ -231,12 +231,12 @@ describe('WebBrowserSession', () => {
     window.history.replaceState(null, null, '/');
     session = new WebBrowserSession();
     session.start(parseInputLocation(window.location));
-    session.navigate('PUSH', {
+    session.navigate('push', {
       pathname: '/new',
       search: '',
       hash: '',
     });
-    session.navigate('PUSH', {
+    session.navigate('push', {
       pathname: '/new-2',
       search: '',
       hash: '',
@@ -250,7 +250,7 @@ describe('WebBrowserSession', () => {
 
     expect(listener).to.have.been.calledOnce();
     expect(listener.firstCall.args[0]).to.include({
-      operation: 'SHIFT',
+      operation: 'shift',
       pathname: '/new',
     });
     listener.resetHistory();

package/types/index.d.ts

@@ -35,22 +35,23 @@ export interface Location extends LocationBase {
    * a unique key identifying the current history entry
    */
   key: string;
+
+  /**
+   * the current index of the history entry, starting at 0 for the initial
+   * entry; this increments on `.push()` but not on `.replace()`
+   */
+  index: number;
 }
 
-type PushOrReplaceOperation = 'PUSH' | 'REPLACE';
+type PushOrReplaceOperation = 'push' | 'replace';
 
 export interface LocationInternal extends Location {
   /**
    * `navigation-stack` operation.
    */
-  operation: PushOrReplaceOperation | 'SHIFT' | 'INIT';
-  /**
-   * the current index of the history entry, starting at 0 for the initial
-   * entry; this increments on `.push()` but not on `.replace()`
-   */
-  index: number;
+  operation: PushOrReplaceOperation | 'shift' | 'init';
   /**
-   * the difference between the current index and the index of the previous location
+   * the difference between the index of the current location and the index of the previous location.
    */
   delta: number;
 }
@@ -155,7 +156,7 @@ export class NavigationStack<ScrollableContainer = any, Anchor = any> {
 
   shift(delta: number): void;
 
-  locationRendered(): void;
+  locationRendered(): Promise<void>;
 
   stop(): void;
 }

package/types/scroll-position/index.d.ts

@@ -29,7 +29,7 @@ export class ScrollPositionRestoration<
       _getPageScrollPositionForLocation?: (
         location: Location,
         prevLocation: Location | undefined,
-      ) => boolean;
+      ) => [number, number] | undefined;
 
       // Using this option, a developer could theoretically provide their own implementation
       // of setting a scroll position. For example, it could use "smooth" (animated) scrolling, etc.
@@ -61,7 +61,7 @@ export class ScrollPositionRestoration<
       _getScrollPositionForLocation?: (
         location: Location,
         prevLocation: Location | undefined,
-      ) => boolean;
+      ) => [number, number] | undefined;
 
       // Using this option, a developer could theoretically provide their own implementation
       // of setting a scroll position. For example, it could use "smooth" (animated) scrolling, etc.
@@ -70,7 +70,7 @@ export class ScrollPositionRestoration<
     },
   ): () => void;
 
-  locationRendered: (location: Location) => void;
+  locationRendered: (location: Location) => Promise<void>;
 
   stop(): void;
 

package/test/scroll-position/withScrollableContainerAtIndexPage.js

@@ -1,62 +0,0 @@
-// Adds a 100x100 scrollable container on the website.
-//
-// * When the current location is "/", it renders a large amount of content
-//   (20000x20000 to be specific) inside the container, making it scrollable.
-//
-// * At any other location, it doesn't render anything in the container.
-//
-export default function withScrollableContainerAtIndexPage(app) {
-  const container = document.createElement('div');
-  container.style.height = '100px';
-  container.style.width = '100px';
-  container.style.overflow = 'hidden';
-  document.body.appendChild(container);
-
-  let element;
-  let unregister;
-
-  // This will only be called once, so no need to guard.
-  function listen(listener) {
-    function shouldUpdatePageScrollPositionForLocation(
-      location,
-      prevLocation,
-    ) {
-      // Disable the automatic scroll restoration after a SHIFT, to check the
-      // scroll-on-register behavior.
-      if (prevLocation && location.operation === 'SHIFT') {
-        return false;
-      }
-
-      return true;
-    }
-
-    const unlisten = app.listen((location) => {
-      listener(location);
-
-      if (location.pathname === '/') {
-        element = document.createElement('div');
-        element.style.height = '20000px';
-        element.style.width = '20000px';
-        container.appendChild(element);
-
-        unregister = app.registerScrollableContainer('container', container, {
-          shouldUpdatePageScrollPositionForLocation,
-        });
-      } else {
-        container.removeChild(element);
-        unregister();
-      }
-    });
-
-    return () => {
-      unlisten();
-      document.body.removeChild(container);
-    };
-  }
-
-  return {
-    ...app,
-    container,
-    listen,
-  };
-}