natural 6.10.2 → 6.10.4

package/lib/natural/brill_pos_tagger/lib/Brill_POS_Trainer.js

@@ -30,401 +30,403 @@ const Sentence = require('./Sentence')
 // Training continues as long as there are rules with a positive score
 // that have not been selected before
 const minScore = 0
-
 // After training rules with a score below scoreThreshold are pruned
-function BrillPOSTrainer (ruleScoreThreshold) {
-  if (ruleScoreThreshold) {
-    this.ruleScoreThreshold = ruleScoreThreshold
-  } else {
-    this.ruleScoreThreshold = 1
+
+class BrillPOSTrainer {
+  constructor (ruleScoreThreshold) {
+    if (ruleScoreThreshold) {
+      this.ruleScoreThreshold = ruleScoreThreshold
+    } else {
+      this.ruleScoreThreshold = 1
+    }
   }
-}
 
-// Return the highest scoring rule from the rule set
-BrillPOSTrainer.prototype.selectHighRule = function () {
-  let highestRule = null
+  // Return the highest scoring rule from the rule set
+  selectHighRule () {
+    let highestRule = null
 
-  // Walk through the map and find the rule with highest score
-  this.positiveRules.getRules().forEach(function (rule) {
-    if (highestRule === null) {
-      if (!rule.hasBeenSelectedAsHighRuleBefore) {
-        highestRule = rule
-      }
-    } else {
-      if ((rule.score() > highestRule.score()) &&
-        !rule.hasBeenSelectedAsHighRuleBefore) {
-        highestRule = rule
+    // Walk through the map and find the rule with highest score
+    this.positiveRules.getRules().forEach(function (rule) {
+      if (highestRule === null) {
+        if (!rule.hasBeenSelectedAsHighRuleBefore) {
+          highestRule = rule
+        }
+      } else {
+        if ((rule.score() > highestRule.score()) &&
+          !rule.hasBeenSelectedAsHighRuleBefore) {
+          highestRule = rule
+        }
       }
-    }
-  })
+    })
 
-  if (highestRule !== null) {
-    highestRule.hasBeenSelectedAsHighRuleBefore = true
+    if (highestRule !== null) {
+      highestRule.hasBeenSelectedAsHighRuleBefore = true
+    }
+    // Return the rule with the highest score
+    return highestRule
   }
-  // Return the rule with the highest score
-  return highestRule
-}
 
-BrillPOSTrainer.prototype.mapRuleToSite = function (rule, i, j) {
-  if (!this.mapRuleToSites[rule.key()]) {
-    this.mapRuleToSites[rule.key()] = {}
-  }
-  if (!this.mapRuleToSites[rule.key()][i]) {
-    this.mapRuleToSites[rule.key()][i] = {}
+  mapRuleToSite (rule, i, j) {
+    if (!this.mapRuleToSites[rule.key()]) {
+      this.mapRuleToSites[rule.key()] = {}
+    }
+    if (!this.mapRuleToSites[rule.key()][i]) {
+      this.mapRuleToSites[rule.key()][i] = {}
+    }
+    this.mapRuleToSites[rule.key()][i][j] = true
   }
-  this.mapRuleToSites[rule.key()][i][j] = true
-}
 
-BrillPOSTrainer.prototype.mapSiteToRule = function (i, j, rule) {
-  if (!this.mapSiteToRules[i]) {
-    this.mapSiteToRules[i] = {}
-  }
-  if (!this.mapSiteToRules[i][j]) {
-    this.mapSiteToRules[i][j] = {}
+  mapSiteToRule (i, j, rule) {
+    if (!this.mapSiteToRules[i]) {
+      this.mapSiteToRules[i] = {}
+    }
+    if (!this.mapSiteToRules[i][j]) {
+      this.mapSiteToRules[i][j] = {}
+    }
+    this.mapSiteToRules[i][j][rule.key()] = rule
   }
-  this.mapSiteToRules[i][j][rule.key()] = rule
-}
 
-BrillPOSTrainer.prototype.associateSiteWithRule = function (i, j, rule) {
-  this.mapRuleToSite(rule, i, j)
-  this.mapSiteToRule(i, j, rule)
-}
+  associateSiteWithRule (i, j, rule) {
+    this.mapRuleToSite(rule, i, j)
+    this.mapSiteToRule(i, j, rule)
+  }
 
-BrillPOSTrainer.prototype.siteIsAssociatedWithRule = function (i, j, rule) {
-  if (this.mapSiteToRules[i]) {
-    if (this.mapSiteToRules[i][j]) {
-      if (this.mapSiteToRules[i][j][rule.key()]) {
-        return true
+  siteIsAssociatedWithRule (i, j, rule) {
+    if (this.mapSiteToRules[i]) {
+      if (this.mapSiteToRules[i][j]) {
+        if (this.mapSiteToRules[i][j][rule.key()]) {
+          return true
+        }
       }
     }
+    return false
   }
-  return false
-}
 
-// Returns an array of all sites associated with rule
-BrillPOSTrainer.prototype.getSites = function (rule) {
-  const that = this
-  const result = []
-  Object.keys(this.mapRuleToSites[rule.key()]).forEach(function (i) {
-    Object.keys(that.mapRuleToSites[rule.key()][i]).forEach(function (j) {
-      // Unary plus the convert hash keys i and j to integer
-      result.push([+i, +j])
+  // Returns an array of all sites associated with rule
+  getSites (rule) {
+    const that = this
+    const result = []
+    Object.keys(this.mapRuleToSites[rule.key()]).forEach(function (i) {
+      Object.keys(that.mapRuleToSites[rule.key()][i]).forEach(function (j) {
+        // Unary plus the convert hash keys i and j to integer
+        result.push([+i, +j])
+      })
     })
-  })
-  // logger.debug("BrillPOSTrainer.prototype.getSites: sites " + JSON.stringify(result));
-  return (result)
-}
+    // logger.debug("BrillPOSTrainer.prototype.getSites: sites " + JSON.stringify(result));
+    return (result)
+  }
 
-// Returns an array of all rules associated with the site
-BrillPOSTrainer.prototype.getRules = function (i, j) {
-  let result = []
-  const that = this
+  // Returns an array of all rules associated with the site
+  getRules (i, j) {
+    let result = []
+    const that = this
 
-  if (this.mapSiteToRules[i]) {
-    if (this.mapSiteToRules[i][j]) {
-      result = Object.keys(this.mapSiteToRules[i][j]).map(function (key) {
-        return that.mapSiteToRules[i][j][key]
-      })
+    if (this.mapSiteToRules[i]) {
+      if (this.mapSiteToRules[i][j]) {
+        result = Object.keys(this.mapSiteToRules[i][j]).map(function (key) {
+          return that.mapSiteToRules[i][j][key]
+        })
+      }
     }
+    return result
   }
-  return result
-}
 
-BrillPOSTrainer.prototype.disconnectSiteFromRule = function (i, j, rule) {
-  // mapRuleToSites
-  if (this.mapRuleToSites[rule.key()]) {
-    if (this.mapRuleToSites[rule.key()][i]) {
-      if (this.mapRuleToSites[rule.key()][i][j]) {
-        delete this.mapRuleToSites[rule.key()][i][j]
+  disconnectSiteFromRule (i, j, rule) {
+    // mapRuleToSites
+    if (this.mapRuleToSites[rule.key()]) {
+      if (this.mapRuleToSites[rule.key()][i]) {
+        if (this.mapRuleToSites[rule.key()][i][j]) {
+          delete this.mapRuleToSites[rule.key()][i][j]
+        }
       }
     }
-  }
 
-  // mapSiteToRules
-  if (this.mapSiteToRules[i]) {
-    if (this.mapSiteToRules[i][j]) {
-      if (this.mapSiteToRules[i][j][rule.key()]) {
-        delete this.mapSiteToRules[i][j][rule.key()]
+    // mapSiteToRules
+    if (this.mapSiteToRules[i]) {
+      if (this.mapSiteToRules[i][j]) {
+        if (this.mapSiteToRules[i][j][rule.key()]) {
+          delete this.mapSiteToRules[i][j][rule.key()]
+        }
       }
     }
   }
-}
 
-// Adjusts the score of the rule at position i, j of the corpus
-BrillPOSTrainer.prototype.scoreRule = function (rule, i, j) {
-  // logger.debug("BrillPOSTrainer.prototype.scoreRule: entry");
-  const token = this.corpus.sentences[i].taggedWords[j]
-  const rightTag = token.tag
-  const oldTag = token.testTag
-  const newTag = token.newTag
-  if (rightTag !== oldTag) {
-    // Old tag is wrong
-    if (newTag === rightTag) {
-      // New tag is right
-      rule.positive++
-      // If the score changes, it may be selected again as highest scoring rule
-      rule.hasBeenSelectedAsHighRuleBefore = false
-      // logger.debug("BrillPOSTrainer.prototype.scoreRule: positive: " + rule.key() + "\t score: " + rule.positive);
-    } else {
-      // New tag is wrong as well --> neutral
-      rule.neutral++
-      // logger.debug("BrillPOSTrainer.prototype.scoreRule: neutral: " + rule.key() + "\t score: " + rule.neutral);
-    }
-  } else {
-    // Old tag is right
-    if (newTag === rightTag) {
-      // New tag is right --> neutral
-      rule.neutral++
-      // logger.debug("BrillPOSTrainer.prototype.scoreRule: neutral: " + rule.key() + "\t score: " + rule.neutral);
+  // Adjusts the score of the rule at position i, j of the corpus
+  scoreRule (rule, i, j) {
+    // logger.debug("BrillPOSTrainer.prototype.scoreRule: entry");
+    const token = this.corpus.sentences[i].taggedWords[j]
+    const rightTag = token.tag
+    const oldTag = token.testTag
+    const newTag = token.newTag
+    if (rightTag !== oldTag) {
+      // Old tag is wrong
+      if (newTag === rightTag) {
+        // New tag is right
+        rule.positive++
+        // If the score changes, it may be selected again as highest scoring rule
+        rule.hasBeenSelectedAsHighRuleBefore = false
+        // logger.debug("BrillPOSTrainer.prototype.scoreRule: positive: " + rule.key() + "\t score: " + rule.positive);
+      } else {
+        // New tag is wrong as well --> neutral
+        rule.neutral++
+        // logger.debug("BrillPOSTrainer.prototype.scoreRule: neutral: " + rule.key() + "\t score: " + rule.neutral);
+      }
     } else {
-      // New tag is false
-      rule.negative++
-      // If the score changes, it may be selected again as highest scoring rule
-      rule.hasBeenSelectedAsHighRuleBefore = false
-      // logger.debug("BrillPOSTrainer.prototype.scoreRule: negative: " + rule.key() + "\t score: " + rule.negative);
+      // Old tag is right
+      if (newTag === rightTag) {
+        // New tag is right --> neutral
+        rule.neutral++
+        // logger.debug("BrillPOSTrainer.prototype.scoreRule: neutral: " + rule.key() + "\t score: " + rule.neutral);
+      } else {
+        // New tag is false
+        rule.negative++
+        // If the score changes, it may be selected again as highest scoring rule
+        rule.hasBeenSelectedAsHighRuleBefore = false
+        // logger.debug("BrillPOSTrainer.prototype.scoreRule: negative: " + rule.key() + "\t score: " + rule.negative);
+      }
     }
+    // logger.debug("BrillPOSTrainer.prototype.scoreRule: exit");
   }
-  // logger.debug("BrillPOSTrainer.prototype.scoreRule: exit");
-}
 
-// Generate positive rules for this given site using templates
-BrillPOSTrainer.prototype.generatePositiveRules = function (i, j) {
-  const sentence = this.corpus.sentences[i]
-  const token = sentence.taggedWords[j]
-  // A positive rule should trigger on the currently assigned testTag
-  const oldTag = token.testTag
-  // logger.debug("BrillPOSTrainer.prototype.generatePositiveRules: oldTag " + oldTag);
-  // It should assign the right tag as given by the corpus
-  const newTag = token.tag
-  // logger.debug("BrillPOSTrainer.prototype.generatePositiveRules: newTag " + newTag);
-
-  const newRules = new RuleSet()
-  // Exit if testTag already is the right tag --> will not result in positive rules
-  if (oldTag === newTag) {
-    return newRules
-  }
+  // Generate positive rules for this given site using templates
+  generatePositiveRules (i, j) {
+    const sentence = this.corpus.sentences[i]
+    const token = sentence.taggedWords[j]
+    // A positive rule should trigger on the currently assigned testTag
+    const oldTag = token.testTag
+    // logger.debug("BrillPOSTrainer.prototype.generatePositiveRules: oldTag " + oldTag);
+    // It should assign the right tag as given by the corpus
+    const newTag = token.tag
+    // logger.debug("BrillPOSTrainer.prototype.generatePositiveRules: newTag " + newTag);
+
+    const newRules = new RuleSet()
+    // Exit if testTag already is the right tag --> will not result in positive rules
+    if (oldTag === newTag) {
+      return newRules
+    }
 
-  this.templates.forEach(function (template) {
-    if (template.windowFitsSite(sentence, j)) {
-      if (template.meta.nrParameters === 1) {
-        template.meta.parameter1Values(sentence, j).forEach(function (value) {
-          newRules.addRule(new TransformationRule(oldTag, newTag, template.predicateName, value))
-        })
-      } else {
-        if (template.meta.nrParameters === 2) {
-          template.meta.parameter1Values(sentence, j).forEach(function (value1) {
-            template.meta.parameter2Values(sentence, j).forEach(function (value2) {
-              newRules.addRule(new TransformationRule(oldTag, newTag, template.predicateName, value1, value2))
-            })
+    this.templates.forEach(function (template) {
+      if (template.windowFitsSite(sentence, j)) {
+        if (template.meta.nrParameters === 1) {
+          template.meta.parameter1Values(sentence, j).forEach(function (value) {
+            newRules.addRule(new TransformationRule(oldTag, newTag, template.predicateName, value))
           })
         } else {
-          // 0 paramaters
-          newRules.addRule(new TransformationRule(oldTag, newTag, template.predicateName))
+          if (template.meta.nrParameters === 2) {
+            template.meta.parameter1Values(sentence, j).forEach(function (value1) {
+              template.meta.parameter2Values(sentence, j).forEach(function (value2) {
+                newRules.addRule(new TransformationRule(oldTag, newTag, template.predicateName, value1, value2))
+              })
+            })
+          } else {
+            // 0 paramaters
+            newRules.addRule(new TransformationRule(oldTag, newTag, template.predicateName))
+          }
         }
       }
-    }
-  })
-  return newRules
-}
+    })
+    return newRules
+  }
 
-// Finds all rules that are applicable at some site
-BrillPOSTrainer.prototype.scanForPositiveRules = function () {
-  // logger.debug("BrillPOSTrainer.prototype.scanForPositiveRules: entry");
-  const that = this
-  this.corpus.sentences.forEach(function (sentence, i) {
-    sentence.taggedWords.forEach(function (token, j) {
-      // logger.debug("BrillPOSTrainer.prototype.scanForPositiveRules: sentence no " + i);
-      const newRules = that.generatePositiveRules(i, j)
-      newRules.getRules().forEach(function (rule) {
-        that.positiveRules.addRule(rule)
-        // logger.debug("BrillPOSTrainer.prototype.scanForPositiveRules: nrRules " + that.positiveRules.nrRules());
+  // Finds all rules that are applicable at some site
+  scanForPositiveRules () {
+    // logger.debug("BrillPOSTrainer.prototype.scanForPositiveRules: entry");
+    const that = this
+    this.corpus.sentences.forEach(function (sentence, i) {
+      sentence.taggedWords.forEach(function (token, j) {
+        // logger.debug("BrillPOSTrainer.prototype.scanForPositiveRules: sentence no " + i);
+        const newRules = that.generatePositiveRules(i, j)
+        newRules.getRules().forEach(function (rule) {
+          that.positiveRules.addRule(rule)
+          // logger.debug("BrillPOSTrainer.prototype.scanForPositiveRules: nrRules " + that.positiveRules.nrRules());
+        })
       })
     })
-  })
-  // logger.debug("BrillPOSTrainer.prototype.scanForPositiveRules: exit, number of rules: " + this.positiveRules.nrRules());
-}
+    // logger.debug("BrillPOSTrainer.prototype.scanForPositiveRules: exit, number of rules: " + this.positiveRules.nrRules());
+  }
 
-// Find all sites where the rules can be applied, register these sites and
-// update the scores
-BrillPOSTrainer.prototype.scanForSites = function () {
-  // logger.debug("BrillPOSTrainer.prototype.scanForSites: entry");
-  const that = this
+  // Find all sites where the rules can be applied, register these sites and
+  // update the scores
+  scanForSites () {
+    // logger.debug("BrillPOSTrainer.prototype.scanForSites: entry");
+    const that = this
 
-  // Scan the corpus
-  this.corpus.sentences.forEach(function (sentence, i) {
-    if (i % 100 === 0) {
-      // logger.info("BrillPOSTrainer.prototype.scanForSites: sentence " + i);
-    }
+    // Scan the corpus
+    this.corpus.sentences.forEach(function (sentence, i) {
+      if (i % 100 === 0) {
+        // logger.info("BrillPOSTrainer.prototype.scanForSites: sentence " + i);
+      }
 
-    const taggedSentence = new Sentence()
-    sentence.taggedWords.forEach(function (wordObject) {
-      taggedSentence.addTaggedWord(wordObject.token, wordObject.testTag)
-    })
+      const taggedSentence = new Sentence()
+      sentence.taggedWords.forEach(function (wordObject) {
+        taggedSentence.addTaggedWord(wordObject.token, wordObject.testTag)
+      })
 
-    sentence.taggedWords.forEach(function (token, j) {
-      that.positiveRules.getRules().forEach(function (rule) {
-        if (rule.isApplicableAt(sentence, taggedSentence, j)) {
-          that.associateSiteWithRule(i, j, rule)
-          that.scoreRule(rule, i, j)
-          // logger.debug("BrillPOSTrainer.prototype.scanForSites: (sentence, token, rule): (" + i + ", " + j + ", " + rule.prettyPrint() + ")");
-        }
+      sentence.taggedWords.forEach(function (token, j) {
+        that.positiveRules.getRules().forEach(function (rule) {
+          if (rule.isApplicableAt(sentence, taggedSentence, j)) {
+            that.associateSiteWithRule(i, j, rule)
+            that.scoreRule(rule, i, j)
+            // logger.debug("BrillPOSTrainer.prototype.scanForSites: (sentence, token, rule): (" + i + ", " + j + ", " + rule.prettyPrint() + ")");
+          }
+        })
       })
     })
-  })
 
-  // logger.debug("BrillPOSTrainer.prototype.scanForSites: exit");
-}
-
-// Returns a list of sites that may have been touched by a changing tag
-BrillPOSTrainer.prototype.neighbourhood = function (i, j) {
-  const sentenceLength = this.corpus.sentences[i].length
-  const list = []
-
-  if (this.index > 2) {
-    list.push([i, j - 3])
-  }
-  if (this.index > 1) {
-    list.push([i, j - 2])
+    // logger.debug("BrillPOSTrainer.prototype.scanForSites: exit");
   }
-  if (this.index > 0) {
-    list.push([i, j - 1])
-  }
-  if (this.index < sentenceLength - 1) {
-    list.push([i, j + 1])
-  }
-  if (this.index < sentenceLength - 2) {
-    list.push([i, j + 2])
-  }
-  if (this.index > sentenceLength - 3) {
-    list.push([i, j + 3])
-  }
-  return list
-}
 
-// corpus: an array of token arrays
-// templates: an array of rule templates
-// lexicon: lexicon that provides method tagWord(word)
-BrillPOSTrainer.prototype.train = function (corpus, templates, lexicon) {
-  this.corpus = corpus
-  this.templates = templates
-  this.positiveRules = new RuleSet()
-  this.mapRuleToSites = {}
-  this.mapSiteToRules = {}
-
-  // logger.debug("BrillPOSTrainer.prototype.train: entry");
-  this.corpus.tag(lexicon)
-  this.scanForPositiveRules()
-  // logger.info("BrillPOSTrainer.prototype.train: initial number of rules: " + this.positiveRules.nrRules());
-  this.scanForSites()
-
-  let highRule = this.selectHighRule()
-  let iterationNumber = 0
-  const that = this
-  while ((highRule !== null) && (highRule.score() > minScore)) {
-    if ((iterationNumber % 5) === 0) {
-      // logger.info("BrillPOSTrainer.prototype.train: training iteration: " + iterationNumber);
+  // Returns a list of sites that may have been touched by a changing tag
+  neighbourhood (i, j) {
+    const sentenceLength = this.corpus.sentences[i].length
+    const list = []
+
+    if (this.index > 2) {
+      list.push([i, j - 3])
     }
-    // logger.debug("BrillPOSTrainer.prototype.train: highRule selected: " + highRule.key());
-    // logger.debug("BrillPOSTrainer.prototype.train: number of rules: " + this.positiveRules.nrRules());
-    // logger.debug("BrillPOSTrainer.prototype.train: score of highRule: " + highRule.score());
-
-    // Apply the high rule to each change site on its site list
-    this.getSites(highRule).forEach(function (site) {
-      // logger.debug("BrillPOSTrainer.prototype.train: apply highRule to: " + site);
-      // logger.debug("BrillPOSTrainer.prototype.train: sentence length: " + that.corpus.sentences[site[0]].length);
-      highRule.applyAt(that.corpus.sentences[site[0]], site[1])
-    })
+    if (this.index > 1) {
+      list.push([i, j - 2])
+    }
+    if (this.index > 0) {
+      list.push([i, j - 1])
+    }
+    if (this.index < sentenceLength - 1) {
+      list.push([i, j + 1])
+    }
+    if (this.index < sentenceLength - 2) {
+      list.push([i, j + 2])
+    }
+    if (this.index > sentenceLength - 3) {
+      list.push([i, j + 3])
+    }
+    return list
+  }
 
-    const unseenRules = new RuleSet()
-    this.getSites(highRule).forEach(function (site) {
-      that.neighbourhood(site[0], site[1]).forEach(function (testSite) {
-        // Generate positive rules for testSite
-        const newRules = that.generatePositiveRules(testSite[0], testSite[1])
-
-        // Disconnect test site from its rules
-        // because highrule has been applied
-        that.getRules(testSite[0], testSite[1]).forEach(function (rule) {
-          if (!newRules.hasRule(rule)) {
-            that.disconnectSiteFromRule(testSite[0], testSite[1], rule)
-          }
-        })
+  // corpus: an array of token arrays
+  // templates: an array of rule templates
+  // lexicon: lexicon that provides method tagWord(word)
+  train (corpus, templates, lexicon) {
+    this.corpus = corpus
+    this.templates = templates
+    this.positiveRules = new RuleSet()
+    this.mapRuleToSites = {}
+    this.mapSiteToRules = {}
+
+    // logger.debug("BrillPOSTrainer.prototype.train: entry");
+    this.corpus.tag(lexicon)
+    this.scanForPositiveRules()
+    // logger.info("BrillPOSTrainer.prototype.train: initial number of rules: " + this.positiveRules.nrRules());
+    this.scanForSites()
+
+    let highRule = this.selectHighRule()
+    let iterationNumber = 0
+    const that = this
+    while ((highRule !== null) && (highRule.score() > minScore)) {
+      if ((iterationNumber % 5) === 0) {
+        // logger.info("BrillPOSTrainer.prototype.train: training iteration: " + iterationNumber);
+      }
+      // logger.debug("BrillPOSTrainer.prototype.train: highRule selected: " + highRule.key());
+      // logger.debug("BrillPOSTrainer.prototype.train: number of rules: " + this.positiveRules.nrRules());
+      // logger.debug("BrillPOSTrainer.prototype.train: score of highRule: " + highRule.score());
+
+      // Apply the high rule to each change site on its site list
+      this.getSites(highRule).forEach(function (site) {
+        // logger.debug("BrillPOSTrainer.prototype.train: apply highRule to: " + site);
+        // logger.debug("BrillPOSTrainer.prototype.train: sentence length: " + that.corpus.sentences[site[0]].length);
+        highRule.applyAt(that.corpus.sentences[site[0]], site[1])
+      })
 
-        // Connect new rules not already connected to the test site
-        newRules.getRules().forEach(function (rule) {
-          if (!that.siteIsAssociatedWithRule(testSite[0].testSite[1], rule)) {
-            if (that.positiveRules.hasRule(rule)) {
-              that.associateSiteWithRule(testSite[0], testSite[1], rule)
-            } else {
-              unseenRules.addRule(rule)
+      const unseenRules = new RuleSet()
+      this.getSites(highRule).forEach(function (site) {
+        that.neighbourhood(site[0], site[1]).forEach(function (testSite) {
+          // Generate positive rules for testSite
+          const newRules = that.generatePositiveRules(testSite[0], testSite[1])
+
+          // Disconnect test site from its rules
+          // because highrule has been applied
+          that.getRules(testSite[0], testSite[1]).forEach(function (rule) {
+            if (!newRules.hasRule(rule)) {
+              that.disconnectSiteFromRule(testSite[0], testSite[1], rule)
             }
-          }
-        })
+          })
 
-        // Process unseen rules
-        if (unseenRules.nrRules() > 0) {
-          unseenRules.getRules().forEach(function (rule) {
-            that.positiveRules.addRule(rule)
+          // Connect new rules not already connected to the test site
+          newRules.getRules().forEach(function (rule) {
+            if (!that.siteIsAssociatedWithRule(testSite[0].testSite[1], rule)) {
+              if (that.positiveRules.hasRule(rule)) {
+                that.associateSiteWithRule(testSite[0], testSite[1], rule)
+              } else {
+                unseenRules.addRule(rule)
+              }
+            }
           })
-          that.corpus.sentences.forEach(function (sentence, i) {
-            const taggedSentence = sentence.map(function (token) {
-              return [token.token, token.testTag]
+
+          // Process unseen rules
+          if (unseenRules.nrRules() > 0) {
+            unseenRules.getRules().forEach(function (rule) {
+              that.positiveRules.addRule(rule)
             })
-            sentence.forEach(function (token, j) {
-              unseenRules.getRules().forEach(function (rule) {
-                if (rule.isApplicableAt(sentence, taggedSentence, j)) {
-                  that.associateSiteWithRule(i, j, rule)
-                  that.scoreRule(rule, i, j)
-                }
+            that.corpus.sentences.forEach(function (sentence, i) {
+              const taggedSentence = sentence.map(function (token) {
+                return [token.token, token.testTag]
+              })
+              sentence.forEach(function (token, j) {
+                unseenRules.getRules().forEach(function (rule) {
+                  if (rule.isApplicableAt(sentence, taggedSentence, j)) {
+                    that.associateSiteWithRule(i, j, rule)
+                    that.scoreRule(rule, i, j)
+                  }
+                })
               })
             })
-          })
-        }
+          }
+        })
       })
-    })
-
-    // Select next highest scoring rule
-    highRule = this.selectHighRule()
-    iterationNumber++
-  }
-  // logger.info("BrillPOSTrainer.prototype.train: number of iterations: " + iterationNumber);
-  // logger.info("BrillPOSTrainer.prototype.train: number of rules: " + this.positiveRules.nrRules());
 
-  // Remove rules having a non-positive score
-  this.positiveRules.getRules().forEach(function (rule) {
-    if (rule.score() < that.ruleScoreThreshold) {
-      that.positiveRules.removeRule(rule)
+      // Select next highest scoring rule
+      highRule = this.selectHighRule()
+      iterationNumber++
     }
-  })
+    // logger.info("BrillPOSTrainer.prototype.train: number of iterations: " + iterationNumber);
+    // logger.info("BrillPOSTrainer.prototype.train: number of rules: " + this.positiveRules.nrRules());
 
-  // logger.info("BrillPOSTrainer.prototype.train: number of rules after pruning: " + this.positiveRules.nrRules());
-  // logger.debug("BrillPOSTrainer.prototype.train: exit");
-  return this.positiveRules
-}
+    // Remove rules having a non-positive score
+    this.positiveRules.getRules().forEach(function (rule) {
+      if (rule.score() < that.ruleScoreThreshold) {
+        that.positiveRules.removeRule(rule)
+      }
+    })
+
+    // logger.info("BrillPOSTrainer.prototype.train: number of rules after pruning: " + this.positiveRules.nrRules());
+    // logger.debug("BrillPOSTrainer.prototype.train: exit");
+    return this.positiveRules
+  }
 
-BrillPOSTrainer.prototype.printRulesWithScores = function () {
-  let result = ''
+  printRulesWithScores () {
+    let result = ''
 
-  function compareRules (a, b) {
-    if (a.score() > b.score()) {
-      return -1
-    } else {
-      if (a.score() < b.score()) {
-        return 1
+    function compareRules (a, b) {
+      if (a.score() > b.score()) {
+        return -1
       } else {
-        return 0
+        if (a.score() < b.score()) {
+          return 1
+        } else {
+          return 0
+        }
       }
     }
-  }
 
-  const rules = this.positiveRules.getRules()
-  const sortedRules = rules.sort(compareRules)
+    const rules = this.positiveRules.getRules()
+    const sortedRules = rules.sort(compareRules)
 
-  sortedRules.forEach(function (rule) {
-    // if (rule.score() > 0) {
-    result += rule.score() + '\t' + rule.positive + '\t' + rule.negative + '\t' + rule.neutral + '\t' + rule.prettyPrint() + '\n'
-    // }
-  })
-  return result
+    sortedRules.forEach(function (rule) {
+      // if (rule.score() > 0) {
+      result += rule.score() + '\t' + rule.positive + '\t' + rule.negative + '\t' + rule.neutral + '\t' + rule.prettyPrint() + '\n'
+      // }
+    })
+    return result
+  }
 }
 
 module.exports = BrillPOSTrainer