nativescript 9.0.0-alpha.7 → 9.0.0-alpha.8

package/lib/services/doctor-service.js

@@ -52,13 +52,9 @@ class DoctorService {
             this.printPackageManagerTip();
         }
         if (!configOptions || configOptions.trackResult) {
-            // TODO(Analytics): Consider sending this information to Google Analytics
-            // await this.$analyticsService.track("DoctorEnvironmentSetup", hasWarnings ? "incorrect" : "correct");
         }
         if (hasWarnings) {
             this.$logger.info("There seem to be issues with your configuration.");
-            // cleanup the cache file as there seems to be issues with the current config
-            // all projects need to be rechecked
             this.$fs.deleteFile(this.jsonFileSettingsPath);
         }
         else {
@@ -72,7 +68,6 @@ class DoctorService {
         catch (err) {
             this.$logger.error("Cannot get the latest versions information from npm. Please try again later.");
         }
-        // todo: check for deprecated imports from `tns-core-modules`
         this.checkForDeprecatedShortImportsInAppDir(configOptions.projectDir);
         await this.$injector
             .resolve("platformEnvironmentRequirements")
@@ -85,12 +80,12 @@ class DoctorService {
     }
     async runSetupScript() {
         await this.$analyticsService.trackEventActionInGoogleAnalytics({
-            action: "Run Setup Script" /* TrackActionNames.RunSetupScript */,
+            action: "Run Setup Script",
             additionalData: "Starting",
         });
         if (this.$hostInfo.isLinux) {
             await this.$analyticsService.trackEventActionInGoogleAnalytics({
-                action: "Run Setup Script" /* TrackActionNames.RunSetupScript */,
+                action: "Run Setup Script",
                 additionalData: "Skipped as OS is Linux",
             });
             return;
@@ -103,13 +98,13 @@ class DoctorService {
             await this.runSetupScriptCore(DoctorService.WindowsSetupScriptExecutable, DoctorService.WindowsSetupScriptArguments);
         }
         await this.$analyticsService.trackEventActionInGoogleAnalytics({
-            action: "Run Setup Script" /* TrackActionNames.RunSetupScript */,
+            action: "Run Setup Script",
             additionalData: "Finished",
         });
     }
     async canExecuteLocalBuild(configuration) {
         await this.$analyticsService.trackEventActionInGoogleAnalytics({
-            action: "Check Local Build Setup" /* TrackActionNames.CheckLocalBuildSetup */,
+            action: "Check Local Build Setup",
             additionalData: "Starting",
         });
         const sysInfoConfig = {
@@ -121,11 +116,9 @@ class DoctorService {
         const warnings = this.filterInfosByType(infos, doctor_1.constants.WARNING_TYPE_NAME);
         const hasWarnings = warnings.length > 0;
         if (hasWarnings) {
-            // cleanup the cache file as there seems to be issues with the current config
-            // all projects need to be rechecked
             this.$fs.deleteFile(this.jsonFileSettingsPath);
             await this.$analyticsService.trackEventActionInGoogleAnalytics({
-                action: "Check Local Build Setup" /* TrackActionNames.CheckLocalBuildSetup */,
+                action: "Check Local Build Setup",
                 additionalData: `Warnings:${warnings.map((w) => w.message).join("__")}`,
             });
             this.printInfosCore(infos);
@@ -135,7 +128,7 @@ class DoctorService {
             await this.$jsonFileSettingsService.saveSetting(this.getKeyForConfiguration(sysInfoConfig), infos);
         }
         await this.$analyticsService.trackEventActionInGoogleAnalytics({
-            action: "Check Local Build Setup" /* TrackActionNames.CheckLocalBuildSetup */,
+            action: "Check Local Build Setup",
             additionalData: `Finished: Is setup correct: ${!hasWarnings}`,
         });
         return !hasWarnings;
@@ -183,13 +176,6 @@ class DoctorService {
             .getFsStats(path.join(pathToTnsCoreModules, entry))
             .isDirectory());
         const stringRegularExpressionsPerDir = coreModulesSubDirs.map((c) => {
-            // require("text");
-            // require("text/smth");
-            // require(   "text/smth");
-            // require(   "text/smth"   );
-            // import * as text from "text";
-            // import { a } from "text";
-            // import {a } from "text/abc"
             const subDirPart = `[\"\']${c}[\"\'/]`;
             return `(\\brequire\\s*?\\(\\s*?${subDirPart})|(\\bimport\\b.*?from\\s*?${subDirPart})`;
         });
@@ -287,4 +273,3 @@ __decorate([
     (0, decorators_1.cache)()
 ], DoctorService.prototype, "$jsonFileSettingsService", null);
 yok_1.injector.register("doctorService", DoctorService);
-//# sourceMappingURL=doctor-service.js.map

package/lib/services/extensibility-service.js

@@ -119,17 +119,12 @@ class ExtensibilityService {
         for (const extensionData of allExtensions) {
             const extensionName = extensionData.package.name;
             try {
-                // now get full package.json for the latest version of the package
                 const registryData = await this.$packageManager.getRegistryPackageData(extensionName);
                 const latestPackageData = registryData.versions[registryData["dist-tags"].latest];
                 const commands = latestPackageData &&
                     latestPackageData.nativescript &&
                     latestPackageData.nativescript.commands;
                 if (commands && commands.length) {
-                    // For each default command we need to add its short syntax in the array of commands.
-                    // For example in case there's a default command called devices list, the commands array will contain devices|*list.
-                    // However, in case the user executes just tns devices, CLI will still execute the tns devices list command.
-                    // So we need to add the devices command as well.
                     _.filter(commands, (command) => command.indexOf(inputOpts.defaultCommandDelimiter) !== -1).forEach((defaultCommand) => {
                         commands.push(defaultCommand.replace(defaultCommandRegExp, ""));
                     });
@@ -151,7 +146,6 @@ class ExtensibilityService {
                 }
             }
             catch (err) {
-                // We do not want to stop the whole process in case we are unable to find data for one of the extensions.
                 this.$logger.trace(`Unable to get data for ${extensionName}. Error is: ${err}`);
             }
         }
@@ -184,7 +178,6 @@ class ExtensibilityService {
         this.assertExtensionsDirExists();
         if (!this.$fs.exists(this.pathToPackageJson)) {
             this.$logger.trace(`Creating ${this.pathToPackageJson}.`);
-            // create default package.json
             this.$fs.writeJson(this.pathToPackageJson, {
                 name: "nativescript-extensibility",
                 version: "1.0.0",
@@ -206,4 +199,3 @@ __decorate([
     (0, decorators_1.cache)()
 ], ExtensibilityService.prototype, "assertPackageJsonExists", null);
 yok_1.injector.register("extensibilityService", ExtensibilityService);
-//# sourceMappingURL=extensibility-service.js.map

package/lib/services/files-hash-service.js

@@ -61,4 +61,3 @@ class FilesHashService {
 }
 exports.FilesHashService = FilesHashService;
 yok_1.injector.register("filesHashService", FilesHashService);
-//# sourceMappingURL=files-hash-service.js.map

package/lib/services/hmr-status-service.js

@@ -56,7 +56,6 @@ class HmrStatusService {
             name: "failedLiveSync",
             platform: this.$devicePlatformsConstants.iOS.toLowerCase(),
         });
-        // webpack5
         const statusStringMap = {
             success: constants_1.HmrConstants.HMR_SUCCESS_STATUS,
             failure: constants_1.HmrConstants.HMR_ERROR_STATUS,
@@ -127,4 +126,3 @@ __decorate([
     (0, decorators_1.cache)()
 ], HmrStatusService.prototype, "attachToHmrStatusEvent", null);
 yok_1.injector.register("hmrStatusService", HmrStatusService);
-//# sourceMappingURL=hmr-status-service.js.map

package/lib/services/info-service.js

@@ -12,4 +12,3 @@ class InfoService {
 }
 exports.InfoService = InfoService;
 yok_1.injector.register("infoService", InfoService);
-//# sourceMappingURL=info-service.js.map

package/lib/services/initialize-service.js

@@ -6,8 +6,6 @@ const _ = require("lodash");
 const constants_1 = require("../constants");
 const yok_1 = require("../common/yok");
 class InitializeService {
-    // NOTE: Do not inject anything here, use $injector.resolve in the code
-    // Injecting something may lead to logger initialization, but we want to initialize it from here.
     constructor($injector) {
         this.$injector = $injector;
     }
@@ -35,7 +33,6 @@ class InitializeService {
             }
         }
         if ($options.json) {
-            // speed up --json commands by not gathering system warnings...
             $logger.trace("Skipping system warnings for --json commands");
         }
         else {
@@ -47,7 +44,7 @@ class InitializeService {
         const systemWarnings = await $sysInfo.getSystemWarnings();
         _.each(systemWarnings, (systemWarning) => {
             const message = `${os_1.EOL}${systemWarning.message}${os_1.EOL}`;
-            if (systemWarning.severity === "high" /* SystemWarningsSeverity.high */) {
+            if (systemWarning.severity === "high") {
                 $logger.error(message);
             }
             else {
@@ -58,4 +55,3 @@ class InitializeService {
 }
 exports.InitializeService = InitializeService;
 yok_1.injector.register("initializeService", InitializeService);
-//# sourceMappingURL=initialize-service.js.map

package/lib/services/ios/export-options-plist-service.js

@@ -54,13 +54,11 @@ class ExportOptionsPlistService {
         plistTemplate += `
 </dict>
 </plist>`;
-        // Save the options...
         const exportOptionsPlistFilePath = await this.$tempService.path({
             prefix: "export-",
             suffix: ".plist",
         });
         this.$fs.writeFile(exportOptionsPlistFilePath, plistTemplate);
-        // The xcodebuild exportPath expects directory and writes the <project-name>.ipa at that directory.
         const exportFileDir = path.resolve(path.dirname(archivePath));
         const exportFilePath = path.join(exportFileDir, projectData.projectName + ".ipa");
         return { exportFileDir, exportFilePath, exportOptionsPlistFilePath };
@@ -98,7 +96,6 @@ class ExportOptionsPlistService {
     <false/>
 </dict>
 </plist>`;
-        // Save the options...
         const exportOptionsPlistFilePath = await this.$tempService.path({
             prefix: "export-",
             suffix: ".plist",
@@ -121,4 +118,3 @@ class ExportOptionsPlistService {
 }
 exports.ExportOptionsPlistService = ExportOptionsPlistService;
 yok_1.injector.register("exportOptionsPlistService", ExportOptionsPlistService);
-//# sourceMappingURL=export-options-plist-service.js.map

package/lib/services/ios/ios-signing-service.js

@@ -45,7 +45,6 @@ class IOSSigningService {
         let shouldUpdateXcode = false;
         if (signing && signing.style === "Automatic") {
             if (signing.team !== teamId) {
-                // Maybe the provided team is name such as "Telerik AD" and we need to convert it to CH******37
                 const teamIdsForName = await this.$iOSProvisionService.getTeamIdsWithName(teamId);
                 if (!teamIdsForName.some((id) => id === signing.team)) {
                     shouldUpdateXcode = true;
@@ -79,7 +78,6 @@ class IOSSigningService {
     }
     async setupSigningFromProvision(projectRoot, projectData, provision, mobileProvisionData) {
         if (!provision) {
-            // read uuid from Xcode an cache...
             return;
         }
         const xcode = this.$pbxprojDomXcode.Xcode.open(this.getPbxProjPath(projectData, projectRoot));
@@ -112,7 +110,6 @@ class IOSSigningService {
                 this.$logger.trace(`Set Manual signing style and provisioning profile: ${configuration.name} (${configuration.uuid})`);
             });
             xcode.save();
-            // this.cache(uuid);
         }
         else {
             this.$logger.trace(`The specified provisioning profile is already set in the Xcode: ${provision}`);
@@ -269,4 +266,3 @@ class IOSSigningService {
 }
 exports.IOSSigningService = IOSSigningService;
 yok_1.injector.register("iOSSigningService", IOSSigningService);
-//# sourceMappingURL=ios-signing-service.js.map

package/lib/services/ios/spm-service.js

@@ -15,16 +15,11 @@ class SPMService {
         const spmPackages = this.$projectConfigService.getValue(`${platform}.SPMPackages`, []);
         return spmPackages;
     }
-    // note: this is not used anywhere at the moment.
-    // public hasSPMPackages(projectData: IProjectData): boolean {
-    // 	return this.getSPMPackages(projectData).length > 0;
-    // }
     async applySPMPackages(platformData, projectData, pluginSpmPackages) {
         var _a;
         try {
             const spmPackages = this.getSPMPackages(projectData, platformData.platformNameLowerCase);
             if (pluginSpmPackages === null || pluginSpmPackages === void 0 ? void 0 : pluginSpmPackages.length) {
-                // include swift packages from plugin configs
                 spmPackages.push(...pluginSpmPackages);
             }
             if (!spmPackages.length) {
@@ -38,21 +33,17 @@ class SPMService {
                 enableAndroid: false,
             });
             await project.load();
-            // note: in trapeze both visionOS and iOS are handled by the ios project.
             if (!project.ios) {
                 this.$logger.trace("SPM: no iOS project found via trapeze.");
                 return;
             }
-            // todo: handle removing packages? Or just warn and require a clean?
             for (const pkg of spmPackages) {
                 if ("path" in pkg) {
-                    // resolve the path relative to the project root
                     this.$logger.trace("SPM: resolving path for package: ", pkg.path);
                     pkg.path = path.resolve(projectData.projectDir, pkg.path);
                 }
                 this.$logger.trace(`SPM: adding package ${pkg.name} to project.`, pkg);
                 await project.ios.addSPMPackage(projectData.projectName, pkg);
-                // Add to other Targets if specified (like widgets, etc.)
                 if ((_a = pkg.targets) === null || _a === void 0 ? void 0 : _a.length) {
                     for (const target of pkg.targets) {
                         await project.ios.addSPMPackage(target, pkg);
@@ -60,7 +51,6 @@ class SPMService {
                 }
             }
             await project.commit();
-            // finally resolve the dependencies
             await this.resolveSPMDependencies(platformData, projectData);
         }
         catch (err) {
@@ -82,4 +72,3 @@ class SPMService {
 }
 exports.SPMService = SPMService;
 yok_1.injector.register("spmService", SPMService);
-//# sourceMappingURL=spm-service.js.map

package/lib/services/ios/xcodebuild-args-service.js

@@ -88,8 +88,6 @@ class XcodebuildArgsService {
     }
     getXcodeProjectArgs(platformData, projectData) {
         const xcworkspacePath = path.join(platformData.projectRoot, `${projectData.projectName}.xcworkspace`);
-        // Introduced in Xcode 14+
-        // ref: https://forums.swift.org/t/telling-xcode-14-beta-4-to-trust-build-tool-plugins-programatically/59305/5
         const skipPackageValidation = "-skipPackagePluginValidation";
         const extraArgs = [
             "-scheme",
@@ -97,12 +95,6 @@ class XcodebuildArgsService {
             skipPackageValidation,
         ];
         const BUILD_SETTINGS_FILE_PATH = path.join(projectData.appResourcesDirectoryPath, platformData.normalizedPlatformName, constants.BUILD_XCCONFIG_FILE_NAME);
-        // Only include explicit properties from build.xcconfig
-        // Note: we could include entire file via -xcconfig flag
-        // however doing so introduces unwanted side effects
-        // like cocoapods issues related to ASSETCATALOG_COMPILER_APPICON_NAME
-        // references: https://medium.com/@iostechset/why-cocoapods-eats-app-icons-79fe729808d4
-        // https://github.com/CocoaPods/CocoaPods/issues/7003
         const deployTargetProperty = "IPHONEOS_DEPLOYMENT_TARGET";
         const deployTargetVersion = this.$xcconfigService.readPropertyValue(BUILD_SETTINGS_FILE_PATH, deployTargetProperty);
         if (deployTargetVersion) {
@@ -152,4 +144,3 @@ class XcodebuildArgsService {
 }
 exports.XcodebuildArgsService = XcodebuildArgsService;
 yok_1.injector.register("xcodebuildArgsService", XcodebuildArgsService);
-//# sourceMappingURL=xcodebuild-args-service.js.map

package/lib/services/ios/xcodebuild-command-service.js

@@ -27,4 +27,3 @@ class XcodebuildCommandService {
 }
 exports.XcodebuildCommandService = XcodebuildCommandService;
 yok_1.injector.register("xcodebuildCommandService", XcodebuildCommandService);
-//# sourceMappingURL=xcodebuild-command-service.js.map

package/lib/services/ios/xcodebuild-service.js

@@ -64,7 +64,7 @@ class XcodebuildService {
             output.exportFileDir,
             "-exportOptionsPlist",
             output.exportOptionsPlistFilePath,
-            provision ? "" : "-allowProvisioningUpdates", // no profiles specificed so let xcode decide.
+            provision ? "" : "-allowProvisioningUpdates",
         ];
         await this.$xcodebuildCommandService.executeCommand(args, {
             cwd: platformData.projectRoot,
@@ -74,4 +74,3 @@ class XcodebuildService {
 }
 exports.XcodebuildService = XcodebuildService;
 yok_1.injector.register("xcodebuildService", XcodebuildService);
-//# sourceMappingURL=xcodebuild-service.js.map

package/lib/services/ios-debugger-port-service.js

@@ -125,4 +125,3 @@ __decorate([
     (0, decorators_1.cache)()
 ], IOSDebuggerPortService.prototype, "attachToAttachRequestEvent", null);
 yok_1.injector.register("iOSDebuggerPortService", IOSDebuggerPortService);
-//# sourceMappingURL=ios-debugger-port-service.js.map

package/lib/services/ios-device-debug-service.js

@@ -138,4 +138,3 @@ __decorate([
     (0, decorators_1.performanceLog)()
 ], IOSDeviceDebugService.prototype, "openAppInspector", null);
 yok_1.injector.register("iOSDeviceDebugService", IOSDeviceDebugService, false);
-//# sourceMappingURL=ios-device-debug-service.js.map

package/lib/services/ios-entitlements-service.js

@@ -65,4 +65,3 @@ class IOSEntitlementsService {
 exports.IOSEntitlementsService = IOSEntitlementsService;
 IOSEntitlementsService.DefaultEntitlementsName = "app.entitlements";
 yok_1.injector.register("iOSEntitlementsService", IOSEntitlementsService);
-//# sourceMappingURL=ios-entitlements-service.js.map

package/lib/services/ios-extensions-service.js

@@ -50,4 +50,3 @@ class IOSExtensionsService {
 }
 exports.IOSExtensionsService = IOSExtensionsService;
 yok_1.injector.register("iOSExtensionsService", IOSExtensionsService);
-//# sourceMappingURL=ios-extensions-service.js.map

package/lib/services/ios-log-filter.js

@@ -5,20 +5,8 @@ const yok_1 = require("../common/yok");
 class IOSLogFilter {
     constructor($loggingLevels) {
         this.$loggingLevels = $loggingLevels;
-        // Used to recognize output related to the current project
-        // This looks for artifacts like: AppName[22432] or AppName(SomeTextHere)[23123]
         this.appOutputRegex = /([^\s\(\)]+)(?:\(([^\s]+)\))?\[[0-9]+\]/;
-        // Used to trim the passed messages to a simpler output
-        // Example:
-        // This: "May 24 15:54:52 Dragons-iPhone NativeScript250(NativeScript)[356] <Notice>: CONSOLE ERROR file:///app/tns_modules/@angular/core/bundles/core.umd.js:3477:36: ORIGINAL STACKTRACE:"
-        // Becomes: CONSOLE ERROR file:///app/tns_modules/@angular/core/bundles/core.umd.js:3477:36: ORIGINAL STACKTRACE:
         this.infoFilterRegex = new RegExp(`^.*(?:<Notice>:[ \t]?|<Error>:[ \t]?|<Warning>:[ \t]?|\\(NativeScript\\)[ \t]?|${this.appOutputRegex.source}:[ \t]?){1}`);
-        // Used to post filter messages that slip through but are not coming from NativeScript itself.
-        // Looks for text in parenthesis at the beginning
-        // Example:
-        // (RunningBoardServices) [com.apple.runningboard:connection] Identity resolved as application<...>
-        // ^(~~capture group~~~)^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-        // we then use this to filter out non-NativeScript lines
         this.postFilterRegex = /^\((.+)\) \[com\.apple.+\]/;
         this.filterActive = true;
         this.partialLine = null;
@@ -41,15 +29,11 @@ class IOSLogFilter {
                 this.partialLine = currentLine;
                 break;
             }
-            // Legacy filter moved to preFilter
             if (this.preFilter(data, currentLine)) {
                 continue;
             }
             const matchResult = this.appOutputRegex.exec(currentLine);
             if (matchResult && matchResult.length > 1) {
-                // Check if the name of the app equals the name of the CLI project and turn on the filter if not.
-                // We call initializeProjectData in order to obtain the current project name as the instance
-                // of this filter may be used accross multiple projects.
                 const projectName = loggingOptions && loggingOptions.projectName;
                 this.filterActive = matchResult[1] !== projectName;
                 if (matchResult === null || matchResult === void 0 ? void 0 : matchResult[2]) {
@@ -64,11 +48,8 @@ class IOSLogFilter {
                 currentLine = currentLine.replace(filteredLineInfo[0], "");
             }
             currentLine = currentLine
-                // remove lading space before CONSOLE
                 .replace(/^\s*CONSOLE/, "CONSOLE")
-                // trim trailing spaces only to preserve indentation
                 .trimEnd();
-            // post filtering: (<anything>) check if <anything> is not "NativeScript"
             const postFilterMatch = this.postFilterRegex.exec(currentLine);
             if (postFilterMatch && (postFilterMatch === null || postFilterMatch === void 0 ? void 0 : postFilterMatch[1]) !== "NativeScript") {
                 continue;
@@ -87,4 +68,3 @@ class IOSLogFilter {
 }
 exports.IOSLogFilter = IOSLogFilter;
 yok_1.injector.register("iOSLogFilter", IOSLogFilter);
-//# sourceMappingURL=ios-log-filter.js.map

package/lib/services/ios-native-target-service.js

@@ -58,8 +58,8 @@ class IOSNativeTargetService {
     setXcodeTargetBuildConfigurationProperties(properties, targetName, project) {
         properties.forEach((property) => {
             const buildNames = property.buildNames || [
-                "Debug" /* BuildNames.debug */,
-                "Release" /* BuildNames.release */,
+                "Debug",
+                "Release",
             ];
             buildNames.forEach((buildName) => {
                 project.addBuildProperty(property.name, property.value, buildName, targetName);
@@ -76,7 +76,6 @@ class IOSNativeTargetService {
                 project.addToBuildSettings("ASSETCATALOG_COMPILER_APPICON_NAME", configurationJson.assetcatalogCompilerAppiconName, targetUuid);
             }
             const properties = [];
-            // Set for both release and debug
             if (configurationJson.targetBuildConfigurationProperties) {
                 _.forEach(configurationJson.targetBuildConfigurationProperties, (value, name) => properties.push({ value, name }));
             }
@@ -85,11 +84,11 @@ class IOSNativeTargetService {
                     var buildName = null;
                     switch (name) {
                         case "debug": {
-                            buildName = "Debug" /* BuildNames.debug */;
+                            buildName = "Debug";
                             break;
                         }
                         case "release": {
-                            buildName = "Release" /* BuildNames.release */;
+                            buildName = "Release";
                             break;
                         }
                         default: {
@@ -107,4 +106,3 @@ class IOSNativeTargetService {
 }
 exports.IOSNativeTargetService = IOSNativeTargetService;
 yok_1.injector.register("iOSNativeTargetService", IOSNativeTargetService);
-//# sourceMappingURL=ios-native-target-service.js.map