nativescript 8.9.0-dev.3 → 8.9.0-dev.4

package/lib/services/project-data-service.js

@@ -27,12 +27,14 @@ class ProjectDataService {
         this.$injector = $injector;
         this.projectDataCache = {};
         try {
+            // add the ProjectData of the default projectDir to the projectData cache
             const projectData = this.$injector.resolve("projectData");
             projectData.initializeProjectData();
             this.defaultProjectDir = projectData.projectDir;
             this.projectDataCache[this.defaultProjectDir] = projectData;
         }
         catch (e) {
+            // the CLI is required as a lib from a non-project folder
         }
     }
     get $pluginsService() {
@@ -61,6 +63,8 @@ class ProjectDataService {
         delete projectFileInfo.projectData[ProjectDataService.DEPENDENCIES_KEY_NAME][dependencyName];
         this.$fs.writeJson(projectFileInfo.projectFilePath, projectFileInfo.projectData);
     }
+    // TODO: Add tests
+    // TODO: Remove $projectData and replace it with $projectDataService.getProjectData
     getProjectData(projectDir) {
         projectDir = projectDir || this.defaultProjectDir;
         this.projectDataCache[projectDir] =
@@ -112,6 +116,10 @@ class ProjectDataService {
         this.$logger.trace(`"${propertyName}" property successfully removed.`);
     }
     async getAndroidAssetsStructure(opts) {
+        // TODO: Use image-size package to get the width and height of an image.
+        // TODO: Parse the splash_screen.xml in nodpi directory and get from it the names of the background and center image.
+        // TODO: Parse the AndroidManifest.xml to get the name of the icon.
+        // This way we'll not use the image-definitions.json and the method will return the real android structure.
         const projectDir = opts.projectDir;
         const projectData = this.getProjectData(projectDir);
         const pathToAndroidDir = path.join(projectData.appResourcesDirectoryPath, this.$devicePlatformsConstants.Android);
@@ -125,6 +133,7 @@ class ProjectDataService {
             useLegacy = !manifest.includes(`android:icon="@mipmap/ic_launcher"`);
         }
         catch (err) {
+            // ignore
         }
         const content = this.getImageDefinitions()[useLegacy ? "android_legacy" : "android"];
         return {
@@ -148,6 +157,8 @@ class ProjectDataService {
             }
             if (fstat.isDirectory()) {
                 if (filePath === pathToProjectNodeModules) {
+                    // we do not want to get the files from node_modules directory of the project.
+                    // We'll get here only when you have nativescript.config with appDirectoryPath set to "."
                     return false;
                 }
                 return true;
@@ -162,6 +173,9 @@ class ProjectDataService {
         }
     }
     updateNsConfigValue(projectDir, updateObject, propertiesToRemove) {
+        // todo: figure out a way to update js/ts configs
+        // most likely needs an ast parser/writer
+        // should be delegated to the config service
         const nsConfigPath = path.join(projectDir, constants.CONFIG_FILE_NAME_JS);
         const currentNsConfig = this.getNsConfig(nsConfigPath);
         let newNsConfig = currentNsConfig;
@@ -202,10 +216,14 @@ class ProjectDataService {
         const imageDefinitions = this.getImageDefinitions().ios;
         _.each(content && content.images, (image) => {
             let foundMatchingDefinition = false;
+            // In some cases the image may not be available, it will just be described.
+            // When this happens, the filename will be empty.
+            // So we'll keep the path empty as well.
             if (image.filename) {
                 image.path = path.join(dirPath, image.filename);
             }
             if (image.size) {
+                // size is basically <width>x<height>
                 const [width, height] = image.size
                     .toString()
                     .split(constants_1.AssetConstants.sizeDelimiter);
@@ -214,6 +232,7 @@ class ProjectDataService {
                     image.height = +height;
                 }
             }
+            // Find the image size based on the hardcoded values in the image-definitions.json
             _.each(imageDefinitions, (assetSubGroup) => {
                 const assetItem = _.find(assetSubGroup, (assetElement) => assetElement.filename === image.filename &&
                     path.basename(assetElement.directory) === path.basename(dirPath));
@@ -233,6 +252,7 @@ class ProjectDataService {
                     image.scale = image.scale || assetItem.scale;
                     image.rgba = assetItem.rgba;
                     finalContent.images.push(image);
+                    // break each
                     return false;
                 }
             });
@@ -335,13 +355,16 @@ class ProjectDataService {
     getRuntimePackage(projectDir, platform) {
         platform = platform.toLowerCase();
         const packageJson = this.$fs.readJson(path.join(projectDir, constants.PACKAGE_JSON_FILE_NAME));
-        const runtimeName = platform === "android"
+        const runtimeName = platform === "android" /* PlatformTypes.android */
             ? constants.TNS_ANDROID_RUNTIME_NAME
             : constants.TNS_IOS_RUNTIME_NAME;
         if (packageJson &&
             packageJson.nativescript &&
             packageJson.nativescript[runtimeName] &&
             packageJson.nativescript[runtimeName].version) {
+            // if we have a nativescript key with a runtime version in package.json
+            // that means we are dealing with a legacy project, and should respect
+            // that information
             return {
                 name: runtimeName,
                 version: packageJson.nativescript[runtimeName].version,
@@ -353,19 +376,19 @@ class ProjectDataService {
         const runtimePackage = this.$pluginsService
             .getDependenciesFromPackageJson(projectDir)
             .devDependencies.find((d) => {
-            if (platform === "ios") {
+            if (platform === "ios" /* constants.PlatformTypes.ios */) {
                 return [
                     constants.SCOPED_IOS_RUNTIME_NAME,
                     constants.TNS_IOS_RUNTIME_NAME,
                 ].includes(d.name);
             }
-            else if (platform === "android") {
+            else if (platform === "android" /* constants.PlatformTypes.android */) {
                 return [
                     constants.SCOPED_ANDROID_RUNTIME_NAME,
                     constants.TNS_ANDROID_RUNTIME_NAME,
                 ].includes(d.name);
             }
-            else if (platform === "visionos") {
+            else if (platform === "visionos" /* constants.PlatformTypes.visionos */) {
                 return d.name === constants.SCOPED_VISIONOS_RUNTIME_NAME;
             }
         });
@@ -373,12 +396,14 @@ class ProjectDataService {
             const coerced = semver.coerce(runtimePackage.version);
             const isRange = !!coerced && coerced.version !== runtimePackage.version;
             const isTag = !coerced;
+            // in case we are using a local tgz for the runtime or a range like ~8.0.0, ^8.0.0 etc. or a tag like JSC
             if (runtimePackage.version.includes("tgz") || isRange || isTag) {
                 try {
                     const runtimePackageJsonPath = (0, package_path_helper_1.resolvePackageJSONPath)(runtimePackage.name, {
                         paths: [projectDir],
                     });
                     if (!runtimePackageJsonPath) {
+                        // caught below
                         throw new Error("Runtime package.json not found.");
                     }
                     runtimePackage.version = this.$fs.readJson(runtimePackageJsonPath).version;
@@ -395,20 +420,21 @@ class ProjectDataService {
             }
             return runtimePackage;
         }
+        // default to the scoped runtimes
         this.$logger.trace("Could not find an installed runtime, falling back to default runtimes");
-        if (platform === "ios") {
+        if (platform === "ios" /* constants.PlatformTypes.ios */) {
             return {
                 name: constants.SCOPED_IOS_RUNTIME_NAME,
                 version: null,
             };
         }
-        else if (platform === "android") {
+        else if (platform === "android" /* constants.PlatformTypes.android */) {
             return {
                 name: constants.SCOPED_ANDROID_RUNTIME_NAME,
                 version: null,
             };
         }
-        else if (platform === "visionos") {
+        else if (platform === "visionos" /* constants.PlatformTypes.visionos */) {
             return {
                 name: constants.SCOPED_VISIONOS_RUNTIME_NAME,
                 version: null,
@@ -443,9 +469,11 @@ __decorate([
             return projectDir + ":" + platform;
         },
         shouldCache(result) {
+            // don't cache coerced versions
             if (result._coerced) {
                 return false;
             }
+            // only cache if version is defined
             return !!result.version;
         },
     })
@@ -454,3 +482,4 @@ __decorate([
     (0, decorators_1.exported)("projectDataService")
 ], ProjectDataService.prototype, "getNsConfigDefaultContent", null);
 yok_1.injector.register("projectDataService", ProjectDataService);
+//# sourceMappingURL=project-data-service.js.map

package/lib/services/project-name-service.js

@@ -50,3 +50,4 @@ class ProjectNameService {
 }
 exports.ProjectNameService = ProjectNameService;
 yok_1.injector.register("projectNameService", ProjectNameService);
+//# sourceMappingURL=project-name-service.js.map

package/lib/services/project-service.js

@@ -64,11 +64,15 @@ class ProjectService {
             appId: appId,
             projectName,
         });
+        // can pass --no-git to skip creating a git repo
+        // useful in monorepos where we're creating
+        // sub projects in an existing git repo.
         if (this.$options.git) {
             try {
                 if (!this.$options.force) {
                     const git = (0, simple_git_1.default)(projectDir);
                     if (await git.checkIsRepo()) {
+                        // throwing here since we're catching below.
                         throw new Error("Already part of a git repository.");
                     }
                 }
@@ -108,6 +112,7 @@ class ProjectService {
             this.alterPackageJsonData(projectCreationSettings);
             this.$projectConfigService.writeDefaultConfig(projectDir, appId);
             await this.ensureAppResourcesExist(projectDir);
+            // Install devDependencies and execute all scripts:
             await this.$packageManager.install(projectDir, projectDir, {
                 disableNpmInstall: false,
                 frameworkPath: null,
@@ -137,6 +142,7 @@ class ProjectService {
             this.$logger.trace("Project does not have App_Resources - fetching from default template.");
             this.$fs.createDirectory(appResourcesDestinationPath);
             const tempDir = await this.$tempService.mkdirSync("ns-default-template");
+            // the template installed doesn't have App_Resources -> get from a default template
             await this.$pacoteService.extractPackage(constants.RESERVED_TEMPLATE_NAMES["default"], tempDir);
             const templateProjectData = this.$projectDataService.getProjectData(tempDir);
             const templateAppResourcesDir = templateProjectData.getAppResourcesDirectoryPath(tempDir);
@@ -147,12 +153,14 @@ class ProjectService {
         const { projectDir, projectName } = projectCreationSettings;
         const projectFilePath = path.join(projectDir, this.$staticConfig.PROJECT_FILE_NAME);
         let packageJsonData = this.$fs.readJson(projectFilePath);
+        // clean up keys from the template package.json that we don't care about.
         Object.keys(packageJsonData).forEach((key) => {
             if (key.startsWith("_") ||
                 constants.TemplatesV2PackageJsonKeysToRemove.includes(key)) {
                 delete packageJsonData[key];
             }
         });
+        // this is used to ensure the order of keys is consistent, the blanks are filled in from the template
         const packageJsonSchema = {
             name: projectName,
             main: "",
@@ -160,6 +168,7 @@ class ProjectService {
             private: true,
             dependencies: {},
             devDependencies: {},
+            // anythign else would go below
         };
         packageJsonData = Object.assign(packageJsonSchema, packageJsonData);
         this.$fs.writeJson(projectFilePath, packageJsonData);
@@ -183,3 +192,4 @@ __decorate([
     (0, decorators_2.performanceLog)()
 ], ProjectService.prototype, "alterPackageJsonData", null);
 yok_1.injector.register("projectService", ProjectService);
+//# sourceMappingURL=project-service.js.map

package/lib/services/project-templates-service.js

@@ -40,12 +40,12 @@ class ProjectTemplatesService {
         const templateNameToBeTracked = this.getTemplateNameToBeTracked(templateValue, templatePackageJsonContent);
         if (templateNameToBeTracked) {
             await this.$analyticsService.trackEventActionInGoogleAnalytics({
-                action: "Create project",
+                action: "Create project" /* constants.TrackActionNames.CreateProject */,
                 isForDevice: null,
                 additionalData: templateNameToBeTracked,
             });
             await this.$analyticsService.trackEventActionInGoogleAnalytics({
-                action: "Using Template",
+                action: "Using Template" /* constants.TrackActionNames.UsingTemplate */,
                 additionalData: templateNameToBeTracked,
             });
         }
@@ -97,3 +97,4 @@ __decorate([
     (0, decorators_1.performanceLog)()
 ], ProjectTemplatesService.prototype, "prepareTemplate", null);
 yok_1.injector.register("projectTemplatesService", ProjectTemplatesService);
+//# sourceMappingURL=project-templates-service.js.map

package/lib/services/qr-code-terminal-service.js

@@ -18,3 +18,4 @@ class QrCodeTerminalService {
 }
 exports.QrCodeTerminalService = QrCodeTerminalService;
 yok_1.injector.register("qrCodeTerminalService", QrCodeTerminalService);
+//# sourceMappingURL=qr-code-terminal-service.js.map

package/lib/services/require-service.js

@@ -9,3 +9,4 @@ class RequireService {
 }
 exports.RequireService = RequireService;
 yok_1.injector.register("requireService", RequireService);
+//# sourceMappingURL=require-service.js.map

package/lib/services/start-service.js

@@ -96,3 +96,4 @@ class StartService {
 }
 exports.default = StartService;
 yok_1.injector.register("startService", StartService);
+//# sourceMappingURL=start-service.js.map

package/lib/services/temp-service.js

@@ -21,3 +21,4 @@ class TempService {
 }
 exports.TempService = TempService;
 yok_1.injector.register("tempService", TempService);
+//# sourceMappingURL=temp-service.js.map

package/lib/services/terminal-spinner-service.js

@@ -5,6 +5,7 @@ const ora_1 = require("ora");
 const yok_1 = require("../common/yok");
 class TerminalSpinnerService {
     createSpinner(spinnerOptions = {}) {
+        // @ts-expect-error - options are readonly, however we still want to override them before passing them on...
         spinnerOptions.stream = spinnerOptions.stream || process.stdout;
         return (0, ora_1.default)(spinnerOptions);
     }
@@ -25,3 +26,4 @@ class TerminalSpinnerService {
 }
 exports.TerminalSpinnerService = TerminalSpinnerService;
 yok_1.injector.register("terminalSpinnerService", TerminalSpinnerService);
+//# sourceMappingURL=terminal-spinner-service.js.map

package/lib/services/test-execution-service.js

@@ -24,8 +24,10 @@ class TestExecutionService {
         platform = platform.toLowerCase();
         this.platform = platform;
         const projectData = this.$projectDataService.getProjectData(liveSyncInfo.projectDir);
+        // We need the dependencies installed here, so we can start the Karma server.
         await this.$pluginsService.ensureAllDependenciesAreInstalled(projectData);
         const karmaConfig = this.getKarmaConfiguration(platform, projectData);
+        // In case you want to debug the unit test runner, add "--inspect-brk=<port>" as a first element in the array of args.
         const karmaRunner = this.$childProcess.spawn(process.execPath, [path.join(__dirname, "karma-execution.js")], { stdio: ["inherit", "inherit", "inherit", "ipc"] });
         const launchKarmaTests = async (karmaData) => {
             this.$logger.trace("## Unit-testing: Parent process received message", karmaData);
@@ -42,6 +44,8 @@ class TestExecutionService {
                 const configJs = this.generateConfig(port, configOptions);
                 this.$fs.writeFile(path.join(liveSyncInfo.projectDir, TestExecutionService.CONFIG_FILE_NAME), configJs);
             }
+            // Prepare the project AFTER the TestExecutionService.CONFIG_FILE_NAME file is created in node_modules
+            // so it will be sent to device.
             await this.$runController.run({
                 liveSyncInfo,
                 deviceDescriptors,
@@ -54,12 +58,13 @@ class TestExecutionService {
             }
             launchKarmaTests(karmaData).catch((result) => {
                 this.$logger.error(result);
-                process.exit(130);
+                process.exit(130 /* ErrorCodes.KARMA_FAIL */);
             });
         });
         return new Promise((resolve, reject) => {
             karmaRunner.on("exit", (exitCode) => {
                 if (exitCode !== 0) {
+                    //End our process with a non-zero exit code
                     const testError = new Error("Test run failed.");
                     reject(testError);
                 }
@@ -72,7 +77,7 @@ class TestExecutionService {
     }
     async canStartKarmaServer(projectData) {
         let canStartKarmaServer = true;
-        const requiredDependencies = ["@nativescript/unit-test-runner"];
+        const requiredDependencies = ["@nativescript/unit-test-runner"]; // we need @nativescript/unit-test-runner at the local level because of hooks!
         _.each(requiredDependencies, (dep) => {
             if (!projectData.dependencies[dep] && !projectData.devDependencies[dep]) {
                 canStartKarmaServer = false;
@@ -121,6 +126,7 @@ class TestExecutionService {
             karmaConfig.logLevel = "DEBUG";
         }
         if (!this.$options.watch) {
+            // Setting singleRun to true will automatically start the tests when new browser (device in our case) is registered in karma.
             karmaConfig.singleRun = true;
         }
         if (this.$options.debugBrk) {
@@ -139,3 +145,4 @@ exports.TestExecutionService = TestExecutionService;
 TestExecutionService.CONFIG_FILE_NAME = `node_modules/${constants.TEST_RUNNER_NAME}/config.js`;
 TestExecutionService.SOCKETIO_JS_FILE_NAME = `node_modules/${constants.TEST_RUNNER_NAME}/socket.io.js`;
 yok_1.injector.register("testExecutionService", TestExecutionService);
+//# sourceMappingURL=test-execution-service.js.map

package/lib/services/test-initialization-service.js

@@ -34,6 +34,9 @@ class TestInitializationService {
         });
         return targetFrameworkDependencies;
     }
+    /**
+     * This method is used from test-init.md file so it is not allowed to use "this" inside the method's body.
+     */
     getFrameworkNames() {
         const configsPath = path.join(__dirname, "..", "..", "config");
         const dependenciesPath = path.join(configsPath, "test-dependencies.json");
@@ -52,3 +55,4 @@ __decorate([
     (0, decorators_1.cache)()
 ], TestInitializationService.prototype, "getFrameworkNames", null);
 yok_1.injector.register("testInitializationService", TestInitializationService);
+//# sourceMappingURL=test-initialization-service.js.map

package/lib/services/timeline-profiler-service.js

@@ -98,3 +98,4 @@ __decorate([
     (0, decorators_1.cache)()
 ], TimelineProfilerService.prototype, "isEnabled", null);
 yok_1.injector.register("timelineProfilerService", TimelineProfilerService);
+//# sourceMappingURL=timeline-profiler-service.js.map

package/lib/services/user-settings-service.js

@@ -32,3 +32,4 @@ class UserSettingsService {
 }
 exports.UserSettingsService = UserSettingsService;
 yok_1.injector.register("userSettingsService", UserSettingsService);
+//# sourceMappingURL=user-settings-service.js.map

package/lib/services/versions-service.js

@@ -47,6 +47,7 @@ class VersionsService {
             const tnsCoreModulesPath = path.join(nodeModulesPath, constants.TNS_CORE_MODULES_NAME);
             const dependsOnNonScopedPackage = !!this.projectData.dependencies[constants.TNS_CORE_MODULES_NAME];
             const dependsOnScopedPackage = !!this.projectData.dependencies[constants.SCOPED_TNS_CORE_MODULES];
+            // ensure the dependencies are installed, so we can get their actual versions from node_modules
             if (!this.$fs.exists(nodeModulesPath) ||
                 (dependsOnNonScopedPackage && !this.$fs.exists(tnsCoreModulesPath)) ||
                 (dependsOnScopedPackage && !this.$fs.exists(scopedPackagePath))) {
@@ -73,16 +74,16 @@ class VersionsService {
         return versionInformations;
     }
     async getRuntimesVersions(platform) {
-        const iosRuntime = this.$projectDataService.getRuntimePackage(this.projectData.projectDir, "ios");
-        const androidRuntime = this.$projectDataService.getRuntimePackage(this.projectData.projectDir, "android");
+        const iosRuntime = this.$projectDataService.getRuntimePackage(this.projectData.projectDir, "ios" /* constants.PlatformTypes.ios */);
+        const androidRuntime = this.$projectDataService.getRuntimePackage(this.projectData.projectDir, "android" /* constants.PlatformTypes.android */);
         let runtimes = [];
         if (!platform) {
             runtimes = [iosRuntime, androidRuntime];
         }
-        else if (platform === "ios") {
+        else if (platform === "ios" /* PlatformTypes.ios */) {
             runtimes.push(iosRuntime);
         }
-        else if (platform === "android") {
+        else if (platform === "android" /* PlatformTypes.android */) {
             runtimes.push(androidRuntime);
         }
         const runtimesVersions = await Promise.all(runtimes.map(async (runtime) => {
@@ -175,3 +176,4 @@ VersionsService.UP_TO_DATE_MESSAGE = "up to date";
 VersionsService.UPDATE_AVAILABLE_MESSAGE = "Update available";
 VersionsService.NOT_INSTALLED_MESSAGE = "not installed";
 yok_1.injector.register("versionsService", VersionsService);
+//# sourceMappingURL=versions-service.js.map

package/lib/services/watch-ignore-list-service.js

@@ -18,3 +18,4 @@ class WatchIgnoreListService {
 }
 exports.WatchIgnoreListService = WatchIgnoreListService;
 yok_1.injector.register("watchIgnoreListService", WatchIgnoreListService);
+//# sourceMappingURL=watch-ignore-list-service.js.map

package/lib/services/webpack/webpack-compiler-service.js

@@ -16,7 +16,8 @@ const constants_1 = require("../../constants");
 const yok_1 = require("../../common/yok");
 const package_path_helper_1 = require("../../helpers/package-path-helper");
 class WebpackCompilerService extends events_1.EventEmitter {
-    constructor($options, $errors, $childProcess, $fs, $hooksService, $hostInfo, $logger, $mobileHelper, $cleanupService, $packageManager, $packageInstallationManager) {
+    constructor($options, $errors, $childProcess, $fs, $hooksService, $hostInfo, $logger, $mobileHelper, $cleanupService, $packageManager, $packageInstallationManager // private $sharedEventBus: ISharedEventBus
+    ) {
         super();
         this.$options = $options;
         this.$errors = $errors;
@@ -50,14 +51,23 @@ class WebpackCompilerService extends events_1.EventEmitter {
                 });
                 childProcess.on("message", (message) => {
                     this.$logger.trace("Message from webpack", message);
+                    // if we are on webpack5 - we handle HMR in a  slightly different way
                     if (typeof message === "object" &&
                         "version" in message &&
                         "type" in message) {
+                        // first compilation can be ignored because it will be synced regardless
+                        // handling it here would trigger 2 syncs
                         if (isFirstWebpackWatchCompilation) {
                             isFirstWebpackWatchCompilation = false;
                             resolve(childProcess);
                             return;
                         }
+                        // if ((message as IWebpackMessage).type === "hmr-status") {
+                        // 	// we pass message through our event-bus to be handled wherever needed
+                        // 	// in this case webpack-hmr-status-service listens for this event
+                        // 	this.$sharedEventBus.emit("webpack:hmr-status", message);
+                        // 	return;
+                        // }
                         return this.handleHMRMessage(message, platformData, projectData, prepareData);
                     }
                     if (message === "Webpack compilation complete.") {
@@ -72,6 +82,7 @@ class WebpackCompilerService extends events_1.EventEmitter {
                                 prepareData.hmr ? message.hash : "";
                             return;
                         }
+                        // Persist the previousHash value before calling `this.getUpdatedEmittedFiles` as it will modify the expectedHashes object with the current hash
                         const previousHash = this.expectedHashes[platformData.platformNameLowerCase];
                         let result;
                         if (prepareData.hmr) {
@@ -96,6 +107,7 @@ class WebpackCompilerService extends events_1.EventEmitter {
                             platform: platformData.platformNameLowerCase,
                         };
                         this.$logger.trace("Generated data from webpack message:", data);
+                        // the hash of the compilation is the same as the previous one and there are only hot updates produced
                         if (data.hasOnlyHotUpdateFiles && previousHash === message.hash) {
                             return;
                         }
@@ -168,6 +180,9 @@ class WebpackCompilerService extends events_1.EventEmitter {
         }
     }
     async shouldUsePreserveSymlinksOption() {
+        // pnpm does not require symlink (https://github.com/nodejs/node-eps/issues/46#issuecomment-277373566)
+        // and it also does not work in some cases.
+        // Check https://github.com/NativeScript/nativescript-cli/issues/5259 for more information
         const currentPackageManager = await this.$packageManager.getPackageManagerName();
         const res = currentPackageManager !== constants_1.PackageManagers.pnpm;
         return res;
@@ -230,16 +245,28 @@ class WebpackCompilerService extends events_1.EventEmitter {
         });
         envData.verbose = envData.verbose || this.$logger.isVerbose();
         envData.production = envData.production || prepareData.release;
+        // add the config file name to the env data so the webpack process can read the
+        // correct config file when resolving the CLI lib and the config service
+        // we are explicitly setting it to false to force using the defaults
         envData.config =
             (_b = (_a = process.env.NATIVESCRIPT_CONFIG_NAME) !== null && _a !== void 0 ? _a : this.$options.config) !== null && _b !== void 0 ? _b : "false";
+        // explicitly set the env variable
         process.env.NATIVESCRIPT_CONFIG_NAME = envData.config;
+        // The snapshot generation is wrongly located in the Webpack plugin.
+        // It should be moved in the Native Prepare of the CLI or a Gradle task in the Runtime.
+        // As a workaround, we skip the mksnapshot, xxd and android-ndk calls based on skipNativePrepare.
+        // In this way the plugin will prepare only the snapshot JS entry without any native prepare and
+        // we will able to execute cloud builds with snapshot without having any local snapshot or Docker setup.
+        // TODO: Remove this flag when we remove the native part from the plugin.
         envData.skipSnapshotTools =
             prepareData.nativePrepare && prepareData.nativePrepare.skipNativePrepare;
+        // only set sourceMap if not explicitly set through a flag
         if (typeof ((_c = prepareData === null || prepareData === void 0 ? void 0 : prepareData.env) === null || _c === void 0 ? void 0 : _c.sourceMap) === "undefined") {
             if (!prepareData.release) {
                 envData.sourceMap = true;
             }
         }
+        // convert string to boolean
         if (envData.sourceMap === "true" || envData.sourceMap === "false") {
             envData.sourceMap = envData.sourceMap === "true";
         }
@@ -291,6 +318,15 @@ class WebpackCompilerService extends events_1.EventEmitter {
     }
     getUpdatedEmittedFiles(allEmittedFiles, chunkFiles, nextHash, platform) {
         const currentHash = this.getCurrentHotUpdateHash(allEmittedFiles);
+        // This logic is needed as there are already cases when webpack doesn't emit any files physically.
+        // We've set noEmitOnErrors in webpack.config.js based on noEmitOnError from tsconfig.json,
+        // so webpack doesn't emit any files when noEmitOnErrors: true is set in webpack.config.js and
+        // there is a compilation error in the source code. On the other side, hmr generates new hot-update files
+        // on every change and the hash of the next hmr update is written inside hot-update.json file.
+        // Although webpack doesn't emit any files, hmr hash is still generated. The hash is generated per compilation no matter
+        // if files will be emitted or not. This way, the first successful compilation after fixing the compilation error generates
+        // a hash that is not the same as the one expected in the latest emitted hot-update.json file.
+        // As a result, the hmr chain is broken and the changes are not applied.
         const isHashValid = nextHash
             ? this.expectedHashes[platform] === currentHash
             : true;
@@ -309,6 +345,7 @@ class WebpackCompilerService extends events_1.EventEmitter {
         let hotHash;
         const hotUpdateScripts = emittedFiles.filter((x) => x.endsWith(".hot-update.js"));
         if (hotUpdateScripts && hotUpdateScripts.length) {
+            // the hash is the same for each hot update in the current compilation
             const hotUpdateName = hotUpdateScripts[0];
             const matcher = /^(.+)\.(.+)\.hot-update/gm;
             const matches = matcher.exec(hotUpdateName);
@@ -326,6 +363,7 @@ class WebpackCompilerService extends events_1.EventEmitter {
         }
     }
     handleHMRMessage(message, platformData, projectData, prepareData) {
+        // handle new webpack hmr packets
         this.$logger.trace("Received message from webpack process:", message);
         if (message.type !== "compilation") {
             return;
@@ -333,6 +371,7 @@ class WebpackCompilerService extends events_1.EventEmitter {
         this.$logger.trace("Webpack build done!");
         const files = message.data.emittedAssets.map((asset) => path.join(platformData.appDestinationDirectoryPath, this.$options.hostProjectModuleName, asset));
         const staleFiles = message.data.staleAssets.map((asset) => path.join(platformData.appDestinationDirectoryPath, this.$options.hostProjectModuleName, asset));
+        // extract last hash from emitted filenames
         const lastHash = (() => {
             const absoluteFileNameWithLastHash = files.find((fileName) => fileName.endsWith("hot-update.js"));
             if (!absoluteFileNameWithLastHash) {
@@ -345,6 +384,7 @@ class WebpackCompilerService extends events_1.EventEmitter {
             }
         })();
         if (!files.length) {
+            // ignore compilations if no new files are emitted
             return;
         }
         this.emit(constants_1.WEBPACK_COMPILATION_COMPLETE, {
@@ -394,3 +434,4 @@ __decorate([
     (0, decorators_1.performanceLog)()
 ], WebpackCompilerService.prototype, "startWebpackProcess", null);
 yok_1.injector.register("webpackCompilerService", WebpackCompilerService);
+//# sourceMappingURL=webpack-compiler-service.js.map

package/lib/services/xcconfig-service.js

@@ -55,6 +55,7 @@ class XcconfigService {
                 }
             });
             if (isPropertyParsed) {
+                // property can be an empty string, so we don't check for that.
                 return property;
             }
         }
@@ -63,3 +64,4 @@ class XcconfigService {
 }
 exports.XcconfigService = XcconfigService;
 yok_1.injector.register("xcconfigService", XcconfigService);
+//# sourceMappingURL=xcconfig-service.js.map

package/lib/services/xcproj-service.js

@@ -21,3 +21,4 @@ class XcprojService {
     }
 }
 yok_1.injector.register("xcprojService", XcprojService);
+//# sourceMappingURL=xcproj-service.js.map

package/lib/shared-event-bus.js

@@ -2,6 +2,12 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 const events_1 = require("events");
 const yok_1 = require("./common/yok");
+/**
+ * Event Bus used by different services to emit state changes and
+ * allow listening for these state changes without needing a reference
+ * to the emitting service.
+ */
 class SharedEventBus extends events_1.EventEmitter {
 }
 yok_1.injector.register("sharedEventBus", SharedEventBus);
+//# sourceMappingURL=shared-event-bus.js.map

package/lib/sys-info.js

@@ -79,7 +79,7 @@ class SysInfo {
         if (macOSVersion && macOSVersion < constants_1.MacOSVersions.HighSierra) {
             return {
                 message: (0, util_1.format)(constants_1.MacOSDeprecationStringFormat, macOSVersion),
-                severity: "high",
+                severity: "high" /* SystemWarningsSeverity.high */,
             };
         }
         return null;
@@ -101,3 +101,4 @@ __decorate([
     (0, decorators_1.exported)("sysInfo")
 ], SysInfo.prototype, "getSupportedNodeVersionRange", null);
 yok_1.injector.register("sysInfo", SysInfo);
+//# sourceMappingURL=sys-info.js.map