nativescript 8.8.0 → 8.8.1

package/lib/services/ios-project-service.js

@@ -145,7 +145,7 @@ class IOSProjectService extends projectServiceBaseLib.PlatformProjectServiceBase
                     ".ico",
                     ".cur",
                     ".xbm",
-                ],
+                ], // https://developer.apple.com/library/ios/documentation/UIKit/Reference/UIImage_Class/
             };
         }
         return this._platformData;
@@ -198,9 +198,12 @@ class IOSProjectService extends projectServiceBaseLib.PlatformProjectServiceBase
             shell.cp("-R", path.join(frameworkDir, "*"), this.getPlatformData(projectData).projectRoot);
         });
     }
+    //TODO: plamen5kov: revisit this method, might have unnecessary/obsolete logic
     interpolateData(projectData) {
         return __awaiter(this, void 0, void 0, function* () {
             const projectRootFilePath = path.join(this.getPlatformData(projectData).projectRoot, IOSProjectService.IOS_PROJECT_NAME_PLACEHOLDER);
+            // Starting with NativeScript for iOS 1.6.0, the project Info.plist file resides not in the platform project,
+            // but in the hello-world app template as a platform specific resource.
             if (this.$fs.exists(path.join(projectRootFilePath, IOSProjectService.IOS_PROJECT_NAME_PLACEHOLDER + "-Info.plist"))) {
                 this.replaceFileName("-Info.plist", projectRootFilePath, projectData);
             }
@@ -311,18 +314,34 @@ class IOSProjectService extends projectServiceBaseLib.PlatformProjectServiceBase
                 frameworkAddOptions["sign"] = true;
             }
             if (this.$options.hostProjectPath) {
+                // always mark xcframeworks for embedding
                 frameworkAddOptions["embed"] = true;
                 frameworkAddOptions["sign"] = false;
             }
+            // Note: we used to prepend "$(SRCROOT)/" to the framework path, but seems like it's not needed anymore
+            // "$(SRCROOT)/" +
             const frameworkRelativePath = this.getLibSubpathRelativeToProjectPath(frameworkPath, projectData);
             project.addFramework(frameworkRelativePath, frameworkAddOptions);
+            // filePathsArray, buildPhaseType, comment, target, optionsOrFolderType, subfolderPath
+            // project.addBuildPhase(
+            // 	[],
+            // 	"PBXShellScriptBuildPhase",
+            // 	"Debug SRCROOT",
+            // 	undefined,
+            // 	{
+            // 		shellPath: "/bin/sh",
+            // 		shellScript: `echo "SRCROOT: $SRCROOT"`,
+            // 	}
+            // );
             this.savePbxProj(project, projectData);
         });
     }
     addStaticLibrary(staticLibPath, projectData) {
         return __awaiter(this, void 0, void 0, function* () {
+            // Copy files to lib folder.
             const libraryName = path.basename(staticLibPath, ".a");
             const headersSubpath = path.join(path.dirname(staticLibPath), "include", libraryName);
+            // Add static library to project file and setup header search paths
             const project = this.createPbxProj(projectData);
             const relativeStaticLibPath = this.getLibSubpathRelativeToProjectPath(staticLibPath, projectData);
             project.addFramework(relativeStaticLibPath);
@@ -359,10 +378,60 @@ class IOSProjectService extends projectServiceBaseLib.PlatformProjectServiceBase
                         filesRelativeToProject: true,
                         uuid: "NATIVESCRIPTNATIVESCRIPT",
                     });
-                    const buildFolderPath = path.join(this.$options.hostProjectPath, projectData.projectName);
+                    /**
+                     * 1. Add platforms/ios/{projectname}/app build to the host app
+                     */
+                    // Note: allow customization of this targetFolderName
+                    // const targetFolderName = "app";
+                    const buildFolderPath = path.join(this.$options.hostProjectPath, projectData.projectName
+                    // targetFolderName
+                    );
                     project.addResourceFile(buildFolderPath, {}, "NATIVESCRIPTNATIVESCRIPT");
+                    // filePathsArray, buildPhaseType, comment, target, optionsOrFolderType, subfolderPath
+                    // project.addBuildPhase(
+                    // 	[],
+                    // 	"PBXShellScriptBuildPhase",
+                    // 	"Copy Metadata (DEBUG)",
+                    // 	undefined,
+                    // 	{
+                    // 		shellPath: "/bin/sh",
+                    // 		shellScript: `cp ./platforms/ios/build/Debug-iphonesimulator/metadata-arm64.bin $CONFIGURATION_BUILD_DIR`,
+                    // 		outputPaths: [
+                    // 			JSON.stringify("$(CONFIGURATION_BUILD_DIR)/metadata-arm64.bin"),
+                    // 			// JSON.stringify("$(CONFIGURATION_BUILD_DIR)/metadata-arm64e.bin"),
+                    // 			// JSON.stringify("$(CONFIGURATION_BUILD_DIR)/metadata-i386.bin"),
+                    // 			// JSON.stringify("$(CONFIGURATION_BUILD_DIR)/metadata-x86_64.bin"),
+                    // 		],
+                    // 	}
+                    // );
                     const metadataPath = path.relative(this.$options.hostProjectPath, buildFolderPath);
                     project.addToOtherLinkerFlags(JSON.stringify(`-sectcreate __DATA __TNSMetadata "${metadataPath}/metadata-arm64.bin"`));
+                    // // no shorthand way to get UUID of build phase that i can tell
+                    // // methods return the phase as an object but ommitted the actual key (uuid we need)
+                    // // this does it same way nativescript-dev-xcode does but gets the uuid we need
+                    // const resourcesBuildPhaseKeys = Object.keys(
+                    // 	project.hash.project.objects["PBXResourcesBuildPhase"]
+                    // );
+                    // // console.log('resourcesBuildPhaseKeys:', resourcesBuildPhaseKeys);
+                    // const buildPhaseUUID = resourcesBuildPhaseKeys[0];
+                    // const comment = `${targetFolderName} in Resources`;
+                    // project.hash.project.objects["PBXResourcesBuildPhase"][
+                    // 	buildPhaseUUID
+                    // ].files.forEach((f: any) => {
+                    // 	console.log(f);
+                    // });
+                    // if (
+                    // 	!project.hash.project.objects["PBXResourcesBuildPhase"][
+                    // 		buildPhaseUUID
+                    // 	].files.find((f: any) => f.comment === comment)
+                    // ) {
+                    // 	project.addResourceFile(buildFolderPath, {}, buildPhaseUUID);
+                    // }
+                    /**
+                     * 2. Ensure metadata is copied as a file
+                     * 		The apps metadata-{arch}.bin should be added as a file reference.
+                     */
+                    // TODO
                     this.savePbxProj(project, projectData);
                 }
                 catch (err) {
@@ -410,10 +479,12 @@ class IOSProjectService extends projectServiceBaseLib.PlatformProjectServiceBase
         this.$fs.deleteDirectory(platformsAppResourcesPath);
         this.$fs.ensureDirectoryExists(platformsAppResourcesPath);
         const platformAppResourcesPath = path.join(projectAppResourcesPath, platformData.normalizedPlatformName);
+        // this allows App_Resources/visionOS
         if (this.$fs.exists(platformAppResourcesPath)) {
             this.$fs.copyFile(path.join(platformAppResourcesPath, "*"), platformsAppResourcesPath);
         }
         else {
+            // otherwise falls back to App_Resources/iOS
             this.$fs.copyFile(path.join(projectAppResourcesPath, this.$devicePlatformsConstants.iOS, "*"), platformsAppResourcesPath);
         }
         this.$fs.deleteFile(path.join(platformsAppResourcesPath, platformData.configurationFileName));
@@ -516,6 +587,12 @@ class IOSProjectService extends projectServiceBaseLib.PlatformProjectServiceBase
     getLibSubpathRelativeToProjectPath(targetPath, projectData) {
         const projectRoot = this.getPlatformData(projectData).projectRoot;
         const frameworkPath = path.relative(projectRoot, targetPath);
+        // console.log({
+        // 	targetPath,
+        // 	projectRoot,
+        // 	frameworkPath,
+        // 	resolved: path.resolve(projectRoot, frameworkPath),
+        // });
         return frameworkPath;
     }
     getPbxProjPath(projectData) {
@@ -568,6 +645,10 @@ class IOSProjectService extends projectServiceBaseLib.PlatformProjectServiceBase
             const projectPodfilePath = this.$cocoapodsService.getProjectPodfilePath(platformData.projectRoot);
             if (this.$fs.exists(projectPodfilePath)) {
                 yield this.$cocoapodsService.executePodInstall(platformData.projectRoot, this.$xcprojService.getXcodeprojPath(projectData, platformData.projectRoot));
+                // The `pod install` command adds a new target to the .pbxproject. This target adds additional build phases to Xcode project.
+                // Some of these phases relies on env variables (like PODS_PODFILE_DIR_PATH or PODS_ROOT).
+                // These variables are produced from merge of pod's xcconfig file and project's xcconfig file.
+                // So the correct order is `pod install` to be executed before merging pod's xcconfig file.
                 yield this.$cocoapodsService.mergePodXcconfigFile(projectData, platformData, opts);
             }
             yield this.$spmService.applySPMPackages(platformData, projectData);
@@ -582,6 +663,7 @@ class IOSProjectService extends projectServiceBaseLib.PlatformProjectServiceBase
             const hasProvision = provision !== undefined;
             const hasTeamId = teamId !== undefined;
             if (hasProvision || hasTeamId) {
+                // Check if the native project's signing is set to the provided provision...
                 const pbxprojPath = this.getPbxProjPath(projectData);
                 if (this.$fs.exists(pbxprojPath)) {
                     const xcode = this.$pbxprojDomXcode.Xcode.open(pbxprojPath);
@@ -597,6 +679,9 @@ class IOSProjectService extends projectServiceBaseLib.PlatformProjectServiceBase
                             }
                         }
                         else {
+                            // Specifying provisioning profile requires "Manual" signing style.
+                            // If the current signing style was not "Manual" it was probably "Automatic" or,
+                            // it was not uniform for the debug and release build configurations.
                             changesInfo.signingChanged = true;
                         }
                     }
@@ -610,6 +695,8 @@ class IOSProjectService extends projectServiceBaseLib.PlatformProjectServiceBase
                             }
                         }
                         else {
+                            // Specifying team id or name requires "Automatic" signing style.
+                            // If the current signing style was not "Automatic" it was probably "Manual".
                             changesInfo.signingChanged = true;
                         }
                     }
@@ -828,10 +915,14 @@ class IOSProjectService extends projectServiceBaseLib.PlatformProjectServiceBase
             }
             for (const pluginsXcconfigFilePath of pluginsXcconfigFilePaths) {
                 if (!this.$fs.exists(pluginsXcconfigFilePath)) {
+                    // We need the pluginsXcconfig file to exist in platforms dir as it is required in the native template:
+                    // https://github.com/NativeScript/ios-runtime/blob/9c2b7b5f70b9bee8452b7a24aa6b646214c7d2be/build/project-template/__PROJECT_NAME__/build-debug.xcconfig#L3
+                    // From Xcode 10 in case the file is missing, this include fails and the build itself fails (was a warning in previous Xcode versions).
                     this.$fs.writeFile(pluginsXcconfigFilePath, "");
                 }
             }
             for (const pluginsXcconfigFilePath of pluginsXcconfigFilePaths) {
+                // Set Entitlements Property to point to default file if not set explicitly by the user.
                 const entitlementsPropertyValue = this.$xcconfigService.readPropertyValue(pluginsXcconfigFilePath, constants.CODE_SIGN_ENTITLEMENTS);
                 if (entitlementsPropertyValue === null &&
                     this.$fs.exists(this.$iOSEntitlementsService.getPlatformsEntitlementsPath(projectData))) {
@@ -879,3 +970,4 @@ __decorate([
 ], IOSProjectService.prototype, "buildProject", null);
 exports.IOSProjectService = IOSProjectService;
 yok_1.injector.register("iOSProjectService", IOSProjectService);
+//# sourceMappingURL=ios-project-service.js.map

package/lib/services/ios-provision-service.js

@@ -145,6 +145,8 @@ class IOSProvisionService {
     getDevelopmentTeams() {
         return __awaiter(this, void 0, void 0, function* () {
             const teams = {};
+            // NOTE: We are reading all provisioning profiles and collect team information from them.
+            // It would be better if we can check the Apple ID registered in Xcode and read the teams associated with it.
             mobileprovision.provision.read().forEach((provision) => provision.TeamIdentifier &&
                 provision.TeamIdentifier.forEach((id) => {
                     if (!teams[provision.TeamName]) {
@@ -171,3 +173,4 @@ class IOSProvisionService {
 }
 exports.IOSProvisionService = IOSProvisionService;
 yok_1.injector.register("iOSProvisionService", IOSProvisionService);
+//# sourceMappingURL=ios-provision-service.js.map

package/lib/services/ios-watch-app-service.js

@@ -74,3 +74,4 @@ IOSWatchAppService.WATCH_APP_IDENTIFIER = "watchkitapp";
 IOSWatchAppService.WACTCH_EXTENSION_IDENTIFIER = "watchkitextension";
 exports.IOSWatchAppService = IOSWatchAppService;
 yok_1.injector.register("iOSWatchAppService", IOSWatchAppService);
+//# sourceMappingURL=ios-watch-app-service.js.map

package/lib/services/ip-service.js

@@ -52,6 +52,7 @@ class IPService {
     }
     getIPAddressFromIpifyOrgAPI() {
         return __awaiter(this, void 0, void 0, function* () {
+            // https://www.ipify.org/
             const ipifyOrgAPIEndpoint = "https://api.ipify.org";
             let ipAddress = null;
             try {
@@ -76,3 +77,4 @@ __decorate([
 ], IPService.prototype, "getCurrentIPv4Address", null);
 exports.IPService = IPService;
 yok_1.injector.register("ipService", IPService);
+//# sourceMappingURL=ip-service.js.map

package/lib/services/itmstransporter-service.js

@@ -214,3 +214,4 @@ __decorate([
 ], ITMSTransporterService.prototype, "getITMSTransporterPath", null);
 exports.ITMSTransporterService = ITMSTransporterService;
 yok_1.injector.register("itmsTransporterService", ITMSTransporterService);
+//# sourceMappingURL=itmstransporter-service.js.map

package/lib/services/karma-execution.js

@@ -9,8 +9,10 @@ process.on("message", (data) => {
         });
         const KarmaServer = require(path.join(pathToKarma, "lib/server"));
         const karma = new KarmaServer(data.karmaConfig, (exitCode) => {
+            // Exit with the correct exit code and signal the manager process.
             process.exit(exitCode);
         });
         karma.start();
     }
 });
+//# sourceMappingURL=karma-execution.js.map

package/lib/services/livesync/android-device-livesync-service-base.js

@@ -66,3 +66,4 @@ class AndroidDeviceLiveSyncServiceBase extends device_livesync_service_base_1.De
     }
 }
 exports.AndroidDeviceLiveSyncServiceBase = AndroidDeviceLiveSyncServiceBase;
+//# sourceMappingURL=android-device-livesync-service-base.js.map

package/lib/services/livesync/android-device-livesync-service.js

@@ -119,6 +119,7 @@ class AndroidDeviceLiveSyncService extends android_device_livesync_service_base_
             ]);
             const regex = new RegExp(`^-.*${deviceRootBasename}$`, "m");
             const matchingFile = (listResult || "").match(regex);
+            // Check if there is already a file with deviceRootBasename. If so, delete it as it breaks LiveSyncing.
             if (matchingFile && matchingFile[0] && _.startsWith(matchingFile[0], "-")) {
                 yield this.device.adb.executeShellCommand(["rm", "-f", deviceRootPath]);
             }
@@ -201,3 +202,4 @@ __decorate([
     (0, decorators_1.performanceLog)()
 ], AndroidDeviceLiveSyncService.prototype, "removeFiles", null);
 exports.AndroidDeviceLiveSyncService = AndroidDeviceLiveSyncService;
+//# sourceMappingURL=android-device-livesync-service.js.map

package/lib/services/livesync/android-device-livesync-sockets-service.js

@@ -111,6 +111,8 @@ class AndroidDeviceSocketsLiveSyncService extends android_device_livesync_servic
                     yield this.$cleanupService.removeCleanupCommand(cleanupCommand);
                 });
                 yield this.$cleanupService.addCleanupCommand(cleanupCommand);
+                // We need to clear resources when the action fails
+                // But we also need the real result of the action.
                 yield doSyncPromise.then(actionOnEnd.bind(this), actionOnEnd.bind(this));
                 result = yield doSyncPromise;
             }
@@ -195,3 +197,4 @@ class AndroidDeviceSocketsLiveSyncService extends android_device_livesync_servic
 AndroidDeviceSocketsLiveSyncService.STATUS_UPDATE_INTERVAL = 10000;
 AndroidDeviceSocketsLiveSyncService.MINIMAL_VERSION_LONG_LIVING_CONNECTION = "0.2.0";
 exports.AndroidDeviceSocketsLiveSyncService = AndroidDeviceSocketsLiveSyncService;
+//# sourceMappingURL=android-device-livesync-sockets-service.js.map

package/lib/services/livesync/android-livesync-service.js

@@ -74,3 +74,4 @@ __decorate([
 ], AndroidLiveSyncService.prototype, "fullSync", null);
 exports.AndroidLiveSyncService = AndroidLiveSyncService;
 yok_1.injector.register("androidLiveSyncService", AndroidLiveSyncService);
+//# sourceMappingURL=android-livesync-service.js.map

package/lib/services/livesync/android-livesync-tool.js

@@ -159,9 +159,12 @@ class AndroidLivesyncTool {
             error =
                 error ||
                     this.getErrorWithMessage("Socket connection ended before sync operation is complete.");
+            //remove listeners and delete this.socketConnection
             this.cleanState(socketUid);
+            //call end of the connection (close and error callbacks won't be called - listeners removed)
             socket.end();
             socket.destroy();
+            //reject all pending sync requests and clear timeouts
             this.rejectPendingSyncOperations(socketUid, error);
         }
     }
@@ -425,3 +428,4 @@ AndroidLivesyncTool.SOCKET_CONNECTION_TIMED_OUT_ERROR = "Socket connection timed
 AndroidLivesyncTool.NO_SOCKET_CONNECTION_AVAILABLE_ERROR = "No socket connection available.";
 exports.AndroidLivesyncTool = AndroidLivesyncTool;
 yok_1.injector.register("androidLivesyncTool", AndroidLivesyncTool);
+//# sourceMappingURL=android-livesync-tool.js.map

package/lib/services/livesync/device-livesync-service-base.js

@@ -52,6 +52,7 @@ class DeviceLiveSyncServiceBase {
     }
     finalizeSync(liveSyncInfo, projectData) {
         return __awaiter(this, void 0, void 0, function* () {
+            //implement in case a sync point for all remove/create operation is needed
             return {
                 didRefresh: true,
                 operationId: "",
@@ -67,3 +68,4 @@ __decorate([
     (0, decorators_2.performanceLog)()
 ], DeviceLiveSyncServiceBase.prototype, "transferFiles", null);
 exports.DeviceLiveSyncServiceBase = DeviceLiveSyncServiceBase;
+//# sourceMappingURL=device-livesync-service-base.js.map

package/lib/services/livesync/ios-device-livesync-service.js

@@ -47,11 +47,13 @@ class IOSDeviceLiveSyncService extends device_livesync_service_base_1.DeviceLive
     }
     setupSocketIfNeeded(projectData) {
         return __awaiter(this, void 0, void 0, function* () {
+            // TODO: persist the sockets per app in order to support LiveSync on multiple apps on the same device
             if (this.socket) {
                 return true;
             }
             const appId = projectData.projectIdentifiers.ios;
             try {
+                // TODO: temp workaround till we setup the sockets along with the app start
                 const ensureAppStarted = true;
                 this.socket = yield this.device.getDebugSocket(appId, projectData.projectName, projectData.projectDir, ensureAppStarted);
             }
@@ -143,6 +145,7 @@ class IOSDeviceLiveSyncService extends device_livesync_service_base_1.DeviceLive
                 projectDir: projectData.projectDir,
             });
             if (liveSyncInfo.useHotModuleReload) {
+                // enable HOT updates
                 yield this.setupSocketIfNeeded(projectData);
             }
         });
@@ -205,6 +208,9 @@ class IOSDeviceLiveSyncService extends device_livesync_service_base_1.DeviceLive
     destroySocket() {
         return __awaiter(this, void 0, void 0, function* () {
             if (this.socket) {
+                // we do not support LiveSync on multiple apps on the same device
+                // in order to do that, we should cache the socket per app
+                // and destroy just the current app socket when possible
                 yield this.device.destroyAllSockets();
                 this.socket = null;
             }
@@ -216,3 +222,4 @@ __decorate([
     (0, decorators_1.performanceLog)()
 ], IOSDeviceLiveSyncService.prototype, "removeFiles", null);
 exports.IOSDeviceLiveSyncService = IOSDeviceLiveSyncService;
+//# sourceMappingURL=ios-device-livesync-service.js.map

package/lib/services/livesync/ios-livesync-service.js

@@ -73,6 +73,7 @@ class IOSLiveSyncService extends platform_livesync_service_base_1.PlatformLiveSy
     syncAfterInstall(device, liveSyncInfo) {
         return __awaiter(this, void 0, void 0, function* () {
             if (!device.isEmulator) {
+                // In this case we should execute fullsync because iOS Runtime requires the full content of app dir to be extracted in the root of sync dir.
                 yield this.fullSync({
                     projectData: liveSyncInfo.projectData,
                     device,
@@ -93,3 +94,4 @@ __decorate([
 ], IOSLiveSyncService.prototype, "fullSync", null);
 exports.IOSLiveSyncService = IOSLiveSyncService;
 yok_1.injector.register("iOSLiveSyncService", IOSLiveSyncService);
+//# sourceMappingURL=ios-livesync-service.js.map

package/lib/services/livesync/livesync-socket.js

@@ -12,3 +12,4 @@ class LiveSyncSocket extends net.Socket {
 }
 exports.LiveSyncSocket = LiveSyncSocket;
 yok_1.injector.register("LiveSyncSocket", LiveSyncSocket, false);
+//# sourceMappingURL=livesync-socket.js.map

package/lib/services/livesync/platform-livesync-service-base.js

@@ -52,6 +52,7 @@ class PlatformLiveSyncServiceBase {
     }
     syncAfterInstall(device, liveSyncInfo) {
         return __awaiter(this, void 0, void 0, function* () {
+            /* intentionally left blank */
         });
     }
     restartApplication(projectData, liveSyncInfo) {
@@ -105,6 +106,8 @@ class PlatformLiveSyncServiceBase {
             let modifiedLocalToDevicePaths = [];
             if (liveSyncInfo.filesToSync.length) {
                 const filesToSync = liveSyncInfo.filesToSync;
+                // const mappedFiles = _.map(filesToSync, filePath => this.$projectFilesProvider.mapFilePath(filePath, device.deviceInfo.platform, projectData));
+                // Some plugins modify platforms dir on afterPrepare (check nativescript-dev-sass) - we want to sync only existing file.
                 const existingFiles = filesToSync.filter((m) => m && this.$fs.exists(m));
                 this.$logger.trace("Will execute livesync for files: ", existingFiles);
                 const skippedFiles = _.difference(filesToSync, existingFiles);
@@ -123,6 +126,7 @@ class PlatformLiveSyncServiceBase {
                 const filePaths = liveSyncInfo.filesToRemove;
                 const platformData = this.$platformsDataService.getPlatformData(device.deviceInfo.platform, projectData);
                 const mappedFiles = _(filePaths)
+                    // .map(filePath => this.$projectFilesProvider.mapFilePath(filePath, device.deviceInfo.platform, projectData))
                     .filter((filePath) => !!filePath)
                     .value();
                 const projectFilesPath = path.join(platformData.appDestinationDirectoryPath, constants_1.APP_FOLDER_NAME);
@@ -179,3 +183,4 @@ __decorate([
     (0, decorators_1.performanceLog)()
 ], PlatformLiveSyncServiceBase.prototype, "liveSyncWatchAction", null);
 exports.PlatformLiveSyncServiceBase = PlatformLiveSyncServiceBase;
+//# sourceMappingURL=platform-livesync-service-base.js.map

package/lib/services/livesync-process-data-service.js

@@ -41,3 +41,4 @@ class LiveSyncProcessDataService {
 }
 exports.LiveSyncProcessDataService = LiveSyncProcessDataService;
 yok_1.injector.register("liveSyncProcessDataService", LiveSyncProcessDataService);
+//# sourceMappingURL=livesync-process-data-service.js.map

package/lib/services/log-parser-service.js

@@ -50,3 +50,4 @@ __decorate([
 ], LogParserService.prototype, "startParsingLogCore", null);
 exports.LogParserService = LogParserService;
 yok_1.injector.register("logParserService", LogParserService);
+//# sourceMappingURL=log-parser-service.js.map

package/lib/services/log-source-map-service.js

@@ -41,6 +41,7 @@ class LogSourceMapService {
                 if (!this.$fs.getFsStats(filePath).isDirectory()) {
                     const mapFile = filePath + ".map";
                     let sourceMapRaw;
+                    // Skip files bigger than 50MB
                     if (this.$fs.getFileSize(filePath) > 50 * 1000 * 1000) {
                         this.$logger.trace(`Skipping source map for file ${filePath} because it is too big (> 50MB).`);
                         return;
@@ -166,6 +167,8 @@ class LogSourceMapService {
         }
     }
     parseAndroidLog(projectData, rawMessage) {
+        // "JS: at module.exports.push../main-view-model.ts.HelloWorldModel.onTap (file:///data/data/org.nativescript.sourceMap/files/app/bundle.js:303:17)"
+        // "System.err: File: "file:///data/data/org.nativescript.sourceMap/files/app/bundle.js, line: 304, column: 8"
         const fileIndex = rawMessage.lastIndexOf(LogSourceMapService.FILE_PREFIX);
         const deviceProjectPath = util.format(constants_1.ANDROID_DEVICE_APP_ROOT_TEMPLATE, projectData.projectIdentifiers.android);
         let separator = ",";
@@ -173,18 +176,25 @@ class LogSourceMapService {
         let parts, filePath, line, column, messagePrefix;
         if (fileIndex >= 0) {
             const fileSubstring = rawMessage.substring(fileIndex + LogSourceMapService.FILE_PREFIX.length);
+            //"data/data/org.nativescript.sourceMap/files/app/bundle.js, line: 304, column: 8"
             parts = fileSubstring.split(separator);
             if (parts.length >= 3) {
+                // "data/data/org.nativescript.sourceMap/files/app/bundle.js"
                 parts[0] = parts[0].replace("'", "");
+                // " line: 304"
                 parts[1] = parts[1].replace(" line: ", "");
+                // " column: 8"
                 parts[2] = parts[2].replace(" column: ", "");
             }
             else {
+                // "data/data/org.nativescript.sourceMap/files/app/bundle.js:303:17)"
                 separator = ":";
                 parts = fileSubstring.split(separator);
             }
             if (parts.length >= 3) {
+                // "/data/data/org.nativescript.sourceMap/files/app/"
                 const devicePath = `${deviceProjectPath}/${constants_1.APP_FOLDER_NAME}/`;
+                // "bundle.js"
                 filePath = path.relative(devicePath, `${"/"}${parts[0]}`);
                 line = parseInt(parts[1]);
                 column = parseInt(parts[2]);
@@ -192,20 +202,24 @@ class LogSourceMapService {
                 for (let i = 3; i < parts.length; i++) {
                     messageSuffix += `${parts[i]}${i === parts.length - 1 ? "" : separator}`;
                 }
+                // "JS: at module.exports.push../main-view-model.ts.HelloWorldModel.onTap ("
                 messagePrefix = _.trimEnd(messagePrefix, "(");
             }
         }
         return { filePath, line, column, messagePrefix, messageSuffix };
     }
     parseIosLog(rawMessage) {
+        // "CONSOLE INFO file:///app/vendor.js:131:36: HMR: Hot Module Replacement Enabled. Waiting for signal."
         const fileIndex = rawMessage.lastIndexOf(LogSourceMapService.FILE_PREFIX);
         let messageSuffix = "";
         let parts, filePath, line, column, messagePrefix;
         if (fileIndex >= 0) {
+            // "app/vendor.js:131:36: HMR: Hot Module Replacement Enabled. Waiting for signal."
             const fileSubstring = rawMessage.substring(fileIndex + LogSourceMapService.FILE_PREFIX.length);
             parts = fileSubstring.split(":");
             if (parts && parts.length >= 3) {
                 filePath = parts[0];
+                // "app/vendor.js"
                 if (_.startsWith(filePath, constants_1.APP_FOLDER_NAME)) {
                     filePath = path.relative(constants_1.APP_FOLDER_NAME, parts[0]);
                 }
@@ -234,3 +248,4 @@ LogSourceMapService.FILE_PREFIX_REPLACEMENT = "file: ";
 LogSourceMapService.MEMOIZE_FUNCTION_RANDOM_KEY_FOR_JOIN = "__some_random_value__";
 exports.LogSourceMapService = LogSourceMapService;
 yok_1.injector.register("logSourceMapService", LogSourceMapService);
+//# sourceMappingURL=log-source-map-service.js.map

package/lib/services/marking-mode-service.js

@@ -15,7 +15,7 @@ const constants_1 = require("../constants");
 const yok_1 = require("../common/yok");
 const semver = require("semver/preload");
 const MARKING_MODE_PROP = "markingMode";
-const MARKING_MODE_FULL_DEPRECATION_MSG = `In the current version of NativeScript "${MARKING_MODE_PROP}:${"full"}" is no longer supported.`;
+const MARKING_MODE_FULL_DEPRECATION_MSG = `In the current version of NativeScript "${MARKING_MODE_PROP}:${"full" /* MarkingMode.Full */}" is no longer supported.`;
 class MarkingModeService {
     constructor($logger, $projectConfigService, $projectHelper, $projectDataService) {
         this.$logger = $logger;
@@ -28,11 +28,13 @@ class MarkingModeService {
             const markingModeValue = this.$projectConfigService.getValue("android.markingMode");
             const { skipWarnings, forceSwitch } = options;
             if (forceSwitch) {
-                yield this.setMarkingMode("none");
+                yield this.setMarkingMode("none" /* MarkingMode.None */);
                 return;
             }
-            if (!skipWarnings && (markingModeValue === null || markingModeValue === void 0 ? void 0 : markingModeValue.toLowerCase()) !== "none") {
-                const { version } = this.$projectDataService.getRuntimePackage(this.$projectHelper.projectDir, "android");
+            if (!skipWarnings && (markingModeValue === null || markingModeValue === void 0 ? void 0 : markingModeValue.toLowerCase()) !== "none" /* MarkingMode.None */) {
+                // only warn if runtime is less than 7.0.0-rc.5 - where the default has been changed to None
+                // if version is null - we are about to add the latest runtime, so no need to warn
+                const { version } = this.$projectDataService.getRuntimePackage(this.$projectHelper.projectDir, "android" /* PlatformTypes.android */);
                 const isMarkingModeFullDefault = version && semver.lt(semver.coerce(version), "7.0.0-rc.5");
                 if (isMarkingModeFullDefault) {
                     this.showMarkingModeFullWarning();
@@ -46,7 +48,7 @@ class MarkingModeService {
         });
     }
     showMarkingModeFullWarning() {
-        const markingModeFullWarning = `You are using the deprecated "${MARKING_MODE_PROP}:${"full"}".${os_1.EOL}${os_1.EOL}${MARKING_MODE_FULL_DEPRECATION_MSG}${os_1.EOL}${os_1.EOL}You should update your marking mode by executing 'ns update --markingMode'.`;
+        const markingModeFullWarning = `You are using the deprecated "${MARKING_MODE_PROP}:${"full" /* MarkingMode.Full */}".${os_1.EOL}${os_1.EOL}${MARKING_MODE_FULL_DEPRECATION_MSG}${os_1.EOL}${os_1.EOL}You should update your marking mode by executing 'ns update --markingMode'.`;
         this.$logger.warn(markingModeFullWarning, {
             [constants_1.LoggerConfigData.wrapMessageWithBorders]: true,
         });
@@ -54,3 +56,4 @@ class MarkingModeService {
 }
 exports.MarkingModeService = MarkingModeService;
 yok_1.injector.register("markingModeService", MarkingModeService);
+//# sourceMappingURL=marking-mode-service.js.map

package/lib/services/metadata-filtering-service.js

@@ -103,3 +103,4 @@ class MetadataFilteringService {
 }
 exports.MetadataFilteringService = MetadataFilteringService;
 yok_1.injector.register("metadataFilteringService", MetadataFilteringService);
+//# sourceMappingURL=metadata-filtering-service.js.map

package/lib/services/npm-config-service.js

@@ -21,8 +21,11 @@ class NpmConfigService {
     readConfig() {
         try {
             const res = (0, child_process_1.execSync)("npm config list --json --global");
+            // const data: any = npmconfig.read();
             const data = JSON.parse(res.toString());
+            // todo: remove if not needed with npm config list --json?
             Object.entries(data).forEach(([key, value]) => {
+                // replace env ${VARS} in strings with the process.env value
                 this.config[key] =
                     typeof value !== "string"
                         ? value
@@ -37,3 +40,4 @@ __decorate([
 ], NpmConfigService.prototype, "readConfig", null);
 exports.NpmConfigService = NpmConfigService;
 yok_1.injector.register("npmConfigService", NpmConfigService);
+//# sourceMappingURL=npm-config-service.js.map

package/lib/services/pacote-service.js

@@ -33,6 +33,7 @@ class PacoteService {
         this.$proxyService = $proxyService;
     }
     get $packageManager() {
+        // need to be resolved here due to cyclic dependency
         return this.$injector.resolve("packageManager");
     }
     manifest(packageName, options) {
@@ -51,6 +52,8 @@ class PacoteService {
     }
     extractPackage(packageName, destinationDirectory, options) {
         return __awaiter(this, void 0, void 0, function* () {
+            // strip: Remove the specified number of leading path elements. Pathnames with fewer elements will be silently skipped. More info: https://github.com/npm/node-tar/blob/e89c4d37519b1c20133a9f49d5f6b85fa34c203b/README.md
+            // C: Create an archive
             this.$logger.trace(`Calling pacoteService.extractPackage for packageName: '${packageName}', destinationDir: '${destinationDirectory}' and options: ${options}`);
             const extractOptions = { strip: 1, C: destinationDirectory };
             if (options) {
@@ -68,6 +71,7 @@ class PacoteService {
                 });
                 this.$logger.trace(`Creating extract tar stream with options: ${JSON.stringify(extractOptions, null, 2)}`);
                 const destination = tar.x(extractOptions);
+                // Initiate the source
                 const sourceStream = new stream_1.PassThrough();
                 sourceStream.end(source);
                 sourceStream.pipe(destination);
@@ -84,7 +88,9 @@ class PacoteService {
     }
     getPacoteBaseOptions() {
         return __awaiter(this, void 0, void 0, function* () {
+            // In case `tns create myapp --template https://github.com/NativeScript/template-hello-world.git` command is executed, pacote module throws an error if cache option is not provided.
             const cachePath = yield this.$packageManager.getCachePath();
+            // Add NPM Configuration to our Manifest options
             const npmConfig = this.$npmConfigService.getConfig();
             const pacoteOptions = _.extend(npmConfig, { cache: cachePath, Arborist: arborist_1.Arborist });
             const proxySettings = yield this.$proxyService.getCache();
@@ -107,3 +113,4 @@ __decorate([
 ], PacoteService.prototype, "$packageManager", null);
 exports.PacoteService = PacoteService;
 yok_1.injector.register("pacoteService", PacoteService);
+//# sourceMappingURL=pacote-service.js.map

package/lib/services/performance-service.js

@@ -41,7 +41,7 @@ class PerformanceService {
     trackAnalyticsData(methodInfo, executionTime) {
         this.$analyticsService
             .trackEventActionInGoogleAnalytics({
-            action: "Performance",
+            action: "Performance" /* TrackActionNames.Performance */,
             additionalData: methodInfo,
             value: executionTime,
         })
@@ -71,6 +71,7 @@ class PerformanceService {
             this.$logger.info(PerformanceService.LOG_MESSAGE_TEMPLATE, methodInfo, executionTime);
         }
     }
+    //removes any injected members of the arguments and excludes the options object even if it was renamed
     getJsonSanitizer() {
         const seen = new WeakSet();
         seen.add(this.$options);
@@ -90,3 +91,4 @@ PerformanceService.FAIL_LOG_MESSAGE_TEMPLATE = `Failed to log pefromance data in
 PerformanceService.MIN_NODE_PERFORMANCE_MODULE_VERSION = "8.5.0";
 exports.PerformanceService = PerformanceService;
 yok_1.injector.register("performanceService", PerformanceService);
+//# sourceMappingURL=performance-service.js.map