nativescript 8.7.0-rc.1 → 8.7.0-rc.2

package/lib/services/android-project-service.js

@@ -27,7 +27,40 @@ const constants_1 = require("../common/constants");
 const helpers_1 = require("../common/helpers");
 const decorators_1 = require(".././common/decorators");
 const yok_1 = require("../common/yok");
-function topologicalSortNativeDependencies(dependencies, start = [], depth = 0, total = 0) {
+//
+// we sort the native dependencies topologically to make sure they are processed in the right order
+// native dependenciess need to be sorted so the deepst dependencies are built before it's parents
+//
+// for example, given this dep structure (assuming these are all native dependencies that need to be built)
+// (note: we list all dependencies at the root level, so the leaf nodes are essentially references to the root nodes)
+//
+//   |- dep1
+//   |- dep2
+//   |- |- dep3
+//   |- |- dep4
+//   |- |- |- dep5
+//   |- dep3
+//   |- dep4
+//   |- |- dep5
+//   |- dep5
+//
+// It is sorted:
+//
+//   |- dep1
+//   |- dep3
+//   |- dep5
+//   |- dep4        # depends on dep5, so dep5 must be built first, ie above ^
+//   |- |- dep5
+//   |- dep2        # depends on dep3, dep4 (and dep5 through dep4) so all of them must be built first before dep2 is built
+//   |- |- dep3
+//   |- |- dep4
+//   |- |- |- dep5
+//
+// for more details see: https://wikiless.org/wiki/Topological_sorting?lang=en
+//
+function topologicalSortNativeDependencies(dependencies, start = [], depth = 0, total = 0 // do not pass in, we calculate it in the initial run!
+) {
+    // we set the total on the initial call - and never increment it, as it's used for esacaping the recursion
     if (total === 0) {
         total = dependencies.length;
     }
@@ -41,6 +74,8 @@ function topologicalSortNativeDependencies(dependencies, start = [], depth = 0,
         return sortedDeps;
     }, start);
     const remainingDeps = dependencies.filter((nativeDep) => !sortedDeps.includes(nativeDep));
+    // recurse if we still have remaining deps
+    // the second condition here prevents infinite recursion
     if (remainingDeps.length && sortedDeps.length < total) {
         return topologicalSortNativeDependencies(remainingDeps, sortedDeps, depth + 1, total);
     }
@@ -92,7 +127,7 @@ class AndroidProjectService extends projectServiceBaseLib.PlatformProjectService
                 constants.APK_DIR,
             ];
             const packageName = this.getProjectNameFromId(projectData);
-            const runtimePackage = this.$projectDataService.getRuntimePackage(projectData.projectDir, "android");
+            const runtimePackage = this.$projectDataService.getRuntimePackage(projectData.projectDir, "android" /* constants.PlatformTypes.android */);
             this._platformData = {
                 frameworkPackageName: runtimePackage.name,
                 normalizedPlatformName: "Android",
@@ -133,7 +168,7 @@ class AndroidProjectService extends projectServiceBaseLib.PlatformProjectService
                 configurationFileName: constants.MANIFEST_FILE_NAME,
                 configurationFilePath: path.join(...configurationsDirectoryArr),
                 relativeToFrameworkConfigurationFilePath: path.join(constants.SRC_DIR, constants.MAIN_DIR, constants.MANIFEST_FILE_NAME),
-                fastLivesyncFileExtensions: [".jpg", ".gif", ".png", ".bmp", ".webp"],
+                fastLivesyncFileExtensions: [".jpg", ".gif", ".png", ".bmp", ".webp"], // http://developer.android.com/guide/appendix/media-formats.html
             };
         }
         return this._platformData;
@@ -188,6 +223,7 @@ class AndroidProjectService extends projectServiceBaseLib.PlatformProjectService
             const targetSdkVersion = androidToolsInfo && androidToolsInfo.targetSdkVersion;
             this.$logger.trace(`Using Android SDK '${targetSdkVersion}'.`);
             this.copy(this.getPlatformData(projectData).projectRoot, frameworkDir, "*", "-R");
+            // TODO: Check if we actually need this and if it should be targetSdk or compileSdk
             this.cleanResValues(targetSdkVersion, projectData);
         });
     }
@@ -221,6 +257,7 @@ class AndroidProjectService extends projectServiceBaseLib.PlatformProjectService
     }
     interpolateData(projectData) {
         return __awaiter(this, void 0, void 0, function* () {
+            // Interpolate the apilevel and package
             this.interpolateConfigurationFile(projectData);
             const appResourcesDirectoryPath = projectData.getAppResourcesDirectoryPath();
             let stringsFilePath;
@@ -236,8 +273,10 @@ class AndroidProjectService extends projectServiceBaseLib.PlatformProjectService
             const gradleSettingsFilePath = path.join(this.getPlatformData(projectData).projectRoot, "settings.gradle");
             shell.sed("-i", /__PROJECT_NAME__/, this.getProjectNameFromId(projectData), gradleSettingsFilePath);
             try {
+                // will replace applicationId in app/App_Resources/Android/app.gradle if it has not been edited by the user
                 const appGradleContent = this.$fs.readText(projectData.appGradlePath);
                 if (appGradleContent.indexOf(constants.PACKAGE_PLACEHOLDER_NAME) !== -1) {
+                    //TODO: For compatibility with old templates. Once all templates are updated should delete.
                     shell.sed("-i", new RegExp(constants.PACKAGE_PLACEHOLDER_NAME), projectData.projectIdentifiers.android, projectData.appGradlePath);
                 }
             }
@@ -297,6 +336,7 @@ class AndroidProjectService extends projectServiceBaseLib.PlatformProjectService
     }
     prepareProject() {
         return __awaiter(this, void 0, void 0, function* () {
+            // Intentionally left empty.
         });
     }
     ensureConfigurationFileInAppResources(projectData) {
@@ -314,6 +354,7 @@ class AndroidProjectService extends projectServiceBaseLib.PlatformProjectService
             this.$logger.warn("No manifest found in " + originalAndroidManifestFilePath);
             return;
         }
+        // Overwrite the AndroidManifest from runtime.
         if (!appResourcesDirStructureHasMigrated) {
             this.$fs.copyFile(originalAndroidManifestFilePath, this.getPlatformData(projectData).configurationFilePath);
         }
@@ -330,6 +371,8 @@ class AndroidProjectService extends projectServiceBaseLib.PlatformProjectService
         }
         else {
             this.$fs.copyFile(path.join(projectAppResourcesPath, platformData.normalizedPlatformName, "*"), platformsAppResourcesPath);
+            // https://github.com/NativeScript/android-runtime/issues/899
+            // App_Resources/Android/libs is reserved to user's aars and jars, but they should not be copied as resources
             this.$fs.deleteDirectory(path.join(platformsAppResourcesPath, "libs"));
         }
         const androidToolsInfo = this.$androidToolsInfo.getToolsInfo({
@@ -340,6 +383,7 @@ class AndroidProjectService extends projectServiceBaseLib.PlatformProjectService
     }
     preparePluginNativeCode(pluginData, projectData) {
         return __awaiter(this, void 0, void 0, function* () {
+            // build Android plugins which contain AndroidManifest.xml and/or resources
             const pluginPlatformsFolderPath = this.getPluginPlatformsFolderPath(pluginData, AndroidProjectService.ANDROID_PLATFORM_NAME);
             if (this.$fs.exists(pluginPlatformsFolderPath)) {
                 const options = {
@@ -365,6 +409,7 @@ class AndroidProjectService extends projectServiceBaseLib.PlatformProjectService
     }
     removePluginNativeCode(pluginData, projectData) {
         return __awaiter(this, void 0, void 0, function* () {
+            // not implemented
         });
     }
     beforePrepareAllPlugins(projectData, dependencies) {
@@ -383,6 +428,7 @@ class AndroidProjectService extends projectServiceBaseLib.PlatformProjectService
     filterUniqueDependencies(dependencies) {
         const depsDictionary = dependencies.reduce((dict, dep) => {
             const collision = dict[dep.name];
+            // in case there are multiple dependencies to the same module, the one declared in the package.json takes precedence
             if (!collision || collision.depth > dep.depth) {
                 dict[dep.name] = dep;
             }
@@ -399,6 +445,7 @@ class AndroidProjectService extends projectServiceBaseLib.PlatformProjectService
                 name,
                 directory: path.relative(platformDir, directory),
                 dependencies: dependencies.filter((dep) => {
+                    // filter out transient dependencies that don't have native dependencies
                     return (nativeDependencyData.findIndex((nativeDep) => nativeDep.name === dep) !== -1);
                 }),
             };
@@ -406,6 +453,7 @@ class AndroidProjectService extends projectServiceBaseLib.PlatformProjectService
         nativeDependencies = topologicalSortNativeDependencies(nativeDependencies);
         const jsonContent = JSON.stringify(nativeDependencies, null, 4);
         this.$fs.writeFile(dependenciesJsonPath, jsonContent);
+        // we sort all the dependencies to respect the topological sorting of the native dependencies
         return dependencies.sort(function (a, b) {
             return (nativeDependencies.findIndex((n) => n.name === a.name) -
                 nativeDependencies.findIndex((n) => n.name === b.name));
@@ -444,6 +492,7 @@ class AndroidProjectService extends projectServiceBaseLib.PlatformProjectService
     }
     checkForChanges() {
         return __awaiter(this, void 0, void 0, function* () {
+            // Nothing android specific to check yet.
         });
     }
     getDeploymentTarget(projectData) {
@@ -454,9 +503,12 @@ class AndroidProjectService extends projectServiceBaseLib.PlatformProjectService
         shell.cp(cpArg, paths, projectRoot);
     }
     validatePackageName(packageName) {
+        //Make the package conform to Java package types
+        //Enforce underscore limitation
         if (!/^[a-zA-Z]+(\.[a-zA-Z0-9][a-zA-Z0-9_]*)+$/.test(packageName)) {
             this.$errors.fail(`Package name must look like: com.company.Name. Got: ${packageName}`);
         }
+        //Class is a reserved word
         if (/\b[Cc]lass\b/.test(packageName)) {
             this.$errors.fail("class is a reserved word");
         }
@@ -465,6 +517,7 @@ class AndroidProjectService extends projectServiceBaseLib.PlatformProjectService
         if (projectName === "") {
             this.$errors.fail("Project name cannot be empty");
         }
+        //Classes in Java don't begin with numbers
         if (/^[0-9]/.test(projectName)) {
             this.$errors.fail("Project name must not begin with a number");
         }
@@ -485,6 +538,19 @@ class AndroidProjectService extends projectServiceBaseLib.PlatformProjectService
         ];
         return path.join(this.getPlatformData(projectData).projectRoot, ...resourcePath);
     }
+    /**
+     * The purpose of this method is to delete the previously prepared user resources.
+     * The content of the `<platforms>/android/.../res` directory is based on user's resources and gradle project template from android-runtime.
+     * During preparation of the `<path to user's App_Resources>/Android` we want to clean all the users files from previous preparation,
+     * but keep the ones that were introduced during `platform add` of the android-runtime.
+     * Currently the Gradle project template contains resources only in values and values-v21 directories.
+     * So the current logic of the method is cleaning al resources from `<platforms>/android/.../res` that are not in `values.*` directories
+     * and that exist in the `<path to user's App_Resources>/Android/.../res` directory
+     * This means that if user has a resource file in values-v29 for example, builds the project and then deletes this resource,
+     * it will be kept in platforms directory. Reference issue: `https://github.com/NativeScript/nativescript-cli/issues/5083`
+     * Same is valid for files in `drawable-<resolution>` directories - in case in user's resources there's drawable-hdpi directory,
+     * which is deleted after the first build of app, it will remain in platforms directory.
+     */
     cleanUpPreparedResources(projectData) {
         let resourcesDirPath = path.join(projectData.appResourcesDirectoryPath, this.getPlatformData(projectData).normalizedPlatformName);
         if (this.$androidResourcesMigrationService.hasMigrated(projectData.appResourcesDirectoryPath)) {
@@ -510,7 +576,7 @@ class AndroidProjectService extends projectServiceBaseLib.PlatformProjectService
                     const hasUseKotlinPropertyInAppData = `hasUseKotlinPropertyInApp${analyticsDelimiter}${buildStatistics.kotlinUsage.hasUseKotlinPropertyInApp}`;
                     const hasKotlinRuntimeClassesData = `hasKotlinRuntimeClasses${analyticsDelimiter}${buildStatistics.kotlinUsage.hasKotlinRuntimeClasses}`;
                     yield this.$analyticsService.trackEventActionInGoogleAnalytics({
-                        action: "Using Kotlin",
+                        action: "Using Kotlin" /* constants.TrackActionNames.UsingKotlin */,
                         additionalData: `${hasUseKotlinPropertyInAppData}${analyticsDelimiter}${hasKotlinRuntimeClassesData}`,
                     });
                 }
@@ -544,3 +610,4 @@ __decorate([
 ], AndroidProjectService.prototype, "buildProject", null);
 exports.AndroidProjectService = AndroidProjectService;
 yok_1.injector.register("androidProjectService", AndroidProjectService);
+//# sourceMappingURL=android-project-service.js.map

package/lib/services/android-resources-migration-service.js

@@ -58,6 +58,7 @@ class AndroidResourcesMigrationService {
             const appResourcesMainSourceSetResourcesDestination = path.join(appMainSourceSet, constants.RESOURCES_DIR);
             this.$fs.ensureDirectoryExists(appResourcesDestination);
             this.$fs.ensureDirectoryExists(appMainSourceSet);
+            // create /java, /res and /assets in the App_Resources/Android/src/main directory
             this.$fs.ensureDirectoryExists(appResourcesMainSourceSetResourcesDestination);
             this.$fs.ensureDirectoryExists(path.join(appMainSourceSet, "java"));
             this.$fs.ensureDirectoryExists(path.join(appMainSourceSet, constants.ASSETS_DIR));
@@ -71,20 +72,25 @@ class AndroidResourcesMigrationService {
             const resourceFiles = getFiles(appResourcesFiles);
             resourceDirectories.forEach((dir) => {
                 if (path.basename(dir) !== "libs") {
+                    // don't copy /App_Resources/Android/libs into the src/main/res/libs directory
                     this.$fs.copyFile(dir, appResourcesMainSourceSetResourcesDestination);
                 }
                 else {
+                    // copy App_Resources/Android/libs to App_ResourcesNew/Android/libs
                     this.$fs.copyFile(dir, path.join(appResourcesDestination));
                 }
             });
             resourceFiles.forEach((file) => {
                 const fileName = path.basename(file);
                 if (fileName !== constants.MANIFEST_FILE_NAME) {
+                    // don't copy AndroidManifest into /App_Resources/Android as it needs to be inside src/main/
                     this.$fs.copyFile(file, path.join(appResourcesDestination, fileName));
                 }
             });
             this.$fs.copyFile(path.join(originalAppResources, constants.MANIFEST_FILE_NAME), path.join(appMainSourceSet, constants.MANIFEST_FILE_NAME));
+            // rename the legacy app_resources to ANDROID_DIR_OLD
             this.$fs.rename(originalAppResources, appResourcesBackup);
+            // move the new, updated app_resources to App_Resources/Android, as  the de facto resources
             this.$fs.rename(appResourcesDestination, originalAppResources);
         });
     }
@@ -102,3 +108,4 @@ AndroidResourcesMigrationService.ANDROID_DIR_TEMP = "Android-Updated";
 AndroidResourcesMigrationService.ANDROID_DIR_OLD = "Android-Pre-v4";
 exports.AndroidResourcesMigrationService = AndroidResourcesMigrationService;
 yok_1.injector.register("androidResourcesMigrationService", AndroidResourcesMigrationService);
+//# sourceMappingURL=android-resources-migration-service.js.map

package/lib/services/apple-portal/apple-portal-application-service.js

@@ -80,3 +80,4 @@ class ApplePortalApplicationService {
 }
 exports.ApplePortalApplicationService = ApplePortalApplicationService;
 yok_1.injector.register("applePortalApplicationService", ApplePortalApplicationService);
+//# sourceMappingURL=apple-portal-application-service.js.map

package/lib/services/apple-portal/apple-portal-cookie-service.js

@@ -51,3 +51,4 @@ class ApplePortalCookieService {
 }
 exports.ApplePortalCookieService = ApplePortalCookieService;
 yok_1.injector.register("applePortalCookieService", ApplePortalCookieService);
+//# sourceMappingURL=apple-portal-cookie-service.js.map

package/lib/services/apple-portal/apple-portal-session-service.js

@@ -190,10 +190,10 @@ For more details how to set up your environment, please execute "ns publish ios
             const data = JSON.parse(authResponse.body);
             const isSMS = data.trustedPhoneNumbers &&
                 data.trustedPhoneNumbers.length === 1 &&
-                data.noTrustedDevices;
+                data.noTrustedDevices; // 1 device and no trusted devices means sms was automatically sent.
             const multiSMS = data.trustedPhoneNumbers &&
                 data.trustedPhoneNumbers.length !== 1 &&
-                data.noTrustedDevices;
+                data.noTrustedDevices; // Not handling more than 1 sms device and no trusted devices.
             let token;
             if (data.trustedPhoneNumbers &&
                 data.trustedPhoneNumbers.length &&
@@ -207,6 +207,7 @@ For more details how to set up your environment, please execute "ns publish ios
                 };
                 let url = `https://idmsa.apple.com/appleauth/auth/verify/trusteddevice/securitycode`;
                 if (isSMS) {
+                    // No trusted devices means it must be sms.
                     body.mode = "sms";
                     body.phoneNumber = {
                         id: data.trustedPhoneNumbers[0].id,
@@ -270,8 +271,9 @@ function checkBits(bits, digest) {
     return result;
 }
 function checkBit(position, buffer) {
-    const bitOffset = position & 7;
-    const byteIndex = position >> 3;
+    const bitOffset = position & 7; // in byte
+    const byteIndex = position >> 3; // in buffer
     const bit = (buffer[byteIndex] >> bitOffset) & 1;
     return bit === 0;
 }
+//# sourceMappingURL=apple-portal-session-service.js.map

package/lib/services/assets-generation/assets-generation-service.js

@@ -92,7 +92,7 @@ class AssetsGenerationService {
                     }
                     continue;
                 }
-                const operation = assetItem.resizeOperation || "resize";
+                const operation = assetItem.resizeOperation || "resize" /* Operations.Resize */;
                 let tempScale = null;
                 if (assetItem.scale) {
                     if (_.isNumber(assetItem.scale)) {
@@ -117,27 +117,36 @@ class AssetsGenerationService {
                 }
                 let image;
                 switch (operation) {
-                    case "overlayWith":
+                    case "overlayWith" /* Operations.OverlayWith */:
                         const overlayImageScale = assetItem.overlayImageScale ||
                             constants_1.AssetConstants.defaultOverlayImageScale;
                         const imageResize = Math.round(Math.min(width, height) * overlayImageScale);
                         image = yield this.resize(generationData.imagePath, imageResize, imageResize);
                         image = this.generateImage(background, width, height, outputPath, image);
                         break;
-                    case "blank":
+                    case "blank" /* Operations.Blank */:
                         image = this.generateImage(background, width, height, outputPath);
                         break;
-                    case "resize":
+                    case "resize" /* Operations.Resize */:
                         image = yield this.resize(generationData.imagePath, width, height);
                         break;
-                    case "outerScale":
+                    case "outerScale" /* Operations.OuterScale */:
+                        // Resize image without applying scale
                         image = yield this.resize(generationData.imagePath, assetItem.width, assetItem.height);
+                        // The scale will apply to the underlying layer of the generated image
                         image = this.generateImage("#00000000", width, height, outputPath, image);
                         break;
                     default:
                         throw new Error(`Invalid image generation operation: ${operation}`);
                 }
+                // This code disables the alpha chanel, as some images for the Apple App Store must not have transparency.
                 if (assetItem.rgba === false) {
+                    //
+                    // The original code here became broken at some time and there is an issue posted here..
+                    //    https://github.com/oliver-moran/jimp/issues/954
+                    // But NathanaelA recommended the below change and it works so maybe that's just what we go with.
+                    //
+                    // image = image.rgba(false);
                     image = image.colorType(2);
                 }
                 image.write(outputPath);
@@ -151,6 +160,7 @@ class AssetsGenerationService {
         });
     }
     generateImage(background, width, height, outputPath, overlayImage) {
+        // Typescript declarations for Jimp are not updated to define the constructor with backgroundColor so we workaround it by casting it to <any> for this case only.
         const J = Jimp;
         const backgroundColor = this.getRgbaNumber(background);
         let image = new J(width, height, backgroundColor);
@@ -176,3 +186,4 @@ __decorate([
 ], AssetsGenerationService.prototype, "generateSplashScreens", null);
 exports.AssetsGenerationService = AssetsGenerationService;
 yok_1.injector.register("assetsGenerationService", AssetsGenerationService);
+//# sourceMappingURL=assets-generation-service.js.map

package/lib/services/build-artifacts-service.js

@@ -75,7 +75,7 @@ class BuildArtifactsService {
         if (packages.length > 1) {
             this.$logger.warn(`More than one ${packageExtName} found in ${buildOutputPath} directory. Using the last one produced from build.`);
         }
-        packages = _.sortBy(packages, (pkg) => pkg.time).reverse();
+        packages = _.sortBy(packages, (pkg) => pkg.time).reverse(); // We need to reverse because sortBy always sorts in ascending order
         return packages[0];
     }
     getApplicationPackagesCore(candidates, validPackageNames) {
@@ -96,3 +96,4 @@ class BuildArtifactsService {
 }
 exports.BuildArtifactsService = BuildArtifactsService;
 yok_1.injector.register("buildArtifactsService", BuildArtifactsService);
+//# sourceMappingURL=build-artifacts-service.js.map

package/lib/services/build-data-service.js

@@ -8,7 +8,7 @@ class BuildDataService {
         this.$mobileHelper = $mobileHelper;
     }
     getBuildData(projectDir, platform, data) {
-        if (this.$mobileHelper.isApplePlatfrom(platform)) {
+        if (this.$mobileHelper.isApplePlatform(platform)) {
             return new build_data_1.IOSBuildData(projectDir, platform, data);
         }
         else if (this.$mobileHelper.isAndroidPlatform(platform)) {
@@ -18,3 +18,4 @@ class BuildDataService {
 }
 exports.BuildDataService = BuildDataService;
 yok_1.injector.register("buildDataService", BuildDataService);
+//# sourceMappingURL=build-data-service.js.map

package/lib/services/build-info-file-service.js

@@ -77,3 +77,4 @@ class BuildInfoFileService {
 }
 exports.BuildInfoFileService = BuildInfoFileService;
 yok_1.injector.register("buildInfoFileService", BuildInfoFileService);
+//# sourceMappingURL=build-info-file-service.js.map

package/lib/services/cleanup-service.js

@@ -30,7 +30,7 @@ class CleanupService {
         return __awaiter(this, void 0, void 0, function* () {
             const cleanupProcess = yield this.getCleanupProcess();
             cleanupProcess.send({
-                messageType: "AddCleanCommand",
+                messageType: "AddCleanCommand" /* CleanupProcessMessage.AddCleanCommand */,
                 commandInfo,
             });
         });
@@ -39,7 +39,7 @@ class CleanupService {
         return __awaiter(this, void 0, void 0, function* () {
             const cleanupProcess = yield this.getCleanupProcess();
             cleanupProcess.send({
-                messageType: "RemoveCleanCommand",
+                messageType: "RemoveCleanCommand" /* CleanupProcessMessage.RemoveCleanCommand */,
                 commandInfo,
             });
         });
@@ -48,7 +48,7 @@ class CleanupService {
         return __awaiter(this, void 0, void 0, function* () {
             const cleanupProcess = yield this.getCleanupProcess();
             cleanupProcess.send({
-                messageType: "AddRequest",
+                messageType: "AddRequest" /* CleanupProcessMessage.AddRequest */,
                 requestInfo,
             });
         });
@@ -57,7 +57,7 @@ class CleanupService {
         return __awaiter(this, void 0, void 0, function* () {
             const cleanupProcess = yield this.getCleanupProcess();
             cleanupProcess.send({
-                messageType: "RemoveRequest",
+                messageType: "RemoveRequest" /* CleanupProcessMessage.RemoveRequest */,
                 requestInfo,
             });
         });
@@ -66,7 +66,7 @@ class CleanupService {
         return __awaiter(this, void 0, void 0, function* () {
             const cleanupProcess = yield this.getCleanupProcess();
             cleanupProcess.send({
-                messageType: "AddDeleteFileAction",
+                messageType: "AddDeleteFileAction" /* CleanupProcessMessage.AddDeleteFileAction */,
                 filePath,
             });
         });
@@ -75,7 +75,7 @@ class CleanupService {
         return __awaiter(this, void 0, void 0, function* () {
             const cleanupProcess = yield this.getCleanupProcess();
             cleanupProcess.send({
-                messageType: "RemoveDeleteFileAction",
+                messageType: "RemoveDeleteFileAction" /* CleanupProcessMessage.RemoveDeleteFileAction */,
                 filePath,
             });
         });
@@ -84,7 +84,7 @@ class CleanupService {
         return __awaiter(this, void 0, void 0, function* () {
             const cleanupProcess = yield this.getCleanupProcess();
             cleanupProcess.send({
-                messageType: "AddJSFileToRequire",
+                messageType: "AddJSFileToRequire" /* CleanupProcessMessage.AddJSFileToRequire */,
                 jsCommand,
             });
         });
@@ -93,7 +93,7 @@ class CleanupService {
         return __awaiter(this, void 0, void 0, function* () {
             const cleanupProcess = yield this.getCleanupProcess();
             cleanupProcess.send({
-                messageType: "RemoveJSFileToRequire",
+                messageType: "RemoveJSFileToRequire" /* CleanupProcessMessage.RemoveJSFileToRequire */,
                 jsCommand,
             });
         });
@@ -121,6 +121,8 @@ class CleanupService {
     setShouldDispose(shouldDispose) {
         this.shouldDispose = shouldDispose;
     }
+    // TODO: Consider extracting this method to a separate service
+    // as it has the same logic as the one used in analytics-service
     getCleanupProcess() {
         return new Promise((resolve, reject) => {
             const cleanupProcessArgs = this.getCleanupProcessArgs();
@@ -139,11 +141,12 @@ class CleanupService {
                 clearTimeout(timeoutId);
                 if (!isSettled) {
                     isSettled = true;
+                    // In case we throw error here, CLI will break its execution.
                     reject(err);
                 }
             });
             cleanupProcess.on("message", (data) => {
-                if (data === "ProcessReadyToReceive") {
+                if (data === "ProcessReadyToReceive" /* DetachedProcessMessages.ProcessReadyToReceive */) {
                     clearTimeout(timeoutId);
                     if (!isSettled) {
                         isSettled = true;
@@ -192,3 +195,4 @@ __decorate([
 ], CleanupService.prototype, "getCleanupProcess", null);
 exports.CleanupService = CleanupService;
 yok_1.injector.register("cleanupService", CleanupService);
+//# sourceMappingURL=cleanup-service.js.map

package/lib/services/cocoapods-platform-manager.js

@@ -82,6 +82,7 @@ class CocoaPodsPlatformManager {
         _.each(allPodfiles, (podfileContent) => {
             const platformMatch = platformRowRegExp.exec(podfileContent);
             const podfilePathMatch = podfilePathRegExp.exec(podfileContent) || [];
+            // platform without version -> select it with highest priority
             if (platformMatch && platformMatch[0] && !platformMatch[2]) {
                 selectedPlatformData = {
                     version: null,
@@ -90,6 +91,7 @@ class CocoaPodsPlatformManager {
                 };
                 return false;
             }
+            // platform with version
             if (platformMatch && platformMatch[0] && platformMatch[2]) {
                 if (!selectedPlatformData ||
                     semver.gt(semver.coerce(platformMatch[2]), semver.coerce(selectedPlatformData.version))) {
@@ -104,6 +106,12 @@ class CocoaPodsPlatformManager {
         return selectedPlatformData;
     }
     shouldReplacePlatformSection(projectData, oldPodfilePlatformData, currentPodfilePlatformData) {
+        // The selected platform should be replaced in the following cases:
+        // 1. When the pod file is from App_Resources and the selected platform is not from App_Resources
+        // 2. When the pod file is from App_Resources, the selected platform is also from App_Resources
+        // and the pod's version is greater than the selected one
+        // 3. When the pod file doesn't have platform's version -> `platform :ios`
+        // 4. When the pod file has a version greater than the selected platform's version
         const appResourcesPodfilePath = path.join(projectData.getAppResourcesDirectoryPath(), "iOS", constants_1.PODFILE_NAME);
         const isFromAppResources = oldPodfilePlatformData.path !== appResourcesPodfilePath &&
             currentPodfilePlatformData.path === appResourcesPodfilePath;
@@ -135,3 +143,4 @@ class CocoaPodsPlatformManager {
 }
 exports.CocoaPodsPlatformManager = CocoaPodsPlatformManager;
 yok_1.injector.register("cocoaPodsPlatformManager", CocoaPodsPlatformManager);
+//# sourceMappingURL=cocoapods-platform-manager.js.map

package/lib/services/cocoapods-service.js

@@ -44,6 +44,12 @@ class CocoaPodsService {
             let podTool = this.$config.USE_POD_SANDBOX ? "sandbox-pod" : "pod";
             const args = ["install"];
             if (process.platform === "darwin" && process.arch === "arm64") {
+                // check if pod is installed as an x86_64 binary or a native arm64 one
+                // we run the following:
+                // arch -x86_64 pod --version
+                // if it's an arm64 binary, we'll get something like this as a result:
+                // arch: posix_spawnp: pod: Bad CPU type in executable
+                // in which case, we should run it natively.
                 const res = yield this.$childProcess
                     .exec("arch -x86_64 pod --version", null, {
                     showStderr: true,
@@ -57,8 +63,11 @@ class CocoaPodsService {
                     podTool = "arch";
                 }
             }
+            // cocoapods print a lot of non-error information on stderr. Pipe the `stderr` to `stdout`, so we won't polute CLI's stderr output.
             const podInstallResult = yield this.$childProcess.spawnFromEvent(podTool, args, "close", { cwd: projectRoot, stdio: ["pipe", process.stdout, process.stdout] }, { throwError: false });
             if (podInstallResult.exitCode !== 0) {
+                // https://github.com/CocoaPods/CocoaPods/blob/92aaf0f1120d32f3487960b485fb69fcaf61486c/lib/cocoapods/resolver.rb#L498
+                // TODO add article
                 const versionResolutionHint = podInstallResult.exitCode === 31
                     ? `For more information on resolving CocoaPod issues in NativeScript read.`
                     : "";
@@ -96,6 +105,7 @@ ${versionResolutionHint}`);
     applyPodfileArchExclusions(projectData, platformData) {
         return __awaiter(this, void 0, void 0, function* () {
             const xcodeVersionData = yield this.$xcodeSelectService.getXcodeVersion();
+            // only apply EXCLUDED_ARCHS workaround on XCode 12
             if (+xcodeVersionData.major !== 12) {
                 return;
             }
@@ -114,6 +124,7 @@ end`.trim();
                 this.$fs.writeFile(exclusionsPodfile, exclusions);
             }
             yield this.applyPodfileToProject("NativeScript-CLI-Architecture-Exclusions", exclusionsPodfile, projectData, platformData);
+            // clean up
             this.$fs.deleteFile(exclusionsPodfile);
         });
     }
@@ -138,6 +149,7 @@ end`.trim();
                 podfilePath: path.join(extensionFolderPath, name, constants.PODFILE_NAME),
             }));
             extensionsPodfile.forEach(({ targetName, podfilePath }) => {
+                // Remove the data between #Begin Podfile and #EndPodfile
                 const regExpToRemove = new RegExp(`${this.getExtensionPodfileHeader(podfilePath, targetName)}[\\s\\S]*?${this.getExtensionPodfileEnd()}`, "mg");
                 projectPodFileContent = projectPodFileContent.replace(regExpToRemove, "");
                 if (this.$fs.exists(podfilePath)) {
@@ -166,6 +178,7 @@ end`.trim();
                 ? this.$fs.readText(pathToProjectPodfile).trim()
                 : "";
             if (projectPodfileContent.indexOf(podfileContent) === -1) {
+                // Remove old occurences of the plugin from the project's Podfile.
                 this.removePodfileFromProject(moduleName, podfilePath, projectData, nativeProjectPath);
                 let finalPodfileContent = this.$fs.exists(pathToProjectPodfile)
                     ? this.getPodfileContentWithoutTarget(projectData, this.$fs.readText(pathToProjectPodfile))
@@ -184,6 +197,7 @@ end`.trim();
     removePodfileFromProject(moduleName, podfilePath, projectData, projectRoot) {
         if (this.$fs.exists(this.getProjectPodfilePath(projectRoot))) {
             let projectPodFileContent = this.$fs.readText(this.getProjectPodfilePath(projectRoot));
+            // Remove the data between #Begin Podfile and #EndPodfile
             const regExpToRemove = new RegExp(`${this.getPluginPodfileHeader(podfilePath)}[\\s\\S]*?${this.getPluginPodfileEnd()}`, "mg");
             projectPodFileContent = projectPodFileContent.replace(regExpToRemove, "");
             projectPodFileContent = this.removePostInstallHook(moduleName, projectPodFileContent);
@@ -204,7 +218,7 @@ end`.trim();
         }
     }
     getPluginPodfilePath(pluginData) {
-        const pluginPlatformsFolderPath = pluginData.pluginPlatformsFolderPath("ios");
+        const pluginPlatformsFolderPath = pluginData.pluginPlatformsFolderPath("ios" /* PlatformTypes.ios */);
         const pluginPodFilePath = path.join(pluginPlatformsFolderPath, constants_1.PODFILE_NAME);
         return pluginPodFilePath;
     }
@@ -240,6 +254,7 @@ end`.trim();
         if (_.startsWith(projectPodfileContent, podFileHeader)) {
             projectPodfileContent = projectPodfileContent.substr(podFileHeader.length);
             const podFileFooter = this.getPodfileFooter();
+            // Only remove the final end in case the file starts with the podFileHeader
             if (_.endsWith(projectPodfileContent, podFileFooter)) {
                 projectPodfileContent = projectPodfileContent.substr(0, projectPodfileContent.length - podFileFooter.length);
             }
@@ -260,6 +275,8 @@ end`.trim();
         return projectPodFileContent;
     }
     getHookBasicFuncNameForPlugin(hookName, pluginName) {
+        // nativescript-hook and nativescript_hook should have different names, so replace all _ with ___ first and then replace all special symbols with _
+        // This will lead to a clash in case plugins are called nativescript-hook and nativescript___hook
         const replacedPluginName = pluginName
             .replace(/_/g, "___")
             .replace(/[^A-Za-z0-9_]/g, "_");
@@ -273,6 +290,7 @@ end`.trim();
             const newFunctionName = `${this.getHookBasicFuncNameForPlugin(hookName, pluginName)}_${newFunctions.length}`;
             let newDefinition = `def ${newFunctionName}`;
             const rubyFunction = { functionName: newFunctionName };
+            // firstGroup is the block parameter, secondGroup is the block parameter name.
             if (firstGroup && secondGroup) {
                 newDefinition = `${newDefinition} (${secondGroup})`;
                 rubyFunction.functionParameters = secondGroup;
@@ -283,6 +301,7 @@ end`.trim();
         return { replacedContent, newFunctions };
     }
     getPluginPodfileHeader(pluginPodFilePath) {
+        // escape special + from the podfile path (pnpm)
         pluginPodFilePath = pluginPodFilePath.replace(/\+/g, "\\+");
         return `# Begin Podfile - ${pluginPodFilePath}`;
     }
@@ -352,3 +371,4 @@ CocoaPodsService.PODFILE_POST_INSTALL_SECTION_NAME = "post_install";
 CocoaPodsService.INSTALLER_BLOCK_PARAMETER_NAME = "installer";
 exports.CocoaPodsService = CocoaPodsService;
 yok_1.injector.register("cocoapodsService", CocoaPodsService);
+//# sourceMappingURL=cocoapods-service.js.map

package/lib/services/debug-data-service.js

@@ -19,3 +19,4 @@ class DebugDataService {
 }
 exports.DebugDataService = DebugDataService;
 yok_1.injector.register("debugDataService", DebugDataService);
+//# sourceMappingURL=debug-data-service.js.map