nativekeel 0.1.12 → 0.1.13

package/README.md

@@ -6,7 +6,7 @@ Health check for React Native and Expo apps. One command, no install, no account
 npx nativekeel
 ```
 
-**What's new in 0.1.12:** hacking risks mapped to OWASP MASVS: open Firebase rules, TLS certificate checks turned off, hardcoded keys and weak crypto, tokens in plain storage, with a security overview in every report. **0.1.10:** every report opens with *Start here*, the three most urgent first steps; missing iOS permission texts (a crash and an App Review rejection) are caught. Recent releases added known vulnerabilities in the exact versions you ship, password leaks into logs and databases, unsafe WebViews, open Android components, plain-HTTP API calls and runtime crash risks. Tuned on 280+ open-source React Native and Expo apps to keep false alarms out. [All releases →](https://nativekeel.com/changelog)
+**What's new in 0.1.13:** performance traps (nested lists, JS-thread animations, release console logs, heavy imports, oversized images) and reverse-engineering exposure (source maps in the app, Hermes/R8 off). **0.1.12:** hacking risks mapped to OWASP MASVS: open Firebase rules, TLS certificate checks turned off, hardcoded keys and weak crypto, tokens in plain storage, with a security overview in every report. **0.1.10:** every report opens with *Start here*, the three most urgent first steps; missing iOS permission texts (a crash and an App Review rejection) are caught. Recent releases added known vulnerabilities in the exact versions you ship, password leaks into logs and databases, unsafe WebViews, open Android components, plain-HTTP API calls and runtime crash risks. Tuned on 280+ open-source React Native and Expo apps to keep false alarms out. [All releases →](https://nativekeel.com/changelog)
 
 It answers the questions that decide whether your app can still ship:
 
@@ -20,6 +20,8 @@ It answers the questions that decide whether your app can still ship:
 - **Do you ship known vulnerabilities?** Advisories from the GitHub Advisory Database for the exact versions in your lockfile or `node_modules`. Advisories that only affect Node.js servers are kept, at low severity.
 - **Can someone break in?** Grouped by OWASP MASVS: Firebase Realtime Database/Firestore/Storage rules open to anyone (or in test mode), TLS certificate checks turned off in native code, hardcoded encryption keys, MD5/SHA-1 on passwords, ECB mode, `Math.random` for nonces and salts. These are static checks: they catch the common, detectable mistakes, not everything a penetration test of the running app would.
 - **Can someone read your users' data?** Passwords that flow into crash reports, analytics, remote databases or plain AsyncStorage (followed through intermediate variables), WebViews that let page scripts read local files or load HTTP into HTTPS, Android backups that copy tokens, Android components any app can start, API calls over plain HTTP, auth tokens in unencrypted storage.
+- **Is it slow or heavy?** A FlatList inside a ScrollView (no virtualization), animations with `useNativeDriver: false`, `console.log` left in release builds, whole-library `lodash`/`moment` imports, images over 500 KB that the app requires. Static signs to measure on a device, not a profiler.
+- **Can it be taken apart?** Source maps packaged into the app, Hermes or R8 off in release (OWASP MASVS-RESILIENCE). Obfuscation only slows an attacker down; keep secrets and checks on the server.
 - **Will it crash at runtime?** Reanimated without its Babel plugin or `react-native-worklets`, mixed `@react-native-firebase/*` or `@react-navigation/*` majors, a second copy of React or React Native inside a dependency, Kotlin modules that cannot load through the New Architecture interop layer, AppDelegate setups that crash in Release, camera/photos/location access without the Info.plist description iOS requires.
 - **Leftovers from old templates?** Flipper, JavaScriptCore instead of Hermes.
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nativekeel",
-  "version": "0.1.12",
+  "version": "0.1.13",
   "description": "Health check for React Native and Expo apps: upgrade blockers, store deadlines, crash risks, vulnerable dependencies and leaked secrets, with a step-by-step upgrade plan.",
   "type": "module",
   "bin": {

package/src/analyze.js

@@ -5,7 +5,8 @@ import { createRegistry, fetchJson } from './registry.js';
 import { scanSecrets } from './secrets.js';
 import { nativeChecks } from './native.js';
 import { stabilityChecks } from './stability.js';
-import { vulnerableDependencies, passwordLeaks, webViewRisks, androidBackup, exportedComponents, plainHttpCalls, cloudRules, insecureTls, weakCrypto, tokenStorage, masvsOf, MASVS_GROUPS } from './security.js';
+import { performanceChecks } from './performance.js';
+import { vulnerableDependencies, passwordLeaks, webViewRisks, androidBackup, exportedComponents, plainHttpCalls, cloudRules, insecureTls, weakCrypto, tokenStorage, reverseEngineering, masvsOf, MASVS_GROUPS } from './security.js';
 import { lockedVersions } from './lockfile.js';
 import { findUnused, filesImportingWith } from './usage.js';
 import { matchKnownIssues, compareVersions } from './known-issues.js';
@@ -403,9 +404,11 @@ export async function analyze(project, { get, now = new Date(), offline: forcedO
   // 7. Secrets
   // Setups that build and then crash at runtime.
   for (const f of stabilityChecks(project)) add(f);
+  // Static signs of performance problems.
+  for (const f of performanceChecks(project)) add(f);
 
   // Security beyond leaked keys.
-  for (const f of [...passwordLeaks(project.root), ...webViewRisks(project.root), ...androidBackup(project.root), ...exportedComponents(project.root), ...plainHttpCalls(project.root), ...cloudRules(project.root, project.deps, now), ...insecureTls(project.root), ...weakCrypto(project.root), ...tokenStorage(project.root)]) add(f);
+  for (const f of [...passwordLeaks(project.root), ...webViewRisks(project.root), ...androidBackup(project.root), ...exportedComponents(project.root), ...plainHttpCalls(project.root), ...cloudRules(project.root, project.deps, now), ...insecureTls(project.root), ...weakCrypto(project.root), ...tokenStorage(project.root), ...reverseEngineering(project.root, project)]) add(f);
   if (!forcedOffline) {
     // Exact versions only (installed, else the lockfile): a range would be a guess.
     const locked = lockedVersions(project.root, project.deps);

package/src/performance.js

@@ -0,0 +1,163 @@
+import fs from 'node:fs';
+import path from 'node:path';
+
+// Performance problems you can see in the code: things that make lists stutter, animations run
+// on the JavaScript thread, or the app download heavier than it needs to be. Runtime profiling
+// (frame drops, start-up time) needs a device; these are the static signs.
+
+const SKIP_DIRS = new Set(['node_modules', '.git', 'Pods', 'build', '.gradle', 'DerivedData', '.expo', 'dist', 'coverage', 'vendor', '__tests__', '__mocks__', 'e2e', 'android', 'ios']);
+const JS_EXT = /\.(?:[cm]?[jt]sx?)$/;
+
+function* walk(dir, test) {
+  let entries;
+  try {
+    entries = fs.readdirSync(dir, { withFileTypes: true });
+  } catch {
+    return;
+  }
+  for (const e of entries) {
+    if (e.isDirectory()) {
+      if (!SKIP_DIRS.has(e.name) && !e.name.startsWith('.')) yield* walk(path.join(dir, e.name), test);
+    } else if (test.test(e.name) && !/\.(test|spec)[._]/.test(e.name)) {
+      yield path.join(dir, e.name);
+    }
+  }
+}
+
+const read = (file) => {
+  try {
+    return fs.statSync(file).size > 512 * 1024 ? '' : fs.readFileSync(file, 'utf8');
+  } catch {
+    return '';
+  }
+};
+
+// The props text of the JSX tag starting at `start` (up to its closing `>` or `/>`, skipping
+// `>` inside {...} expressions such as arrow functions).
+function tagProps(text, start) {
+  let depth = 0;
+  for (let i = start + 1; i < text.length && i < start + 4000; i++) {
+    const c = text[i];
+    if (c === '{') depth++;
+    else if (c === '}') depth--;
+    else if (c === '>' && depth === 0) return { props: text.slice(start, i), end: i + 1 };
+  }
+  return { props: text.slice(start, start + 4000), end: start + 4000 };
+}
+
+export function performanceChecks(project) {
+  const root = project.root;
+  const findings = [];
+  const nested = [];
+  let jsDriver = 0;
+  let jsDriverAt = null;
+  let logs = 0;
+  const heavyImports = new Map();
+  for (const file of walk(root, JS_EXT)) {
+    const text = read(file);
+    if (!text) continue;
+    const rel = path.relative(root, file);
+    const code = text.replace(/\/\*[\s\S]*?\*\//g, '').replace(/\/\/[^\n]*/g, '');
+
+    // A vertical FlatList/SectionList inside a vertical ScrollView renders every item at once
+    // (React Native warns "VirtualizedLists should never be nested").
+    // JSX tags only: not TypeScript generics like useRef<ScrollView>(null).
+    for (const m of code.matchAll(/(?<![\w.$])<ScrollView\b/g)) {
+      const open = tagProps(code, m.index);
+      if (/\bhorizontal\b/.test(open.props)) continue;
+      const close = code.indexOf('</ScrollView>', open.end);
+      if (close < 0) continue;
+      const body = code.slice(open.end, close);
+      const im = body.match(/(?<![\w.$])<(FlatList|SectionList|FlashList)\b/);
+      if (!im) continue;
+      const inner = tagProps(body, im.index);
+      if (!/\bhorizontal\b/.test(inner.props) && !/scrollEnabled\s*=\s*\{\s*false\s*\}/.test(inner.props)) {
+        nested.push(`${rel}:${code.slice(0, m.index).split('\n').length}`);
+      }
+    }
+    // Animations driven from JavaScript: every frame crosses to the JS thread.
+    for (const m of code.matchAll(/useNativeDriver\s*:\s*false/g)) {
+      jsDriver++;
+      jsDriverAt = jsDriverAt || `${rel}:${code.slice(0, m.index).split('\n').length}`;
+    }
+    logs += (code.match(/\bconsole\.(?:log|debug|info)\s*\(/g) || []).length;
+    // Whole-library imports of packages with per-function or lighter alternatives.
+    if (/from\s+['"]lodash['"]|require\(\s*['"]lodash['"]\s*\)/.test(code)) heavyImports.set('lodash', heavyImports.get('lodash') || rel);
+    if (/from\s+['"]moment['"]|require\(\s*['"]moment['"]\s*\)/.test(code)) heavyImports.set('moment', heavyImports.get('moment') || rel);
+  }
+
+  if (nested.length) {
+    findings.push({
+      id: 'perf-nested-lists',
+      severity: 'medium',
+      area: 'performance',
+      title: `A list inside a ScrollView renders every item at once (${nested[0]}${nested.length > 1 ? ` and ${nested.length - 1} more` : ''})`,
+      detail: 'A vertical FlatList/SectionList inside a vertical ScrollView loses virtualization: all rows mount up front, which costs memory and makes long lists stutter or crash on low-end Android. Use the list as the scroll container and move the other content into ListHeaderComponent/ListFooterComponent.',
+      fix: { kind: 'performance', step: `In \`${nested[0]}\`, make the FlatList the scroll container (ListHeaderComponent/ListFooterComponent) instead of nesting it in a ScrollView.` },
+    });
+  }
+  if (jsDriver >= 3) {
+    findings.push({
+      id: 'perf-js-driven-animations',
+      severity: 'low',
+      area: 'performance',
+      title: `${jsDriver} animations run on the JavaScript thread (useNativeDriver: false, e.g. ${jsDriverAt})`,
+      detail: 'Each frame of these animations waits for JavaScript, so they drop frames whenever the app is busy. Transform and opacity animations can use useNativeDriver: true; layout animations can move to Reanimated.',
+      fix: { kind: 'performance', step: 'Switch transform/opacity animations to `useNativeDriver: true` (or Reanimated for layout properties).' },
+    });
+  }
+  const babel = ['babel.config.js', '.babelrc', 'babel.config.json'].map((f) => read(path.join(root, f))).join('\n');
+  if (logs >= 30 && !/transform-remove-console|remove-console/.test(babel)) {
+    findings.push({
+      id: 'perf-console-in-release',
+      severity: 'low',
+      area: 'performance',
+      title: `${logs} console.log calls ship in the release build`,
+      detail: 'They run in production, slow the JavaScript thread in hot paths, and can write user data to the device log. Strip them from release builds with babel-plugin-transform-remove-console (keep console.error/warn).',
+      fix: { kind: 'performance', step: "Add `['transform-remove-console', { exclude: ['error', 'warn'] }]` to the production `env` of your Babel config." },
+    });
+  }
+  if (heavyImports.size) {
+    const advice = { lodash: 'import single functions (lodash/debounce) or use lodash-es with tree shaking', moment: 'use dayjs or date-fns (moment is in maintenance mode and pulls in all locales)' };
+    findings.push({
+      id: 'perf-heavy-imports',
+      severity: 'low',
+      area: 'performance',
+      title: `Whole-library imports of ${[...heavyImports.keys()].join(' and ')}`,
+      detail: `${[...heavyImports].map(([k, at]) => `${k} (${at}): ${advice[k]}`).join('; ')}. They add hundreds of KB to the bundle the app parses at start-up.`,
+      fix: { kind: 'performance', step: `Replace whole-library imports: ${[...heavyImports.keys()].map((k) => advice[k]).join('; ')}.` },
+    });
+  }
+
+  // Oversized images bundled with the app (require()d from code): download size and decode
+  // memory. Screenshots and docs in the repo are not part of the app, so only required files count.
+  const big = [];
+  const seen = new Set();
+  for (const file of walk(root, JS_EXT)) {
+    const text = read(file);
+    for (const m of text.matchAll(/require\(\s*['"](\.{1,2}\/[^'"]+\.(?:png|jpe?g|gif|webp))['"]\s*\)|import\s+\w+\s+from\s+['"](\.{1,2}\/[^'"]+\.(?:png|jpe?g|gif|webp))['"]/gi)) {
+      const img = path.resolve(path.dirname(file), m[1] || m[2]);
+      if (seen.has(img)) continue;
+      seen.add(img);
+      try {
+        const size = fs.statSync(img).size;
+        if (size > 500 * 1024) big.push({ rel: path.relative(root, img), size });
+      } catch {
+        // missing or @2x variant only
+      }
+    }
+  }
+  if (big.length) {
+    big.sort((a, b) => b.size - a.size);
+    const total = big.reduce((s, b) => s + b.size, 0);
+    findings.push({
+      id: 'perf-large-images',
+      severity: big.length >= 5 || total > 10 * 1024 * 1024 ? 'medium' : 'low',
+      area: 'performance',
+      title: `${big.length} image${big.length === 1 ? '' : 's'} over 500 KB in the app (${(total / 1024 / 1024).toFixed(1)} MB)`,
+      detail: `${big.slice(0, 3).map((b) => `${b.rel} (${Math.round(b.size / 1024)} KB)`).join(', ')}${big.length > 3 ? ', …' : ''}. They grow the download and take memory when decoded. Resize to the size shown on screen (2x/3x) and use WebP.`,
+      fix: { kind: 'performance', step: `Resize and convert the largest bundled images (${big.slice(0, 2).map((b) => `\`${b.rel}\``).join(', ')}) to WebP at the size shown on screen.` },
+    });
+  }
+  return findings;
+}

package/src/plan.js

@@ -66,6 +66,7 @@ const WEIGHTS = {
   'folly-flags': () => 0.25,
   'default-react-host': () => 0.25,
   crash: () => 1,
+  performance: () => 0.5,
   security: () => 1,
   'vuln-dep': (f) => (f.severity === 'critical' || f.severity === 'high' ? 1 : 0.25),
 };
@@ -526,6 +527,15 @@ export function buildPlan(result) {
     });
   }
 
+  const perf = byKind('performance');
+  if (perf.length) {
+    phases.push({
+      title: 'Speed up the app',
+      why: 'Static signs of jank and weight. Measure on a low-end Android device before and after: these are the usual suspects, not proof.',
+      steps: perf.map((p) => p.step),
+    });
+  }
+
   const jsBumps = byKind('bump-dep').filter((d) => !d.native && !movesWithExpo(d.name));
   if (jsBumps.length) {
     phases.push({

package/src/security.js

@@ -584,6 +584,7 @@ export const MASVS_GROUPS = {
   NETWORK: 'Network traffic',
   PLATFORM: 'WebViews and platform interaction',
   CODE: 'Dependencies and build',
+  RESILIENCE: 'Reverse engineering',
 };
 
 export function masvsOf(id) {
@@ -593,5 +594,56 @@ export function masvsOf(id) {
   if (/^(webview-|android-exported)/.test(id)) return 'PLATFORM';
   if (/^firebase-/.test(id)) return 'AUTH';
   if (/^(vuln:|signing-|android-debuggable)/.test(id)) return 'CODE';
+  if (/^(sourcemap-in-app|easy-reverse-engineering)/.test(id)) return 'RESILIENCE';
   return null;
 }
+
+// How easily the shipped app reads back as source (MASVS-RESILIENCE). React Native JavaScript is
+// recoverable from any APK/IPA; Hermes bytecode and R8 only slow that down. The real defence is
+// keeping secrets and trust decisions off the device, so this is advice, not an alarm.
+export function reverseEngineering(root, project) {
+  const findings = [];
+  // Source maps packaged into the app give back the original code, names and comments.
+  const mapDirs = [path.join(root, 'android', 'app', 'src', 'main', 'assets'), path.join(root, 'ios')];
+  const maps = [];
+  const scan = (dir, depth) => {
+    let entries = [];
+    try {
+      entries = fs.readdirSync(dir, { withFileTypes: true });
+    } catch {
+      return;
+    }
+    for (const e of entries) {
+      if (e.isDirectory() && depth < 3 && !['Pods', 'build', 'DerivedData'].includes(e.name)) scan(path.join(dir, e.name), depth + 1);
+      else if (/\.(?:bundle|jsbundle|hbc)\.map$|^index\.android\.bundle\.map$|^main\.jsbundle\.map$/.test(e.name)) maps.push(path.relative(root, path.join(dir, e.name)));
+    }
+  };
+  for (const d of mapDirs) scan(d, 0);
+  if (maps.length) {
+    findings.push({
+      id: 'sourcemap-in-app',
+      severity: 'high',
+      area: 'security',
+      title: `A source map is packaged into the app (${maps[0]})`,
+      detail: 'Anyone who unzips the APK/IPA gets your original JavaScript with names and comments. Upload source maps to your crash reporter instead, and keep them out of the app folders. (OWASP MASVS-RESILIENCE)',
+      fix: { kind: 'security', step: `Remove \`${maps[0]}\` from the app sources (and from git), and upload source maps to the crash reporter instead.` },
+    });
+  }
+
+  const gradle = read(path.join(root, 'android', 'app', 'build.gradle')) || read(path.join(root, 'android', 'app', 'build.gradle.kts')) || '';
+  const props = read(path.join(root, 'android', 'gradle.properties')) || '';
+  const r8Off = gradle && (/enableProguardInReleaseBuilds\s*=\s*false/.test(gradle) || /release\s*\{[^}]*minifyEnabled\s*\(?\s*false/.test(gradle));
+  const hermesOff = /^\s*hermesEnabled\s*=\s*false/m.test(props) || /hermes_enabled\s*=>\s*false/.test(read(path.join(root, 'ios', 'Podfile')) || '');
+  const factors = [hermesOff && 'Hermes is off, so the JavaScript ships as readable text', r8Off && 'R8/ProGuard is off, so Java/Kotlin class and method names stay readable'].filter(Boolean);
+  if (factors.length && !project.managed) {
+    findings.push({
+      id: 'easy-reverse-engineering',
+      severity: 'low',
+      area: 'security',
+      title: 'The release build is easy to read back',
+      detail: `${factors.join('; ')}. Any React Native app can be unpacked, and obfuscation only slows that down, so never rely on it: keep secrets and checks that matter (prices, entitlements, admin flags) on the server. Turning these on is still cheap. (OWASP MASVS-RESILIENCE)`,
+      fix: { kind: 'security', step: `${hermesOff ? 'Turn on Hermes. ' : ''}${r8Off ? 'Set `enableProguardInReleaseBuilds = true` in `android/app/build.gradle` and test a release build (add keep rules for libraries that need them). ' : ''}Keep secrets and trust decisions on the server.` },
+    });
+  }
+  return findings;
+}