native-update 2.0.0 → 3.1.0

package/ios/Plugin/LiveUpdate/LiveUpdatePlugin.swift

@@ -134,44 +134,58 @@ class LiveUpdatePlugin {
         }
         
         Task {
+            let bundleId = "bundle-\(Date().timeIntervalSince1970)"
+            let downloadDir = getUpdatesDirectory().appendingPathComponent(bundleId)
+            var downloadSucceeded = false
+            defer {
+                // Remove the download directory if anything in download/
+                // verify/extract failed. Without this, every failed
+                // download leaks an empty bundle-<ts>/ directory that
+                // never gets cleaned up.
+                if !downloadSucceeded {
+                    try? FileManager.default.removeItem(at: downloadDir)
+                }
+            }
             do {
-                let bundleId = "bundle-\(Date().timeIntervalSince1970)"
-                let downloadDir = getUpdatesDirectory().appendingPathComponent(bundleId)
                 try FileManager.default.createDirectory(at: downloadDir, withIntermediateDirectories: true)
-                
-                // Start download
+
                 let downloadedFile = try await downloadBundle(from: url, to: downloadDir, bundleId: bundleId)
-                
-                // Verify checksum
+
                 let calculatedChecksum = try calculateChecksum(for: downloadedFile)
                 if calculatedChecksum != checksum {
-                    try FileManager.default.removeItem(at: downloadedFile)
                     call.reject("CHECKSUM_ERROR", "Bundle checksum validation failed")
                     return
                 }
-                
-                // Verify signature if provided
+
                 if let signature = call.getString("signature"),
                    let publicKey = (config?["security"] as? [String: Any])?["publicKey"] as? String,
                    (config?["security"] as? [String: Any])?["enableSignatureValidation"] as? Bool == true {
-                    
+
                     let fileData = try Data(contentsOf: downloadedFile)
                     let securityManager = SecurityManager()
-                    
+
                     if !securityManager.verifySignature(data: fileData, signature: signature, publicKeyString: publicKey) {
-                        try FileManager.default.removeItem(at: downloadedFile)
                         call.reject("SIGNATURE_ERROR", "Bundle signature validation failed")
                         return
                     }
                 }
-                
-                // Create bundle info. Persist the signature so the
-                // boot-time re-verify (verifyActiveBundleOnBoot) can run
-                // without needing to re-download.
+
+                // Extract immediately so the bundle is bootable, but DO
+                // NOT swap the WebView's serverBasePath here. set() does
+                // that. This matches Android's contract — download stages
+                // a verified bundle, set() activates it.
+                try extractZipBundleForBundle(bundleId: bundleId, zipUrl: downloadedFile)
+
+                let extractedPath = getUpdatesDirectory()
+                    .appendingPathComponent(bundleId)
+                    .appendingPathComponent("www")
+                    .path
+
                 var bundleInfo: [String: Any] = [
                     "bundleId": bundleId,
                     "version": version,
                     "path": downloadedFile.path,
+                    "extractedPath": extractedPath,
                     "downloadTime": Date().timeIntervalSince1970 * 1000,
                     "size": try FileManager.default.attributesOfItem(atPath: downloadedFile.path)[.size] ?? 0,
                     "status": "READY",
@@ -181,34 +195,42 @@ class LiveUpdatePlugin {
                 if let signature = call.getString("signature") {
                     bundleInfo["signature"] = signature
                 }
-                
-                // Save bundle info
                 saveBundleInfo(bundleInfo)
-                
-                // Extract the bundle
-                try extractAndApplyBundle(downloadedFile, bundleId: bundleId)
-                
-                // Notify state change
+
                 stateChangeListener?([
                     "status": "READY",
                     "bundleId": bundleId,
                     "version": version
                 ])
-                
+
+                downloadSucceeded = true
                 call.resolve(bundleInfo)
             } catch {
                 call.reject("DOWNLOAD_ERROR", error.localizedDescription)
             }
         }
     }
-    
+
     func set(_ call: CAPPluginCall) {
         guard let bundleId = call.getString("bundleId") else {
             call.reject("Bundle ID is required")
             return
         }
-        
+
+        // Activation = update the active-bundle pointer AND swap the
+        // WebView's serverBasePath. Previously the swap happened in
+        // download(), which auto-activated bundles before the host app
+        // had a chance to call set(). That broke parity with Android
+        // and meant a partially-completed download could end up live.
+        let bundles = UserDefaults.standard.dictionary(forKey: "native_update_bundles") ?? [:]
+        guard let bundleInfo = bundles[bundleId] as? [String: Any],
+              let extractedPath = bundleInfo["extractedPath"] as? String else {
+            call.reject("Bundle not found or not extracted: \(bundleId)")
+            return
+        }
+
         setActiveBundle(bundleId)
+        configureWebViewPath(extractedPath)
         call.resolve()
     }
     
@@ -711,32 +733,34 @@ class LiveUpdatePlugin {
     
     // MARK: - Bundle Extraction and WebView Configuration
     
-    private func extractAndApplyBundle(_ bundleUrl: URL, bundleId: String) throws {
-        let extractedPath = getUpdatesDirectory().appendingPathComponent(bundleId).appendingPathComponent("www")
-
+    /// Extract a downloaded zip into `bundles/{bundleId}/www/`. Does NOT
+    /// touch `setServerBasePath` — activation is owned by set().
+    private func extractZipBundleForBundle(bundleId: String, zipUrl: URL) throws {
+        let extractedPath = getUpdatesDirectory()
+            .appendingPathComponent(bundleId)
+            .appendingPathComponent("www")
         do {
-            // Extract the zip bundle
-            try extractZipBundle(from: bundleUrl, to: extractedPath)
-
-            // Update bundle info with extracted path
-            var bundleInfo = getAllBundles().first { $0["bundleId"] as? String == bundleId } ?? [:]
-            bundleInfo["extractedPath"] = extractedPath.path
-            bundleInfo["status"] = "READY"
-            saveBundleInfo(bundleInfo)
-
-            // Configure WebView to use new path
-            configureWebViewPath(extractedPath.path)
+            try extractZipBundle(from: zipUrl, to: extractedPath)
         } catch {
-            // Get the safe bundle path (current working bundle)
-            let safePath = UserDefaults.standard.string(forKey: "native_update_webview_path") ?? "/"
-
-            // Rollback to safe bundle
-            try? rollbackToSafeBundle(currentPath: extractedPath.path, safePath: safePath)
-
-            // Re-throw the error
+            // Roll back the partial extraction so a re-download is clean.
+            try? FileManager.default.removeItem(at: extractedPath)
             throw error
         }
     }
+
+    private func extractAndApplyBundle(_ bundleUrl: URL, bundleId: String) throws {
+        // Legacy path retained for any caller still using it. Extracts
+        // and immediately activates — equivalent to the old behavior.
+        try extractZipBundleForBundle(bundleId: bundleId, zipUrl: bundleUrl)
+        let extractedPath = getUpdatesDirectory()
+            .appendingPathComponent(bundleId)
+            .appendingPathComponent("www")
+        var bundleInfo = getAllBundles().first { $0["bundleId"] as? String == bundleId } ?? [:]
+        bundleInfo["extractedPath"] = extractedPath.path
+        bundleInfo["status"] = "READY"
+        saveBundleInfo(bundleInfo)
+        configureWebViewPath(extractedPath.path)
+    }
     
     /// Hard cap on total uncompressed size of an OTA bundle. Protects
     /// against zip-bombs (a small zip that expands to gigabytes and fills

package/ios/Plugin/NativeUpdatePlugin.swift

@@ -68,16 +68,21 @@ public class NativeUpdatePlugin: CAPPlugin {
     }
     
     @objc func cleanup(_ call: CAPPluginCall) {
-        // Clean up any resources
         liveUpdatePlugin.cleanup()
-        // Disable background updates through the plugin method
-        let disableCall = CAPPluginCall(
-            callbackId: "cleanup_disable",
-            options: [:],
-            success: { _ in },
-            error: { _ in }
-        )
-        backgroundUpdatePlugin.disableBackgroundUpdates(disableCall)
+        // CAPACITOR-SDK-WORKAROUND (assumes Capacitor 8.x):
+        // We cannot manufacture a synthetic CAPPluginCall to forward into
+        // backgroundUpdatePlugin.disableBackgroundUpdates(_:) because
+        // CAPPluginCall(callbackId:options:success:error:) is `internal`
+        // in the public Capacitor SDK — referencing it produces a
+        // compile error against the shipped framework. The internal
+        // `disableBackgroundUpdatesInternal()` shim wraps the same
+        // teardown logic and is the ONLY entry point that doesn't
+        // require a CAPPluginCall.
+        //
+        // Revisit on every Capacitor major bump: if the constructor
+        // becomes public, replace the shim with a real synthetic call.
+        // Tracked in docs/project-audit/PRODUCTION-READINESS-AUDIT-2026-05-08.md (item I2).
+        backgroundUpdatePlugin.disableBackgroundUpdatesInternal()
         call.resolve()
     }
     

package/package.json

@@ -1,16 +1,26 @@
 {
   "name": "native-update",
-  "version": "2.0.0",
+  "version": "3.1.0",
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=24.16.0"
   },
-  "description": "Capacitor update plugin with live updates, app update checks, app reviews, and support for HTTP or Firestore-backed release delivery.",
+  "description": "Capacitor update plugin with live updates, app update checks, and app reviews. v3 ships an HTTP-only backend contract (Laravel + Nova reference implementation) and is paired with the hosted Native Update SaaS for release delivery.",
   "type": "module",
   "main": "dist/plugin.cjs.js",
   "module": "dist/esm/index.js",
   "types": "dist/esm/index.d.ts",
   "unpkg": "dist/plugin.js",
-  "bin": "./cli/index.js",
+  "exports": {
+    ".": {
+      "types": "./dist/esm/index.d.ts",
+      "import": "./dist/plugin.esm.js",
+      "require": "./dist/plugin.cjs.js"
+    },
+    "./package.json": "./package.json",
+    "./dist/*": "./dist/*",
+    "./cli/*": "./cli/*"
+  },
+  "bin": "cli/index.js",
   "files": [
     "android/src/main/",
     "android/build.gradle",
@@ -19,6 +29,7 @@
     "android/gradle/",
     "android/settings.gradle",
     "android/proguard-rules.pro",
+    "android/manifest-additions.xml",
     "dist/",
     "ios/Plugin/",
     "NativeUpdate.podspec",
@@ -57,52 +68,41 @@
     "android",
     "hybrid"
   ],
-  "packageManager": "yarn@4.10.3",
   "scripts": {
     "build": "rimraf ./dist && tsc && rollup -c rollup.config.js",
     "build:prod": "rimraf ./dist && tsc && NODE_ENV=production rollup -c rollup.config.js",
     "clean": "rimraf ./dist",
     "tsc": "tsc",
     "watch": "tsc --watch",
-    "lint": "eslint . --ext ts",
+    "lint": "eslint .",
     "prettier": "prettier --write .",
     "prepublishOnly": "yarn build:prod",
-    "swiftlint": "cd ios && swiftlint lint --fix --format --path Plugin --verbose",
-    "test": "vitest",
-    "test:run": "vitest --run",
-    "test:ui": "vitest --ui",
-    "test:coverage": "vitest --coverage"
+    "swiftlint": "cd ios && swiftlint lint --fix --format --path Plugin --verbose"
   },
   "dependencies": {
-    "archiver": "^7.0.1",
+    "archiver": "^8.0.0",
     "chalk": "^5.6.2",
-    "commander": "^14.0.3",
-    "ora": "^9.3.0",
+    "commander": "^15.0.0",
+    "express": "^5.2.1",
+    "ora": "^9.4.0",
     "prompts": "^2.4.2"
   },
   "devDependencies": {
-    "@capacitor/android": "^8.3.0",
     "@capacitor/app": "^8.1.0",
-    "@capacitor/core": "^8.3.0",
+    "@capacitor/core": "^8.4.1",
     "@capacitor/device": "^8.0.2",
     "@capacitor/filesystem": "^8.1.2",
-    "@capacitor/ios": "^8.3.0",
     "@capacitor/preferences": "^8.0.1",
-    "@rollup/plugin-json": "^6.1.0",
     "@rollup/plugin-node-resolve": "^16.0.3",
     "@rollup/plugin-terser": "^1.0.0",
-    "@types/node": "^25.6.0",
-    "@typescript-eslint/eslint-plugin": "^8.58.2",
-    "@typescript-eslint/parser": "^8.58.2",
-    "@vitest/ui": "^4.1.4",
-    "eslint": "^10.2.0",
-    "express": "^5.2.1",
-    "happy-dom": "^20.9.0",
-    "prettier": "^3.8.3",
+    "@types/node": "^26.0.0",
+    "@typescript-eslint/eslint-plugin": "^8.61.1",
+    "@typescript-eslint/parser": "^8.61.1",
+    "eslint": "^10.5.0",
+    "prettier": "^3.8.4",
     "rimraf": "^6.1.3",
-    "rollup": "^4.60.1",
-    "typescript": "^6.0.2",
-    "vitest": "^4.1.4"
+    "rollup": "^4.62.0",
+    "typescript": "^6.0.3"
   },
   "peerDependencies": {
     "@capacitor/core": "^8.0.1"

package/cli/node_modules/.yarn-integrity

@@ -1,16 +0,0 @@
-{
-  "systemParams": "linux-x64-137",
-  "modulesFolders": [
-    "node_modules"
-  ],
-  "flags": [],
-  "linkedModules": [],
-  "topLevelPatterns": [
-    "commander@^11.0.0"
-  ],
-  "lockfileEntries": {
-    "commander@^11.0.0": "https://registry.npmjs.org/commander/-/commander-11.1.0.tgz#62fdce76006a68e5c1ab3314dc92e800eb83d906"
-  },
-  "files": [],
-  "artifacts": {}
-}

package/cli/node_modules/commander/LICENSE

@@ -1,22 +0,0 @@
-(The MIT License)
-
-Copyright (c) 2011 TJ Holowaychuk <tj@vision-media.ca>
-
-Permission is hereby granted, free of charge, to any person obtaining
-a copy of this software and associated documentation files (the
-'Software'), to deal in the Software without restriction, including
-without limitation the rights to use, copy, modify, merge, publish,
-distribute, sublicense, and/or sell copies of the Software, and to
-permit persons to whom the Software is furnished to do so, subject to
-the following conditions:
-
-The above copyright notice and this permission notice shall be
-included in all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND,
-EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
-MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
-IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
-CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
-TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
-SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.