nastechai-desktop 18.1.0

package/src/store/notifications.ts

@@ -0,0 +1,165 @@
+import { atom } from 'nanostores'
+
+import { translateNow } from '@/i18n'
+
+export type NotificationKind = 'error' | 'warning' | 'info' | 'success'
+
+export interface NotificationAction {
+  label: string
+  onClick: () => void
+}
+
+export interface AppNotification {
+  id: string
+  kind: NotificationKind
+  title?: string
+  message: string
+  detail?: string
+  action?: NotificationAction
+  onDismiss?: () => void
+  createdAt: number
+}
+
+interface NotificationInput {
+  id?: string
+  kind?: NotificationKind
+  title?: string
+  message: string
+  detail?: string
+  action?: NotificationAction
+  onDismiss?: () => void
+  durationMs?: number
+}
+
+let notificationCounter = 0
+const timers = new Map<string, number>()
+
+export const $notifications = atom<AppNotification[]>([])
+
+function defaultDuration(kind: NotificationKind) {
+  if (kind === 'error' || kind === 'warning') {
+    return 0
+  }
+
+  return 5_000
+}
+
+function cleanErrorText(value: string) {
+  return value.replace(/^Error:\s*/, '').trim()
+}
+
+const ERROR_SUMMARIES: { test: (msg: string) => boolean; summarize: (msg: string) => string }[] = [
+  {
+    test: msg => /incorrect api key provided/i.test(msg) || /['"]code['"]\s*:\s*['"]invalid_api_key['"]/i.test(msg),
+    summarize: msg => {
+      const status = msg.match(/(?:error code|status(?:Code)?)[^\d]*(\d{3})/i)?.[1]
+
+      return status
+        ? translateNow('notifications.errors.openaiRejectedApiKeyWithStatus', status)
+        : translateNow('notifications.errors.openaiRejectedApiKey')
+    }
+  },
+  {
+    test: msg => /neither voice_tools_openai_key nor openai_api_key is set/i.test(msg),
+    summarize: () => translateNow('notifications.errors.openaiTtsNeedsKey')
+  },
+  {
+    test: msg => /ELEVENLABS_API_KEY not set/i.test(msg) || /ElevenLabs STT API error \(HTTP 401\)/i.test(msg),
+    summarize: msg =>
+      /ELEVENLABS_API_KEY not set/i.test(msg)
+        ? translateNow('notifications.errors.elevenLabsNeedsKey')
+        : translateNow('notifications.errors.elevenLabsRejectedKey')
+  },
+  {
+    test: msg => /method not allowed/i.test(msg),
+    summarize: () => translateNow('notifications.errors.methodNotAllowed')
+  },
+  {
+    test: msg => /microphone permission/i.test(msg),
+    summarize: () => translateNow('notifications.errors.microphonePermission')
+  }
+]
+
+function summarizeErrorMessage(message: string, fallback: string) {
+  const rule = ERROR_SUMMARIES.find(r => r.test(message))
+
+  if (rule) {
+    return rule.summarize(message)
+  }
+
+  return message.length > 180 ? fallback : message || fallback
+}
+
+function readableError(error: unknown, fallback: string): { message: string; detail?: string } {
+  const raw = error instanceof Error ? error.message : typeof error === 'string' ? error : fallback
+  const unwrapped = raw.match(/Error invoking remote method '[^']+': Error: (.+)$/)?.[1] ?? raw
+  const cleaned = cleanErrorText(unwrapped)
+  const detail = cleaned.match(/"detail"\s*:\s*"([^"]+)"/)?.[1] ?? cleaned
+  const summary = summarizeErrorMessage(detail, fallback)
+
+  return { message: summary, detail: detail === summary ? undefined : detail }
+}
+
+export function notify(input: NotificationInput): string {
+  const kind = input.kind ?? 'info'
+  const id = input.id ?? `${Date.now()}-${notificationCounter++}`
+
+  const notification: AppNotification = {
+    id,
+    kind,
+    title: input.title,
+    message: input.message,
+    detail: input.detail,
+    action: input.action,
+    onDismiss: input.onDismiss,
+    createdAt: Date.now()
+  }
+
+  window.clearTimeout(timers.get(id))
+  timers.delete(id)
+  $notifications.set([notification, ...$notifications.get().filter(item => item.id !== id)].slice(0, 4))
+
+  const duration = input.durationMs ?? defaultDuration(kind)
+
+  if (duration > 0) {
+    timers.set(
+      id,
+      window.setTimeout(() => dismissNotification(id), duration)
+    )
+  }
+
+  return id
+}
+
+export function notifyError(error: unknown, fallback: string): string {
+  const readable = readableError(error, fallback)
+
+  return notify({
+    kind: 'error',
+    title: fallback,
+    message: readable.message,
+    detail: readable.detail
+  })
+}
+
+export function dismissNotification(id: string) {
+  window.clearTimeout(timers.get(id))
+  timers.delete(id)
+  const dismissed = $notifications.get().find(item => item.id === id)
+  $notifications.set($notifications.get().filter(item => item.id !== id))
+  dismissed?.onDismiss?.()
+}
+
+export function clearNotifications() {
+  for (const timer of timers.values()) {
+    window.clearTimeout(timer)
+  }
+
+  timers.clear()
+  const all = $notifications.get()
+  $notifications.set([])
+
+  for (const item of all) {
+    item.onDismiss?.()
+  }
+}

package/src/store/onboarding.test.ts

@@ -0,0 +1,372 @@
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
+
+import type { OAuthProvider } from '@/types/nastech'
+
+import {
+  $desktopOnboarding,
+  type DesktopOnboardingState,
+  type OnboardingContext,
+  refreshOnboarding,
+  requestDesktopOnboarding,
+  saveOnboardingLocalEndpoint,
+  submitOnboardingCode
+} from './onboarding'
+
+function provider(id: string, name = id): OAuthProvider {
+  return {
+    cli_command: `NASTECH login ${id}`,
+    docs_url: `https://example.com/${id}`,
+    flow: 'pkce',
+    id,
+    name,
+    status: { logged_in: false }
+  }
+}
+
+function baseState(overrides: Partial<DesktopOnboardingState> = {}): DesktopOnboardingState {
+  return {
+    configured: false,
+    flow: { status: 'idle' },
+    mode: 'oauth',
+    providers: null,
+    reason: null,
+    requested: false,
+    firstRunSkipped: false,
+    manual: false,
+    ...overrides
+  }
+}
+
+function installApiMock(api: (request: { path: string }) => Promise<unknown>) {
+  Object.defineProperty(window, 'NASTECHDesktop', {
+    configurable: true,
+    value: { api }
+  })
+}
+
+function runtimeMismatchGateway(): OnboardingContext['requestGateway'] {
+  return async method => {
+    if (method === 'setup.status') {
+      return { provider_configured: true } as never
+    }
+
+    if (method === 'setup.runtime_check') {
+      return { error: 'Selected runtime is not available.', ok: false } as never
+    }
+
+    throw new Error(`unexpected gateway method: ${method}`)
+  }
+}
+
+function onboardingContext(requestGateway: OnboardingContext['requestGateway']): OnboardingContext {
+  return { requestGateway }
+}
+
+describe('refreshOnboarding', () => {
+  beforeEach(() => {
+    window.localStorage.clear()
+    $desktopOnboarding.set(baseState())
+  })
+
+  afterEach(() => {
+    window.localStorage.clear()
+    $desktopOnboarding.set(baseState())
+    vi.restoreAllMocks()
+  })
+
+  it('refreshes OAuth providers again when onboarding was explicitly requested', async () => {
+    const api = vi.fn(async ({ path }: { path: string }) => {
+      if (path === '/api/providers/oauth') {
+        return { providers: [provider('fresh')] }
+      }
+
+      throw new Error(`unexpected api path: ${path}`)
+    })
+
+    installApiMock(api)
+    $desktopOnboarding.set(baseState({ providers: [provider('cached')] }))
+    requestDesktopOnboarding('Need provider setup')
+
+    const ready = await refreshOnboarding(onboardingContext(runtimeMismatchGateway()))
+
+    expect(ready).toBe(false)
+    expect(api).toHaveBeenCalledTimes(1)
+    expect($desktopOnboarding.get().providers?.map(p => p.id)).toEqual(['fresh'])
+    expect($desktopOnboarding.get().reason).toContain('Selected runtime is not available.')
+    expect($desktopOnboarding.get().reason).toContain('setup.status reports configured credentials')
+  })
+
+  it('keeps cached providers when onboarding was not re-requested', async () => {
+    const api = vi.fn(async ({ path }: { path: string }) => {
+      if (path === '/api/providers/oauth') {
+        return { providers: [provider('fresh')] }
+      }
+
+      throw new Error(`unexpected api path: ${path}`)
+    })
+
+    installApiMock(api)
+    $desktopOnboarding.set(baseState({ providers: [provider('cached')] }))
+
+    const ready = await refreshOnboarding(onboardingContext(runtimeMismatchGateway()))
+
+    expect(ready).toBe(false)
+    expect(api).not.toHaveBeenCalled()
+    expect($desktopOnboarding.get().providers?.map(p => p.id)).toEqual(['cached'])
+  })
+
+  it('deduplicates concurrent provider refresh calls', async () => {
+    let resolveProviders!: (value: { providers: OAuthProvider[] }) => void
+
+    const providersPromise = new Promise<{ providers: OAuthProvider[] }>(resolve => {
+      resolveProviders = value => {
+        resolve(value)
+      }
+    })
+
+    const api = vi.fn(async ({ path }: { path: string }) => {
+      if (path === '/api/providers/oauth') {
+        return providersPromise
+      }
+
+      throw new Error(`unexpected api path: ${path}`)
+    })
+
+    installApiMock(api)
+    $desktopOnboarding.set(baseState({ requested: true }))
+
+    const first = refreshOnboarding(onboardingContext(runtimeMismatchGateway()))
+    const second = refreshOnboarding(onboardingContext(runtimeMismatchGateway()))
+
+    await vi.waitFor(() => expect(api).toHaveBeenCalledTimes(1))
+
+    resolveProviders({ providers: [provider('shared')] })
+    await Promise.all([first, second])
+
+    expect($desktopOnboarding.get().providers?.map(p => p.id)).toEqual(['shared'])
+  })
+})
+
+describe('OAuth onboarding', () => {
+  beforeEach(() => {
+    window.localStorage.clear()
+    $desktopOnboarding.set(baseState())
+  })
+
+  afterEach(() => {
+    window.localStorage.clear()
+    $desktopOnboarding.set(baseState())
+    vi.restoreAllMocks()
+  })
+
+  it('clears stale readiness errors after OAuth succeeds and model confirmation is shown', async () => {
+    const model = 'anthropic/claude-opus-4.8'
+    const calls: { body?: unknown; path: string }[] = []
+
+    installApiMock(async ({ body, path }: { body?: unknown; path: string }) => {
+      calls.push({ body, path })
+
+      if (path === '/api/providers/oauth/nastech/submit') {
+        return { ok: true, status: 'approved' }
+      }
+
+      if (path === '/api/model/options') {
+        return {
+          providers: [
+            {
+              name: 'NasTech Portal',
+              slug: 'nastech',
+              models: [model]
+            }
+          ]
+        }
+      }
+
+      if (path.startsWith('/api/model/recommended-default?')) {
+        return { provider: 'nastech', model, free_tier: false }
+      }
+
+      if (path === '/api/model/set') {
+        return { ok: true, provider: 'nastech', model, gateway_tools: [] }
+      }
+
+      throw new Error(`unexpected api path: ${path}`)
+    })
+
+    const requestGateway: OnboardingContext['requestGateway'] = async method => {
+      if (method === 'reload.env') {
+        return {} as never
+      }
+
+      if (method === 'setup.status') {
+        return { provider_configured: true } as never
+      }
+
+      if (method === 'setup.runtime_check') {
+        return { ok: true } as never
+      }
+
+      throw new Error(`unexpected gateway method: ${method}`)
+    }
+
+    $desktopOnboarding.set(
+      baseState({
+        flow: {
+          status: 'awaiting_user',
+          provider: provider('nastech', 'NasTech Portal'),
+          start: {
+            auth_url: 'https://portal.example/auth',
+            expires_in: 600,
+            flow: 'pkce',
+            session_id: 'portal-session'
+          },
+          code: 'fresh-code'
+        },
+        reason:
+          'No access token found for NasTech Portal login. setup.status reports configured credentials, but runtime resolution still failed.',
+        requested: true
+      })
+    )
+
+    await submitOnboardingCode(onboardingContext(requestGateway))
+
+    const state = $desktopOnboarding.get()
+    expect(state.reason).toBeNull()
+    expect(state.flow.status).toBe('confirming_model')
+    if (state.flow.status === 'confirming_model') {
+      expect(state.flow.label).toBe('NasTech Portal')
+      expect(state.flow.currentModel).toBe(model)
+    }
+    expect(calls.some(c => c.path === '/api/model/set')).toBe(true)
+  })
+})
+
+describe('saveOnboardingLocalEndpoint', () => {
+  beforeEach(() => {
+    window.localStorage.clear()
+    $desktopOnboarding.set(baseState())
+  })
+
+  afterEach(() => {
+    window.localStorage.clear()
+    $desktopOnboarding.set(baseState())
+    vi.restoreAllMocks()
+  })
+
+  function readyGateway(): OnboardingContext['requestGateway'] {
+    return async method => {
+      if (method === 'reload.env') {
+        return {} as never
+      }
+
+      if (method === 'setup.status') {
+        return { provider_configured: true } as never
+      }
+
+      if (method === 'setup.runtime_check') {
+        return { ok: true } as never
+      }
+
+      throw new Error(`unexpected gateway method: ${method}`)
+    }
+  }
+
+  it('errors when the endpoint advertises no models (nothing to route to)', async () => {
+    const calls: string[] = []
+    installApiMock(async ({ path }: { path: string }) => {
+      calls.push(path)
+
+      if (path === '/api/providers/validate') {
+        return { ok: true, reachable: true, message: '', models: [] }
+      }
+
+      throw new Error(`unexpected api path: ${path}`)
+    })
+
+    const result = await saveOnboardingLocalEndpoint('http://127.0.0.1:8000/v1', {
+      requestGateway: readyGateway()
+    })
+
+    expect(result.ok).toBe(false)
+    expect(result.message).toContain('no models')
+    // Must not attempt to persist an assignment without a model.
+    expect(calls).not.toContain('/api/model/set')
+  })
+
+  it('auto-discovers the model and persists provider=custom + base_url, then finishes', async () => {
+    const calls: { body?: unknown; path: string }[] = []
+
+    const api = vi.fn(async ({ body, path }: { body?: unknown; path: string }) => {
+      calls.push({ body, path })
+
+      if (path === '/api/providers/validate') {
+        return { ok: true, reachable: true, message: '', models: ['llama-3.1-8b', 'qwen2.5-7b'] }
+      }
+
+      if (path === '/api/model/set') {
+        return { ok: true, provider: 'custom', model: 'llama-3.1-8b', base_url: 'http://127.0.0.1:8000/v1' }
+      }
+
+      throw new Error(`unexpected api path: ${path}`)
+    })
+
+    installApiMock(api)
+    const onCompleted = vi.fn()
+
+    const result = await saveOnboardingLocalEndpoint('http://127.0.0.1:8000/v1', {
+      onCompleted,
+      requestGateway: readyGateway()
+    })
+
+    expect(result.ok).toBe(true)
+
+    const assign = calls.find(c => c.path === '/api/model/set')
+    expect(assign?.body).toMatchObject({
+      scope: 'main',
+      provider: 'custom',
+      model: 'llama-3.1-8b',
+      base_url: 'http://127.0.0.1:8000/v1'
+    })
+
+    expect(onCompleted).toHaveBeenCalledTimes(1)
+    expect($desktopOnboarding.get().configured).toBe(true)
+  })
+
+  it('reports the runtime reason when resolution still fails after saving', async () => {
+    installApiMock(async ({ path }: { path: string }) => {
+      if (path === '/api/providers/validate') {
+        return { ok: true, reachable: true, message: '', models: ['llama-3.1-8b'] }
+      }
+
+      if (path === '/api/model/set') {
+        return { ok: true }
+      }
+
+      throw new Error(`unexpected api path: ${path}`)
+    })
+
+    const failingGateway: OnboardingContext['requestGateway'] = async method => {
+      if (method === 'reload.env') {
+        return {} as never
+      }
+
+      if (method === 'setup.status') {
+        return { provider_configured: false } as never
+      }
+
+      if (method === 'setup.runtime_check') {
+        return { ok: false, error: 'No provider can serve the selected model.' } as never
+      }
+
+      throw new Error(`unexpected gateway method: ${method}`)
+    }
+
+    const result = await saveOnboardingLocalEndpoint('http://127.0.0.1:8000/v1', {
+      requestGateway: failingGateway
+    })
+
+    expect(result.ok).toBe(false)
+    expect(result.message).toContain('No provider can serve the selected model.')
+    expect($desktopOnboarding.get().configured).not.toBe(true)
+  })
+})