n8n 2.47.3 → 2.47.4

package/dist/modules/instance-ai/instance-ai.service.d.ts

@@ -134,6 +134,7 @@ export declare class InstanceAiService {
     getActiveRunId(threadId: string): string | undefined;
     private stopRunsForQuotaExhaustion;
     cancelRun(threadId: string, reason?: string): void;
+    private settleCancelledSuspension;
     sendCorrectionToTask(threadId: string, taskId: string, correction: string): 'queued' | 'task-completed' | 'task-not-found';
     cancelBackgroundTask(threadId: string, taskId: string): void;
     private broadcastTaskControl;

package/dist/modules/instance-ai/instance-ai.service.js

@@ -11,6 +11,7 @@ var __metadata = (this && this.__metadata) || function (k, v) {
 var InstanceAiService_1;
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.InstanceAiService = exports.QuotaExhaustedStreamError = exports.isAssistantCreditBalanceExhausted = void 0;
+const agents_1 = require("@n8n/agents");
 const api_types_1 = require("@n8n/api-types");
 const backend_common_1 = require("@n8n/backend-common");
 const backend_services_1 = require("@n8n/backend-services");
@@ -86,6 +87,14 @@ function isTelemetryConfigurableAgent(agent) {
         agent !== null &&
         typeof Reflect.get(agent, 'telemetry') === 'function');
 }
+function describeMemoryTaskOutcome(value) {
+    if (!(0, is_record_1.isRecord)(value) || typeof value.status !== 'string')
+        return {};
+    return {
+        outcome: value.status,
+        ...(typeof value.reason === 'string' ? { reason: value.reason } : {}),
+    };
+}
 const WORKFLOW_SETUP_ROUTING_CLAIM_TTL_MS = 15 * 60 * 1000;
 const CONFIRMATION_EXPIRED_MESSAGE = 'This confirmation has expired. Send a new message to continue.';
 const RESUME_REJECTED_MESSAGE = 'I could not apply that confirmation. Send a new message to continue.';
@@ -408,13 +417,7 @@ let InstanceAiService = InstanceAiService_1 = class InstanceAiService {
                 pendingCount: pendingTasks.length,
                 ...(event.type === 'skipped' ? { reason: event.reason } : {}),
                 ...(event.type === 'failed' ? { error: (0, get_error_message_1.getErrorMessage)(event.error) } : {}),
-                ...(event.type === 'completed' &&
-                    event.value &&
-                    typeof event.value === 'object' &&
-                    'status' in event.value &&
-                    typeof event.value.status === 'string'
-                    ? { outcome: event.value.status }
-                    : {}),
+                ...(event.type === 'completed' ? describeMemoryTaskOutcome(event.value) : {}),
             };
             this.logger.info(`Observational memory task ${event.type}`, logContext);
         };
@@ -714,6 +717,7 @@ let InstanceAiService = InstanceAiService_1 = class InstanceAiService {
                     ...(suspended.modelId !== undefined ? { modelId: suspended.modelId } : {}),
                     promptVersion: suspended.orchestrationContext?.promptConfiguration?.version,
                 });
+                void this.settleCancelledSuspension(threadId, suspended.user.id);
             }
             else {
                 void this.finalizeCancelledSuspendedRun(suspended, reason);
@@ -721,6 +725,17 @@ let InstanceAiService = InstanceAiService_1 = class InstanceAiService {
         }
         void this.suspendedThreads.dropPendingConfirmationsForThread(threadId);
     }
+    async settleCancelledSuspension(threadId, resourceId) {
+        try {
+            await (0, agents_1.settleAbandonedToolCallsInMemory)(this.agentMemory, { threadId, resourceId });
+        }
+        catch (error) {
+            this.logger.warn('Failed to settle the tool call of a cancelled suspended run', {
+                threadId,
+                error: (0, get_error_message_1.getErrorMessage)(error),
+            });
+        }
+    }
     sendCorrectionToTask(threadId, taskId, correction) {
         return this.backgroundTasks.queueCorrection(threadId, taskId, correction);
     }
@@ -2995,6 +3010,7 @@ let InstanceAiService = InstanceAiService_1 = class InstanceAiService {
         }
     }
     async finalizeCancelledSuspendedRun(suspended, reason = 'user_cancelled') {
+        void this.settleCancelledSuspension(suspended.threadId, suspended.user.id);
         const runTimeout = reason === liveness_1.INSTANCE_AI_RUN_TIMEOUT_REASON
             ? this.liveness.consumeRunTimeout(suspended.runId)
             : undefined;