n8n 2.42.4 → 2.43.1

package/dist/modules/instance-ai/instance-ai.adapter.service.js

@@ -30,6 +30,7 @@ const ai_utilities_1 = require("@n8n/ai-utilities");
 const api_types_1 = require("@n8n/api-types");
 const backend_common_1 = require("@n8n/backend-common");
 const backend_network_1 = require("@n8n/backend-network");
+const backend_services_1 = require("@n8n/backend-services");
 const config_1 = require("@n8n/config");
 const constants_1 = require("@n8n/constants");
 const db_1 = require("@n8n/db");
@@ -47,14 +48,10 @@ const node_path_1 = __importDefault(require("node:path"));
 const active_executions_1 = require("../../active-executions");
 const collaboration_service_1 = require("../../collaboration/collaboration.service");
 const credentials_overwrites_1 = require("../../credentials-overwrites");
-const credentials_finder_service_1 = require("../../credentials/credentials-finder.service");
 const credentials_service_1 = require("../../credentials/credentials.service");
-const conflict_error_1 = require("../../errors/response-errors/conflict.error");
-const locked_error_1 = require("../../errors/response-errors/locked.error");
-const not_found_error_1 = require("../../errors/response-errors/not-found.error");
+const errors_1 = require("@n8n/errors");
 const evaluation_config_service_1 = require("../../evaluation.ee/evaluation-config.service");
 const llm_judge_provider_registry_1 = require("../../evaluation.ee/llm-judge-provider-registry");
-const event_service_1 = require("../../events/event.service");
 const execution_persistence_1 = require("../../executions/execution-persistence");
 const license_1 = require("../../license");
 const load_nodes_and_credentials_1 = require("../../load-nodes-and-credentials");
@@ -76,12 +73,9 @@ const posthog_1 = require("../../posthog");
 const ai_gateway_service_1 = require("../../services/ai-gateway.service");
 const ai_preference_write_1 = require("../../services/ai-preference-write");
 const ai_preference_service_1 = require("../../services/ai-preference.service");
-const folder_finder_service_1 = require("../../services/folder-finder.service");
 const folder_service_1 = require("../../services/folder.service");
-const instance_write_access_service_1 = require("../../services/instance-write-access.service");
 const node_resource_explorer_service_1 = require("../../services/node-resource-explorer.service");
 const project_service_ee_1 = require("../../services/project.service.ee");
-const role_service_1 = require("../../services/role.service");
 const tag_service_1 = require("../../services/tag.service");
 const telemetry_2 = require("../../telemetry");
 const node_definition_dirs_1 = require("../../utils/node-definition-dirs");
@@ -252,9 +246,9 @@ let InstanceAiAdapterService = class InstanceAiAdapterService {
         });
     }
     createContext(user, options) {
-        const { searchProxyConfig, pushRef, threadId, projectId, getCredentialIdAllowlist, shouldBypassCredentialTest, agentId, configEvalsEnabled, setupPanelVariant, mcpConnectionsAvailable, nodeUsageEnabled, instanceContextEnabled, conversationHistory, folderExplorationEnabled, onboardingThread, credentialDescriptionsEnabled, aiPreferencesEnabled, modelId, } = options ?? {};
+        const { searchProxyConfig, pushRef, threadId, projectId, getCredentialIdAllowlist, resumeAgentBuild = false, shouldBypassCredentialTest, agentId, configEvalsEnabled, setupPanelVariant, mcpConnectionsAvailable, nodeUsageEnabled, instanceContextEnabled, conversationHistory, folderExplorationEnabled, onboardingThread, credentialDescriptionsEnabled, aiPreferencesEnabled, modelId, allowSendingParameterValues = this.allowSendingParameterValues, } = options ?? {};
         void this.trackGatewayAvailability();
-        const builderDelegateAdapter = this.getBuilderDelegateAdapter();
+        const builderDelegateAdapter = this.getBuilderDelegateAdapter(resumeAgentBuild);
         const credentialService = this.createCredentialAdapter(user, projectId, getCredentialIdAllowlist, shouldBypassCredentialTest);
         return {
             userId: user.id,
@@ -267,8 +261,9 @@ let InstanceAiAdapterService = class InstanceAiAdapterService {
                 nodeUsageGateOpen: nodeUsageEnabled === true,
                 folderExploration: folderExplorationEnabled === true,
                 setupPanelVariant,
+                allowSendingParameterValues,
             }),
-            executionService: this.createExecutionAdapter(user, pushRef, threadId),
+            executionService: this.createExecutionAdapter(user, allowSendingParameterValues, pushRef, threadId),
             credentialService,
             nodeService: this.createNodeAdapter(user),
             dataTableService: this.createDataTableAdapter(user, projectId),
@@ -279,7 +274,7 @@ let InstanceAiAdapterService = class InstanceAiAdapterService {
                 : {}),
             mcpService: mcpConnectionsAvailable ? this.createMcpAdapter(user) : undefined,
             executeNodeService: this.executeNodeService
-                ? this.createExecuteNodeAdapter(this.executeNodeService, user, projectId)
+                ? this.createExecuteNodeAdapter(this.executeNodeService, user, allowSendingParameterValues, projectId)
                 : undefined,
             conversationHistoryService: conversationHistory,
             ...(instanceContextEnabled === true && this.instanceContext
@@ -294,7 +289,7 @@ let InstanceAiAdapterService = class InstanceAiAdapterService {
             logger: this.logger,
             nodeTypesProvider: this.nodeTypes,
             outputSchemaLookup: this.loadNodesAndCredentials.createOutputSchemaLookup?.(),
-            allowSendingParameterValues: this.allowSendingParameterValues,
+            allowSendingParameterValues,
             ...(builderDelegateAdapter && agentId && projectId
                 ? { agentBuilderTarget: { agentId, projectId } }
                 : {}),
@@ -311,8 +306,10 @@ let InstanceAiAdapterService = class InstanceAiAdapterService {
             ? (0, scoped_credential_provider_1.scopeCredentialProvider)(provider, getCredentialIdAllowlist)
             : provider;
     }
-    getBuilderDelegateAdapter() {
-        if (!di_1.Container.get(backend_common_1.ModuleRegistry).isActive('agents'))
+    getBuilderDelegateAdapter(resumeAgentBuild) {
+        const moduleRegistry = di_1.Container.get(backend_common_1.ModuleRegistry);
+        if (!moduleRegistry.isActive('agents') ||
+            (!resumeAgentBuild && moduleRegistry.settings.get('agents')?.enabled === false))
             return null;
         try {
             return di_1.Container.get(instance_ai_builder_delegate_adapter_1.InstanceAiBuilderDelegateAdapterService);
@@ -411,6 +408,7 @@ let InstanceAiAdapterService = class InstanceAiAdapterService {
             },
             recordRejection: (reason, textLength, scope) => {
                 this.telemetry.track(telemetry_1.TELEMETRY_EVENT.CONTEXT.PREFERENCE_WRITE_REJECTED, {
+                    user_id: user.id,
                     surface: 'aia',
                     reason,
                     scope_type: scope,
@@ -457,7 +455,7 @@ let InstanceAiAdapterService = class InstanceAiAdapterService {
             listConnections: async () => await this.listMcpRegistryConnections(user),
         };
     }
-    createExecuteNodeAdapter(executeNodeService, user, boundProjectId) {
+    createExecuteNodeAdapter(executeNodeService, user, allowSendingParameterValues, boundProjectId) {
         const { resolveProjectId } = this.createProjectScopeHelpers(user, boundProjectId);
         return {
             execute: async (request) => {
@@ -474,7 +472,7 @@ let InstanceAiAdapterService = class InstanceAiAdapterService {
                     timeoutMs: request.timeoutMs,
                     projectId,
                 });
-                return redactExecuteNodeResult(result, this.allowSendingParameterValues);
+                return redactExecuteNodeResult(result, allowSendingParameterValues);
             },
         };
     }
@@ -588,19 +586,24 @@ let InstanceAiAdapterService = class InstanceAiAdapterService {
         const foldersOn = options.folderExploration === true;
         const foldersAttributed = foldersOn && this.license.isLicensed('feat:folders');
         const { folderRepository, folderFinderService, projectService } = this;
-        const { workflowService, workflowFinderService, workflowRepository, sharedWorkflowRepository, aiBuilderTemporaryWorkflowRepository, workflowHistoryService, enterpriseWorkflowService, executionRepository, executionPersistence, license, allowSendingParameterValues, telemetry, collaborationService, policyEnforcementService, workflowDependencyQueryService, } = this;
+        const { workflowService, workflowFinderService, workflowRepository, sharedWorkflowRepository, aiBuilderTemporaryWorkflowRepository, workflowHistoryService, enterpriseWorkflowService, executionRepository, executionPersistence, license, telemetry, collaborationService, policyEnforcementService, workflowDependencyQueryService, } = this;
         const logger = this.logger;
         const assertNotReadOnly = () => this.assertInstanceNotReadOnly('workflows');
         const nodeUsageEnabled = options.nodeUsageGateOpen === true && workflowDependencyQueryService !== undefined;
         const resolveTargetProjectId = (options) => options?.projectId ?? (options?.scope !== 'instance' ? boundProjectId : undefined);
         const { resolveBoundProjectId } = this.createProjectScopeHelpers(user, boundProjectId);
-        const redactParameters = !allowSendingParameterValues;
+        const redactParameters = !(options.allowSendingParameterValues ?? this.allowSendingParameterValues);
+        const assertParameterValuesAvailable = () => {
+            if (redactParameters) {
+                throw new n8n_workflow_1.UserError('Cannot create or edit workflows while parameter values are hidden from n8n Assistant. An instance owner or admin can turn on "Send actual data values" in Settings > AI usage.');
+            }
+        };
         const assertNotLockedByEditor = async (workflowId) => {
             try {
                 await collaborationService.ensureWorkflowEditable(workflowId);
             }
             catch (error) {
-                if (error instanceof locked_error_1.LockedError)
+                if (error instanceof errors_1.LockedError)
                     throw new instance_ai_1.WorkflowEditorLockedError(workflowId);
                 throw error;
             }
@@ -992,6 +995,7 @@ let InstanceAiAdapterService = class InstanceAiAdapterService {
             },
             async createFromWorkflowJSON(json, options) {
                 assertNotReadOnly();
+                assertParameterValuesAvailable();
                 const projectId = await resolveBoundProjectId(['workflow:create']);
                 let placement;
                 if (foldersOn && (options?.folderPath !== undefined || options?.folderId !== undefined)) {
@@ -1028,7 +1032,7 @@ let InstanceAiAdapterService = class InstanceAiAdapterService {
                     workflow: { id: null, name: newWorkflow.name, nodes: newWorkflow.nodes },
                     storedWorkflow: null,
                     projectId,
-                });
+                }, { kind: 'user', user });
                 const saved = await workflowRepository.runInTransaction({ policyCleared: cleared }, async (transactionManager, ctx) => {
                     const workflow = await workflowRepository.createContent(newWorkflow, ctx);
                     await sharedWorkflowRepository.makeOwner([workflow.id], projectId, transactionManager);
@@ -1097,6 +1101,7 @@ let InstanceAiAdapterService = class InstanceAiAdapterService {
             },
             async updateFromWorkflowJSON(workflowId, json, options) {
                 assertNotReadOnly();
+                assertParameterValuesAvailable();
                 await assertNotLockedByEditor(workflowId);
                 const settings = (json.settings ?? {});
                 if (settings.redactionPolicy !== undefined) {
@@ -1134,10 +1139,10 @@ let InstanceAiAdapterService = class InstanceAiAdapterService {
                     });
                 }
                 catch (error) {
-                    if (error instanceof conflict_error_1.ConflictError) {
+                    if (error instanceof errors_1.ConflictError) {
                         throw new instance_ai_1.WorkflowSaveConflictError(workflowId);
                     }
-                    if (error instanceof not_found_error_1.NotFoundError) {
+                    if (error instanceof errors_1.NotFoundError) {
                         throw new instance_ai_1.WorkflowNotFoundError(workflowId);
                     }
                     logger.warn('AI-builder workflow save failed', {
@@ -1205,6 +1210,7 @@ let InstanceAiAdapterService = class InstanceAiAdapterService {
                 };
             },
             async restoreVersion(workflowId, versionId) {
+                assertParameterValuesAvailable();
                 await assertNotLockedByEditor(workflowId);
                 const version = await workflowHistoryService.getVersion(user, workflowId, versionId);
                 const updateData = workflowRepository.create({
@@ -1227,8 +1233,8 @@ let InstanceAiAdapterService = class InstanceAiAdapterService {
                 : {}),
         };
     }
-    createExecutionAdapter(user, pushRef, threadId) {
-        const { workflowFinderService, workflowRunner, activeExecutions, executionRepository, executionPersistence, workflowHistoryService, nodeTypes, allowSendingParameterValues, roleService, telemetry, logger, globalConfig, } = this;
+    createExecutionAdapter(user, allowSendingParameterValues, pushRef, threadId) {
+        const { workflowFinderService, workflowRunner, activeExecutions, executionRepository, executionPersistence, workflowHistoryService, nodeTypes, roleService, telemetry, logger, globalConfig, } = this;
         const assertNotReadOnly = () => this.assertInstanceNotReadOnly('executions');
         const DEFAULT_TIMEOUT_MS = 5 * constants_1.Time.minutes.toMilliseconds;
         const MAX_TIMEOUT_MS = 10 * constants_1.Time.minutes.toMilliseconds;
@@ -2801,7 +2807,7 @@ let InstanceAiAdapterService = class InstanceAiAdapterService {
 exports.InstanceAiAdapterService = InstanceAiAdapterService;
 exports.InstanceAiAdapterService = InstanceAiAdapterService = __decorate([
     (0, di_1.Service)(),
-    __metadata("design:paramtypes", [backend_common_1.Logger, config_1.GlobalConfig, workflow_service_1.WorkflowService, workflow_finder_service_1.WorkflowFinderService, db_1.WorkflowRepository, db_1.SharedWorkflowRepository, db_1.ProjectRepository, db_1.ExecutionRepository, credentials_service_1.CredentialsService, credentials_finder_service_1.CredentialsFinderService, active_executions_1.ActiveExecutions, workflow_runner_1.WorkflowRunner, load_nodes_and_credentials_1.LoadNodesAndCredentials, node_types_1.NodeTypes, n8n_core_1.InstanceSettings, data_table_service_1.DataTableService, data_table_repository_1.DataTableRepository, node_resource_explorer_service_1.NodeResourceExplorerService, folder_service_1.FolderService, project_service_ee_1.ProjectService, tag_service_1.TagService, instance_write_access_service_1.InstanceWriteAccessService, instance_ai_settings_service_1.InstanceAiSettingsService, workflow_history_service_1.WorkflowHistoryService, workflow_service_ee_1.EnterpriseWorkflowService, license_1.License, execution_persistence_1.ExecutionPersistence, event_service_1.EventService, role_service_1.RoleService, telemetry_2.Telemetry, db_1.AiBuilderTemporaryWorkflowRepository, backend_network_1.OutboundHttp, ai_gateway_service_1.AiGatewayService, workflow_templates_service_1.WorkflowTemplatesService, collaboration_service_1.CollaborationService, policy_enforcement_service_1.PolicyEnforcementService, node_catalog_1.NodeCatalogService, evaluation_config_service_1.EvaluationConfigService, llm_judge_provider_registry_1.LlmJudgeProviderRegistry, workflow_dependency_query_service_1.WorkflowDependencyQueryService, db_1.FolderRepository, folder_finder_service_1.FolderFinderService, instance_context_service_1.InstanceContextService, node_execution_1.ExecuteNodeService, backend_common_1.LicenseState, ai_preference_service_1.AiPreferenceService])
+    __metadata("design:paramtypes", [backend_common_1.Logger, config_1.GlobalConfig, workflow_service_1.WorkflowService, workflow_finder_service_1.WorkflowFinderService, db_1.WorkflowRepository, db_1.SharedWorkflowRepository, db_1.ProjectRepository, db_1.ExecutionRepository, credentials_service_1.CredentialsService, backend_services_1.CredentialsFinderService, active_executions_1.ActiveExecutions, workflow_runner_1.WorkflowRunner, load_nodes_and_credentials_1.LoadNodesAndCredentials, node_types_1.NodeTypes, n8n_core_1.InstanceSettings, data_table_service_1.DataTableService, data_table_repository_1.DataTableRepository, node_resource_explorer_service_1.NodeResourceExplorerService, folder_service_1.FolderService, project_service_ee_1.ProjectService, tag_service_1.TagService, backend_services_1.InstanceWriteAccessService, instance_ai_settings_service_1.InstanceAiSettingsService, workflow_history_service_1.WorkflowHistoryService, workflow_service_ee_1.EnterpriseWorkflowService, license_1.License, execution_persistence_1.ExecutionPersistence, backend_services_1.EventService, backend_services_1.RoleService, telemetry_2.Telemetry, db_1.AiBuilderTemporaryWorkflowRepository, backend_network_1.OutboundHttp, ai_gateway_service_1.AiGatewayService, workflow_templates_service_1.WorkflowTemplatesService, collaboration_service_1.CollaborationService, policy_enforcement_service_1.PolicyEnforcementService, node_catalog_1.NodeCatalogService, evaluation_config_service_1.EvaluationConfigService, llm_judge_provider_registry_1.LlmJudgeProviderRegistry, workflow_dependency_query_service_1.WorkflowDependencyQueryService, db_1.FolderRepository, backend_services_1.FolderFinderService, instance_context_service_1.InstanceContextService, node_execution_1.ExecuteNodeService, backend_common_1.LicenseState, ai_preference_service_1.AiPreferenceService])
 ], InstanceAiAdapterService);
 const MAX_RESULT_CHARS = 20_000;
 const MAX_NODE_OUTPUT_CHARS = 1_000;
@@ -3043,6 +3049,7 @@ async function extractExecutionOutcome(executionId, includeOutputData = true, no
     const resultData = {};
     const runData = foldToolExecutorRun(execution.data?.resultData?.runData, subNodeTarget);
     const executedNodeNames = Object.keys(runData ?? {});
+    const binaryOutputNodeNames = [];
     if (includeOutputData && runData) {
         const workflow = buildExecutionWorkflow(execution.workflowData, nodeTypes);
         await workflow?.expression.acquireIsolate();
@@ -3053,6 +3060,9 @@ async function extractExecutionOutcome(executionId, includeOutputData = true, no
                     (nodeName === subNodeTarget ? nonMainOutputs(lastRun) : undefined);
                 if (!outputs)
                     continue;
+                if (outputs.some((items) => items?.some((item) => Object.keys(item.binary ?? {}).length))) {
+                    binaryOutputNodeNames.push(nodeName);
+                }
                 const branches = outputs.map((items) => (items ?? []).map((item) => item.json));
                 const totalItems = branches.reduce((sum, items) => sum + items.length, 0);
                 if (totalItems === 0)
@@ -3087,6 +3097,7 @@ async function extractExecutionOutcome(executionId, includeOutputData = true, no
                 ? wrapResultDataEntries(truncateResultData(resultData))
                 : undefined,
             executedNodeNames: executedNodeNames.length > 0 ? executedNodeNames : undefined,
+            binaryOutputNodeNames: binaryOutputNodeNames.length > 0 ? binaryOutputNodeNames : undefined,
             nodeErrors: nodeErrors.length > 0 ? nodeErrors : undefined,
             lastNodeExecuted: renameToolExecutor(execution.data?.resultData?.lastNodeExecuted, subNodeTarget),
             workflowVersionId: execution.workflowVersionId,